)]}'
{"id":"openocd~master~Ia8b1d221cf9df73db1196e3f51986023dcaf78eb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-04-15 12:56:24.000000000","reason":"Antonio Borneo replied on the change"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-04-15 00:08:42.000000000","reason":"Erhan Kurubas replied on the change"}},"hashtags":[],"change_id":"Ia8b1d221cf9df73db1196e3f51986023dcaf78eb","subject":"target/espressif: fix clang report on list use","status":"MERGED","created":"2023-04-14 22:39:42.000000000","updated":"2023-04-30 14:52:36.000000000","submitted":"2023-04-30 14:52:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7608","meta_rev_id":"d0150dc2220171fe4cff1757fef9cdab8f084f82","_number":7608,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-30 14:52:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-04-30 14:52:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-30 14:52:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-14 22:39:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2023-04-15 00:32:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"04b6209bff4b4affabf9f31adf6415e196fe8388","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-14 22:39:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4ee95f15fe4d2ee2f606bc30dba7dd0fa8d10177","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-04-15 00:08:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"11e34772c52dd04b86444bf8b703c3320986c68d","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-04-15 00:13:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ad9801e6a1bff082fc9d8d781dab79c47e1cf642","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-15 00:32:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16844/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17642/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e0a59e5c28b2040e05501309df7883d1d3548953","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-15 12:56:24.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d0150dc2220171fe4cff1757fef9cdab8f084f82","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-30 14:52:36.000000000","message":"Change has been successfully cherry-picked as 8670ad4caa705c460972badbd0fc28aa98c41866","accounts_in_message":[],"_revision_number":2}],"current_revision":"8670ad4caa705c460972badbd0fc28aa98c41866","revisions":{"a8bcf7197d90e9d6be02be0bcd7014662d590d71":{"kind":"REWORK","_number":1,"created":"2023-04-14 22:39:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/7608/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7608/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/1 \u0026\u0026 git checkout -b change-7608 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7608/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d2ee13bc108778b01c46a7f94a04cc0c19c775c","subject":"target/espressif: fix clang report on use of garbage value"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-14 22:25:54.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-14 22:37:22.000000000","tz":120},"subject":"target/espressif: fix clang report on list use","message":"target/espressif: fix clang report on list use\n\nIt looks like a false positive.\nScan-build considers as possible to:\n- have list_empty() return false;\n- list_for_each_safe() to not execute any loop, thus not assigning\n  a non-NULL value to \u0027block\u0027;\n- the NULL pointer \u0027block\u0027 is passed to list_del().\nThis is not possible because with list_empty(), the loop runs at\nleast once.\n\nRewrite the function to simplify the code and making it easier for\nscan-build to check it.\n\nThis also drops an incorrect use of list_for_each_safe(), where\nthe \u0027safe\u0027 version was not required.\n\nChange-Id: Ia8b1d221cf9df73db1196e3f51986023dcaf78eb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 8d1dcf293a0c (\"target/espressif: add application tracing functionality over JTAG\")\n"}},"8670ad4caa705c460972badbd0fc28aa98c41866":{"kind":"REWORK","_number":2,"created":"2023-04-30 14:52:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/7608/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/7608/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/2 \u0026\u0026 git checkout -b change-7608 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/7608/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/7608/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c1dc7935f78973e89dfe10e5b93238ae3f4eacd3","subject":"target/espressif: fix clang report on use of garbage value"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-14 22:25:54.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 14:52:36.000000000","tz":0},"subject":"target/espressif: fix clang report on list use","message":"target/espressif: fix clang report on list use\n\nIt looks like a false positive.\nScan-build considers as possible to:\n- have list_empty() return false;\n- list_for_each_safe() to not execute any loop, thus not assigning\n  a non-NULL value to \u0027block\u0027;\n- the NULL pointer \u0027block\u0027 is passed to list_del().\nThis is not possible because with list_empty(), the loop runs at\nleast once.\n\nRewrite the function to simplify the code and making it easier for\nscan-build to check it.\n\nThis also drops an incorrect use of list_for_each_safe(), where\nthe \u0027safe\u0027 version was not required.\n\nChange-Id: Ia8b1d221cf9df73db1196e3f51986023dcaf78eb\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 8d1dcf293a0c (\"target/espressif: add application tracing functionality over JTAG\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7608\nReviewed-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}