)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e6a2ac41f4009fab1e117aff01e98fdaffe84824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04ba5721_624cb901","updated":"2023-05-01 05:16:39.000000000","message":"Damn, just after sending the last reply I noticed we have very similar patch in gerrit. Could you please review \n7277: flash/nor/stm32f2x: fix OTP write protection | https://review.openocd.org/c/openocd/+/7277\nand put +1 score if you think it\u0027s ok\nThanks","commit_id":"b2837a3b82ba6d1635b5bac11ca875817430aa87"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4c7118bebd6c8a40bbd58fec70aa86de64521fe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6352f98b_00318868","updated":"2023-05-01 05:01:06.000000000","message":"Indeed, this part of the original code looks as never used.\nThanks for the fix.\n\nCould you please write what MCUs you tested the patch on?","commit_id":"b2837a3b82ba6d1635b5bac11ca875817430aa87"}],"src/flash/nor/stm32f2x.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4c7118bebd6c8a40bbd58fec70aa86de64521fe5","unresolved":true,"context_lines":[{"line_number":532,"context_line":"{"},{"line_number":533,"context_line":"\tstruct target *target \u003d bank-\u003etarget;"},{"line_number":534,"context_line":"\tuint32_t lock_base;"},{"line_number":535,"context_line":"\tunsigned int i, retval;"},{"line_number":536,"context_line":"\tuint8_t lock;"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"\tassert((first \u003c\u003d last) \u0026\u0026 (last \u003c bank-\u003enum_sectors));"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d18c88f6_99c17869","line":535,"range":{"start_line":535,"start_character":17,"end_line":535,"end_character":23},"updated":"2023-05-01 05:01:06.000000000","message":"Keep retval signed","commit_id":"b2837a3b82ba6d1635b5bac11ca875817430aa87"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4c7118bebd6c8a40bbd58fec70aa86de64521fe5","unresolved":true,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"\tlock_base \u003d stm32x_otp_is_f7(bank) ? STM32F7_OTP_LOCK_BASE"},{"line_number":549,"context_line":"\t\t  : STM32F2_OTP_LOCK_BASE;"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tfor (i \u003d first; i \u003c\u003d last; i++) {"},{"line_number":552,"context_line":"\t\tretval \u003d target_read_u8(target, lock_base + i, \u0026lock);"},{"line_number":553,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"789ec0d8_a7a63195","line":550,"updated":"2023-05-01 05:01:06.000000000","message":"While on it could you please add a comment that the code locks the range, no unlock possible","commit_id":"b2837a3b82ba6d1635b5bac11ca875817430aa87"}]}