)]}'
{"id":"openocd~master~Ib4a3e35cfe743731b760d198309cdd6e8a4833c7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001023":{"account":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"last_update":"2023-05-19 12:38:06.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ib4a3e35cfe743731b760d198309cdd6e8a4833c7","subject":"flash/nor/stm32f2x: Fix setting OTP sector protection","status":"ABANDONED","created":"2023-04-27 16:09:05.000000000","updated":"2023-05-19 12:38:06.000000000","total_comment_count":4,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"e638fb281e063579ee885b96f7c975a54b2001d2","_number":7612,"owner":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2023-04-27 17:31:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-27 16:13:16.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-04-27 17:31:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-01 05:01:06.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"9898665af1854155ee54bedaef7443ed720cda3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"real_author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"date":"2023-04-27 16:09:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"71574f5b2924a32cb101a1916d7ed9496093d26b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"real_author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"date":"2023-04-27 16:13:08.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c98f1d4679a4f33492f67c386f4662fdb2095fca","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-27 16:13:16.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"ef8010163ffe57cf6a3604f8a00f0942bbc09a1d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-27 17:31:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16847/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17647/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4c7118bebd6c8a40bbd58fec70aa86de64521fe5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-01 05:01:06.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e6a2ac41f4009fab1e117aff01e98fdaffe84824","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-01 05:16:39.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e638fb281e063579ee885b96f7c975a54b2001d2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"real_author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"date":"2023-05-19 12:38:06.000000000","message":"Abandoned\n\nClosing in favor of pre-existing (and better) patch: https://review.openocd.org/c/openocd/+/7277","accounts_in_message":[],"_revision_number":2}],"current_revision":"b2837a3b82ba6d1635b5bac11ca875817430aa87","revisions":{"b2837a3b82ba6d1635b5bac11ca875817430aa87":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-04-27 16:13:08.000000000","uploader":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"ref":"refs/changes/12/7612/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/7612/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/2 \u0026\u0026 git checkout -b change-7612 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/7612/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"91bd4313444c5a949ce49d88ab487608df7d6c37","subject":"pld: move file sanity checks to pld.c"}],"author":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 08:06:33.000000000","tz":120},"committer":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 16:11:49.000000000","tz":120},"subject":"flash/nor/stm32f2x: Fix setting OTP sector protection","message":"flash/nor/stm32f2x: Fix setting OTP sector protection\n\nThis fixes three problems:\n - The loop checked the wrong variable, so it would loop infinitely (try\n   to protect all sectors after the first requested, and then try to\n   read and/or or write to system ROM after the OTP and eventually error\n   out when passing the end of the system ROM area).\n - It treated a non-zero value as locked when checking the current\n   status before writing and the actual writing used 0xff as locked,\n   while in reality a value of 0x00 means a locked sector. In practice,\n   this means that it would skip unlocked sectors and try to write to\n   locked sectors (and fail).\n - The code did not perform the FLASH_KEYR sequence to unlock the\n   FLASH_CR register and enable flash programming with the FLASH_PG bit\n   (like the regular flash erase/write code does), which caused the\n   writes to silently fail.\n\nIn addition, the `i` variable was made unsigned to match the `first` and\n`last` arguments and prevent a signedness mismatch warning.\n\nChange-Id: Ib4a3e35cfe743731b760d198309cdd6e8a4833c7\nFixes: f21c12abec (\"flash: stm32f2/f4/f7: Add One-Time-Porgrammable (OTP) support\")\nBugLink: https://sourceforge.net/p/openocd/tickets/393/\nSigned-off-by: Matthijs Kooijman \u003cmatthijs@stdin.nl\u003e\n"}},"3248998224dc4b189bf4e2977ceb45dcb75c6495":{"kind":"REWORK","_number":1,"created":"2023-04-27 16:09:05.000000000","uploader":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"ref":"refs/changes/12/7612/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/7612/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/1 \u0026\u0026 git checkout -b change-7612 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/7612/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/7612/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"91bd4313444c5a949ce49d88ab487608df7d6c37","subject":"pld: move file sanity checks to pld.c"}],"author":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 08:06:33.000000000","tz":120},"committer":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 16:08:33.000000000","tz":120},"subject":"flash/nor/stm32f2x: Fix setting OTP sector protection","message":"flash/nor/stm32f2x: Fix setting OTP sector protection\n\nThis fixes three problems:\n - The loop checked the wrong variable, so it would loop infinitely (try\n   to protect all sectors after the first requested, and then try to\n   read and/or or write to system ROM after the OTP and eventually error\n   out when passing the end of the system ROM area).\n - It treated a non-zero value as locked when checking the current\n   status before writing and the actual writing used 0xff as locked,\n   while in reality a value of 0x00 means a locked sector. In practice,\n   this means that it would skip unlocked sectors and try to write to\n   locked sectors (and fail).\n - The code did not perform the FLASH_KEYR sequence to unlock the\n   FLASH_CR register and enable flash programming with the FLASH_PG bit\n   (like the regular flash erase/write code does), which caused the\n   writes to silently fail.\n\nIn addition, the `i` variable was made unsigned to match the `first` and\n`last` arguments and prevent a signedness mismatch warning.\n\nChange-Id: Ib4a3e35cfe743731b760d198309cdd6e8a4833c7\nSigned-off-by: Matthijs Kooijman \u003cmatthijs@stdin.nl\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}