)]}'
{"id":"openocd~master~I6d4974eb0bcd23a0a6cf68ff955d9e59b8b1b06a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001023":{"account":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"last_update":"2023-05-25 16:25:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6d4974eb0bcd23a0a6cf68ff955d9e59b8b1b06a","subject":"flash/nor/stm32f2x: Show error message when unprotecting OTP","status":"MERGED","created":"2023-04-27 16:37:48.000000000","updated":"2023-05-25 16:25:44.000000000","submitted":"2023-05-25 16:25:44.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7615","meta_rev_id":"9242aada876cd2f4ce3fff1b2841c23992584203","_number":7615,"owner":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-25 16:25:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-25 16:25:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-27 20:40:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-01 05:25:08.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"85c204cc4abff0bda929e76f02029a739727e79a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"real_author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"date":"2023-04-27 16:37:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"31b047e55b068d376e31136334709bfd7cd8821b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-27 20:40:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16850/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17649/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2993406269f18ddb8b68a12e3161c5c098399231","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-01 05:25:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9242aada876cd2f4ce3fff1b2841c23992584203","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-25 16:25:44.000000000","message":"Change has been successfully cherry-picked as a5d34202c6880bc9b8d0b326628ba1f2e5b061ff","accounts_in_message":[],"_revision_number":2}],"current_revision":"a5d34202c6880bc9b8d0b326628ba1f2e5b061ff","revisions":{"ac045143d4c7c988b756cccbbbdd9d227811feff":{"kind":"REWORK","_number":1,"created":"2023-04-27 16:37:48.000000000","uploader":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"ref":"refs/changes/15/7615/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/7615/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/1 \u0026\u0026 git checkout -b change-7615 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/7615/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a69f8dbf47fb76d54cf75d9375192c0041fbe627","subject":"flash/nor/stm32f2x: Fix typos in log messages"}],"author":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 16:34:44.000000000","tz":120},"committer":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 16:37:08.000000000","tz":120},"subject":"flash/nor/stm32f2x: Show error message when unprotecting OTP","message":"flash/nor/stm32f2x: Show error message when unprotecting OTP\n\nTrying to disable OTP write protection by running e.g. `flash protect\n1 0 1 off` would already be rejected with an error code, but that would\nresult in a generic \"failed setting protection for blocks 0 to 1\"\nmessage. Now a more specific error message is also printed, telling the\nuser why it failed.\n\nChange-Id: I6d4974eb0bcd23a0a6cf68ff955d9e59b8b1b06a\nSigned-off-by: Matthijs Kooijman \u003cmatthijs@stdin.nl\u003e\n"}},"a5d34202c6880bc9b8d0b326628ba1f2e5b061ff":{"kind":"REWORK","_number":2,"created":"2023-05-25 16:25:44.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/7615/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/7615/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/2 \u0026\u0026 git checkout -b change-7615 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/7615/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/7615/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3733cf196153f56be3a790311aeb95e3c15c56f3","subject":"flash/nor/stm32f2x: Fix typos in log messages"}],"author":{"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","date":"2023-04-27 16:34:44.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-25 16:25:44.000000000","tz":0},"subject":"flash/nor/stm32f2x: Show error message when unprotecting OTP","message":"flash/nor/stm32f2x: Show error message when unprotecting OTP\n\nTrying to disable OTP write protection by running e.g. `flash protect\n1 0 1 off` would already be rejected with an error code, but that would\nresult in a generic \"failed setting protection for blocks 0 to 1\"\nmessage. Now a more specific error message is also printed, telling the\nuser why it failed.\n\nChange-Id: I6d4974eb0bcd23a0a6cf68ff955d9e59b8b1b06a\nSigned-off-by: Matthijs Kooijman \u003cmatthijs@stdin.nl\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7615\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}