)]}'
{"id":"openocd~master~I2f7fadee903f9c65cdc9ab9b52ccb5803b48a59d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001810":{"account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"last_update":"2023-05-01 07:26:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1001810\u003e replied on the change","reason_account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-05 22:14:58.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I2f7fadee903f9c65cdc9ab9b52ccb5803b48a59d","subject":"pld: gatemate: fix memory leak","status":"MERGED","created":"2023-04-30 21:04:58.000000000","updated":"2023-05-05 22:15:02.000000000","submitted":"2023-05-05 22:15:02.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7632","meta_rev_id":"593524270c9520f3133f56d125c1eea8d5ad83e4","_number":7632,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-05 22:15:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-05 22:15:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-05 22:15:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-30 21:04:58.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"state":"REVIEWER"},{"updated":"2023-04-30 22:12:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-01 16:01:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d3958fae84f2b3eb833e18772fec7494518a8a7b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-30 21:04:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5cd1b73d697b3a863e22d0ef40bf128f2c8ab168","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-04-30 22:12:43.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16857/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17654/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3bf7147e4476368e5d66abc734057708793533bc","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2023-05-01 07:26:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d5ee4f34816d20df3e67eb880f22ca5f5a70a2e3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-01 15:02:09.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16859/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17656/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"71ebc864a3a3734e6462100e932e33ad46db501a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-01 16:01:32.000000000","message":"Patch Set 1: Verified+1","accounts_in_message":[],"_revision_number":1},{"id":"4b445ae2f6eb66e7bc42864b3777d2d7e5ec6acb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:14:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"593524270c9520f3133f56d125c1eea8d5ad83e4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 22:15:02.000000000","message":"Change has been successfully cherry-picked as 57f7ce68a48b03bcd198a009fc9c75fe3948c0db","accounts_in_message":[],"_revision_number":2}],"current_revision":"57f7ce68a48b03bcd198a009fc9c75fe3948c0db","revisions":{"57f7ce68a48b03bcd198a009fc9c75fe3948c0db":{"kind":"REWORK","_number":2,"created":"2023-05-05 22:15:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/32/7632/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/7632/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/2 \u0026\u0026 git checkout -b change-7632 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/7632/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d771d7f1a7d0181b4670c7c3ddb83ba8b8eb7da0","subject":"target: with pointers, use NULL instead of 0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 20:57:59.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-05 22:15:02.000000000","tz":0},"subject":"pld: gatemate: fix memory leak","message":"pld: gatemate: fix memory leak\n\nWhen gatemate_set_instr() fails, the array pointed by\nbit_file.raw_file.data is not freed.\nIssue identified by OpenOCD Jenkins clang build.\n\nFree the array while propagating the error.\n\nChange-Id: I2f7fadee903f9c65cdc9ab9b52ccb5803b48a59d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 682f927f8e4e (\"pld: add support for cologne chip gatemate fpgas\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7632\nTested-by: jenkins\nReviewed-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}},"9795a133e7f5e56ad6e697ca54fdbba71ffcb1cd":{"kind":"REWORK","_number":1,"created":"2023-04-30 21:04:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/32/7632/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/7632/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/1 \u0026\u0026 git checkout -b change-7632 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/7632/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/7632/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"682f927f8e4e6c6216c6d0b259b3c24b9f3f6342","subject":"pld: add support for cologne chip gatemate fpgas"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 20:57:59.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 21:02:14.000000000","tz":120},"subject":"pld: gatemate: fix memory leak","message":"pld: gatemate: fix memory leak\n\nWhen gatemate_set_instr() fails, the array pointed by\nbit_file.raw_file.data is not freed.\nIssue identified by OpenOCD Jenkins clang build.\n\nFree the array while propagating the error.\n\nChange-Id: I2f7fadee903f9c65cdc9ab9b52ccb5803b48a59d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 682f927f8e4e (\"pld: add support for cologne chip gatemate fpgas\")\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}