)]}'
{"id":"openocd~master~I42580ecd75ae824a4145f6f17f0df9bcf825b50f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001043":{"account":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"last_update":"2023-05-13 09:24:05.000000000","reason":"Change was submitted"},"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2023-05-13 09:24:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I42580ecd75ae824a4145f6f17f0df9bcf825b50f","subject":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap","status":"MERGED","created":"2023-05-02 12:30:34.000000000","updated":"2023-05-13 09:24:05.000000000","submitted":"2023-05-13 09:24:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7654","meta_rev_id":"cb0477f0964c24c78f3a51697dd42e478e3fa5d7","_number":7654,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-13 09:24:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-13 09:24:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-02 13:41:32.000000000","updated_by":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"reviewer":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"state":"REVIEWER"},{"updated":"2023-05-02 14:46:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-02 22:10:11.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-05-05 21:39:49.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"68e304b58a4549eeae8fe04e95522848389ce628","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2023-05-02 12:30:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0dbff6dce515f4a26b57463e18b8d3f6eed770d8","author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"real_author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"date":"2023-05-02 13:41:32.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9928dd08f81bbe1afb628be903c2b16a09b19214","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-02 14:46:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17659/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16862/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"17dd966822a203b63a053fe237d3a81a6126dcb9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-02 22:10:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1c096cf4d96c7ef10a837964b71fbdc8b55b4dbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2023-05-03 19:18:54.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2c09ab8665c014cd14b10819d902ec287e4d7dc0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-03 21:40:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17663/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16867/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d05e416631304a2b52d6a9414a1c8dfa7a4ab5bc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-05 21:39:49.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2893535561f7356627d20e1442704edbf33146b5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 09:23:58.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cb0477f0964c24c78f3a51697dd42e478e3fa5d7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 09:24:05.000000000","message":"Change has been successfully cherry-picked as 3a4f445bd92101d3daee3715178d3fbff3b7b029","accounts_in_message":[],"_revision_number":3}],"current_revision":"3a4f445bd92101d3daee3715178d3fbff3b7b029","revisions":{"19dec3227bb433279cccd147630d8af2a69967e1":{"kind":"REWORK","_number":1,"created":"2023-05-02 12:30:34.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/54/7654/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/7654/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/1 \u0026\u0026 git checkout -b change-7654 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/7654/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b8c62e5965960536ceffe8dbf20922845fa3e1ce","subject":"jtag: tcl: change drscan usage to show at least one value is required"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2023-05-02 12:15:21.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2023-05-02 12:28:24.000000000","tz":180},"subject":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap","message":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap\n\nTo perform any meaningful manipulations with DR the corresponding IR should\nbe set to a relevant instruction, not BYPASS, so warn the user accordingly.\n\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nChange-Id: I42580ecd75ae824a4145f6f17f0df9bcf825b50f\n"}},"3a4f445bd92101d3daee3715178d3fbff3b7b029":{"kind":"REWORK","_number":3,"created":"2023-05-13 09:24:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/7654/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/7654/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/3 \u0026\u0026 git checkout -b change-7654 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/7654/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d12ae796ead267aeef48467ccd49ec4c2f863ad","subject":"jtag: tcl: change drscan usage to show at least one value is required"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2023-05-02 12:15:21.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-13 09:24:05.000000000","tz":0},"subject":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap","message":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap\n\nTo perform any meaningful manipulations with DR the corresponding IR should\nbe set to a relevant instruction, not BYPASS, so warn the user accordingly.\n\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nChange-Id: I42580ecd75ae824a4145f6f17f0df9bcf825b50f\nReviewed-on: https://review.openocd.org/c/openocd/+/7654\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"ecbf7150af25ba20bb03d6e13d34d1990d967776":{"kind":"REWORK","_number":2,"created":"2023-05-03 19:18:54.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/54/7654/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/7654/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/2 \u0026\u0026 git checkout -b change-7654 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/7654/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/7654/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1e2759937555d12089a51a9ec44f95c05dc90dc","subject":"jtag: tcl: change drscan usage to show at least one value is required"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2023-05-02 12:15:21.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2023-05-03 19:17:02.000000000","tz":180},"subject":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap","message":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap\n\nTo perform any meaningful manipulations with DR the corresponding IR should\nbe set to a relevant instruction, not BYPASS, so warn the user accordingly.\n\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nChange-Id: I42580ecd75ae824a4145f6f17f0df9bcf825b50f\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}