)]}'
{"id":"openocd~master~If1f220aca67452adbcd3a1c9cf691fc984b16b27","project":"openocd","branch":"master","hashtags":[],"change_id":"If1f220aca67452adbcd3a1c9cf691fc984b16b27","subject":"jtag: xds110: fix check on malloc() returned pointer","status":"MERGED","created":"2023-05-06 08:43:23.000000000","updated":"2023-05-06 13:30:33.000000000","submitted":"2023-05-06 13:30:33.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7656","meta_rev_id":"7888169246eb157b0c3f4c8b8a463f1c135a102c","_number":7656,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-06 13:30:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-06 13:30:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-06 11:47:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b8dc05579528a4a60747b10aaa57818813c12fbe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-06 08:43:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aa2d945088be4189a95924013e1cc6d9df4c6dc5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-06 11:47:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17669/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16872/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c1b5f4f6d07c2fdc023d0277a670170c93a91844","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-06 13:30:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7888169246eb157b0c3f4c8b8a463f1c135a102c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-06 13:30:33.000000000","message":"Change has been successfully cherry-picked as 92c1bee18c8268511de3478aabd226ce4f92322a","accounts_in_message":[],"_revision_number":2}],"current_revision":"92c1bee18c8268511de3478aabd226ce4f92322a","revisions":{"adb1ec7539a9db5ffbc368989b2b87c6de31ad46":{"kind":"REWORK","_number":1,"created":"2023-05-06 08:43:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/56/7656/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7656/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/1 \u0026\u0026 git checkout -b change-7656 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7656/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd9137dc0e0c9a7dd3468ecb7adb0427b8f06715","subject":"pld/virtex2: add missing error checks"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 08:16:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 08:16:08.000000000","tz":120},"subject":"jtag: xds110: fix check on malloc() returned pointer","message":"jtag: xds110: fix check on malloc() returned pointer\n\nCommit 07e1ebcc12cd (\"jtag: drivers: with pointers, use NULL\ninstead of 0\") incorrectly inverts the check, making the driver\u0027s\npathmove operation not functional and triggering two clang errors.\n\nFix the check on malloc() returned pointer.\n\nChange-Id: If1f220aca67452adbcd3a1c9cf691fc984b16b27\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 07e1ebcc12cd (\"jtag: drivers: with pointers, use NULL instead of 0\")\n"}},"92c1bee18c8268511de3478aabd226ce4f92322a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-05-06 13:30:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/56/7656/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7656/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/2 \u0026\u0026 git checkout -b change-7656 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7656/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7656/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd9137dc0e0c9a7dd3468ecb7adb0427b8f06715","subject":"pld/virtex2: add missing error checks"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 08:16:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 13:30:33.000000000","tz":0},"subject":"jtag: xds110: fix check on malloc() returned pointer","message":"jtag: xds110: fix check on malloc() returned pointer\n\nCommit 07e1ebcc12cd (\"jtag: drivers: with pointers, use NULL\ninstead of 0\") incorrectly inverts the check, making the driver\u0027s\npathmove operation not functional and triggering two clang errors.\n\nFix the check on malloc() returned pointer.\n\nChange-Id: If1f220aca67452adbcd3a1c9cf691fc984b16b27\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 07e1ebcc12cd (\"jtag: drivers: with pointers, use NULL instead of 0\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7656\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}