)]}'
{"id":"openocd~master~I0f917aecc7534c1b51af0afa9b32ccfd33db3511","project":"openocd","branch":"master","hashtags":[],"change_id":"I0f917aecc7534c1b51af0afa9b32ccfd33db3511","subject":"pld: move in pld.h the pld_driver\u0027s declaration","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-18 10:07:58.000000000","submitted":"2023-05-18 10:07:58.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7663","meta_rev_id":"0b502a3a0e8d4c604c37d7d870d9e6258b5f748f","_number":7663,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:07:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:07:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-07 23:45:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9a34dfa88e735440ad61f1636654668d0ab631a4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"7f017e040949f3ac036cc616dcdcc11a7a42553c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-07 23:45:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17677/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16880/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"302aaf51e261e98119846e833db2b764d69f59a3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:07:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0b502a3a0e8d4c604c37d7d870d9e6258b5f748f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:07:58.000000000","message":"Change has been successfully cherry-picked as 177bafd4cccf505df0d02ace0d235af78cac4d8a","accounts_in_message":[],"_revision_number":2}],"current_revision":"177bafd4cccf505df0d02ace0d235af78cac4d8a","revisions":{"231fdf4bf8887a0171a596d90c79b112b724e608":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/7663/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/7663/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/1 \u0026\u0026 git checkout -b change-7663 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/7663/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"512412a2bf241eadaf59367eef98575efa7c1bb2","subject":"nor: move in driver.h the flash_driver\u0027s declaration"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 22:24:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 10:30:21.000000000","tz":120},"subject":"pld: move in pld.h the pld_driver\u0027s declaration","message":"pld: move in pld.h the pld_driver\u0027s declaration\n\nThe static analyser \u0027sparse\u0027 complains, while compiling a pld\ndriver, that the struct pld_driver is declared in the file as\nnon static, but it is not exposed through an include file.\nThe message is:\n\twarning: symbol \u0027XXX\u0027 was not declared. Should it be static?\n\nMove the list of pld_driver\u0027s declaration in pld.h\n\nChange-Id: I0f917aecc7534c1b51af0afa9b32ccfd33db3511\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"177bafd4cccf505df0d02ace0d235af78cac4d8a":{"kind":"REWORK","_number":2,"created":"2023-05-18 10:07:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/7663/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/7663/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/2 \u0026\u0026 git checkout -b change-7663 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/7663/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/7663/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20005eb81abaa3d191d6cdf36fd6f3d4e48a1db7","subject":"nor: move in driver.h the flash_driver\u0027s declaration"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 22:24:37.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:07:58.000000000","tz":0},"subject":"pld: move in pld.h the pld_driver\u0027s declaration","message":"pld: move in pld.h the pld_driver\u0027s declaration\n\nThe static analyser \u0027sparse\u0027 complains, while compiling a pld\ndriver, that the struct pld_driver is declared in the file as\nnon static, but it is not exposed through an include file.\nThe message is:\n\twarning: symbol \u0027XXX\u0027 was not declared. Should it be static?\n\nMove the list of pld_driver\u0027s declaration in pld.h\n\nChange-Id: I0f917aecc7534c1b51af0afa9b32ccfd33db3511\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7663\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}