)]}'
{"id":"openocd~master~I5b8f5fe48a89ff0ffce38d547c551cd196379fbf","project":"openocd","branch":"master","hashtags":[],"change_id":"I5b8f5fe48a89ff0ffce38d547c551cd196379fbf","subject":"jtag: move in interface.h the adapter_driver\u0027s declaration","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-18 10:09:24.000000000","submitted":"2023-05-18 10:09:24.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7665","meta_rev_id":"839bbd98b0d2d2844fdc01429fbe592fd3fef029","_number":7665,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:09:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:09:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-07 22:33:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27879b92280943eed1f5440781abba78f5dd93bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"6b140491bf738b2d563d6efaa6fe11757893e92f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-07 22:33:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17676/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16879/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6255f024f82f503340f5661aca1f4c0b28dbcca4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:09:17.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"839bbd98b0d2d2844fdc01429fbe592fd3fef029","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:09:24.000000000","message":"Change has been successfully cherry-picked as ea530015b0f69d7a0e3ee3dca6fb69554e6d2046","accounts_in_message":[],"_revision_number":2}],"current_revision":"ea530015b0f69d7a0e3ee3dca6fb69554e6d2046","revisions":{"a7444b1a7778a4fe864f50e9c0d34bdde1d67cc6":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/65/7665/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/7665/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/1 \u0026\u0026 git checkout -b change-7665 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/7665/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ea2b702ad7688f3c4bc97e6b556d0ffa5bf4f0e","subject":"pld: validate exported functions by including its own .h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 22:40:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 10:32:43.000000000","tz":120},"subject":"jtag: move in interface.h the adapter_driver\u0027s declaration","message":"jtag: move in interface.h the adapter_driver\u0027s declaration\n\nThe static analyser \u0027sparse\u0027 complains, while compiling a jtag\ndriver, that the struct adapter_driver is declared in the file as\nnon static, but it is not exposed through an include file.\nThe message is:\n\twarning: symbol \u0027XXX\u0027 was not declared. Should it be static?\n\nMove the list of adapter_driver\u0027s declaration in interface.h\nDrop the preprocessor #ifdef/#endif around the declaration, as it\nhas no effect when the declaration is not used and/or the symbol\ndoes not exist.\n\nChange-Id: I5b8f5fe48a89ff0ffce38d547c551cd196379fbf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ea530015b0f69d7a0e3ee3dca6fb69554e6d2046":{"kind":"REWORK","_number":2,"created":"2023-05-18 10:09:24.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/65/7665/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/7665/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/2 \u0026\u0026 git checkout -b change-7665 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/7665/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/7665/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e17fe4db0f256ee4fb97dcfd6b9f7f55c966b190","subject":"pld: validate exported functions by including its own .h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 22:40:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:09:24.000000000","tz":0},"subject":"jtag: move in interface.h the adapter_driver\u0027s declaration","message":"jtag: move in interface.h the adapter_driver\u0027s declaration\n\nThe static analyser \u0027sparse\u0027 complains, while compiling a jtag\ndriver, that the struct adapter_driver is declared in the file as\nnon static, but it is not exposed through an include file.\nThe message is:\n\twarning: symbol \u0027XXX\u0027 was not declared. Should it be static?\n\nMove the list of adapter_driver\u0027s declaration in interface.h\nDrop the preprocessor #ifdef/#endif around the declaration, as it\nhas no effect when the declaration is not used and/or the symbol\ndoes not exist.\n\nChange-Id: I5b8f5fe48a89ff0ffce38d547c551cd196379fbf\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7665\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}