)]}'
{"id":"openocd~master~I2c22b084fb513f4b3b1b1db96dfbc8fa4bfe7238","project":"openocd","branch":"master","hashtags":[],"change_id":"I2c22b084fb513f4b3b1b1db96dfbc8fa4bfe7238","subject":"nand: declare exported function in core.h","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-18 10:09:57.000000000","submitted":"2023-05-18 10:09:57.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7666","meta_rev_id":"5194491073f6e204e11bb3dd30d505d78cf33364","_number":7666,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:09:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:09:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-08 02:34:46.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c6a5b581917e6bb88603477f6955e0ceb9578e7e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"add7a962ed94591af1e2ed60b3c83becbf5fc40b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-08 02:34:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17679/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16882/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7b111f8fdd2c44ec0fd7bdcb9bcb4c3245919af9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:09:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5194491073f6e204e11bb3dd30d505d78cf33364","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:09:57.000000000","message":"Change has been successfully cherry-picked as faf7202f8ee65f21a96ea1ebf33f7157c97065f0","accounts_in_message":[],"_revision_number":2}],"current_revision":"faf7202f8ee65f21a96ea1ebf33f7157c97065f0","revisions":{"950a683cca99947636ab175bc2ff0e069ff780f0":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/7666/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/7666/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/1 \u0026\u0026 git checkout -b change-7666 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/7666/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7444b1a7778a4fe864f50e9c0d34bdde1d67cc6","subject":"jtag: move in interface.h the adapter_driver\u0027s declaration"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 22:55:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 10:35:44.000000000","tz":120},"subject":"nand: declare exported function in core.h","message":"nand: declare exported function in core.h\n\nDon\u0027t use \u0027extern\u0027 in a C file, but declare the exported function\nin a H file.\nThis helps validating the function prototype across declaration\nand use.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I2c22b084fb513f4b3b1b1db96dfbc8fa4bfe7238\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"faf7202f8ee65f21a96ea1ebf33f7157c97065f0":{"kind":"REWORK","_number":2,"created":"2023-05-18 10:09:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/7666/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/7666/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/2 \u0026\u0026 git checkout -b change-7666 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/7666/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/7666/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea530015b0f69d7a0e3ee3dca6fb69554e6d2046","subject":"jtag: move in interface.h the adapter_driver\u0027s declaration"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 22:55:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:09:57.000000000","tz":0},"subject":"nand: declare exported function in core.h","message":"nand: declare exported function in core.h\n\nDon\u0027t use \u0027extern\u0027 in a C file, but declare the exported function\nin a H file.\nThis helps validating the function prototype across declaration\nand use.\n\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I2c22b084fb513f4b3b1b1db96dfbc8fa4bfe7238\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7666\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}