)]}'
{"id":"openocd~master~I0b84043600a41c72d0e4ddb3dd195d69e3b2896b","project":"openocd","branch":"master","hashtags":[],"change_id":"I0b84043600a41c72d0e4ddb3dd195d69e3b2896b","subject":"helper: types: rework h_u32_to_le() and similar for sparse","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-18 10:12:16.000000000","submitted":"2023-05-18 10:12:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7670","meta_rev_id":"8cfa2646d8e9c214f3123439950407fb4d134ad0","_number":7670,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:12:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:12:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-08 07:40:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5cd0fc771d79eb7340aff7a92691e391ce232fa1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"88f41478088d6abcef489df0e23550b2fff49bca","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-08 07:40:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17682/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16885/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"46a8695640f5402c7a67b7098ea6308b85925ac0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:12:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8cfa2646d8e9c214f3123439950407fb4d134ad0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:12:16.000000000","message":"Change has been successfully cherry-picked as d2afdefd264f088c2c1057026037cfe5b5a86413","accounts_in_message":[],"_revision_number":2}],"current_revision":"d2afdefd264f088c2c1057026037cfe5b5a86413","revisions":{"139a4c13ec50e7a19c376271354d143e765e7923":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/7670/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/7670/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/1 \u0026\u0026 git checkout -b change-7670 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/7670/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9dbcce24d0e30f88cdce7d9316adbdd64dc10728","subject":"target: arm_dpm: with pointers, use NULL instead of 0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 14:35:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 14:55:27.000000000","tz":120},"subject":"helper: types: rework h_u32_to_le() and similar for sparse","message":"helper: types: rework h_u32_to_le() and similar for sparse\n\nThe static analyser \u0027sparse\u0027 complains about values bigger that\n255 that gets cast-ed and/or stored in an 8 bit variable.\n\nRework the functions:\n- h_u32_to_le()\n- h_u32_to_be()\n- h_u24_to_le()\n- h_u24_to_be()\n- h_u16_to_le()\n- h_u16_to_be()\nto avoid all the related warnings, without adding any functional\nchange. Any modern compiler should not be impacted by this.\n\nChange-Id: I0b84043600a41c72d0e4ddb3dd195d69e3b2896b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d2afdefd264f088c2c1057026037cfe5b5a86413":{"kind":"REWORK","_number":2,"created":"2023-05-18 10:12:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/7670/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/7670/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/2 \u0026\u0026 git checkout -b change-7670 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/7670/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/7670/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d15f58ad4c451ca30478d26a89295c65b7257d0d","subject":"target: arm_dpm: with pointers, use NULL instead of 0"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 14:35:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:12:16.000000000","tz":0},"subject":"helper: types: rework h_u32_to_le() and similar for sparse","message":"helper: types: rework h_u32_to_le() and similar for sparse\n\nThe static analyser \u0027sparse\u0027 complains about values bigger that\n255 that gets cast-ed and/or stored in an 8 bit variable.\n\nRework the functions:\n- h_u32_to_le()\n- h_u32_to_be()\n- h_u24_to_le()\n- h_u24_to_be()\n- h_u16_to_le()\n- h_u16_to_be()\nto avoid all the related warnings, without adding any functional\nchange. Any modern compiler should not be impacted by this.\n\nChange-Id: I0b84043600a41c72d0e4ddb3dd195d69e3b2896b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7670\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}