)]}'
{"id":"openocd~master~Ia5dfb92dc4bc6d52ead4f0cb8c68319c83ff85b0","project":"openocd","branch":"master","hashtags":[],"change_id":"Ia5dfb92dc4bc6d52ead4f0cb8c68319c83ff85b0","subject":"jtag: move declaration outside function","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-18 10:14:21.000000000","submitted":"2023-05-18 10:14:21.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7672","meta_rev_id":"212c1ffdea71bf6e9644ab689c1f1894e66b35aa","_number":7672,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:14:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:14:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-08 11:45:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f4290a70f3551cee2b2370ccdf64ae0300146e53","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"cc6c641f0ac0a6b9b239bc5a3b17d82dc482e6da","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-08 11:45:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17685/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16888/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"eba216fd7ab8e39fdd360e1adac94eddd722d5f1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:14:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"212c1ffdea71bf6e9644ab689c1f1894e66b35aa","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:14:21.000000000","message":"Change has been successfully cherry-picked as 7fa29dc5196accb3ea159e6a29fd969640e30421","accounts_in_message":[],"_revision_number":2}],"current_revision":"7fa29dc5196accb3ea159e6a29fd969640e30421","revisions":{"a354771002241491b2a1afdbc43c4ce4338d32a3":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/7672/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/7672/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/1 \u0026\u0026 git checkout -b change-7672 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/7672/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e961ba497fd455b3881a2427b23cfdad359d8c4b","subject":"hello: include hello.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 19:28:51.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 14:58:54.000000000","tz":120},"subject":"jtag: move declaration outside function","message":"jtag: move declaration outside function\n\nThe function jtag_debug_state_machine_() is only used by a static\ninline function and declared inside it as private.\nThe static analyser \u0027sparse\u0027 complains that the function is\ndefined as global but not cross checked against a prototype in an\ninclude file.\n\nMove the declaration outside the inline function so it get visible\nby interface.c, which already includes interface.h\nWhile there, change the argument type from \u0027unsigned\u0027 to \u0027unsigned\nint\u0027 to pass checkpatch check.\n\nChange-Id: Ia5dfb92dc4bc6d52ead4f0cb8c68319c83ff85b0\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7fa29dc5196accb3ea159e6a29fd969640e30421":{"kind":"REWORK","_number":2,"created":"2023-05-18 10:14:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/7672/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/7672/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/2 \u0026\u0026 git checkout -b change-7672 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/7672/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/7672/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"04a11812883fafee8f0fcb4fee64832716fd43ca","subject":"hello: include hello.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 19:28:51.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:14:21.000000000","tz":0},"subject":"jtag: move declaration outside function","message":"jtag: move declaration outside function\n\nThe function jtag_debug_state_machine_() is only used by a static\ninline function and declared inside it as private.\nThe static analyser \u0027sparse\u0027 complains that the function is\ndefined as global but not cross checked against a prototype in an\ninclude file.\n\nMove the declaration outside the inline function so it get visible\nby interface.c, which already includes interface.h\nWhile there, change the argument type from \u0027unsigned\u0027 to \u0027unsigned\nint\u0027 to pass checkpatch check.\n\nChange-Id: Ia5dfb92dc4bc6d52ead4f0cb8c68319c83ff85b0\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7672\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}