)]}'
{"id":"openocd~master~I08c6b92fb01594320bc3ae6b16067ac4eb51ca12","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-18 13:04:55.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I08c6b92fb01594320bc3ae6b16067ac4eb51ca12","subject":"target: espressif: apptrace: declare a local function as static","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-27 06:39:35.000000000","submitted":"2023-05-27 06:39:35.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7676","meta_rev_id":"0c2f3c8a838a53f1ca90ffd38e1e3b017a19e5e0","_number":7676,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-27 06:39:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-27 06:39:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-08 16:41:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b7b498ef8097e41702fe76c223e35eb3c1ed89ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"07b51c31d8ec67a456c65ca74c3e79dd5af7537b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-08 16:41:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17689/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16892/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d42e46f6663cd884db346dbc055bb866cf9a562e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 13:02:15.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a987f9d64b23abb5a13c5209ceb404f97b57d2c8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 13:04:55.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"131ce294705d6ebc8fc8adbed33c0ea510452116","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-18 13:15:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17730/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16932/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"524132e65e8a8731cc44d7d013181deb43965fa6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-27 06:39:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0c2f3c8a838a53f1ca90ffd38e1e3b017a19e5e0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-27 06:39:35.000000000","message":"Change has been successfully cherry-picked as 0f0a4b1452198160ae38be3d26ebd555224e3fbc","accounts_in_message":[],"_revision_number":3}],"current_revision":"0f0a4b1452198160ae38be3d26ebd555224e3fbc","revisions":{"9440f09251a8e7d54d9cbe044c616479a129ff39":{"kind":"REWORK","_number":2,"created":"2023-05-18 13:02:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/7676/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/7676/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/2 \u0026\u0026 git checkout -b change-7676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/7676/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc01e9ad0899b27a57492b3d55532435bac44c46","subject":"target/espressif: add system level tracing feature"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 20:26:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 13:00:00.000000000","tz":120},"subject":"target: espressif: apptrace: declare a local function as static","message":"target: espressif: apptrace: declare a local function as static\n\nThe function esp32_cmd_apptrace_generic() is not used outside the\nfile.\n\nDeclare it as static.\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I08c6b92fb01594320bc3ae6b16067ac4eb51ca12\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0f0a4b1452198160ae38be3d26ebd555224e3fbc":{"kind":"REWORK","_number":3,"created":"2023-05-27 06:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/7676/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/7676/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/3 \u0026\u0026 git checkout -b change-7676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/7676/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a0fecd6c41a6f2c965352efb0df70a149b7b260c","subject":"target/espressif: add system level tracing feature"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 20:26:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-27 06:39:35.000000000","tz":0},"subject":"target: espressif: apptrace: declare a local function as static","message":"target: espressif: apptrace: declare a local function as static\n\nThe function esp32_cmd_apptrace_generic() is not used outside the\nfile.\n\nDeclare it as static.\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I08c6b92fb01594320bc3ae6b16067ac4eb51ca12\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7676\nTested-by: jenkins\n"}},"f2f6c14d6dde5b7b5dd839e1841dd5a2c35ee739":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/7676/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/7676/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/1 \u0026\u0026 git checkout -b change-7676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/7676/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/7676/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8631c693395bd4f2b31d08d5630460fad53dc36a","subject":"target: arm_adi_v5: move in include file the declaration of dap_ops"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-06 20:26:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 14:59:38.000000000","tz":120},"subject":"target: espressif: apptrace: declare a local function as static","message":"target: espressif: apptrace: declare a local function as static\n\nThe function esp32_cmd_apptrace_generic() is not used outside the\nfile.\n\nDeclare it as static.\nDetected through \u0027sparse\u0027 tool.\n\nChange-Id: I08c6b92fb01594320bc3ae6b16067ac4eb51ca12\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
