)]}'
{"id":"openocd~master~I569011a257783d35a8795adbda06e942b4157f2a","project":"openocd","branch":"master","hashtags":[],"change_id":"I569011a257783d35a8795adbda06e942b4157f2a","subject":"rtos: uCOS-III: split struct ucos_iii_params","status":"MERGED","created":"2023-05-07 15:03:57.000000000","updated":"2023-05-18 10:17:18.000000000","submitted":"2023-05-18 10:17:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7678","meta_rev_id":"0f9085b11c00554b691824d189a49e7a9148ab46","_number":7678,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:17:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:17:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-08 18:57:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6381f3688abb143caa7a8e7bfcfbd86ad96fc20d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-07 15:03:57.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"c3d4475b6f207c02276bf99950397a8761d779c8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-08 18:57:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17691/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16894/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3fa6949897af71457d172bc64caf5f32a8041bf6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:17:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0f9085b11c00554b691824d189a49e7a9148ab46","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:17:18.000000000","message":"Change has been successfully cherry-picked as 17f86fdedf03626eed545dcd69c6387a825e0b5d","accounts_in_message":[],"_revision_number":2}],"current_revision":"17f86fdedf03626eed545dcd69c6387a825e0b5d","revisions":{"17f86fdedf03626eed545dcd69c6387a825e0b5d":{"kind":"REWORK","_number":2,"created":"2023-05-18 10:17:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/78/7678/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/7678/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/2 \u0026\u0026 git checkout -b change-7678 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/7678/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aaa67f733df5ef29bfdc83e808434a23d6edb580","subject":"rtos: move prototype of rtos_thread_packet() in rtos.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 13:50:26.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:17:18.000000000","tz":0},"subject":"rtos: uCOS-III: split struct ucos_iii_params","message":"rtos: uCOS-III: split struct ucos_iii_params\n\nThe static analyser \u0027sparse\u0027 complains about using sizeof() on a\nstruct that has variable size:\n\tsrc/rtos/uCOS-III.c:267:32: warning: using sizeof on a flexible structure\n\tsrc/rtos/uCOS-III.c:269:41: warning: using sizeof on a flexible structure\n\tsrc/rtos/uCOS-III.c:275:66: warning: using sizeof on a flexible structure\nThe struct ucos_iii_params contains either constants values for\ndifferent target type and variable fields. The last field is an\nvariable size array, always allocated to UCOS_III_MAX_THREADS\nitems. It\u0027s not practical to fix this size because we would get\ntoo huge initialization in data segment.\n\nSplit away from struct ucos_iii_params all the variable fields and\nput them in struct ucos_iii_private. Add in the new struct a\npointer to the selected element of ucos_iii_params_list[] and fix\nthe size of array threads[] to its maximum value; this would be\nallocated at run-time, avoiding impacts to data segment.\n\nChange-Id: I569011a257783d35a8795adbda06e942b4157f2a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7678\nTested-by: jenkins\n"}},"507f608e1300e9302cee8202b70954cc3d7e5c36":{"kind":"REWORK","_number":1,"created":"2023-05-07 15:03:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/78/7678/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/7678/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/1 \u0026\u0026 git checkout -b change-7678 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/7678/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/7678/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4fff6732d52c66070ebd67176580c456d9b92963","subject":"rtos: move prototype of rtos_thread_packet() in rtos.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 13:50:26.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-07 14:59:38.000000000","tz":120},"subject":"rtos: uCOS-III: split struct ucos_iii_params","message":"rtos: uCOS-III: split struct ucos_iii_params\n\nThe static analyser \u0027sparse\u0027 complains about using sizeof() on a\nstruct that has variable size:\n\tsrc/rtos/uCOS-III.c:267:32: warning: using sizeof on a flexible structure\n\tsrc/rtos/uCOS-III.c:269:41: warning: using sizeof on a flexible structure\n\tsrc/rtos/uCOS-III.c:275:66: warning: using sizeof on a flexible structure\nThe struct ucos_iii_params contains either constants values for\ndifferent target type and variable fields. The last field is an\nvariable size array, always allocated to UCOS_III_MAX_THREADS\nitems. It\u0027s not practical to fix this size because we would get\ntoo huge initialization in data segment.\n\nSplit away from struct ucos_iii_params all the variable fields and\nput them in struct ucos_iii_private. Add in the new struct a\npointer to the selected element of ucos_iii_params_list[] and fix\nthe size of array threads[] to its maximum value; this would be\nallocated at run-time, avoiding impacts to data segment.\n\nChange-Id: I569011a257783d35a8795adbda06e942b4157f2a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}