)]}'
{"id":"openocd~master~I1fb3949070c8abbf4aa45a740f0ca2fdb753d4fa","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-13 08:47:22.000000000","reason":"removed on reply"},"1001982":{"account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"last_update":"2023-05-08 13:52:10.000000000","reason":"\u003cGERRIT_ACCOUNT_1001982\u003e replied on the change","reason_account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-05-08 10:12:19.000000000","reason":"\u003cGERRIT_ACCOUNT_1001964\u003e replied on the change","reason_account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}}},"hashtags":[],"change_id":"I1fb3949070c8abbf4aa45a740f0ca2fdb753d4fa","subject":"xtensa: fix build with gcc 13.1.1","status":"MERGED","created":"2023-05-08 08:54:16.000000000","updated":"2023-05-13 08:47:27.000000000","submitted":"2023-05-13 08:47:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7681","meta_rev_id":"a5f16855bec3557e8471b8a75ff233093bfb8de5","_number":7681,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-13 08:47:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-13 08:47:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-13 08:47:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-13 08:47:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-08 08:54:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2023-05-08 08:54:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"state":"REVIEWER"},{"updated":"2023-05-08 22:41:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a65d7d3c833e23baf1bc79e58bc215834f40ebd9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-08 08:54:16.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"f7c2ddc52498a4c891fa4e86c0286637cf91ea18","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-05-08 10:12:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7e278aef3692d64d1f6751673352a7244cfb763d","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2023-05-08 13:52:10.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d0ee533e13409ef3892bfe08ba3ec22d510fd4d6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-08 22:41:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17694/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16897/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"525d46ab20632f4393cfe725049643868a48a83b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 08:47:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a5f16855bec3557e8471b8a75ff233093bfb8de5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 08:47:27.000000000","message":"Change has been successfully cherry-picked as 160288137aad7dc8825566f2221dd24db7f81110","accounts_in_message":[],"_revision_number":2}],"current_revision":"160288137aad7dc8825566f2221dd24db7f81110","revisions":{"986c0be76e5b5e54800ca3404eaf0d541e7958bc":{"kind":"REWORK","_number":1,"created":"2023-05-08 08:54:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/7681/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/7681/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/1 \u0026\u0026 git checkout -b change-7681 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/7681/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-08 08:45:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-08 08:45:25.000000000","tz":120},"subject":"xtensa: fix build with gcc 13.1.1","message":"xtensa: fix build with gcc 13.1.1\n\nNew gcc does not understand that the variable \u0027restore_ms\u0027 is set\nto \u0027true\u0027 only when the variable \u0027ms\u0027 is assigned in\n\tstatic int xtensa_write_dirty_registers(...)\n\t{\n\t\txtensa_reg_val_t ms;\n\t\tbool restore_ms \u003d false;\n\t\t...\n\t\tif (...) {\n\t\t\tms \u003d regval;\n\t\t\trestore_ms \u003d true;\n\t\t\t...\n\t\t}\n\t\t...\n\t\tif (restore_ms) {\n\t\t\tUSE(ms);\n\t\t}\n\t\t...\n\t}\nand complains about possible use of uninitialized variable \u0027ms\u0027.\n\nSadly initialize \u0027ms\u0027 to zero to hide this false positive.\n\nChange-Id: I1fb3949070c8abbf4aa45a740f0ca2fdb753d4fa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"160288137aad7dc8825566f2221dd24db7f81110":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-05-13 08:47:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/7681/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/7681/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/2 \u0026\u0026 git checkout -b change-7681 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/7681/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/7681/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-08 08:45:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-13 08:47:27.000000000","tz":0},"subject":"xtensa: fix build with gcc 13.1.1","message":"xtensa: fix build with gcc 13.1.1\n\nNew gcc does not understand that the variable \u0027restore_ms\u0027 is set\nto \u0027true\u0027 only when the variable \u0027ms\u0027 is assigned in\n\tstatic int xtensa_write_dirty_registers(...)\n\t{\n\t\txtensa_reg_val_t ms;\n\t\tbool restore_ms \u003d false;\n\t\t...\n\t\tif (...) {\n\t\t\tms \u003d regval;\n\t\t\trestore_ms \u003d true;\n\t\t\t...\n\t\t}\n\t\t...\n\t\tif (restore_ms) {\n\t\t\tUSE(ms);\n\t\t}\n\t\t...\n\t}\nand complains about possible use of uninitialized variable \u0027ms\u0027.\n\nSadly initialize \u0027ms\u0027 to zero to hide this false positive.\n\nChange-Id: I1fb3949070c8abbf4aa45a740f0ca2fdb753d4fa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7681\nReviewed-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nReviewed-by: Ian Thompson \u003cianst@cadence.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}