)]}'
{"id":"openocd~master~Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-12 13:32:41.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-05-18 10:23:18.000000000","reason":"Change was submitted"},"1002140":{"account":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"last_update":"2023-05-18 10:23:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6","subject":"tcl/target: Add support for TMS570LC43xx","status":"MERGED","created":"2023-05-09 09:24:54.000000000","updated":"2023-05-18 10:23:18.000000000","submitted":"2023-05-18 10:23:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7682","meta_rev_id":"d0e00c689ecb5e2ea1b4d9bd9ae0ee8d0195252a","_number":7682,"owner":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-18 10:23:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-18 10:23:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-09 09:39:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-10 16:46:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-05-11 16:12:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2023-05-12 13:32:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"15e4ecceb0386d7a9a49cc67bf2d3636bb514212","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-09 09:24:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a51569641be033e24ceed8909048494f4ca6d660","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-09 09:39:20.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17701/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16903/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"8db621160f983c212cbff89b568a11a2982a25b9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-09 12:12:51.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"39adc63a228f6cc547af0c5b6b24033824a246e8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-09 14:58:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17703/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16905/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"56c50ae838f7756a1d1d7e26a430cb4ddc546673","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-10 16:46:10.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cce9214197775953e5f63253aec094d5b8d3be2a","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-11 07:44:57.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ee894d5744e67f3a81fabd0abd976b8c4a78196f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-11 16:12:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"60fc9acc9416f2f6f7cf541de295644bb6337388","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-11 16:47:37.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f7a6970004921cfc17250d84acd57a4591c4830b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-12 07:28:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8d6c11a8c2a88471e5b24ec2ba982b951809c776","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-12 13:11:18.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"2d46ece1a2ee847bb315645059a0619455f63b85","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-12 13:12:08.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"96e66f5d1a02212418f16baee4c00f048a1bb7cc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-12 13:12:12.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17708/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16910/ : ABORTED","accounts_in_message":[],"_revision_number":3},{"id":"e47d11b802f9364d5f88ae57e271cad5034929fe","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-12 13:15:31.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"25fb11a9f61d028cf58ca6a7dfac17383957e81b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-12 13:32:41.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"32102f5b28f52d5d2099544f1dbbeab3baffd1ef","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-12 14:39:24.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17709/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16911/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"5fb6f122680daa69455cb0d8ef335147ce3bbf22","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-12 14:40:50.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"8b9c7b196ab95ef1584f8d93fb800656354b166f","author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"real_author":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"date":"2023-05-12 16:10:55.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f3ae40e03e30b23bcd0e7b62d7f39205c97aaaf2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:23:11.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d0e00c689ecb5e2ea1b4d9bd9ae0ee8d0195252a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-18 10:23:18.000000000","message":"Change has been successfully cherry-picked as 30b0e9af8d1e68ee051ac62dd0e27c920fb396bd","accounts_in_message":[],"_revision_number":5}],"current_revision":"30b0e9af8d1e68ee051ac62dd0e27c920fb396bd","revisions":{"f01161d697667d45d1bcae047dcbe2c4b199fb39":{"kind":"REWORK","_number":4,"created":"2023-05-12 13:12:08.000000000","uploader":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"ref":"refs/changes/82/7682/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7682/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/4 \u0026\u0026 git checkout -b change-7682 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7682/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 09:04:24.000000000","tz":120},"committer":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-12 13:12:00.000000000","tz":120},"subject":"tcl/target: Add support for TMS570LC43xx","message":"tcl/target: Add support for TMS570LC43xx\n\nAdded support for TMS570LC43xx series parts.  This uses the pre-existing\nti_tms570.cfg parent config.  In ti_tms570.cfg, dbgbase was changed.\nNote 1: Based on the following TI E2E post, the previous dbgbase was wrong\nand the new value isn\u0027t due to a difference in parts.\nLink: https://e2e.ti.com/support/microcontrollers/arm-based-microcontrollers-group/arm-based-microcontrollers/f/arm-based-microcontrollers-forum/1106954/tms570ls3137-debugging-with-openocd\nNote 2: Both the previous dbgbase and the one suggested in the TI E2E post\nhave the 2 LSB set. In the current version of OpenOCD, this will cause\ncortex_a_read_cpu_memory_fast and cortex_a_write_cpu_memory_fast to fail\ndue to an alignment checks in\nmem_ap_\u003cread/write\u003e_buf_noincr()-\u003emem_ap_\u003cread/write\u003e().\nIn all other uses of dbgbase for arm cortex parts, the 2 LSB are masked\nand ignored.\n\nChange-Id: Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6\nSigned-off-by: Phil Kirkpatrick \u003cp.kirkpatrick@reflexaerospace.com\u003e\n"}},"30b0e9af8d1e68ee051ac62dd0e27c920fb396bd":{"kind":"REWORK","_number":5,"created":"2023-05-18 10:23:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/7682/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7682/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/5 \u0026\u0026 git checkout -b change-7682 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7682/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d4225192df17687f82fa35e5aaec6bed533a8f1f","subject":"flash/jtagspi: handle error return values where needed"}],"author":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 09:04:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-18 10:23:18.000000000","tz":0},"subject":"tcl/target: Add support for TMS570LC43xx","message":"tcl/target: Add support for TMS570LC43xx\n\nAdded support for TMS570LC43xx series parts.  This uses the pre-existing\nti_tms570.cfg parent config.  In ti_tms570.cfg, dbgbase was changed.\nNote 1: Based on the following TI E2E post, the previous dbgbase was wrong\nand the new value isn\u0027t due to a difference in parts.\nLink: https://e2e.ti.com/support/microcontrollers/arm-based-microcontrollers-group/arm-based-microcontrollers/f/arm-based-microcontrollers-forum/1106954/tms570ls3137-debugging-with-openocd\nNote 2: Both the previous dbgbase and the one suggested in the TI E2E post\nhave the 2 LSB set. In the current version of OpenOCD, this will cause\ncortex_a_read_cpu_memory_fast and cortex_a_write_cpu_memory_fast to fail\ndue to an alignment checks in\nmem_ap_\u003cread/write\u003e_buf_noincr()-\u003emem_ap_\u003cread/write\u003e().\nIn all other uses of dbgbase for arm cortex parts, the 2 LSB are masked\nand ignored.\n\nChange-Id: Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6\nSigned-off-by: Phil Kirkpatrick \u003cp.kirkpatrick@reflexaerospace.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7682\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d3eaecfec955bb091195787d8cb13f3cc97e5aec":{"kind":"REWORK","_number":1,"created":"2023-05-09 09:24:54.000000000","uploader":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"ref":"refs/changes/82/7682/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7682/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/1 \u0026\u0026 git checkout -b change-7682 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7682/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 09:04:24.000000000","tz":120},"committer":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 09:20:55.000000000","tz":120},"subject":"tcl/target: Add support for TMS570LC43xx","message":"tcl/target: Add support for TMS570LC43xx\n\nAdded support for TMS570LC43xx series parts.  This uses the pre-existing\nti_tms570.cfg parent config.  In ti_tms570.cfg, dbgbase was changed.\nNote 1: Based on the following TI E2E post, the previous dbgbase was wrong\nand the new value isn\u0027t due to a difference in parts.\nhttps://e2e.ti.com/support/microcontrollers/arm-based-microcontrollers-group/arm-based-microcontrollers/f/arm-based-microcontrollers-forum/1106954/tms570ls3137-debugging-with-openocd\nNote 2: Both the previous dbgbase and the one suggested in the TI E2E post\nhave the 2 LSB set. In the current version of OpenOCD, this will cause\ncortex_a_read_cpu_memory_fast and cortex_a_write_cpu_memory_fast to fail\ndue to an alignment checks in\nmem_ap_\u003cread/write\u003e_buf_noincr()-\u003emem_ap_\u003cread/write\u003e().\nIn all other uses of dbgbase for arm cortex parts, the 2 LSB are masked\nand ignored.\n\nChange-Id: Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6\nSigned-off-by: Phil Kirkpatrick \u003cp.kirkpatrick@reflexaerospace.com\u003e\n"}},"d03cb02c9585eb28a60080d1248011ca9c48e479":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-05-09 12:12:51.000000000","uploader":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"ref":"refs/changes/82/7682/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7682/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/2 \u0026\u0026 git checkout -b change-7682 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7682/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 09:04:24.000000000","tz":120},"committer":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 12:12:07.000000000","tz":120},"subject":"tcl/target: Add support for TMS570LC43xx","message":"tcl/target: Add support for TMS570LC43xx\n\nAdded support for TMS570LC43xx series parts.  This uses the pre-existing\nti_tms570.cfg parent config.  In ti_tms570.cfg, dbgbase was changed.\nNote 1: Based on the following TI E2E post, the previous dbgbase was wrong\nand the new value isn\u0027t due to a difference in parts.\nLink: https://e2e.ti.com/support/microcontrollers/arm-based-microcontrollers-group/arm-based-microcontrollers/f/arm-based-microcontrollers-forum/1106954/tms570ls3137-debugging-with-openocd\nNote 2: Both the previous dbgbase and the one suggested in the TI E2E post\nhave the 2 LSB set. In the current version of OpenOCD, this will cause\ncortex_a_read_cpu_memory_fast and cortex_a_write_cpu_memory_fast to fail\ndue to an alignment checks in\nmem_ap_\u003cread/write\u003e_buf_noincr()-\u003emem_ap_\u003cread/write\u003e().\nIn all other uses of dbgbase for arm cortex parts, the 2 LSB are masked\nand ignored.\n\nChange-Id: Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6\nSigned-off-by: Phil Kirkpatrick \u003cp.kirkpatrick@reflexaerospace.com\u003e\n"}},"c1adedc346aadffcb1bebe09a9eab6a50e4c74ce":{"kind":"NO_CHANGE","_number":3,"created":"2023-05-12 13:11:18.000000000","uploader":{"_account_id":1002140,"name":"Philip Kirkpatrick","display_name":"Philip Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","username":"RA-Phil-K","status":"Reflex Aerospace"},"ref":"refs/changes/82/7682/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7682/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/3 \u0026\u0026 git checkout -b change-7682 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7682/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7682/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-09 09:04:24.000000000","tz":120},"committer":{"name":"Phil Kirkpatrick","email":"p.kirkpatrick@reflexaerospace.com","date":"2023-05-12 13:10:55.000000000","tz":120},"subject":"tcl/target: Add support for TMS570LC43xx","message":"tcl/target: Add support for TMS570LC43xx\n\nAdded support for TMS570LC43xx series parts.  This uses the pre-existing\nti_tms570.cfg parent config.  In ti_tms570.cfg, dbgbase was changed.\nNote 1: Based on the following TI E2E post, the previous dbgbase was wrong\nand the new value isn\u0027t due to a difference in parts.\nLink: https://e2e.ti.com/support/microcontrollers/arm-based-microcontrollers-group/arm-based-microcontrollers/f/arm-based-microcontrollers-forum/1106954/tms570ls3137-debugging-with-openocd\nNote 2: Both the previous dbgbase and the one suggested in the TI E2E post\nhave the 2 LSB set. In the current version of OpenOCD, this will cause\ncortex_a_read_cpu_memory_fast and cortex_a_write_cpu_memory_fast to fail\ndue to an alignment checks in\nmem_ap_\u003cread/write\u003e_buf_noincr()-\u003emem_ap_\u003cread/write\u003e().\nIn all other uses of dbgbase for arm cortex parts, the 2 LSB are masked\nand ignored.\n\nChange-Id: Ic936722e5a4cfc7161b0df1fe3325ee12fd901c6\nSigned-off-by: Phil Kirkpatrick \u003cp.kirkpatrick@reflexaerospace.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}