)]}'
{"id":"openocd~master~I0bce76cade8f7efd75efd9087a7d9ba6511a6239","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002041":{"account":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"last_update":"2023-05-15 09:12:03.000000000","reason":"\u003cGERRIT_ACCOUNT_1002041\u003e replied on the change","reason_account":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-05-15 16:24:30.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I0bce76cade8f7efd75efd9087a7d9ba6511a6239","subject":"jtag/drivers/bcm2835gpio: don\u0027t touch pad setting on /dev/gpiomem","status":"MERGED","created":"2023-05-13 08:44:22.000000000","updated":"2023-05-24 05:25:28.000000000","submitted":"2023-05-24 05:25:28.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7684","meta_rev_id":"063482589c9d9c36004c14a63d0b621a61e59b88","_number":7684,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-24 05:25:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-24 05:25:28.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-24 05:25:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-24 05:25:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-13 14:46:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-13 15:38:33.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-05-13 20:17:30.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"eab948f53336ee011ab453385811c7c96a3080a4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-13 08:44:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d104e945f9a2b61abfcca0b5cc12c6a954d5fd41","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-13 14:46:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17710/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16914/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2584f2a2a399b6b6e0fbc9972286a20d284f2ab5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 15:38:33.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"05172b06e5e99891394025ff9969e4120e4fb975","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2023-05-15 09:12:03.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e88e2528f5d7d9852e073e0447082cc0c50ed41d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-15 16:24:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"063482589c9d9c36004c14a63d0b621a61e59b88","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-24 05:25:28.000000000","message":"Change has been successfully cherry-picked as c164906420521546849d03a26977fb91838aca8e","accounts_in_message":[],"_revision_number":2}],"current_revision":"c164906420521546849d03a26977fb91838aca8e","revisions":{"0a98920619268578c96300ae3b442da3ebc8a407":{"kind":"REWORK","_number":1,"created":"2023-05-13 08:44:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/84/7684/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/7684/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/1 \u0026\u0026 git checkout -b change-7684 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/7684/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"329b10754aa2294d11717c461f356c174eba5094","subject":"target: etm: fix check trace status"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 08:47:43.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-13 08:43:36.000000000","tz":120},"subject":"jtag/drivers/bcm2835gpio: don\u0027t touch pad setting on /dev/gpiomem","message":"jtag/drivers/bcm2835gpio: don\u0027t touch pad setting on /dev/gpiomem\n\nThe pads were configured at a wrong memory address\nif /dev/gpiomem was mapped.\n\nThe pad setting registers are not accessible in mapped /dev/gpiomem,\ndisable the pads setting if the driver doesn\u0027t open /dev/mem.\n\nWhile on it, do not fail the driver initialization if pad mapping fails\n- just emit a warning and work with unchanged pad setting.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I0bce76cade8f7efd75efd9087a7d9ba6511a6239\n"}},"c164906420521546849d03a26977fb91838aca8e":{"kind":"REWORK","_number":2,"created":"2023-05-24 05:25:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/84/7684/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/7684/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/2 \u0026\u0026 git checkout -b change-7684 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/7684/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/7684/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"30b0e9af8d1e68ee051ac62dd0e27c920fb396bd","subject":"tcl/target: Add support for TMS570LC43xx"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 08:47:43.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-24 05:25:28.000000000","tz":0},"subject":"jtag/drivers/bcm2835gpio: don\u0027t touch pad setting on /dev/gpiomem","message":"jtag/drivers/bcm2835gpio: don\u0027t touch pad setting on /dev/gpiomem\n\nThe pads were configured at a wrong memory address\nif /dev/gpiomem was mapped.\n\nThe pad setting registers are not accessible in mapped /dev/gpiomem,\ndisable the pads setting if the driver doesn\u0027t open /dev/mem.\n\nWhile on it, do not fail the driver initialization if pad mapping fails\n- just emit a warning and work with unchanged pad setting.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I0bce76cade8f7efd75efd9087a7d9ba6511a6239\nReviewed-on: https://review.openocd.org/c/openocd/+/7684\nTested-by: jenkins\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}