)]}'
{"id":"openocd~master~I7c5f27a5cf145511a1a8b64a45a586521e1cbe41","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002141":{"account":{"_account_id":1002141,"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","username":"pamaury","status":"lowRISC"},"last_update":"2023-05-25 16:19:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7c5f27a5cf145511a1a8b64a45a586521e1cbe41","subject":"target/riscv-013: clear sticky error when DMI operation fails","status":"MERGED","created":"2023-05-17 11:13:53.000000000","updated":"2023-05-25 16:19:12.000000000","submitted":"2023-05-25 16:19:12.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7688","meta_rev_id":"26a4298ed0e1f2f9c900715cc700e7b7a4c787b2","_number":7688,"owner":{"_account_id":1002141,"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","username":"pamaury","status":"lowRISC"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-25 16:19:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-25 16:19:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-25 16:19:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-17 11:26:35.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-17 16:40:48.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2023-05-18 06:16:01.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2023-05-25 16:19:12.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"e1cb8e168185ae39064f5a9894598cd3df717b8c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002141,"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","username":"pamaury","status":"lowRISC"},"real_author":{"_account_id":1002141,"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","username":"pamaury","status":"lowRISC"},"date":"2023-05-17 11:13:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9581fee507980817ac4dc9e81158b3a24200aae9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-17 11:26:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17724/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16926/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"075250d19b109fa8590406861d09de326aedbe7b","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2023-05-17 16:40:48.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3df9795cb93c3120fdbfdb22134a70ff740761d9","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-05-18 06:16:01.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"26a4298ed0e1f2f9c900715cc700e7b7a4c787b2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-25 16:19:12.000000000","message":"Change has been successfully cherry-picked as 5924d9f30cd68333d37caa7ac8cad43f036148dc","accounts_in_message":[],"_revision_number":2}],"current_revision":"5924d9f30cd68333d37caa7ac8cad43f036148dc","revisions":{"aa6eb8d8fa2be2f4cda218a6f808c4d2ce00a020":{"kind":"REWORK","_number":1,"created":"2023-05-17 11:13:53.000000000","uploader":{"_account_id":1002141,"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","username":"pamaury","status":"lowRISC"},"ref":"refs/changes/88/7688/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/7688/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/1 \u0026\u0026 git checkout -b change-7688 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/7688/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a4f445bd92101d3daee3715178d3fbff3b7b029","subject":"jtag: tcl: show error message when attempting manual \"drscan\" on a bypassed tap"}],"author":{"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","date":"2023-05-17 11:09:32.000000000","tz":60},"committer":{"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","date":"2023-05-17 11:09:32.000000000","tz":60},"subject":"target/riscv-013: clear sticky error when DMI operation fails","message":"target/riscv-013: clear sticky error when DMI operation fails\n\nWhen a DMI operation does not succeed (either because of a timeout\nor an error), the specification says that the error in the `op`\nfield is sticky and needs to cleared by writing `dmireset` in `dtmcs`.\nThis is already done for timeouts in increase_dmi_busy_delay\nbut not for errors.\n\nChange-Id: I7c5f27a5cf145511a1a8b64a45a586521e1cbe41\nSigned-off-by: Amaury Pouly \u003camaury.pouly@lowrisc.org\u003e\n"}},"5924d9f30cd68333d37caa7ac8cad43f036148dc":{"kind":"REWORK","_number":2,"created":"2023-05-25 16:19:12.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/88/7688/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/7688/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/2 \u0026\u0026 git checkout -b change-7688 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/7688/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/7688/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4defa3b1e323b7f7287d8e046b2c97ad4a749f87","subject":"flash/stm32l4x: support STM32C0x devices"}],"author":{"name":"Amaury Pouly","email":"amaury.pouly@lowrisc.org","date":"2023-05-17 11:09:32.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-25 16:19:12.000000000","tz":0},"subject":"target/riscv-013: clear sticky error when DMI operation fails","message":"target/riscv-013: clear sticky error when DMI operation fails\n\nWhen a DMI operation does not succeed (either because of a timeout\nor an error), the specification says that the error in the `op`\nfield is sticky and needs to cleared by writing `dmireset` in `dtmcs`.\nThis is already done for timeouts in increase_dmi_busy_delay\nbut not for errors.\n\nChange-Id: I7c5f27a5cf145511a1a8b64a45a586521e1cbe41\nSigned-off-by: Amaury Pouly \u003camaury.pouly@lowrisc.org\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7688\nTested-by: jenkins\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}