)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f6343b73b0d5e8127f6323ec39a4900c4fc6b20b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed3df58c_7af49dd2","updated":"2023-05-23 10:07:54.000000000","message":"Thanks for the fix, Bohdan. Please consider a faster alternative.","commit_id":"139ffffafa2899dcf3c5a9b5742ff171ae83bfdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3ef62afc4151e758bc5fa252d9a81ad446304e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ccaff70a_edafc4af","updated":"2023-05-23 14:50:56.000000000","message":"Just a minor suggestion to improve reading the code, if you agree","commit_id":"8805493ae62b3401a95be8a16a904d8cb64d9d3c"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"e40c67a57e5213ebad2135cfc10e899d97e47089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f883106_020999af","updated":"2023-05-23 11:44:09.000000000","message":"Thanks, Tomas for the suggestion, I\u0027ve a uploaded new patch","commit_id":"8805493ae62b3401a95be8a16a904d8cb64d9d3c"}],"src/target/cortex_m.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f6343b73b0d5e8127f6323ec39a4900c4fc6b20b","unresolved":true,"context_lines":[{"line_number":809,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":810,"context_line":"\t\t\treturn retval;"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"\t\tsecure_state \u003d (dscsr \u0026 DSCSR_CDS) \u003d\u003d DSCSR_CDS;"},{"line_number":813,"context_line":"\t}"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"\t/* Load all registers to arm.core_cache */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9158ed43_cbfe5052","line":812,"updated":"2023-05-23 10:07:54.000000000","message":"You\u0027re right dscsr is required here.\nBut there is no need to hurry with evaluating secure_state: it not used until line 860\nI would prefer faster debug_entry (time critical when stepping) over the straightforward code and rather postpone dscsr evaluation...","commit_id":"139ffffafa2899dcf3c5a9b5742ff171ae83bfdb"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"3bdfc1729f282ddb365464d997f8a307c246f370","unresolved":false,"context_lines":[{"line_number":809,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":810,"context_line":"\t\t\treturn retval;"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"\t\tsecure_state \u003d (dscsr \u0026 DSCSR_CDS) \u003d\u003d DSCSR_CDS;"},{"line_number":813,"context_line":"\t}"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"\t/* Load all registers to arm.core_cache */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"454d1124_8007846c","line":812,"in_reply_to":"9158ed43_cbfe5052","updated":"2023-05-23 11:44:36.000000000","message":"Done","commit_id":"139ffffafa2899dcf3c5a9b5742ff171ae83bfdb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f6343b73b0d5e8127f6323ec39a4900c4fc6b20b","unresolved":true,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":828,"context_line":"\t\treturn retval;"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"\tr \u003d arm-\u003ecpsr;"},{"line_number":831,"context_line":"\txpsr \u003d buf_get_u32(r-\u003evalue, 0, 32);"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"88449ab7_20cb21b8","line":829,"updated":"2023-05-23 10:07:54.000000000","message":"What about postponing dscsr \u0026 DSCSR_CDS evaluation to here.\nReading of CPU registers in between ensures the queue is run...","commit_id":"139ffffafa2899dcf3c5a9b5742ff171ae83bfdb"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"3bdfc1729f282ddb365464d997f8a307c246f370","unresolved":false,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":828,"context_line":"\t\treturn retval;"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"\tr \u003d arm-\u003ecpsr;"},{"line_number":831,"context_line":"\txpsr \u003d buf_get_u32(r-\u003evalue, 0, 32);"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"21fdb202_3fd68b92","line":829,"in_reply_to":"88449ab7_20cb21b8","updated":"2023-05-23 11:44:36.000000000","message":"Done","commit_id":"139ffffafa2899dcf3c5a9b5742ff171ae83bfdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3ef62afc4151e758bc5fa252d9a81ad446304e6c","unresolved":true,"context_lines":[{"line_number":801,"context_line":"\t\treturn retval;"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"\t/* examine PE security state */"},{"line_number":804,"context_line":"\tuint32_t dscsr \u003d 0;"},{"line_number":805,"context_line":"\tif (armv7m-\u003earm.arch \u003d\u003d ARM_ARCH_V8M) {"},{"line_number":806,"context_line":"\t\tretval \u003d mem_ap_read_u32(armv7m-\u003edebug_ap, DCB_DSCSR, \u0026dscsr);"},{"line_number":807,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5e8d847c_4e389d25","line":804,"updated":"2023-05-23 14:50:56.000000000","message":"In this function this is not always dscsr, as it is only set in case of ARM_ARCH_V8M.\nTo avoid someone else try to use it and find it zero, what about renaming it as dscsr_v8m ?","commit_id":"8805493ae62b3401a95be8a16a904d8cb64d9d3c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fed5f7e86434e77d83804c1b41dded74e165cebe","unresolved":false,"context_lines":[{"line_number":801,"context_line":"\t\treturn retval;"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"\t/* examine PE security state */"},{"line_number":804,"context_line":"\tuint32_t dscsr \u003d 0;"},{"line_number":805,"context_line":"\tif (armv7m-\u003earm.arch \u003d\u003d ARM_ARCH_V8M) {"},{"line_number":806,"context_line":"\t\tretval \u003d mem_ap_read_u32(armv7m-\u003edebug_ap, DCB_DSCSR, \u0026dscsr);"},{"line_number":807,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e7c35c51_3a290771","line":804,"in_reply_to":"4eab9e4d_0f8bdf14","updated":"2023-05-24 07:49:57.000000000","message":"ok! thanks","commit_id":"8805493ae62b3401a95be8a16a904d8cb64d9d3c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"5f49570897902985d3f117d0dcce0526c58666e1","unresolved":true,"context_lines":[{"line_number":801,"context_line":"\t\treturn retval;"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"\t/* examine PE security state */"},{"line_number":804,"context_line":"\tuint32_t dscsr \u003d 0;"},{"line_number":805,"context_line":"\tif (armv7m-\u003earm.arch \u003d\u003d ARM_ARCH_V8M) {"},{"line_number":806,"context_line":"\t\tretval \u003d mem_ap_read_u32(armv7m-\u003edebug_ap, DCB_DSCSR, \u0026dscsr);"},{"line_number":807,"context_line":"\t\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4eab9e4d_0f8bdf14","line":804,"in_reply_to":"5e8d847c_4e389d25","updated":"2023-05-24 05:20:01.000000000","message":"Antonio, just FYI, the DSCSR register is implemented from ARMv8M on and without security extension is RES0. So the dscsr default zero value is a good approximation for both ARMv7M and ARMv6M. I see no point in complicating the variable name.","commit_id":"8805493ae62b3401a95be8a16a904d8cb64d9d3c"}]}