)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"01ddbda9d594ace69fba77833930ee874e95af85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"602819b1_a8a66f08","updated":"2023-07-24 19:16:29.000000000","message":"Tarek,\nplease re-check OTP base address.","commit_id":"d3949b4af3394b7f91ebd842b3e8d6c043b31e95"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14176691f2bced8918898ca131ba41db5f711211","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"495cc3ab_ed18e61e","updated":"2023-09-12 12:27:36.000000000","message":"Apparently gerrit is happy to let this patch be merged alone, without the other two in the relation chain. Locally it seams ok too.\nIf you think there is any dependency I have missed, please rise the hand asap.","commit_id":"498746b0fdddd92647f4c283a3e2ff77585afd89"},{"author":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"change_message_id":"3970c3450a3c32c5a803be486f82963aacbe08ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f148d06_d6e27efa","updated":"2023-08-30 11:53:07.000000000","message":"Fine for me, thanks","commit_id":"498746b0fdddd92647f4c283a3e2ff77585afd89"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"af1939b93d088e59e83dc1d915f47f0fdd594552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51be0640_ec09d082","updated":"2023-08-29 12:32:58.000000000","message":"thanks Tomas for your review.\nI have incorporated the changes by Erwan in https://review.openocd.org/c/openocd/+/7801\n\n@Erwan, please check if this is OK for you.","commit_id":"498746b0fdddd92647f4c283a3e2ff77585afd89"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ecc7f74892abad9548d30848483e6bc1834ec38e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8ea06c28_21db8c79","in_reply_to":"6f148d06_d6e27efa","updated":"2023-08-31 07:40:34.000000000","message":"Erwan, please do NOT put positive review score if you see the patch should be changed.\n\nI asked you in 7801: flash/stm32l4x: support STM32WBAx devices | https://review.openocd.org/c/openocd/+/7801\nto re-submit your newer patch as a new version (new patchset) of this change.\n\nWe need to keep all versions of one change in one Gerrit change number\nto be able to compare versions and to have the evolution history in one place. BTW this is the standard workflow in Gerrit - slightly differs from work with github.\nSee details in\nhttps://openocd.org/doc/doxygen/html/patchguide.html#stepbystep","commit_id":"498746b0fdddd92647f4c283a3e2ff77585afd89"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1dc9dd0c5f6612e3b40d0d6299be0911f446d8c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dcf264ba_21c353c7","in_reply_to":"8ea06c28_21db8c79","updated":"2023-09-12 09:43:12.000000000","message":"Erwan, Tarek, I don\u0027t know what was wrong, I missed the patchset 3 and checked patchset 2 last time. Sorry for the noise.","commit_id":"498746b0fdddd92647f4c283a3e2ff77585afd89"}],"src/flash/nor/stm32l4x.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"01ddbda9d594ace69fba77833930ee874e95af85","unresolved":true,"context_lines":[{"line_number":630,"context_line":"\t  .flags                 \u003d F_QUAD_WORD_PROG | F_HAS_TZ | F_HAS_L5_FLASH_REGS,"},{"line_number":631,"context_line":"\t  .flash_regs_base       \u003d 0x40022000,"},{"line_number":632,"context_line":"\t  .fsize_addr            \u003d 0x0FF907A0,"},{"line_number":633,"context_line":"\t  .otp_base              \u003d 0x0FF90000,"},{"line_number":634,"context_line":"\t  .otp_size              \u003d 512,"},{"line_number":635,"context_line":"\t},"},{"line_number":636,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b7366b1c_362941b7","line":633,"range":{"start_line":633,"start_character":28,"end_line":633,"end_character":38},"updated":"2023-07-24 19:16:29.000000000","message":"Differs from...","commit_id":"d3949b4af3394b7f91ebd842b3e8d6c043b31e95"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14176691f2bced8918898ca131ba41db5f711211","unresolved":false,"context_lines":[{"line_number":630,"context_line":"\t  .flags                 \u003d F_QUAD_WORD_PROG | F_HAS_TZ | F_HAS_L5_FLASH_REGS,"},{"line_number":631,"context_line":"\t  .flash_regs_base       \u003d 0x40022000,"},{"line_number":632,"context_line":"\t  .fsize_addr            \u003d 0x0FF907A0,"},{"line_number":633,"context_line":"\t  .otp_base              \u003d 0x0FF90000,"},{"line_number":634,"context_line":"\t  .otp_size              \u003d 512,"},{"line_number":635,"context_line":"\t},"},{"line_number":636,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"593351ec_1f70f5c0","line":633,"range":{"start_line":633,"start_character":28,"end_line":633,"end_character":38},"in_reply_to":"b7366b1c_362941b7","updated":"2023-09-12 12:27:36.000000000","message":"Done","commit_id":"d3949b4af3394b7f91ebd842b3e8d6c043b31e95"}],"tcl/target/stm32wbax.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"01ddbda9d594ace69fba77833930ee874e95af85","unresolved":true,"context_lines":[{"line_number":47,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"flash bank $_CHIPNAME.flash stm32l4x 0x08000000 0 0 0 $_TARGETNAME"},{"line_number":50,"context_line":"flash bank $_CHIPNAME.otp   stm32l4x 0x1fff7000 0 0 0 $_TARGETNAME"},{"line_number":51,"context_line":"# Common knowledges tells JTAG speed should be \u003c\u003d F_CPU/6."},{"line_number":52,"context_line":"# F_CPU after reset is MSI 4MHz, so use F_JTAG \u003d 500 kHz to stay on"},{"line_number":53,"context_line":"# the safe side."}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"01d33a27_fb06a5a9","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":47},"updated":"2023-07-24 19:16:29.000000000","message":"... the configured base.\nAccording to https://sourceforge.net/p/openocd/tickets/398/\nit results in\nError: invalid bank base address\nand rejection of gdb attach.","commit_id":"d3949b4af3394b7f91ebd842b3e8d6c043b31e95"},{"author":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"change_message_id":"3970c3450a3c32c5a803be486f82963aacbe08ff","unresolved":false,"context_lines":[{"line_number":47,"context_line":"$_TARGETNAME configure -work-area-phys 0x20000000 -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"flash bank $_CHIPNAME.flash stm32l4x 0x08000000 0 0 0 $_TARGETNAME"},{"line_number":50,"context_line":"flash bank $_CHIPNAME.otp   stm32l4x 0x1fff7000 0 0 0 $_TARGETNAME"},{"line_number":51,"context_line":"# Common knowledges tells JTAG speed should be \u003c\u003d F_CPU/6."},{"line_number":52,"context_line":"# F_CPU after reset is MSI 4MHz, so use F_JTAG \u003d 500 kHz to stay on"},{"line_number":53,"context_line":"# the safe side."}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"203a6a1d_18806c29","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":47},"in_reply_to":"01d33a27_fb06a5a9","updated":"2023-08-30 11:53:07.000000000","message":"Done","commit_id":"d3949b4af3394b7f91ebd842b3e8d6c043b31e95"},{"author":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"change_message_id":"3970c3450a3c32c5a803be486f82963aacbe08ff","unresolved":false,"context_lines":[{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"$_TARGETNAME configure -event reset-init {"},{"line_number":73,"context_line":"    # CPU comes out of reset with MSI_ON | MSI_RDY | MSI Range 4 MHz."},{"line_number":74,"context_line":"    # Configure system to use MSI 24 MHz clock, compliant with VOS default Range1."},{"line_number":75,"context_line":"    # 2 WS compliant with VOS\u003dRange1 and 24 MHz."},{"line_number":76,"context_line":"    # mmw 0x58004000 0x00000102 0  ;# FLASH_ACR |\u003d PRFTBE | 2(Latency)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"314dffb0_7cfc55a7","line":73,"updated":"2023-08-30 11:53:07.000000000","message":"No MSI on WBA. This should be fixed.","commit_id":"d3949b4af3394b7f91ebd842b3e8d6c043b31e95"}]}