)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00c87cb7_0583774d","updated":"2023-06-18 16:03:49.000000000","message":"Thanks for the patch.\nI have not analyses the code of the FW and I don\u0027t expect I will; I will trust you for it. My main concerns are licenses and stability of OpenOCD.\nI still want to understand the need for the .hex file, as we use to include files .inc, but let\u0027s keep this details for the review of next patch.\nWould it be possible to change the folder name to lowercase \"angie\"?\nYou do not need to abandon old changes and create new ones; just keep same the Change-Id: in the patch and gerrit will create a new version of the same patch.\nI have few minor comments, nothing dramatic.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcc4ab58_28530634","in_reply_to":"00c87cb7_0583774d","updated":"2023-07-11 08:05:30.000000000","message":"this mechanism of loading the firmware to the microcontroller using .hex files was already established in the ulink project, and when i started adding code to it i didn\u0027t change what was written before as i know that its already approuved.\nalso after taking a look at the open_image function that is used to open the .hex file, i found that apparently it doesn\u0027t support the .inc type.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9356e91560245307c209fc2ac399909eef063d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d319076c_f3fbd631","in_reply_to":"bcc4ab58_28530634","updated":"2023-07-11 20:55:53.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"301bc82722afb2048b261ec865f2198b981d3144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b9084e9d_71aec259","updated":"2023-06-20 14:24:14.000000000","message":"I\u0027m sorry, but Apache-2.0 cannot be used inside OpenOCD.\nThe code under Apache 2.0 is developed by you or your team. If for any reason you need to release this code with Apache-2.0 license, would it be possible for you to release it under dual license? E.g.:\nSPDX-License-Identifier: (BSD-3-Clause OR Apache-2.0)\nIn this way it would be compatible with GPL (any license already in LICENSES/preferred/) and also available under Apache-2.0 for any you that requires it","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5a917bfc0cdc2f0c160fc193b9d2a199aa11d208","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f2c42cfd_4ac8fb60","in_reply_to":"5ef8fcbe_582c99c6","updated":"2023-07-11 14:10:57.000000000","message":"Done","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5ef8fcbe_582c99c6","in_reply_to":"b9084e9d_71aec259","updated":"2023-07-11 08:05:30.000000000","message":"yes the code under Apache-2.0 was developed by me and my team, after a quick discussion with my team, we agree to release it under BSD-3-Clause.\nI will make the necessary changes and re-push the project.","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"41cda46d_4c24b971","updated":"2023-06-21 14:27:11.000000000","message":"Thanks for your effort.\nI have put as resolved most of my comments and added few more.\n\nHow often would change the files angie_firmware.hex and angie/angie_bitstream.bit?\nOnly seldom for bug fixes and feature improvements, or do you expect you will need to manage several version of them for specific use cases and you switch continuously from one to the other?\nI\u0027m asking this because you propose to keep them as independent files, as it is done for OpenULINK/ulink_firmware.hex. That is the only example of external file loaded at runtime by OpenOCD, mainly due to legacy/old way of working. All the other cases in contrib/ folder are directly embedded inside OpenOCD binary.\nIf these files are almost stable, I would suggest to embed them too in OpenOCD binary. I can guide you for this additional step.","commit_id":"f805e4f911ade546c4eff9f6377be0d82b4eb4e2"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"85a7ed41_cf8b8aba","in_reply_to":"41cda46d_4c24b971","updated":"2023-07-11 08:05:30.000000000","message":"the \"angie_firmware.hex\" and \"angie_bitstream.bit\" are \u0027rarely\u0027 going to be changed, meaning that we are not planning on changing them constantly.\nyes i would be happy to embed them in openOCD binary with your guide.","commit_id":"f805e4f911ade546c4eff9f6377be0d82b4eb4e2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9356e91560245307c209fc2ac399909eef063d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"69d3174f_42b0b468","in_reply_to":"85a7ed41_cf8b8aba","updated":"2023-07-11 20:55:53.000000000","message":"Ack","commit_id":"f805e4f911ade546c4eff9f6377be0d82b4eb4e2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"91d0122e858767c323c03efd758d7fbe915b75b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"df1acdd0_5ab830a5","updated":"2023-07-10 22:41:37.000000000","message":"the file angie_firmware.bin is already present in next patch. It can be removed from contrib folder","commit_id":"4b27f9fc40605fb2affdd93940c25f1819c8f1ad"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9356e91560245307c209fc2ac399909eef063d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7199f17b_40802be0","updated":"2023-07-11 20:55:53.000000000","message":"thanks for your patience on the (too) many reviews","commit_id":"ebdde2f4c4cf31200a650516945644825574e9f9"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"d41ee03cf7d21c236fb92d5e83af01bf15e9d705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"a6be202a_2e9cb0aa","updated":"2023-07-24 08:30:52.000000000","message":"I changed only the driver commit, but this commit was automatically updated saying:\n\nremote:   https://review.openocd.org/c/openocd/+/7743 LICENSES: Add the LGPL-2.1 license\nremote: \nremote: The following approvals got outdated and were removed:\nremote: * Code-Review+2 by Antonio Borneo\nremote: * Verified+1 by jenkins\nremote: \nremote:   https://review.openocd.org/c/openocd/+/7756 libusb_helper: split error and returned value\nremote: \nremote: The following approvals got outdated and were removed:\nremote: * Code-Review+1 by Antonio Borneo\nremote: * Code-Review+1 by ahmed BOUDJELIDA\nremote: * Verified+1 by jenkins\nremote: \nremote:   https://review.openocd.org/c/openocd/+/7701 contrib/firmware: add new adapter ANGIE\u0027s firmware/bitstream code\nremote: \nremote: The following approvals got outdated and were removed:\nremote: * Code-Review+1 by Antonio Borneo\nremote: * Verified+1 by jenkins","commit_id":"e386ea387e8003e74031d9b58f9e78566bfbf1a3"}],"contrib/firmware/ANGIE/Makefile":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a865633e1389453e872b344e40343230536f9c0e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"PREFIX \u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Small Device C Compiler: http://sdcc.sourceforge.net/"},{"line_number":15,"context_line":"CC \u003d $(PREFIX)-sdcc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# 8051 assembler, part of the SDCC software package."},{"line_number":18,"context_line":"AS \u003d $(PREFIX)-sdas8051"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"44ab5702_4044d364","line":15,"updated":"2023-06-18 20:43:43.000000000","message":"On Arch Linux, installed sdcc, I need to edit this Makefile to remove the \u0027-\u0027 here, at line 18 and 23.\nCan the \u0027-\u0027 be eventually added in PREFIX, if any?","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"PREFIX \u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Small Device C Compiler: http://sdcc.sourceforge.net/"},{"line_number":15,"context_line":"CC \u003d $(PREFIX)-sdcc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# 8051 assembler, part of the SDCC software package."},{"line_number":18,"context_line":"AS \u003d $(PREFIX)-sdas8051"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"73b3a60e_e26ca36c","line":15,"in_reply_to":"44ab5702_4044d364","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[{"line_number":12,"context_line":"PREFIX \u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Small Device C Compiler: http://sdcc.sourceforge.net/"},{"line_number":15,"context_line":"CC \u003d $(PREFIX)-sdcc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# 8051 assembler, part of the SDCC software package."},{"line_number":18,"context_line":"AS \u003d $(PREFIX)-sdas8051"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c9048f5f_6c657621","line":15,"in_reply_to":"44ab5702_4044d364","updated":"2023-07-11 08:05:30.000000000","message":"i removed it, still works correctly.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"bce61cb8a50328b34ece173cc18e61edb3aba30c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"PREFIX \u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Small Device C Compiler: http://sdcc.sourceforge.net/"},{"line_number":15,"context_line":"CC \u003d $(PREFIX)-sdcc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# 8051 assembler, part of the SDCC software package."},{"line_number":18,"context_line":"AS \u003d $(PREFIX)-sdas8051"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6af36f4c_eb899677","line":15,"in_reply_to":"c9048f5f_6c657621","updated":"2023-07-11 08:13:56.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":73,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"hex: angie_firmware.ihx"},{"line_number":76,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da1221bb_e0cfc851","line":76,"updated":"2023-06-18 16:03:49.000000000","message":"Please add newline at the end of the file, without adding an empty line","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":73,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"hex: angie_firmware.ihx"},{"line_number":76,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"2cff32d1_5fc31670","line":76,"in_reply_to":"da1221bb_e0cfc851","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"hex: angie_firmware.ihx"},{"line_number":76,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"341f1fd2_79919284","line":76,"in_reply_to":"da1221bb_e0cfc851","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/README":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f0233357_c19c4a5f","line":1,"updated":"2023-06-18 16:03:49.000000000","message":"it would be preferred having a license TAG for this file too.\nI need to fix all the documentation adding the TAG.\nOpenOCD uses GFDL-1.2 for the documentation, but it\u0027s up to you using GPL for this file too.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8bdf3a18_519405a2","line":1,"updated":"2023-06-18 16:03:49.000000000","message":"it would be preferred having a license TAG for this file too.\nI need to fix all the documentation adding the TAG.\nOpenOCD uses GFDL-1.2 for the documentation, but it\u0027s up to you using GPL or GFDL-1.2 or anything else for this file.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"882a4c73_2ccf5c4b","line":1,"updated":"2023-06-18 16:03:49.000000000","message":"it would be preferred having a license for this file too.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ad298f0e_3b793e30","line":1,"in_reply_to":"882a4c73_2ccf5c4b","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cd623388_880b8ac0","line":1,"in_reply_to":"882a4c73_2ccf5c4b","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"81dcd36d_f897379e","line":1,"in_reply_to":"8bdf3a18_519405a2","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"eb349918_baa25d24","line":1,"in_reply_to":"8bdf3a18_519405a2","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4421f8f0_9e72e2ac","line":1,"in_reply_to":"f0233357_c19c4a5f","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This is the ANGIE firmware for ANGIE USB-JTAG adapter."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"The main components of ANGIE adapter are:"},{"line_number":4,"context_line":"- Cypress EZ-USB FX2 microcontroller"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c210d837_a8b8ec3a","line":1,"in_reply_to":"f0233357_c19c4a5f","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"- SRAM memory chip"},{"line_number":7,"context_line":"- Pin headers for various JTAG pin assignments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To compile the firmware, the SDCC compiler package is required. Most Linux distributions include SDCC in their official package repositories. The SDCC source code can be found at http://sdcc.sourceforge.net/"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Simply type \"make hex\" in the OpenULINK directory to compile the firmware."},{"line_number":12,"context_line":"\"make clean\" will remove all generated files except the Intel HEX file required for downloading the firmware to ANGIE."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"35c5e090_0b958eb8","line":9,"updated":"2023-06-18 16:03:49.000000000","message":"Please format the file with lines of ~80 characters.\nOpenOCD accepts 120 characters so no problem if you exceed 80, but gerrit view is easier to read with 80 or less","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":6,"context_line":"- SRAM memory chip"},{"line_number":7,"context_line":"- Pin headers for various JTAG pin assignments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To compile the firmware, the SDCC compiler package is required. Most Linux distributions include SDCC in their official package repositories. The SDCC source code can be found at http://sdcc.sourceforge.net/"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Simply type \"make hex\" in the OpenULINK directory to compile the firmware."},{"line_number":12,"context_line":"\"make clean\" will remove all generated files except the Intel HEX file required for downloading the firmware to ANGIE."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ddb85ea6_61fb7989","line":9,"in_reply_to":"35c5e090_0b958eb8","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":"- SRAM memory chip"},{"line_number":7,"context_line":"- Pin headers for various JTAG pin assignments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To compile the firmware, the SDCC compiler package is required. Most Linux distributions include SDCC in their official package repositories. The SDCC source code can be found at http://sdcc.sourceforge.net/"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Simply type \"make hex\" in the OpenULINK directory to compile the firmware."},{"line_number":12,"context_line":"\"make clean\" will remove all generated files except the Intel HEX file required for downloading the firmware to ANGIE."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e1bee38b_2aebaed8","line":9,"in_reply_to":"35c5e090_0b958eb8","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Once the firmware downloaded, the FX2 microcontroller activate its GPIF mode, download the Spartan-6 FPGA\u0027s bitstream, program the FPGA rapidly, and switch back to default io mode."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Once the user disconnects the ANGIE adapter, all its memory contents are lost and the firmware \u0026 bitstream download process has to be executed again."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1c2a8619_57cc31eb","line":20,"updated":"2023-06-18 16:03:49.000000000","message":"Also here, please add the newline","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Once the firmware downloaded, the FX2 microcontroller activate its GPIF mode, download the Spartan-6 FPGA\u0027s bitstream, program the FPGA rapidly, and switch back to default io mode."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Once the user disconnects the ANGIE adapter, all its memory contents are lost and the firmware \u0026 bitstream download process has to be executed again."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"567f1040_ac98b129","line":20,"in_reply_to":"1c2a8619_57cc31eb","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Once the firmware downloaded, the FX2 microcontroller activate its GPIF mode, download the Spartan-6 FPGA\u0027s bitstream, program the FPGA rapidly, and switch back to default io mode."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Once the user disconnects the ANGIE adapter, all its memory contents are lost and the firmware \u0026 bitstream download process has to be executed again."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d9cf34ab_c98549a9","line":20,"in_reply_to":"1c2a8619_57cc31eb","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/include/delay.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a865633e1389453e872b344e40343230536f9c0e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/****************************************************************"},{"line_number":4,"context_line":"    File : delay.h                                              *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8f4522c6_426e7bcf","line":1,"updated":"2023-06-18 20:43:43.000000000","message":"Error in all the files.h\nThe comment for the SPDX is not closed by the \u0027*/\u0027\nThe firmware does not compile","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/****************************************************************"},{"line_number":4,"context_line":"    File : delay.h                                              *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8039f337_8389f7a5","line":1,"in_reply_to":"8f4522c6_426e7bcf","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/****************************************************************"},{"line_number":4,"context_line":"    File : delay.h                                              *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b2b023ca_71c8db37","line":1,"in_reply_to":"8f4522c6_426e7bcf","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a865633e1389453e872b344e40343230536f9c0e","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define NOP {__asm nop __endasm; }"},{"line_number":19,"context_line":"#define _nop_() NOP"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"void syncdelay(uint8_t count);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"59f99bbc_ee1f8d6b","line":18,"updated":"2023-06-18 20:43:43.000000000","message":"this macro is re-defined in include/jtag.h\nPlus I get is also defined in /usr/share/sdcc/include/mcs51/compiler.h\nAre you using some specific other macro to avoid the multiple definition?","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define NOP {__asm nop __endasm; }"},{"line_number":19,"context_line":"#define _nop_() NOP"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"void syncdelay(uint8_t count);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9a62680b_dd79b29e","line":18,"in_reply_to":"59f99bbc_ee1f8d6b","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define NOP {__asm nop __endasm; }"},{"line_number":19,"context_line":"#define _nop_() NOP"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"void syncdelay(uint8_t count);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6cbcbcdd_368a88e4","line":18,"in_reply_to":"59f99bbc_ee1f8d6b","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/include/jtag.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a865633e1389453e872b344e40343230536f9c0e","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define NOP { __asm nop __endasm; }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"uint16_t jtag_get_signals(void);"},{"line_number":21,"context_line":"void jtag_configure_tck_delay(uint8_t scan_in, uint8_t scan_out,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"47d40f80_89a778df","line":18,"updated":"2023-06-18 20:43:43.000000000","message":"redefined","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define NOP { __asm nop __endasm; }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"uint16_t jtag_get_signals(void);"},{"line_number":21,"context_line":"void jtag_configure_tck_delay(uint8_t scan_in, uint8_t scan_out,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fc9f36a7_e6b50bd1","line":18,"in_reply_to":"47d40f80_89a778df","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#define NOP { __asm nop __endasm; }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"uint16_t jtag_get_signals(void);"},{"line_number":21,"context_line":"void jtag_configure_tck_delay(uint8_t scan_in, uint8_t scan_out,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b554ca7a_468fa346","line":18,"in_reply_to":"47d40f80_89a778df","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/include/main.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/****************************************************************************"},{"line_number":4,"context_line":"    File : main.h                                                           *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa42d9e2_ff6f8d5e","line":1,"updated":"2023-06-18 16:03:49.000000000","message":"is this empty file needed? Is it a requirement from the development tool?","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/****************************************************************************"},{"line_number":4,"context_line":"    File : main.h                                                           *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1fccfd94_8e83009d","line":1,"in_reply_to":"fa42d9e2_ff6f8d5e","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/****************************************************************************"},{"line_number":4,"context_line":"    File : main.h                                                           *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d38c3044_676fe715","line":1,"in_reply_to":"fa42d9e2_ff6f8d5e","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/include/serial.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/**"},{"line_number":4,"context_line":" * This code was taken from the fx2lib project from this link:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5e8b44c9_f2d9a9c5","line":1,"updated":"2023-06-18 16:03:49.000000000","message":"The original license of this file in\nhttps://github.com/djmuhlestein/fx2lib\nwas LGPL-2.1-or-later.\nI see other files with the same license in this patch.\nToday this license is not listed in OpenOCD LICENSES folder and checkpatch will complain for unknown license.\n\nI have just pushed a patch to add the license in\nhttps://review.openocd.org/7743\nbut I will merge it only together with your patches.\nPlease take my patch with\ngit fetch https://review.openocd.org/openocd refs/changes/43/7743/3\nthen rebase your two patches on top of it through\ngit rebase FETCH_HEAD\nand then apply the modification on your patches.\nDon\u0027t modify the LICENSE file, don\u0027t rebase the patch of the license, so when you git-push your patches they will be pushed on top of mine and checkpatch would be happy.","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/**"},{"line_number":4,"context_line":" * This code was taken from the fx2lib project from this link:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7a03db9a_8aa43032","line":1,"in_reply_to":"5e8b44c9_f2d9a9c5","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/**"},{"line_number":4,"context_line":" * This code was taken from the fx2lib project from this link:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dcfb6780_fc6fb89b","line":1,"in_reply_to":"5e8b44c9_f2d9a9c5","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/src/USBJmpTb.a51":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a865633e1389453e872b344e40343230536f9c0e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"; USB Jump Table                                                           ;"},{"line_number":28,"context_line":";--------------------------------------------------------------------------;"},{"line_number":29,"context_line":".area  USB_JT (ABS)        ; Absolute placement"},{"line_number":30,"context_line":".org   0x3E00              ; Place jump table at 0x3E00"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":33,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"abdd4238_7bf06c22","line":30,"updated":"2023-06-18 20:43:43.000000000","message":"I\u0027m analyzing the file .hex.\nIt is mainly composed of two parts: address 0x0000-0x2451 and 0x3E00-0x3EB7\nThe split between the two parts is caused by this \".org\" assembly directive.\nIs this split required? MUST this table be at address 0x3E00?\n\nI\u0027m asking this because I\u0027m not really happy about using the .hex file format, but the big gap between the two parts makes it unsuitable for other format, like raw binary. I would like to understand what can be improved, here","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":27,"context_line":"; USB Jump Table                                                           ;"},{"line_number":28,"context_line":";--------------------------------------------------------------------------;"},{"line_number":29,"context_line":".area  USB_JT (ABS)        ; Absolute placement"},{"line_number":30,"context_line":".org   0x3E00              ; Place jump table at 0x3E00"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":33,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"deb6f0f7_c2d7e038","line":30,"in_reply_to":"abdd4238_7bf06c22","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":27,"context_line":"; USB Jump Table                                                           ;"},{"line_number":28,"context_line":";--------------------------------------------------------------------------;"},{"line_number":29,"context_line":".area  USB_JT (ABS)        ; Absolute placement"},{"line_number":30,"context_line":".org   0x3E00              ; Place jump table at 0x3E00"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":33,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6c066112_708b527c","line":30,"in_reply_to":"abdd4238_7bf06c22","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/src/main.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"extern void ep6fflag_isr(void)__interrupt;"},{"line_number":59,"context_line":"extern void ep8fflag_isr(void)__interrupt;"},{"line_number":60,"context_line":"extern void gpifcomplete_isr(void)__interrupt;"},{"line_number":61,"context_line":"extern void gpifwaveform_isr(void)__interrupt;"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"void gpif_init(void);"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"76881880_683abf92","line":61,"updated":"2023-06-18 16:03:49.000000000","message":"why you need to add this long list of extern ISR? They are not used here, but only in USBJmpTb.a51","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"bce61cb8a50328b34ece173cc18e61edb3aba30c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"extern void ep6fflag_isr(void)__interrupt;"},{"line_number":59,"context_line":"extern void ep8fflag_isr(void)__interrupt;"},{"line_number":60,"context_line":"extern void gpifcomplete_isr(void)__interrupt;"},{"line_number":61,"context_line":"extern void gpifwaveform_isr(void)__interrupt;"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"void gpif_init(void);"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"92a2341e_31408e98","line":61,"in_reply_to":"1b178519_28f74ef4","updated":"2023-07-11 08:13:56.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":58,"context_line":"extern void ep6fflag_isr(void)__interrupt;"},{"line_number":59,"context_line":"extern void ep8fflag_isr(void)__interrupt;"},{"line_number":60,"context_line":"extern void gpifcomplete_isr(void)__interrupt;"},{"line_number":61,"context_line":"extern void gpifwaveform_isr(void)__interrupt;"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"void gpif_init(void);"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6bf8a168_1a6ca17e","line":61,"in_reply_to":"76881880_683abf92","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[{"line_number":58,"context_line":"extern void ep6fflag_isr(void)__interrupt;"},{"line_number":59,"context_line":"extern void ep8fflag_isr(void)__interrupt;"},{"line_number":60,"context_line":"extern void gpifcomplete_isr(void)__interrupt;"},{"line_number":61,"context_line":"extern void gpifwaveform_isr(void)__interrupt;"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"void gpif_init(void);"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1b178519_28f74ef4","line":61,"in_reply_to":"76881880_683abf92","updated":"2023-07-11 08:05:30.000000000","message":"I removed it.\nDone","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/ANGIE/src/serial.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"14183ad15052e671506f3f4f0ceebc9d40e70c1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"// SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":" * This code was taken from the fx2lib project from this link:"},{"line_number":4,"context_line":" * https://github.com/djmuhlestein/fx2lib"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f2b1934c_e388744c","line":1,"updated":"2023-06-18 16:03:49.000000000","message":"Original file is LGPL-2.1","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":" * This code was taken from the fx2lib project from this link:"},{"line_number":4,"context_line":" * https://github.com/djmuhlestein/fx2lib"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3c77d173_4fda4b7b","line":1,"in_reply_to":"f2b1934c_e388744c","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"/*"},{"line_number":3,"context_line":" * This code was taken from the fx2lib project from this link:"},{"line_number":4,"context_line":" * https://github.com/djmuhlestein/fx2lib"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"80b1934a_eed12531","line":1,"in_reply_to":"f2b1934c_e388744c","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"fc1abe406752ffffafc741e44c42770a65e1e811"}],"contrib/firmware/angie/c/Makefile":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92ad76552fa08b7a7ab7bb0cb065e2e6a1ff66f8","unresolved":true,"context_lines":[{"line_number":71,"context_line":"clean:"},{"line_number":72,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"hex: angie_firmware.ihx"},{"line_number":75,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"43078045_0d74e6a8","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":51},"updated":"2023-07-08 17:58:07.000000000","message":"you distribute this file.hex and you load it from the driver.\nWhat about distributing a .bin created with command below?\nmakebin -p angie_firmware.ihx angie_firmware.bin\nIt\u0027s 66% smaller than the the hex file.\nBut in file src/jtag/drivers/angie.c you should also replace image_open(...,\"ihex\") with image_open(...,\"bin\").\nCould you check if it works?","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6b290be860acc946318a878066762a7a28c75185","unresolved":false,"context_lines":[{"line_number":71,"context_line":"clean:"},{"line_number":72,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"hex: angie_firmware.ihx"},{"line_number":75,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"14176a20_a4e46a0d","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":51},"in_reply_to":"173368a8_fd51b63b","updated":"2023-07-11 08:09:28.000000000","message":"Done","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fd5be4d9ae14c493d3465ba8d5297d909ca0bcae","unresolved":false,"context_lines":[{"line_number":71,"context_line":"clean:"},{"line_number":72,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"hex: angie_firmware.ihx"},{"line_number":75,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"d0bde021_5b388754","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":51},"in_reply_to":"43078045_0d74e6a8","updated":"2023-07-10 22:43:50.000000000","message":"Done","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[{"line_number":71,"context_line":"clean:"},{"line_number":72,"context_line":"\trm -f *.asm *.lst *.rel *.rst *.sym *.ihx *.lk *.map *.mem"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"hex: angie_firmware.ihx"},{"line_number":75,"context_line":"\t$(PACKIHX) angie_firmware.ihx \u003e angie_firmware.hex"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"173368a8_fd51b63b","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":51},"in_reply_to":"43078045_0d74e6a8","updated":"2023-07-11 08:05:30.000000000","message":"Yes it works i will do it","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"}],"contrib/firmware/angie/c/include/delay.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"****************************************************************"},{"line_number":3,"context_line":"    File : delay.h                                              *"},{"line_number":4,"context_line":"    Contents : Delays handling header file for NanoXplore       *"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"9785039b_296441ca","line":1,"updated":"2023-06-21 14:27:11.000000000","message":"please keep the SPDX tag inside and independent comment line:\n\n/\\* SPDX-License-Identifier: GPL-2.0-or-later */\n\nSame for all the other files.\nThe files where the command starts with \u0027#\u0027 are already OK.","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"****************************************************************"},{"line_number":3,"context_line":"    File : delay.h                                              *"},{"line_number":4,"context_line":"    Contents : Delays handling header file for NanoXplore       *"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"00128f33_81b3b419","line":1,"in_reply_to":"9785039b_296441ca","updated":"2023-07-11 08:05:30.000000000","message":"Done","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92ad76552fa08b7a7ab7bb0cb065e2e6a1ff66f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"****************************************************************"},{"line_number":3,"context_line":"    File : delay.h                                              *"},{"line_number":4,"context_line":"    Contents : Delays handling header file for NanoXplore       *"}],"source_content_type":"text/x-csrc","patch_set":15,"id":"c2214db0_c4752cc2","line":1,"in_reply_to":"9785039b_296441ca","updated":"2023-07-08 17:58:07.000000000","message":"Done","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"}],"contrib/firmware/angie/c/src/USBJmpTb.a51":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":true,"context_lines":[{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":28,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"},{"line_number":29,"context_line":"    .db 0"},{"line_number":30,"context_line":"    ljmp  _sof_isr         ; (04) Start of Frame"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"360fe371_1b346eee","line":27,"updated":"2023-06-21 14:27:11.000000000","message":"Have you tested that it works fine after the change that removes\n.org 0x3E00\n?\nPlease notice that in next patch you still have the old file in src/jtag/...; not sure you have tested the new file","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92ad76552fa08b7a7ab7bb0cb065e2e6a1ff66f8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":28,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"},{"line_number":29,"context_line":"    .db 0"},{"line_number":30,"context_line":"    ljmp  _sof_isr         ; (04) Start of Frame"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"2071c360_ed136378","line":27,"in_reply_to":"360fe371_1b346eee","updated":"2023-07-08 17:58:07.000000000","message":"Done","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":28,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"},{"line_number":29,"context_line":"    .db 0"},{"line_number":30,"context_line":"    ljmp  _sof_isr         ; (04) Start of Frame"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"4047e33b_01e72e5f","line":27,"in_reply_to":"360fe371_1b346eee","updated":"2023-07-11 08:05:30.000000000","message":"yes, it seems that i didn\u0027t take the right commit with the changes i want.\nthe reason i chose this adress : 0x3E00 at first is because the Cypress FX2 16kB RAM goes from 0x0000 to 0x3FFF, and i chose to use it as Program only, so i chose to make the jump table at 0x3E00 to leave all the space from 0x0000 to 0x3DFF to be used by the Program.\nupdate: I changed it since i found a small memory area not used between 0x0200 and 0x02B0, so i placed the jump table at 0x0200, and it works fine.\nAnother thing is, the interruption list declared (as extern) in main.c turns out to be essential for the microcontroller to work correctly, when i remove them the microcontroller doesn\u0027t get the interruption signals, (eg. sudav interruption when setup data has been recieved) and so the \"donwload firmware\" operation fail.","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6b290be860acc946318a878066762a7a28c75185","unresolved":false,"context_lines":[{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"USB_Jump_Table:            ; autovector jump table"},{"line_number":28,"context_line":"    ljmp  _sudav_isr       ; (00) Setup Data Available"},{"line_number":29,"context_line":"    .db 0"},{"line_number":30,"context_line":"    ljmp  _sof_isr         ; (04) Start of Frame"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"3395cba7_16224b41","line":27,"in_reply_to":"4047e33b_01e72e5f","updated":"2023-07-11 08:09:28.000000000","message":"Done","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92ad76552fa08b7a7ab7bb0cb065e2e6a1ff66f8","unresolved":true,"context_lines":[{"line_number":19,"context_line":";--------------------------------------------------------------------------;"},{"line_number":20,"context_line":"; Interrupt Vectors                                                        ;"},{"line_number":21,"context_line":";--------------------------------------------------------------------------;"},{"line_number":22,"context_line":".area   USB_JV (ABS,OVR)   ; Absolute, Overlay"},{"line_number":23,"context_line":".org    0x43               ; USB interrupt (INT2) jumps here"},{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":";--------------------------------------------------------------------------;"},{"line_number":28,"context_line":"; USB Jump Table                                                           ;"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"ce452b84_412c450b","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":61},"updated":"2023-07-08 17:58:07.000000000","message":"Question for my understanding, please answer.\nI have tested 3 tools to convert the ihex to binary.\nmakebin (from sdcc tools) gives no error. OK.\nobjcopy (from binutils) gives no error, but fills the gaps with 0, while makebin fills with 0xff that looks more correct. (the objcopy option --gap-fill doesn\u0027t work properly, strange, but who cares)\nsrec_cat (from srecord tools) gives error of address 0x43 overwritten. Why?\n\nIf I understand correctly, here you are declaring the area USB_JV that is populated by the compiler, then you force .org 0x43 to overwrite the default value. Do I understand correctly?\nI don\u0027t think it\u0027s an error to be fixed, I just want to confirm it is ok.","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9356e91560245307c209fc2ac399909eef063d5c","unresolved":false,"context_lines":[{"line_number":19,"context_line":";--------------------------------------------------------------------------;"},{"line_number":20,"context_line":"; Interrupt Vectors                                                        ;"},{"line_number":21,"context_line":";--------------------------------------------------------------------------;"},{"line_number":22,"context_line":".area   USB_JV (ABS,OVR)   ; Absolute, Overlay"},{"line_number":23,"context_line":".org    0x43               ; USB interrupt (INT2) jumps here"},{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":";--------------------------------------------------------------------------;"},{"line_number":28,"context_line":"; USB Jump Table                                                           ;"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"d5384b71_525b7270","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":61},"in_reply_to":"776d210d_14e20ef8","updated":"2023-07-11 20:55:53.000000000","message":"Ack","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[{"line_number":19,"context_line":";--------------------------------------------------------------------------;"},{"line_number":20,"context_line":"; Interrupt Vectors                                                        ;"},{"line_number":21,"context_line":";--------------------------------------------------------------------------;"},{"line_number":22,"context_line":".area   USB_JV (ABS,OVR)   ; Absolute, Overlay"},{"line_number":23,"context_line":".org    0x43               ; USB interrupt (INT2) jumps here"},{"line_number":24,"context_line":"USB_AutoVector \u003d #. + 2"},{"line_number":25,"context_line":"    ljmp  USB_Jump_Table    ; Autovector will replace byte 45"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":";--------------------------------------------------------------------------;"},{"line_number":28,"context_line":"; USB Jump Table                                                           ;"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"776d210d_14e20ef8","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":61},"in_reply_to":"ce452b84_412c450b","updated":"2023-07-11 08:05:30.000000000","message":"in the reference manual, they mentioned that the USB interrupt vector should be in the address 0x43, so i must put it there for the interruptions to function, i think your explanation is correct .org 0x43 maybe overwrited the default value","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"}],"contrib/firmware/angie/hdl/Makefile":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"301bc82722afb2048b261ec865f2198b981d3144","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Needed by timing test"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1c43b57a_1b0c0bf4","line":1,"updated":"2023-06-20 14:24:14.000000000","message":"No, Apache-2.0 license is not compatible with GPL license used by OpenOCD","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Needed by timing test"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"33d47fcd_ad33128f","line":1,"in_reply_to":"1c43b57a_1b0c0bf4","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Needed by timing test"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"eee6f580_690c4e2e","line":1,"in_reply_to":"1c43b57a_1b0c0bf4","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":true,"context_lines":[{"line_number":41,"context_line":"NGDBUILD_OPTS :\u003d"},{"line_number":42,"context_line":"MAP_OPTS :\u003d -mt 2"},{"line_number":43,"context_line":"PAR_OPTS :\u003d -mt 4"},{"line_number":44,"context_line":"BITGEN_OPTS :\u003d -g Binary:Yes"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"XILINX_PLATFORM :\u003d lin64"},{"line_number":47,"context_line":"PATH :\u003d $(PATH):$(XILINX_HOME)/bin/$(XILINX_PLATFORM)"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"d38af984_023ce820","line":44,"updated":"2023-06-21 14:27:11.000000000","message":"The bitstream is 300 kbyte, but has quite sparse content (many zeros).\nAdding such big file to OpenOCD is not the best option. I thinking about compressing it.\n\nApparently BITGEN accepts the command line flag \"-g compress\" to generate a compressed bitstream that will be auto-magically decompressed by the FPGA during the download.\nI have no idea if it really works, if it works with the FPGA in this angie adapter, nor what would be the final size after this compression.\nWould you mind making a test?","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6b290be860acc946318a878066762a7a28c75185","unresolved":false,"context_lines":[{"line_number":41,"context_line":"NGDBUILD_OPTS :\u003d"},{"line_number":42,"context_line":"MAP_OPTS :\u003d -mt 2"},{"line_number":43,"context_line":"PAR_OPTS :\u003d -mt 4"},{"line_number":44,"context_line":"BITGEN_OPTS :\u003d -g Binary:Yes"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"XILINX_PLATFORM :\u003d lin64"},{"line_number":47,"context_line":"PATH :\u003d $(PATH):$(XILINX_HOME)/bin/$(XILINX_PLATFORM)"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"db5a52e9_9f0e5d3f","line":44,"in_reply_to":"6f8cb17b_01f69c85","updated":"2023-07-11 08:09:28.000000000","message":"Done","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92ad76552fa08b7a7ab7bb0cb065e2e6a1ff66f8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"NGDBUILD_OPTS :\u003d"},{"line_number":42,"context_line":"MAP_OPTS :\u003d -mt 2"},{"line_number":43,"context_line":"PAR_OPTS :\u003d -mt 4"},{"line_number":44,"context_line":"BITGEN_OPTS :\u003d -g Binary:Yes"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"XILINX_PLATFORM :\u003d lin64"},{"line_number":47,"context_line":"PATH :\u003d $(PATH):$(XILINX_HOME)/bin/$(XILINX_PLATFORM)"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"09fcec69_c868e565","line":44,"in_reply_to":"d38af984_023ce820","updated":"2023-07-08 17:58:07.000000000","message":"Done","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":true,"context_lines":[{"line_number":41,"context_line":"NGDBUILD_OPTS :\u003d"},{"line_number":42,"context_line":"MAP_OPTS :\u003d -mt 2"},{"line_number":43,"context_line":"PAR_OPTS :\u003d -mt 4"},{"line_number":44,"context_line":"BITGEN_OPTS :\u003d -g Binary:Yes"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"XILINX_PLATFORM :\u003d lin64"},{"line_number":47,"context_line":"PATH :\u003d $(PATH):$(XILINX_HOME)/bin/$(XILINX_PLATFORM)"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"6f8cb17b_01f69c85","line":44,"in_reply_to":"d38af984_023ce820","updated":"2023-07-11 08:05:30.000000000","message":"Yes, i tried it, it works. the bitstream size went from 300KB to 131 KB","commit_id":"2dd28fdd76a19dd5901a8d53c13fe6f75f12027f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"92ad76552fa08b7a7ab7bb0cb065e2e6a1ff66f8","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"$(HDL_BUILD_DIR)/$(PROJECT).bin: $(HDL_BUILD_DIR)/$(PROJECT).ncd"},{"line_number":62,"context_line":"\t$(call RUN,bitgen) $(COMMON_OPTS) $(BITGEN_OPTS) \\"},{"line_number":63,"context_line":"\t\t-g compress -w $(PROJECT).ncd $(PROJECT).bit"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"$(HDL_BUILD_DIR)/$(PROJECT).ncd: $(HDL_BUILD_DIR)/$(PROJECT).map.ncd"},{"line_number":66,"context_line":"\t$(call RUN,par) $(COMMON_OPTS) $(PAR_OPTS) \\"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"88506b7d_8620183c","line":63,"updated":"2023-07-08 17:58:07.000000000","message":"from the comments on the mailing list, better to drop the \"-g compress\" flag.\nThe gain is low and it\u0027s better to keep it uncompressed to test, later on, the zlib option.\nAnyway in gerrit we have the binary either compressed and not compressed, so we can easily change later on.\nCan you please drop the flag here and put back the non-compressed bitstream in the other patch?","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"$(HDL_BUILD_DIR)/$(PROJECT).bin: $(HDL_BUILD_DIR)/$(PROJECT).ncd"},{"line_number":62,"context_line":"\t$(call RUN,bitgen) $(COMMON_OPTS) $(BITGEN_OPTS) \\"},{"line_number":63,"context_line":"\t\t-g compress -w $(PROJECT).ncd $(PROJECT).bit"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"$(HDL_BUILD_DIR)/$(PROJECT).ncd: $(HDL_BUILD_DIR)/$(PROJECT).map.ncd"},{"line_number":66,"context_line":"\t$(call RUN,par) $(COMMON_OPTS) $(PAR_OPTS) \\"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"e9dd532a_06fffc7b","line":63,"in_reply_to":"88506b7d_8620183c","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fd5be4d9ae14c493d3465ba8d5297d909ca0bcae","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"$(HDL_BUILD_DIR)/$(PROJECT).bin: $(HDL_BUILD_DIR)/$(PROJECT).ncd"},{"line_number":62,"context_line":"\t$(call RUN,bitgen) $(COMMON_OPTS) $(BITGEN_OPTS) \\"},{"line_number":63,"context_line":"\t\t-g compress -w $(PROJECT).ncd $(PROJECT).bit"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"$(HDL_BUILD_DIR)/$(PROJECT).ncd: $(HDL_BUILD_DIR)/$(PROJECT).map.ncd"},{"line_number":66,"context_line":"\t$(call RUN,par) $(COMMON_OPTS) $(PAR_OPTS) \\"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"8abe6400_6c759f12","line":63,"in_reply_to":"88506b7d_8620183c","updated":"2023-07-10 22:43:50.000000000","message":"Done","commit_id":"230ff7c1d48c002143a64be62d9ba825853b72d1"}],"contrib/firmware/angie/hdl/README":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"301bc82722afb2048b261ec865f2198b981d3144","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is the source code of Nanoxplore USB-JTAG Adapter Angie\u0027s bitstream."}],"source_content_type":"application/octet-stream","patch_set":11,"id":"5d083cc8_2e99cd0d","line":1,"updated":"2023-06-20 14:24:14.000000000","message":"No, Apache-2.0 license is not compatible with GPL license used by OpenOCD","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is the source code of Nanoxplore USB-JTAG Adapter Angie\u0027s bitstream."}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3a41d672_b7863dcd","line":1,"in_reply_to":"5d083cc8_2e99cd0d","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is the source code of Nanoxplore USB-JTAG Adapter Angie\u0027s bitstream."}],"source_content_type":"application/octet-stream","patch_set":11,"id":"b8406383_2261b9de","line":1,"in_reply_to":"5d083cc8_2e99cd0d","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"}],"contrib/firmware/angie/hdl/set_env.sh":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"301bc82722afb2048b261ec865f2198b981d3144","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[ -z \"${XILINX_HOME}\" ] \u0026\u0026 export XILINX_HOME\u003d/home/software/Xilinx/ISE/14.7/ISE_DS/ISE"}],"source_content_type":"text/x-sh","patch_set":11,"id":"0875f687_89dbc81a","line":2,"updated":"2023-06-20 14:24:14.000000000","message":"No, Apache-2.0 license is not compatible with GPL license used by OpenOCD","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[ -z \"${XILINX_HOME}\" ] \u0026\u0026 export XILINX_HOME\u003d/home/software/Xilinx/ISE/14.7/ISE_DS/ISE"}],"source_content_type":"text/x-sh","patch_set":11,"id":"701c43b8_2cc312a4","line":2,"in_reply_to":"0875f687_89dbc81a","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[ -z \"${XILINX_HOME}\" ] \u0026\u0026 export XILINX_HOME\u003d/home/software/Xilinx/ISE/14.7/ISE_DS/ISE"}],"source_content_type":"text/x-sh","patch_set":11,"id":"da460908_c57ac81a","line":2,"in_reply_to":"0875f687_89dbc81a","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"}],"contrib/firmware/angie/hdl/src/angie_openocd.ucf":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"301bc82722afb2048b261ec865f2198b981d3144","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# WARNING: PullUps on JTAG inputs should be enabled after configuration"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"33e36da5_15aa67b6","line":1,"updated":"2023-06-20 14:24:14.000000000","message":"No, Apache-2.0 license is not compatible with GPL license used by OpenOCD","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# WARNING: PullUps on JTAG inputs should be enabled after configuration"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"64301b81_aa67cdbc","line":1,"in_reply_to":"33e36da5_15aa67b6","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# WARNING: PullUps on JTAG inputs should be enabled after configuration"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"5ff7ae26_688c54d9","line":1,"in_reply_to":"33e36da5_15aa67b6","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"}],"contrib/firmware/angie/hdl/src/angie_openocd.vhd":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"301bc82722afb2048b261ec865f2198b981d3144","unresolved":true,"context_lines":[{"line_number":1,"context_line":"-- SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"-- Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":"----------------------------------------------------------------------------"},{"line_number":4,"context_line":"-- Project Context: nanoXplore USB-JTAG Adapter Board, Spartan6"}],"source_content_type":"text/x-vhdl","patch_set":11,"id":"9dad6937_bcd20d92","line":1,"updated":"2023-06-20 14:24:14.000000000","message":"No, Apache-2.0 license is not compatible with GPL license used by OpenOCD","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ceedf72cac2c9d680f7e202e1bbc6780e2849931","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-- SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"-- Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":"----------------------------------------------------------------------------"},{"line_number":4,"context_line":"-- Project Context: nanoXplore USB-JTAG Adapter Board, Spartan6"}],"source_content_type":"text/x-vhdl","patch_set":11,"id":"f1ebd7f0_0d10bdb1","line":1,"in_reply_to":"9dad6937_bcd20d92","updated":"2023-07-11 08:05:30.000000000","message":"Ack","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f675115ce14b3c307b33a3b8eb0e1b5c5e922ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-- SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"-- Copyright (C) 2023 by NanoXplore, France - all rights reserved"},{"line_number":3,"context_line":"----------------------------------------------------------------------------"},{"line_number":4,"context_line":"-- Project Context: nanoXplore USB-JTAG Adapter Board, Spartan6"}],"source_content_type":"text/x-vhdl","patch_set":11,"id":"81516b96_bf3ea30f","line":1,"in_reply_to":"9dad6937_bcd20d92","updated":"2023-06-21 14:27:11.000000000","message":"Done","commit_id":"a762b2f672e3b5b4bded3b8680f3924dab0a6a8c"}],"doc/usb_adapters/angie/584e_424e_angie.txt":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"91d0122e858767c323c03efd758d7fbe915b75b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later OR GFDL-1.2-no-invariants-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Optional comment"},{"line_number":4,"context_line":"can\u0027t get device qualifier: Resource temporarily unavailable"},{"line_number":5,"context_line":"can\u0027t get debug descriptor: Resource temporarily unavailable"},{"line_number":6,"context_line":"cannot read device status, Resource temporarily unavailable (11)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Bus 001 Device 056: ID 584e:424e NanoXplore, SAS. ANGIE Adapter"},{"line_number":9,"context_line":"Device Descriptor:"}],"source_content_type":"text/plain","patch_set":22,"id":"78067651_8000571f","line":6,"range":{"start_line":4,"start_character":1,"end_line":6,"end_character":5},"updated":"2023-07-10 22:41:37.000000000","message":"please remove these three error lines.\nStrange, the script should have removed them.","commit_id":"4b27f9fc40605fb2affdd93940c25f1819c8f1ad"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"bce61cb8a50328b34ece173cc18e61edb3aba30c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later OR GFDL-1.2-no-invariants-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Optional comment"},{"line_number":4,"context_line":"can\u0027t get device qualifier: Resource temporarily unavailable"},{"line_number":5,"context_line":"can\u0027t get debug descriptor: Resource temporarily unavailable"},{"line_number":6,"context_line":"cannot read device status, Resource temporarily unavailable (11)"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Bus 001 Device 056: ID 584e:424e NanoXplore, SAS. ANGIE Adapter"},{"line_number":9,"context_line":"Device Descriptor:"}],"source_content_type":"text/plain","patch_set":22,"id":"49473c57_9bef1329","line":6,"range":{"start_line":4,"start_character":1,"end_line":6,"end_character":5},"in_reply_to":"78067651_8000571f","updated":"2023-07-11 08:13:56.000000000","message":"Done","commit_id":"4b27f9fc40605fb2affdd93940c25f1819c8f1ad"}]}