)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":17,"context_line":"the firmware (embedded C) to the FX2, and the second to program"},{"line_number":18,"context_line":"the FPGA with its bitstream."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Remove libusb API, instead the wrappers in drivers/libusb_helper.h,c"},{"line_number":21,"context_line":"has been used."},{"line_number":22,"context_line":"Remove reset handling from the queue of commands and make"},{"line_number":23,"context_line":"executable immediately."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Add ANGIE\u0027s configuration file to tcl/interface/"},{"line_number":26,"context_line":"Add the device VID/PID to 60-openocd.rules file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1b05ac8a_278136d0","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":23},"updated":"2023-07-14 22:20:21.000000000","message":"These lines report the log of the patch review and are not required.\nThe commit message should report what the patch does, not the steps to arrive at this version.\nThe lines below, instead, are ok, as they report the content of the patch.","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the firmware (embedded C) to the FX2, and the second to program"},{"line_number":18,"context_line":"the FPGA with its bitstream."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Remove libusb API, instead the wrappers in drivers/libusb_helper.h,c"},{"line_number":21,"context_line":"has been used."},{"line_number":22,"context_line":"Remove reset handling from the queue of commands and make"},{"line_number":23,"context_line":"executable immediately."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Add ANGIE\u0027s configuration file to tcl/interface/"},{"line_number":26,"context_line":"Add the device VID/PID to 60-openocd.rules file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"3efab218_65759614","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":23},"in_reply_to":"1b05ac8a_278136d0","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fe9fe7147353205535846439cdf75ad5421bf59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"615f06a5_0fa14a15","updated":"2023-06-18 19:01:05.000000000","message":"I have not completed the review, mainly on angie.c file I need to look at it.\nThere are already few comments below, plus the comments I added to https://review.openocd.org/7697 and not applied yet:\n\n\u003e Please don\u0027t use directly libusb API, as they return libusb error codes not compatible with OpenOCD error code. Use instead the wrappers in src/jtag/drivers/libusb_helper.h,c\n\n\u003e What about the bitstream? No source code? What is its license?","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc1fb69b_35f2dd32","in_reply_to":"615f06a5_0fa14a15","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c96f32d4_2d5e96ca","in_reply_to":"615f06a5_0fa14a15","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7c26eea9_d2d877f3","updated":"2023-07-02 22:43:10.000000000","message":"Quite few comments, below.\n\nI have noticed that you never answered to the questions I wrote in the comments, but you only modified the code. This left me guessing what would be your intention, while getting your direct feedback can help the review; I don\u0027t have all the details and I can misunderstand the context. Also, feel free to write down in the comments anything you consider invalid in my review.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a03a8f9c2d3babd822d1c8de9c6ca83d3bf8859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c52eb76f_76664bca","updated":"2023-07-08 18:35:31.000000000","message":"I always forget to mention this...\nCan you provide a USB dump of the angie adapter, by plugging it in a Linux PC and running the script\n./doc/usb_adapters/dump.sh 584e 424e\nthen put the output in\ndoc/usb_adapters/angie/584e_424e_angie.txt\nand then posting a new patch with this new file?\n\nI see that there are now two set of USB VID:PID for angie adapters.\nIs it relevant to post also 584e 4a55 ?","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"df5d5bee_65c06f52","updated":"2023-07-08 14:23:51.000000000","message":"We are going through several review, but the result is getting closer to be ready.\nWould you mind adding my patch https://review.openocd.org/7756/ before your 7702 to use it and test if it works at least for your angie driver?","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"ed45521cce3f8579cbf8bf52fdf04b2df1fbe7d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"64f512a0_f257fd13","in_reply_to":"41b1551a_2de60a07","updated":"2023-07-17 11:54:50.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"41b1551a_2de60a07","in_reply_to":"c52eb76f_76664bca","updated":"2023-07-11 08:00:12.000000000","message":"for 584e 4a55 its not relevant because i added it just to correct a bug when we switch from another adapter to my adapter, so the driver can find it in the usb list and change its firmware.","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"051c2243_b5d08484","updated":"2023-07-11 08:00:12.000000000","message":"Hi yes i just saw that my replies didn\u0027t reach you because i was just replying without pressing the key \u0027a\u0027 and sent it.\nhere you will find all my replies.\nthank you","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"c497ee2c_d0a33227","updated":"2023-07-11 21:23:10.000000000","message":"th","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"b815677e_f6704481","updated":"2023-07-14 22:20:21.000000000","message":"Almost done. Only some minor issue not spotted erlier","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"60f161212c9bce5264ffcb164fffedc3d122d8a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"cf7216de_840770a2","updated":"2023-07-22 21:16:44.000000000","message":"I still have few comments, not spotted before.","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6d438d15f7ea6916b55d5feed1d56a0620380101","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"4bd7f81f_582986f9","updated":"2023-07-24 08:25:36.000000000","message":"resolved","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"60a04413e96dbd90768c00f6d45a0473a9309fa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"1e69a1a4_bb5f1ee4","updated":"2023-07-24 15:09:36.000000000","message":"you have missed one part of my last comment.","commit_id":"bfa004958c3fa8d8f6ffaa43351006e9533cf3b6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9d26038a43c95e5c4e3a1f470a2a5f48505cc4fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"a9030f4e_83ccee2c","updated":"2023-07-24 15:36:55.000000000","message":"Thanks.\nThis patch still has some mismatch with OpenOCD coding style, that requires to declare and use the variables in the same line.\nI plan to apply some rework on this code, so I will also fix these coding style later in a separate patch.","commit_id":"095bfb1e1fea98196bddd3a94a2ed3f6deaf8e6c"}],"contrib/60-openocd.rules":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fe9fe7147353205535846439cdf75ad5421bf59","unresolved":true,"context_lines":[{"line_number":221,"context_line":"# Espressif USB JTAG/serial debug units"},{"line_number":222,"context_line":"ATTRS{idVendor}\u003d\u003d\"303a\", ATTRS{idProduct}\u003d\u003d\"1001\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":223,"context_line":"ATTRS{idVendor}\u003d\u003d\"303a\", ATTRS{idProduct}\u003d\u003d\"1002\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Marvell Sheevaplug"},{"line_number":226,"context_line":"ATTRS{idVendor}\u003d\u003d\"9e88\", ATTRS{idProduct}\u003d\u003d\"9e8f\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ed0e5966_524fc9ef","line":224,"updated":"2023-06-18 19:01:05.000000000","message":"please add here the USB ID of the new device, in order to provide automatic permission on Linux machines. Something like:\n \\# ANGIE USB-JTAG Adapter\n ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"424e\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\"","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":221,"context_line":"# Espressif USB JTAG/serial debug units"},{"line_number":222,"context_line":"ATTRS{idVendor}\u003d\u003d\"303a\", ATTRS{idProduct}\u003d\u003d\"1001\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":223,"context_line":"ATTRS{idVendor}\u003d\u003d\"303a\", ATTRS{idProduct}\u003d\u003d\"1002\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Marvell Sheevaplug"},{"line_number":226,"context_line":"ATTRS{idVendor}\u003d\u003d\"9e88\", ATTRS{idProduct}\u003d\u003d\"9e8f\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"04f725f9_d6367db5","line":224,"in_reply_to":"ed0e5966_524fc9ef","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"# Espressif USB JTAG/serial debug units"},{"line_number":222,"context_line":"ATTRS{idVendor}\u003d\u003d\"303a\", ATTRS{idProduct}\u003d\u003d\"1001\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":223,"context_line":"ATTRS{idVendor}\u003d\u003d\"303a\", ATTRS{idProduct}\u003d\u003d\"1002\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Marvell Sheevaplug"},{"line_number":226,"context_line":"ATTRS{idVendor}\u003d\u003d\"9e88\", ATTRS{idProduct}\u003d\u003d\"9e8f\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"124a381d_1adac2ed","line":224,"in_reply_to":"ed0e5966_524fc9ef","updated":"2023-07-02 22:43:10.000000000","message":"Done","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fe9fe7147353205535846439cdf75ad5421bf59","unresolved":true,"context_lines":[{"line_number":3244,"context_line":"This is the Keil ULINK v1 JTAG debugger."},{"line_number":3245,"context_line":"@end deffn"},{"line_number":3246,"context_line":""},{"line_number":3247,"context_line":"@deffn {Interface Driver} {angie}"},{"line_number":3248,"context_line":"This is the NanoXplore\u0027s ANGIE USB-JTAG Adapter."},{"line_number":3249,"context_line":""},{"line_number":3250,"context_line":"@deffn {Command} {angie download_firmware}"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"e617b04d_fdbf2770","line":3247,"updated":"2023-06-18 19:01:05.000000000","message":"This file is not well in order, it needs some rework.\nIn mean time, would you mind moving this section between\n@deffn {Interface Driver} {amt_jtagaccel}\nand\n@deffn {Interface Driver} {arm-jtag-ew}","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":3244,"context_line":"This is the Keil ULINK v1 JTAG debugger."},{"line_number":3245,"context_line":"@end deffn"},{"line_number":3246,"context_line":""},{"line_number":3247,"context_line":"@deffn {Interface Driver} {angie}"},{"line_number":3248,"context_line":"This is the NanoXplore\u0027s ANGIE USB-JTAG Adapter."},{"line_number":3249,"context_line":""},{"line_number":3250,"context_line":"@deffn {Command} {angie download_firmware}"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"cdb4db5f_65d45183","line":3247,"in_reply_to":"e617b04d_fdbf2770","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":false,"context_lines":[{"line_number":3244,"context_line":"This is the Keil ULINK v1 JTAG debugger."},{"line_number":3245,"context_line":"@end deffn"},{"line_number":3246,"context_line":""},{"line_number":3247,"context_line":"@deffn {Interface Driver} {angie}"},{"line_number":3248,"context_line":"This is the NanoXplore\u0027s ANGIE USB-JTAG Adapter."},{"line_number":3249,"context_line":""},{"line_number":3250,"context_line":"@deffn {Command} {angie download_firmware}"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"e4a7ce4d_44ead123","line":3247,"in_reply_to":"e617b04d_fdbf2770","updated":"2023-07-02 22:43:10.000000000","message":"Done","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"}],"src/jtag/drivers/angie.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":52,"context_line":"#define USB_INTERFACE            0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"/** Delay (in microseconds) to wait while EZ-USB performs ReNumeration. */"},{"line_number":55,"context_line":"#define ANGIE_RENUMERATION_DELAY 1500000"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/** Default location of ANGIE firmware image. */"},{"line_number":58,"context_line":"#define ANGIE_FIRMWARE_FILE      PKGDATADIR \"/angie/angie_firmware.hex\""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"65b2d4d3_4bef854f","line":55,"updated":"2023-07-02 22:43:10.000000000","message":"please rename it as ANGIE_RENUMERATION_DELAY_US","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#define USB_INTERFACE            0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"/** Delay (in microseconds) to wait while EZ-USB performs ReNumeration. */"},{"line_number":55,"context_line":"#define ANGIE_RENUMERATION_DELAY 1500000"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/** Default location of ANGIE firmware image. */"},{"line_number":58,"context_line":"#define ANGIE_FIRMWARE_FILE      PKGDATADIR \"/angie/angie_firmware.hex\""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"4bf1b18b_67d63e05","line":55,"in_reply_to":"65b2d4d3_4bef854f","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#define USB_INTERFACE            0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"/** Delay (in microseconds) to wait while EZ-USB performs ReNumeration. */"},{"line_number":55,"context_line":"#define ANGIE_RENUMERATION_DELAY 1500000"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/** Default location of ANGIE firmware image. */"},{"line_number":58,"context_line":"#define ANGIE_FIRMWARE_FILE      PKGDATADIR \"/angie/angie_firmware.hex\""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"a009eba4_6b76aa9b","line":55,"in_reply_to":"65b2d4d3_4bef854f","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":137,"context_line":"\tunsigned int ep_in;\t\t/**\u003c IN endpoint number */"},{"line_number":138,"context_line":"\tunsigned int ep_out;\t\t/**\u003c OUT endpoint number */"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"\tint delay_scan_in;\t/**\u003c Delay value for SCAN_IN commands */"},{"line_number":141,"context_line":"\tint delay_scan_out;\t/**\u003c Delay value for SCAN_OUT commands */"},{"line_number":142,"context_line":"\tint delay_scan_io;\t/**\u003c Delay value for SCAN_IO commands */"},{"line_number":143,"context_line":"\tint delay_clock_tck;\t/**\u003c Delay value for CLOCK_TMS commands */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"443da092_c2ac8d4a","line":140,"updated":"2023-07-02 22:43:10.000000000","message":"To justify why these delay_XX fields are signed values, please add a common comment before this line (if I got it correctly):\n/\\* delay value in [0:255] range in units of 4 us; -1 means ... \\*/","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":137,"context_line":"\tunsigned int ep_in;\t\t/**\u003c IN endpoint number */"},{"line_number":138,"context_line":"\tunsigned int ep_out;\t\t/**\u003c OUT endpoint number */"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"\tint delay_scan_in;\t/**\u003c Delay value for SCAN_IN commands */"},{"line_number":141,"context_line":"\tint delay_scan_out;\t/**\u003c Delay value for SCAN_OUT commands */"},{"line_number":142,"context_line":"\tint delay_scan_io;\t/**\u003c Delay value for SCAN_IO commands */"},{"line_number":143,"context_line":"\tint delay_clock_tck;\t/**\u003c Delay value for CLOCK_TMS commands */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"6c1a8e78_bfa1dc23","line":140,"in_reply_to":"443da092_c2ac8d4a","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":137,"context_line":"\tunsigned int ep_in;\t\t/**\u003c IN endpoint number */"},{"line_number":138,"context_line":"\tunsigned int ep_out;\t\t/**\u003c OUT endpoint number */"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"\tint delay_scan_in;\t/**\u003c Delay value for SCAN_IN commands */"},{"line_number":141,"context_line":"\tint delay_scan_out;\t/**\u003c Delay value for SCAN_OUT commands */"},{"line_number":142,"context_line":"\tint delay_scan_io;\t/**\u003c Delay value for SCAN_IO commands */"},{"line_number":143,"context_line":"\tint delay_clock_tck;\t/**\u003c Delay value for CLOCK_TMS commands */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b96c748e_3e8aa9ed","line":140,"in_reply_to":"443da092_c2ac8d4a","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":157,"context_line":"/* ANGIE MCU (Cypress EZ-USB) specific functions */"},{"line_number":158,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit);"},{"line_number":159,"context_line":"static int angie_load_firmware_and_renumerate(struct angie **device, const char *filename,"},{"line_number":160,"context_line":"\t\tuint32_t delay);"},{"line_number":161,"context_line":"static int angie_load_firmware(struct angie *device, const char *filename);"},{"line_number":162,"context_line":"static int angie_load_bitstream(struct angie *device, const char *filename);"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"bc097136_25151419","line":160,"updated":"2023-07-02 22:43:10.000000000","message":"please rename the argument as delay_us","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":157,"context_line":"/* ANGIE MCU (Cypress EZ-USB) specific functions */"},{"line_number":158,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit);"},{"line_number":159,"context_line":"static int angie_load_firmware_and_renumerate(struct angie **device, const char *filename,"},{"line_number":160,"context_line":"\t\tuint32_t delay);"},{"line_number":161,"context_line":"static int angie_load_firmware(struct angie *device, const char *filename);"},{"line_number":162,"context_line":"static int angie_load_bitstream(struct angie *device, const char *filename);"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"6c25706c_86e07c9c","line":160,"in_reply_to":"bc097136_25151419","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":157,"context_line":"/* ANGIE MCU (Cypress EZ-USB) specific functions */"},{"line_number":158,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit);"},{"line_number":159,"context_line":"static int angie_load_firmware_and_renumerate(struct angie **device, const char *filename,"},{"line_number":160,"context_line":"\t\tuint32_t delay);"},{"line_number":161,"context_line":"static int angie_load_firmware(struct angie *device, const char *filename);"},{"line_number":162,"context_line":"static int angie_load_bitstream(struct angie *device, const char *filename);"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"27137033_aedd41fb","line":160,"in_reply_to":"bc097136_25151419","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":246,"context_line":" * @return on success: ERROR_OK"},{"line_number":247,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":248,"context_line":" */"},{"line_number":249,"context_line":"static int angie_usb_open(struct angie **device)"},{"line_number":250,"context_line":"{"},{"line_number":251,"context_line":"\tssize_t num_devices, i;"},{"line_number":252,"context_line":"\tbool found;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"d24e207c_a9dc5ef7","line":249,"updated":"2023-07-02 22:43:10.000000000","message":"most of the content of this function can be replaced by calling OpenOCD jtag_libusb_open().\nIt will make OpenOCD code more consistent and has the advantages of:\n* support for USB serial serial number (maybe not interesting here because the serial number could change after firmware download);\n* support for USB location, that is ability to provide the path to the USB port where the adapter is plugged;\n* support for multiple USB VID/PID (again maybe not useful here);\n* managing the LIBUSB error codes.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":246,"context_line":" * @return on success: ERROR_OK"},{"line_number":247,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":248,"context_line":" */"},{"line_number":249,"context_line":"static int angie_usb_open(struct angie **device)"},{"line_number":250,"context_line":"{"},{"line_number":251,"context_line":"\tssize_t num_devices, i;"},{"line_number":252,"context_line":"\tbool found;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"7c076cab_7ab47481","line":249,"in_reply_to":"d24e207c_a9dc5ef7","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":246,"context_line":" * @return on success: ERROR_OK"},{"line_number":247,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":248,"context_line":" */"},{"line_number":249,"context_line":"static int angie_usb_open(struct angie **device)"},{"line_number":250,"context_line":"{"},{"line_number":251,"context_line":"\tssize_t num_devices, i;"},{"line_number":252,"context_line":"\tbool found;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"572ef547_74ba7473","line":249,"in_reply_to":"d24e207c_a9dc5ef7","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":294,"context_line":"\tif (libusb_release_interface((*device)-\u003eusb_device_handle, 0) !\u003d 0)"},{"line_number":295,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"\tlibusb_close((*device)-\u003eusb_device_handle);"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\t(*device)-\u003eusb_device_handle \u003d NULL;"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"83b663e6_e7ee0e35","line":297,"updated":"2023-07-02 22:43:10.000000000","message":"and here you can use the jtag_libusb_close()","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":294,"context_line":"\tif (libusb_release_interface((*device)-\u003eusb_device_handle, 0) !\u003d 0)"},{"line_number":295,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"\tlibusb_close((*device)-\u003eusb_device_handle);"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\t(*device)-\u003eusb_device_handle \u003d NULL;"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"4c73af39_9c6f854f","line":297,"in_reply_to":"83b663e6_e7ee0e35","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":294,"context_line":"\tif (libusb_release_interface((*device)-\u003eusb_device_handle, 0) !\u003d 0)"},{"line_number":295,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"\tlibusb_close((*device)-\u003eusb_device_handle);"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\t(*device)-\u003eusb_device_handle \u003d NULL;"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"88fa51e1_51cab5df","line":297,"in_reply_to":"83b663e6_e7ee0e35","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":335,"context_line":" * @param device pointer to struct angie identifying ANGIE driver instance."},{"line_number":336,"context_line":" *  The usb_handle member will be modified during re-enumeration."},{"line_number":337,"context_line":" * @param filename path to the Intel HEX file containing the firmware image."},{"line_number":338,"context_line":" * @param delay the delay to wait for the device to re-enumerate."},{"line_number":339,"context_line":" * @return on success: ERROR_OK"},{"line_number":340,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":341,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"ac2aa8a4_fdadebf5","line":338,"updated":"2023-07-02 22:43:10.000000000","message":"param delay the delay in us ...","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":335,"context_line":" * @param device pointer to struct angie identifying ANGIE driver instance."},{"line_number":336,"context_line":" *  The usb_handle member will be modified during re-enumeration."},{"line_number":337,"context_line":" * @param filename path to the Intel HEX file containing the firmware image."},{"line_number":338,"context_line":" * @param delay the delay to wait for the device to re-enumerate."},{"line_number":339,"context_line":" * @return on success: ERROR_OK"},{"line_number":340,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":341,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"a17b737f_2987d6d0","line":338,"in_reply_to":"ac2aa8a4_fdadebf5","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":335,"context_line":" * @param device pointer to struct angie identifying ANGIE driver instance."},{"line_number":336,"context_line":" *  The usb_handle member will be modified during re-enumeration."},{"line_number":337,"context_line":" * @param filename path to the Intel HEX file containing the firmware image."},{"line_number":338,"context_line":" * @param delay the delay to wait for the device to re-enumerate."},{"line_number":339,"context_line":" * @return on success: ERROR_OK"},{"line_number":340,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":341,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"6273cbb0_3cd0979a","line":338,"in_reply_to":"ac2aa8a4_fdadebf5","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":340,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":341,"context_line":" */"},{"line_number":342,"context_line":"static int angie_load_firmware_and_renumerate(struct angie **device,"},{"line_number":343,"context_line":"\tconst char *filename, uint32_t delay)"},{"line_number":344,"context_line":"{"},{"line_number":345,"context_line":"\tint ret;"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"341ea8ca_4337e319","line":343,"updated":"2023-07-02 22:43:10.000000000","message":"s/delay/delay_us/","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":340,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":341,"context_line":" */"},{"line_number":342,"context_line":"static int angie_load_firmware_and_renumerate(struct angie **device,"},{"line_number":343,"context_line":"\tconst char *filename, uint32_t delay)"},{"line_number":344,"context_line":"{"},{"line_number":345,"context_line":"\tint ret;"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"943899a9_5a51d687","line":343,"in_reply_to":"341ea8ca_4337e319","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":340,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":341,"context_line":" */"},{"line_number":342,"context_line":"static int angie_load_firmware_and_renumerate(struct angie **device,"},{"line_number":343,"context_line":"\tconst char *filename, uint32_t delay)"},{"line_number":344,"context_line":"{"},{"line_number":345,"context_line":"\tint ret;"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"a62c2609_b4871d40","line":343,"in_reply_to":"341ea8ca_4337e319","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"8a6b8a1d_7a7bc47f","line":436,"updated":"2023-07-02 22:43:10.000000000","message":"one of the parameter is a pointer, not an integer!\n0x00, 0xB0, 0, 0, NULL, 0, LIBUSB_TIMEOUT_MS);","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"661924a2_b70374aa","line":436,"in_reply_to":"8a6b8a1d_7a7bc47f","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"17c7544b_57ee5269","line":436,"in_reply_to":"8a6b8a1d_7a7bc47f","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":440,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"e3beaee6_d6b87ccd","line":437,"updated":"2023-07-02 22:43:10.000000000","message":"I think we have a non complete implementation of jtag_libusb_control_transfer() in OpenOCD!\nHere you send the control packet with bRequest\u003d0xB0 without any data.\nData are optional with control packet, so your code is ok.\nThe issue is that the current implementation of jtag_libusb_control_transfer() cannot detect an error when there is zero byte to transfer.\nI\u0027m sending out a to fix that, on top of https://review.openocd.org/7743/\nYou can put this patch in the same series to use it.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":440,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"2e1cd66f_6e44807c","line":437,"in_reply_to":"9f90c6b4_c596abb4","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":440,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"da90f80a_298f25b1","line":437,"in_reply_to":"e3beaee6_d6b87ccd","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":434,"context_line":"\t/* CFGopen */"},{"line_number":435,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":436,"context_line":"\t\t0x00, 0xB0, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":437,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":438,"context_line":"\t\tLOG_ERROR(\"Failed opencfg\");"},{"line_number":439,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":440,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"9f90c6b4_c596abb4","line":437,"in_reply_to":"e3beaee6_d6b87ccd","updated":"2023-07-08 14:23:51.000000000","message":"My error, I mean https://review.openocd.org/7756/","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":453,"context_line":"\tfseek(bitstream_file, 0, SEEK_SET);"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"\t/* Allocate memory for the bitstream data */"},{"line_number":456,"context_line":"\tbitstream_data \u003d (char *)malloc(bitstream_size);"},{"line_number":457,"context_line":"\tif (!bitstream_data) {"},{"line_number":458,"context_line":"\t\tLOG_ERROR(\"Failed to allocate memory for bitstream data.\");"},{"line_number":459,"context_line":"\t\tfclose(bitstream_file);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"bc334289_5eeb538f","line":456,"updated":"2023-07-02 22:43:10.000000000","message":"no need for cast (char \\*)","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":453,"context_line":"\tfseek(bitstream_file, 0, SEEK_SET);"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"\t/* Allocate memory for the bitstream data */"},{"line_number":456,"context_line":"\tbitstream_data \u003d (char *)malloc(bitstream_size);"},{"line_number":457,"context_line":"\tif (!bitstream_data) {"},{"line_number":458,"context_line":"\t\tLOG_ERROR(\"Failed to allocate memory for bitstream data.\");"},{"line_number":459,"context_line":"\t\tfclose(bitstream_file);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b335f3cb_e3e8a997","line":456,"in_reply_to":"bc334289_5eeb538f","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":453,"context_line":"\tfseek(bitstream_file, 0, SEEK_SET);"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"\t/* Allocate memory for the bitstream data */"},{"line_number":456,"context_line":"\tbitstream_data \u003d (char *)malloc(bitstream_size);"},{"line_number":457,"context_line":"\tif (!bitstream_data) {"},{"line_number":458,"context_line":"\t\tLOG_ERROR(\"Failed to allocate memory for bitstream data.\");"},{"line_number":459,"context_line":"\t\tfclose(bitstream_file);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"3d38a762_0d0952fe","line":456,"in_reply_to":"bc334289_5eeb538f","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":471,"context_line":"\t/* Send the bitstream data to the microcontroller */"},{"line_number":472,"context_line":"\tint actual_length \u003d 0;"},{"line_number":473,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, 0x02, bitstream_data, bitstream_size, 1000, \u0026actual_length);"},{"line_number":474,"context_line":"\tif (ret !\u003d LIBUSB_SUCCESS) {"},{"line_number":475,"context_line":"\t\tLOG_ERROR(\"Failed to send bitstream data: %s\", libusb_strerror(ret));"},{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"541f12c4_185894ae","line":474,"updated":"2023-07-02 22:43:10.000000000","message":"if (ret !\u003d ERROR_OK) {","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":471,"context_line":"\t/* Send the bitstream data to the microcontroller */"},{"line_number":472,"context_line":"\tint actual_length \u003d 0;"},{"line_number":473,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, 0x02, bitstream_data, bitstream_size, 1000, \u0026actual_length);"},{"line_number":474,"context_line":"\tif (ret !\u003d LIBUSB_SUCCESS) {"},{"line_number":475,"context_line":"\t\tLOG_ERROR(\"Failed to send bitstream data: %s\", libusb_strerror(ret));"},{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"aa1d3936_526d03b1","line":474,"in_reply_to":"541f12c4_185894ae","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":471,"context_line":"\t/* Send the bitstream data to the microcontroller */"},{"line_number":472,"context_line":"\tint actual_length \u003d 0;"},{"line_number":473,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, 0x02, bitstream_data, bitstream_size, 1000, \u0026actual_length);"},{"line_number":474,"context_line":"\tif (ret !\u003d LIBUSB_SUCCESS) {"},{"line_number":475,"context_line":"\t\tLOG_ERROR(\"Failed to send bitstream data: %s\", libusb_strerror(ret));"},{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"85225039_483e4c0b","line":474,"in_reply_to":"541f12c4_185894ae","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"},{"line_number":478,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":479,"context_line":"\t\tactual_length \u003d 0;"},{"line_number":480,"context_line":"\t} else {"},{"line_number":481,"context_line":"\t\tLOG_INFO(\"Bitstream sent successfully.\");"},{"line_number":482,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"0b196d5f_41352664","line":479,"updated":"2023-07-02 22:43:10.000000000","message":"dead instruction, after a return","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"},{"line_number":478,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":479,"context_line":"\t\tactual_length \u003d 0;"},{"line_number":480,"context_line":"\t} else {"},{"line_number":481,"context_line":"\t\tLOG_INFO(\"Bitstream sent successfully.\");"},{"line_number":482,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"1322c0e6_684f6274","line":479,"in_reply_to":"0b196d5f_41352664","updated":"2023-07-11 08:00:12.000000000","message":"actually, i made this dead line after \"return\" for the checkpatch tool as it does not accept an \"else\" after a return line.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"},{"line_number":478,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":479,"context_line":"\t\tactual_length \u003d 0;"},{"line_number":480,"context_line":"\t} else {"},{"line_number":481,"context_line":"\t\tLOG_INFO(\"Bitstream sent successfully.\");"},{"line_number":482,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"19535786_8b1d003e","line":479,"in_reply_to":"0b196d5f_41352664","updated":"2023-07-10 22:44:00.000000000","message":"dead code still here. The line\nactual_length \u003d 0;\nwill never be executed because it\u0027s after a\nreturn ERROR_FAIL;","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":true,"context_lines":[{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"},{"line_number":478,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":479,"context_line":"\t\tactual_length \u003d 0;"},{"line_number":480,"context_line":"\t} else {"},{"line_number":481,"context_line":"\t\tLOG_INFO(\"Bitstream sent successfully.\");"},{"line_number":482,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"aa9e48ae_3c3920e6","line":479,"in_reply_to":"1322c0e6_684f6274","updated":"2023-07-11 21:23:10.000000000","message":"checkpatch says that there is no need for the else; the else branch can be extracted from the if/then/else, e.g.:\n\nif (ret !\u003d ERROR_OK) {\n...\nreturn ERROR_FAIL;\n}\nLOG_INFO(\"Bitstream sent successfully.\");","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"1577db82c55f88a58320526a873d5efb702d0bd4","unresolved":false,"context_lines":[{"line_number":476,"context_line":"\t\tfree(bitstream_data);"},{"line_number":477,"context_line":"\t\tfclose(bitstream_file);"},{"line_number":478,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":479,"context_line":"\t\tactual_length \u003d 0;"},{"line_number":480,"context_line":"\t} else {"},{"line_number":481,"context_line":"\t\tLOG_INFO(\"Bitstream sent successfully.\");"},{"line_number":482,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b8fc785f_e6d95fbc","line":479,"in_reply_to":"aa9e48ae_3c3920e6","updated":"2023-07-12 08:53:23.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"\t/* CFGopen */"},{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"7827b62a_ff73d433","line":490,"updated":"2023-07-02 22:43:10.000000000","message":"0x00, 0xB1, 0, 0, NULL, 0, LIBUSB_TIMEOUT_MS);","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"\t/* CFGopen */"},{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"3935cb04_00e69cc5","line":490,"in_reply_to":"7827b62a_ff73d433","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"\t/* CFGopen */"},{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"32637cad_b2efc228","line":490,"in_reply_to":"7827b62a_ff73d433","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":488,"context_line":"\t/* CFGopen */"},{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":494,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"5ab16863_742a1bee","line":491,"updated":"2023-07-02 22:43:10.000000000","message":"as for comment at line 437, please switch back to libusb_control_transfer()","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":488,"context_line":"\t/* CFGopen */"},{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":494,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"2202b600_024d84a0","line":491,"in_reply_to":"5ab16863_742a1bee","updated":"2023-07-10 22:44:00.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":488,"context_line":"\t/* CFGopen */"},{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":494,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"54696366_09abc1d4","line":491,"in_reply_to":"5ab16863_742a1bee","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":494,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":495,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"55705166_1370e3dd","line":492,"updated":"2023-07-02 22:43:10.000000000","message":"the comment say CFGopen, the error message cfgclose","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":494,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":495,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"d0d36d7c_f513b6a3","line":492,"in_reply_to":"55705166_1370e3dd","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":489,"context_line":"\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":490,"context_line":"\t\t0x00, 0xB1, 0, 0, 0, 0, LIBUSB_TIMEOUT_MS);"},{"line_number":491,"context_line":"\tif (ret !\u003d ERROR_OK) {"},{"line_number":492,"context_line":"\t\tLOG_INFO(\"error cfgclose\");"},{"line_number":493,"context_line":"\t\t/* Abort if libusb sent less data than requested */"},{"line_number":494,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":495,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"29331d77_93efe9a1","line":492,"in_reply_to":"55705166_1370e3dd","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":511,"context_line":"static int angie_write_firmware_section(struct angie *device,"},{"line_number":512,"context_line":"\tstruct image *firmware_image, int section_index)"},{"line_number":513,"context_line":"{"},{"line_number":514,"context_line":"\tuint16_t addr, size, bytes_remaining, chunk_size;"},{"line_number":515,"context_line":"\tuint8_t data[SECTION_BUFFERSIZE];"},{"line_number":516,"context_line":"\tuint8_t *data_ptr \u003d data;"},{"line_number":517,"context_line":"\tsize_t size_read;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"027b9d62_73b5466b","line":514,"updated":"2023-07-02 22:43:10.000000000","message":"why uint16_t? The types in stdint.h are only useful to match the byte-size of target or protocol. Here these are only used in the host\u0027s code.\nCan int or unsigned int be used?","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":511,"context_line":"static int angie_write_firmware_section(struct angie *device,"},{"line_number":512,"context_line":"\tstruct image *firmware_image, int section_index)"},{"line_number":513,"context_line":"{"},{"line_number":514,"context_line":"\tuint16_t addr, size, bytes_remaining, chunk_size;"},{"line_number":515,"context_line":"\tuint8_t data[SECTION_BUFFERSIZE];"},{"line_number":516,"context_line":"\tuint8_t *data_ptr \u003d data;"},{"line_number":517,"context_line":"\tsize_t size_read;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"927d179b_b601bcd6","line":514,"in_reply_to":"027b9d62_73b5466b","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":511,"context_line":"static int angie_write_firmware_section(struct angie *device,"},{"line_number":512,"context_line":"\tstruct image *firmware_image, int section_index)"},{"line_number":513,"context_line":"{"},{"line_number":514,"context_line":"\tuint16_t addr, size, bytes_remaining, chunk_size;"},{"line_number":515,"context_line":"\tuint8_t data[SECTION_BUFFERSIZE];"},{"line_number":516,"context_line":"\tuint8_t *data_ptr \u003d data;"},{"line_number":517,"context_line":"\tsize_t size_read;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b8a8cb60_c0dfa4ef","line":514,"in_reply_to":"027b9d62_73b5466b","updated":"2023-07-11 08:00:12.000000000","message":"yes we can use int with addr, bytes_remaining and chunk_size, but with \"size\" we need to specify uint16_t as it will need to match later.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":511,"context_line":"static int angie_write_firmware_section(struct angie *device,"},{"line_number":512,"context_line":"\tstruct image *firmware_image, int section_index)"},{"line_number":513,"context_line":"{"},{"line_number":514,"context_line":"\tuint16_t addr, size, bytes_remaining, chunk_size;"},{"line_number":515,"context_line":"\tuint8_t data[SECTION_BUFFERSIZE];"},{"line_number":516,"context_line":"\tuint8_t *data_ptr \u003d data;"},{"line_number":517,"context_line":"\tsize_t size_read;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"13c41577_a48f2044","line":514,"in_reply_to":"b8a8cb60_c0dfa4ef","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"\t\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":546,"context_line":"\t\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":547,"context_line":"\t\t\t\tREQUEST_FIRMWARE_LOAD, addr, FIRMWARE_ADDR, (char *)data_ptr,"},{"line_number":548,"context_line":"\t\t\t\tchunk_size, LIBUSB_TIMEOUT_MS);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"\t\tif (ret !\u003d (int)chunk_size) {"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"089ef00b_cf05b309","line":547,"updated":"2023-07-02 22:43:10.000000000","message":"I don\u0027t know if you really need for cast, but jtag_libusb_control_transfer() here uses (unsigned char *)","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"\t\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":546,"context_line":"\t\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":547,"context_line":"\t\t\t\tREQUEST_FIRMWARE_LOAD, addr, FIRMWARE_ADDR, (char *)data_ptr,"},{"line_number":548,"context_line":"\t\t\t\tchunk_size, LIBUSB_TIMEOUT_MS);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"\t\tif (ret !\u003d (int)chunk_size) {"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"4e3f6fcb_443e0304","line":547,"in_reply_to":"089ef00b_cf05b309","updated":"2023-07-10 22:44:00.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"\t\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":546,"context_line":"\t\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":547,"context_line":"\t\t\t\tREQUEST_FIRMWARE_LOAD, addr, FIRMWARE_ADDR, (char *)data_ptr,"},{"line_number":548,"context_line":"\t\t\t\tchunk_size, LIBUSB_TIMEOUT_MS);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"\t\tif (ret !\u003d (int)chunk_size) {"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"f7082a45_990aa2f0","line":547,"in_reply_to":"089ef00b_cf05b309","updated":"2023-07-11 08:00:12.000000000","message":"actually jtag_libusb_control_transfer uses (char *), it\u0027s the libusbb_control_transfer that uses (unsigned char *), i had to cast it because i get an error.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"\t\tret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":546,"context_line":"\t\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":547,"context_line":"\t\t\t\tREQUEST_FIRMWARE_LOAD, addr, FIRMWARE_ADDR, (char *)data_ptr,"},{"line_number":548,"context_line":"\t\t\t\tchunk_size, LIBUSB_TIMEOUT_MS);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"\t\tif (ret !\u003d (int)chunk_size) {"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"100a5ef6_04edd840","line":547,"in_reply_to":"f7082a45_990aa2f0","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":766,"context_line":" * @return on success: ERROR_OK"},{"line_number":767,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":768,"context_line":" */"},{"line_number":769,"context_line":"static int angie_execute_queued_commands(struct angie *device, int timeout)"},{"line_number":770,"context_line":"{"},{"line_number":771,"context_line":"\tstruct angie_cmd *current;"},{"line_number":772,"context_line":"\tint ret, i, index_out, index_in, count_out, count_in, transferred;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"e99841e7_e98fa6a6","line":769,"updated":"2023-07-02 22:43:10.000000000","message":"timeout is passed as is to libusb. It is in ms. Please rename the parameter as timeout_ms","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":766,"context_line":" * @return on success: ERROR_OK"},{"line_number":767,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":768,"context_line":" */"},{"line_number":769,"context_line":"static int angie_execute_queued_commands(struct angie *device, int timeout)"},{"line_number":770,"context_line":"{"},{"line_number":771,"context_line":"\tstruct angie_cmd *current;"},{"line_number":772,"context_line":"\tint ret, i, index_out, index_in, count_out, count_in, transferred;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"3b3806c9_a6977d1b","line":769,"in_reply_to":"e99841e7_e98fa6a6","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":766,"context_line":" * @return on success: ERROR_OK"},{"line_number":767,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":768,"context_line":" */"},{"line_number":769,"context_line":"static int angie_execute_queued_commands(struct angie *device, int timeout)"},{"line_number":770,"context_line":"{"},{"line_number":771,"context_line":"\tstruct angie_cmd *current;"},{"line_number":772,"context_line":"\tint ret, i, index_out, index_in, count_out, count_in, transferred;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"07af225b_e38fcea9","line":769,"in_reply_to":"e99841e7_e98fa6a6","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":795,"context_line":"\t/* Send packet to ANGIE */"},{"line_number":796,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_out,"},{"line_number":797,"context_line":"\t\t\t(char *)buffer, count_out, timeout, \u0026transferred);"},{"line_number":798,"context_line":"\tif (ret !\u003d 0)"},{"line_number":799,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":800,"context_line":"\tif (transferred !\u003d count_out)"},{"line_number":801,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"55d48c2c_796d2816","line":799,"range":{"start_line":798,"start_character":1,"end_line":799,"end_character":20},"updated":"2023-07-02 22:43:10.000000000","message":"here ret is already an OpenOCD error code, so:\nif (ret !\u003d ERROR_OK)\nreturn ret;","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":795,"context_line":"\t/* Send packet to ANGIE */"},{"line_number":796,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_out,"},{"line_number":797,"context_line":"\t\t\t(char *)buffer, count_out, timeout, \u0026transferred);"},{"line_number":798,"context_line":"\tif (ret !\u003d 0)"},{"line_number":799,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":800,"context_line":"\tif (transferred !\u003d count_out)"},{"line_number":801,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"430599fe_891026fa","line":799,"range":{"start_line":798,"start_character":1,"end_line":799,"end_character":20},"in_reply_to":"55d48c2c_796d2816","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":795,"context_line":"\t/* Send packet to ANGIE */"},{"line_number":796,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_out,"},{"line_number":797,"context_line":"\t\t\t(char *)buffer, count_out, timeout, \u0026transferred);"},{"line_number":798,"context_line":"\tif (ret !\u003d 0)"},{"line_number":799,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":800,"context_line":"\tif (transferred !\u003d count_out)"},{"line_number":801,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"9c42d200_81d2510c","line":799,"range":{"start_line":798,"start_character":1,"end_line":799,"end_character":20},"in_reply_to":"55d48c2c_796d2816","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":804,"context_line":"\tif (count_in \u003e 0) {"},{"line_number":805,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_in,"},{"line_number":806,"context_line":"\t\t\t\t(char *)buffer, count_in, timeout, \u0026transferred);"},{"line_number":807,"context_line":"\t\tif (ret !\u003d 0)"},{"line_number":808,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":809,"context_line":"\t\tif (transferred !\u003d count_in)"},{"line_number":810,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"1eceb15e_269ccb8c","line":808,"range":{"start_line":807,"start_character":2,"end_line":808,"end_character":21},"updated":"2023-07-02 22:43:10.000000000","message":"ditto","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":804,"context_line":"\tif (count_in \u003e 0) {"},{"line_number":805,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_in,"},{"line_number":806,"context_line":"\t\t\t\t(char *)buffer, count_in, timeout, \u0026transferred);"},{"line_number":807,"context_line":"\t\tif (ret !\u003d 0)"},{"line_number":808,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":809,"context_line":"\t\tif (transferred !\u003d count_in)"},{"line_number":810,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"8bc76bec_d683f429","line":808,"range":{"start_line":807,"start_character":2,"end_line":808,"end_character":21},"in_reply_to":"1eceb15e_269ccb8c","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":804,"context_line":"\tif (count_in \u003e 0) {"},{"line_number":805,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_in,"},{"line_number":806,"context_line":"\t\t\t\t(char *)buffer, count_in, timeout, \u0026transferred);"},{"line_number":807,"context_line":"\t\tif (ret !\u003d 0)"},{"line_number":808,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":809,"context_line":"\t\tif (transferred !\u003d count_in)"},{"line_number":810,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"1f6883e6_108623e6","line":808,"range":{"start_line":807,"start_character":2,"end_line":808,"end_character":21},"in_reply_to":"1eceb15e_269ccb8c","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1041,"context_line":"\tint ret;"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tif (!cmd)"},{"line_number":1044,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"\tif (device-\u003edelay_clock_tms \u003c 0)"},{"line_number":1047,"context_line":"\t\tcmd-\u003eid \u003d CMD_CLOCK_TMS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"d9afce2e_1dc274b3","line":1044,"updated":"2023-07-02 22:43:10.000000000","message":"please add, on error\nLOG_ERROR(\"Out of memory\");\nSame below. No need to put a different message for each function, as the LOG_XXX will already report it, plus there out of memory \"should\" never happen","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"\tint ret;"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tif (!cmd)"},{"line_number":1044,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"\tif (device-\u003edelay_clock_tms \u003c 0)"},{"line_number":1047,"context_line":"\t\tcmd-\u003eid \u003d CMD_CLOCK_TMS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b72f6b3e_17fa604d","line":1044,"in_reply_to":"d9afce2e_1dc274b3","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"\tint ret;"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tif (!cmd)"},{"line_number":1044,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"\tif (device-\u003edelay_clock_tms \u003c 0)"},{"line_number":1047,"context_line":"\t\tcmd-\u003eid \u003d CMD_CLOCK_TMS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"487a05d7_0834d2bb","line":1044,"in_reply_to":"d9afce2e_1dc274b3","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1077,"context_line":"\tint ret;"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"\tif (!cmd)"},{"line_number":1080,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"\tif (device-\u003edelay_clock_tck \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"c876dc06_34131985","line":1079,"updated":"2023-07-02 22:43:10.000000000","message":"ditto","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1077,"context_line":"\tint ret;"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"\tif (!cmd)"},{"line_number":1080,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"\tif (device-\u003edelay_clock_tck \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"6b40ca6e_ec81707b","line":1079,"in_reply_to":"c876dc06_34131985","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1077,"context_line":"\tint ret;"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"\tif (!cmd)"},{"line_number":1080,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"\tif (device-\u003edelay_clock_tck \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"0b55cd9f_059d02cc","line":1079,"in_reply_to":"c876dc06_34131985","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1109,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1110,"context_line":"\tint ret;"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"\tif (!cmd)"},{"line_number":1113,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"\tcmd-\u003eid \u003d CMD_GET_SIGNALS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"fee784b3_4874dfa4","line":1112,"updated":"2023-07-02 22:43:10.000000000","message":"ditto","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1110,"context_line":"\tint ret;"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"\tif (!cmd)"},{"line_number":1113,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"\tcmd-\u003eid \u003d CMD_GET_SIGNALS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"15658649_fa9f986c","line":1112,"in_reply_to":"fee784b3_4874dfa4","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1110,"context_line":"\tint ret;"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"\tif (!cmd)"},{"line_number":1113,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"\tcmd-\u003eid \u003d CMD_GET_SIGNALS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"5c0aa768_53848e7f","line":1112,"in_reply_to":"fee784b3_4874dfa4","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1149,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1150,"context_line":"\tint ret;"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"\tif (!cmd)"},{"line_number":1153,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"\tcmd-\u003eid \u003d CMD_SET_SIGNALS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"45adcfcb_d5ec5f80","line":1152,"updated":"2023-07-02 22:43:10.000000000","message":"ditto","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1150,"context_line":"\tint ret;"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"\tif (!cmd)"},{"line_number":1153,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"\tcmd-\u003eid \u003d CMD_SET_SIGNALS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"86067e0b_4ade9770","line":1152,"in_reply_to":"45adcfcb_d5ec5f80","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1150,"context_line":"\tint ret;"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"\tif (!cmd)"},{"line_number":1153,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"\tcmd-\u003eid \u003d CMD_SET_SIGNALS;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"f4244c42_ae57e572","line":1152,"in_reply_to":"45adcfcb_d5ec5f80","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1218,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1219,"context_line":"\tint ret;"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"\tif (!cmd)"},{"line_number":1222,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"\tcmd-\u003eid \u003d CMD_CONFIGURE_TCK_FREQ;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"6ff35c62_eeb6b737","line":1221,"updated":"2023-07-02 22:43:10.000000000","message":"ditto","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1219,"context_line":"\tint ret;"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"\tif (!cmd)"},{"line_number":1222,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"\tcmd-\u003eid \u003d CMD_CONFIGURE_TCK_FREQ;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b5d33300_7a7e9b3c","line":1221,"in_reply_to":"6ff35c62_eeb6b737","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1219,"context_line":"\tint ret;"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"\tif (!cmd)"},{"line_number":1222,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"\tcmd-\u003eid \u003d CMD_CONFIGURE_TCK_FREQ;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"f89b43ad_79f8570d","line":1221,"in_reply_to":"6ff35c62_eeb6b737","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1272,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1273,"context_line":"\tint ret;"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"\tif (!cmd)"},{"line_number":1276,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"\tcmd-\u003eid \u003d CMD_TEST;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"1906853e_f8ad31d6","line":1275,"updated":"2023-07-02 22:43:10.000000000","message":"ditto","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1273,"context_line":"\tint ret;"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"\tif (!cmd)"},{"line_number":1276,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"\tcmd-\u003eid \u003d CMD_TEST;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"00c1be8b_7690f41f","line":1275,"in_reply_to":"1906853e_f8ad31d6","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"\tstruct angie_cmd *cmd \u003d calloc(1, sizeof(struct angie_cmd));"},{"line_number":1273,"context_line":"\tint ret;"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"\tif (!cmd)"},{"line_number":1276,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"\tcmd-\u003eid \u003d CMD_TEST;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"7ab54140_c19d6c45","line":1275,"in_reply_to":"1906853e_f8ad31d6","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1341,"context_line":"\t\t    x \u003d (t - (float)(8.8308 / 1000000)) / (float)(4 / 1000000);"},{"line_number":1342,"context_line":"\t\t    break;"},{"line_number":1343,"context_line":"\t    case DELAY_SCAN_OUT:"},{"line_number":1344,"context_line":"\t\t    x \u003d (t - (float)(1.0527 / 100000)) / (float)(4 / 1000000);"},{"line_number":1345,"context_line":"\t\t    break;"},{"line_number":1346,"context_line":"\t    case DELAY_SCAN_IO:"},{"line_number":1347,"context_line":"\t\t    x \u003d (t - (float)(1.3132 / 100000)) / (float)(4 / 1000000);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"4c9b7b2e_6db1af2f","line":1344,"updated":"2023-07-02 22:43:10.000000000","message":"is 100000 (100k) here correct? Or is it a typo and it should be 1M ?\nI think it\u0027s 100k, since it\u0027s same in the back conversion in angie_calculate_frequency()\n\nTo avoid any kind of concern for a reader of this code, it could be better converting all in us in this function and in the next one:\nt_us \u003d 1000000.0 / f;\nx \u003d (t_us - 1.0527) / 4;\nor, if 100k was correct:\nx \u003d (t_us - 10.527) / 4;","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"\t\t    x \u003d (t - (float)(8.8308 / 1000000)) / (float)(4 / 1000000);"},{"line_number":1342,"context_line":"\t\t    break;"},{"line_number":1343,"context_line":"\t    case DELAY_SCAN_OUT:"},{"line_number":1344,"context_line":"\t\t    x \u003d (t - (float)(1.0527 / 100000)) / (float)(4 / 1000000);"},{"line_number":1345,"context_line":"\t\t    break;"},{"line_number":1346,"context_line":"\t    case DELAY_SCAN_IO:"},{"line_number":1347,"context_line":"\t\t    x \u003d (t - (float)(1.3132 / 100000)) / (float)(4 / 1000000);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"08697195_a7803036","line":1344,"in_reply_to":"21f03923_7ae78d43","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"\t\t    x \u003d (t - (float)(8.8308 / 1000000)) / (float)(4 / 1000000);"},{"line_number":1342,"context_line":"\t\t    break;"},{"line_number":1343,"context_line":"\t    case DELAY_SCAN_OUT:"},{"line_number":1344,"context_line":"\t\t    x \u003d (t - (float)(1.0527 / 100000)) / (float)(4 / 1000000);"},{"line_number":1345,"context_line":"\t\t    break;"},{"line_number":1346,"context_line":"\t    case DELAY_SCAN_IO:"},{"line_number":1347,"context_line":"\t\t    x \u003d (t - (float)(1.3132 / 100000)) / (float)(4 / 1000000);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"9455a6bd_02734ed5","line":1344,"in_reply_to":"4c9b7b2e_6db1af2f","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":1341,"context_line":"\t\t    x \u003d (t - (float)(8.8308 / 1000000)) / (float)(4 / 1000000);"},{"line_number":1342,"context_line":"\t\t    break;"},{"line_number":1343,"context_line":"\t    case DELAY_SCAN_OUT:"},{"line_number":1344,"context_line":"\t\t    x \u003d (t - (float)(1.0527 / 100000)) / (float)(4 / 1000000);"},{"line_number":1345,"context_line":"\t\t    break;"},{"line_number":1346,"context_line":"\t    case DELAY_SCAN_IO:"},{"line_number":1347,"context_line":"\t\t    x \u003d (t - (float)(1.3132 / 100000)) / (float)(4 / 1000000);"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"21f03923_7ae78d43","line":1344,"in_reply_to":"4c9b7b2e_6db1af2f","updated":"2023-07-11 08:00:12.000000000","message":"i agree on this, i will apply it.\nthe 4th delay is 100k not 1M like the others on top.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1395,"context_line":"\t\t    if (delay \u003c 0)"},{"line_number":1396,"context_line":"\t\t\t    t \u003d (float)(2.666 / 1000000);"},{"line_number":1397,"context_line":"\t\t    else"},{"line_number":1398,"context_line":"\t\t\t    t \u003d (float)(4 / 1000000) * (float)(delay) + (float)(6 / 1000000);"},{"line_number":1399,"context_line":"\t\t    break;"},{"line_number":1400,"context_line":"\t    case DELAY_CLOCK_TMS:"},{"line_number":1401,"context_line":"\t\t    if (delay \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"383022a9_73335fd2","line":1398,"updated":"2023-07-02 22:43:10.000000000","message":"also here\nt_us \u003d 2.666;\nelse\nt_us \u003d 4 * delay + 6.0;\nand below\nreturn roundf(1000000 / t_us);","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"\t\t    if (delay \u003c 0)"},{"line_number":1396,"context_line":"\t\t\t    t \u003d (float)(2.666 / 1000000);"},{"line_number":1397,"context_line":"\t\t    else"},{"line_number":1398,"context_line":"\t\t\t    t \u003d (float)(4 / 1000000) * (float)(delay) + (float)(6 / 1000000);"},{"line_number":1399,"context_line":"\t\t    break;"},{"line_number":1400,"context_line":"\t    case DELAY_CLOCK_TMS:"},{"line_number":1401,"context_line":"\t\t    if (delay \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"92ae61b1_55c36733","line":1398,"in_reply_to":"383022a9_73335fd2","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"\t\t    if (delay \u003c 0)"},{"line_number":1396,"context_line":"\t\t\t    t \u003d (float)(2.666 / 1000000);"},{"line_number":1397,"context_line":"\t\t    else"},{"line_number":1398,"context_line":"\t\t\t    t \u003d (float)(4 / 1000000) * (float)(delay) + (float)(6 / 1000000);"},{"line_number":1399,"context_line":"\t\t    break;"},{"line_number":1400,"context_line":"\t    case DELAY_CLOCK_TMS:"},{"line_number":1401,"context_line":"\t\t    if (delay \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"fdcb4de4_62296129","line":1398,"in_reply_to":"383022a9_73335fd2","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1443,"context_line":"\t\ttap_set_end_state(endstate);"},{"line_number":1444,"context_line":"\t} else {"},{"line_number":1445,"context_line":"\t\tLOG_ERROR(\"BUG: %s is not a valid end state\", tap_state_name(endstate));"},{"line_number":1446,"context_line":"\t\texit(EXIT_FAILURE);"},{"line_number":1447,"context_line":"\t}"},{"line_number":1448,"context_line":"}"},{"line_number":1449,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"2c196c40_4aa34695","line":1446,"updated":"2023-07-02 22:43:10.000000000","message":"NO! we should not exit() inside OpenOCD.\nIt is allowed to use assert() for cases that should never happen.\nI invite you to check if this function should return an error value or has to assert()","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"\t\ttap_set_end_state(endstate);"},{"line_number":1444,"context_line":"\t} else {"},{"line_number":1445,"context_line":"\t\tLOG_ERROR(\"BUG: %s is not a valid end state\", tap_state_name(endstate));"},{"line_number":1446,"context_line":"\t\texit(EXIT_FAILURE);"},{"line_number":1447,"context_line":"\t}"},{"line_number":1448,"context_line":"}"},{"line_number":1449,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"5462bce1_4252910a","line":1446,"in_reply_to":"2c196c40_4aa34695","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":1443,"context_line":"\t\ttap_set_end_state(endstate);"},{"line_number":1444,"context_line":"\t} else {"},{"line_number":1445,"context_line":"\t\tLOG_ERROR(\"BUG: %s is not a valid end state\", tap_state_name(endstate));"},{"line_number":1446,"context_line":"\t\texit(EXIT_FAILURE);"},{"line_number":1447,"context_line":"\t}"},{"line_number":1448,"context_line":"}"},{"line_number":1449,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b4c76a4c_6ae69c31","line":1446,"in_reply_to":"2c196c40_4aa34695","updated":"2023-07-11 08:00:12.000000000","message":"No this function should not return. i will remove the exit function","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"\t\ttap_set_end_state(endstate);"},{"line_number":1444,"context_line":"\t} else {"},{"line_number":1445,"context_line":"\t\tLOG_ERROR(\"BUG: %s is not a valid end state\", tap_state_name(endstate));"},{"line_number":1446,"context_line":"\t\texit(EXIT_FAILURE);"},{"line_number":1447,"context_line":"\t}"},{"line_number":1448,"context_line":"}"},{"line_number":1449,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"8f67d2e2_a3da6aa8","line":1446,"in_reply_to":"b4c76a4c_6ae69c31","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":1717,"context_line":" * @return on success: ERROR_OK"},{"line_number":1718,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1719,"context_line":" */"},{"line_number":1720,"context_line":"static int angie_queue_reset(struct angie *device, struct jtag_command *cmd)"},{"line_number":1721,"context_line":"{"},{"line_number":1722,"context_line":"\tuint8_t low \u003d 0, high \u003d 0;"},{"line_number":1723,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"f2e57fb9_996ec6c3","line":1720,"updated":"2023-07-02 22:43:10.000000000","message":"I have still not completed the conversion of all the driver\u0027s code.\nWe should not handle anymore the case JTAG_RESET and move this functionality in struct adapter_driver::reset.\nI think you will have to call angie_execute_queued_commands() at the end of this function for guarantee that the reset is propagated to the adapter.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":1717,"context_line":" * @return on success: ERROR_OK"},{"line_number":1718,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1719,"context_line":" */"},{"line_number":1720,"context_line":"static int angie_queue_reset(struct angie *device, struct jtag_command *cmd)"},{"line_number":1721,"context_line":"{"},{"line_number":1722,"context_line":"\tuint8_t low \u003d 0, high \u003d 0;"},{"line_number":1723,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"4f6ffa64_1087d367","line":1720,"in_reply_to":"bb4e181a_70802d46","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":1717,"context_line":" * @return on success: ERROR_OK"},{"line_number":1718,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1719,"context_line":" */"},{"line_number":1720,"context_line":"static int angie_queue_reset(struct angie *device, struct jtag_command *cmd)"},{"line_number":1721,"context_line":"{"},{"line_number":1722,"context_line":"\tuint8_t low \u003d 0, high \u003d 0;"},{"line_number":1723,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"50ad680a_7026db3d","line":1720,"in_reply_to":"f2e57fb9_996ec6c3","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":1717,"context_line":" * @return on success: ERROR_OK"},{"line_number":1718,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1719,"context_line":" */"},{"line_number":1720,"context_line":"static int angie_queue_reset(struct angie *device, struct jtag_command *cmd)"},{"line_number":1721,"context_line":"{"},{"line_number":1722,"context_line":"\tuint8_t low \u003d 0, high \u003d 0;"},{"line_number":1723,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"bb4e181a_70802d46","line":1720,"in_reply_to":"f2e57fb9_996ec6c3","updated":"2023-07-11 08:00:12.000000000","message":"i have tested the srst and trst signals and they propagate to the adapter, but okay i will add the angie_execute_queued_commands() to garentee it","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"\tangie_handle \u003d calloc(1, sizeof(struct angie));"},{"line_number":2154,"context_line":"\tif (!angie_handle)"},{"line_number":2155,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"\tlibusb_init(\u0026angie_handle-\u003elibusb_ctx);"},{"line_number":2158,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"70ae1c96_2d105a88","line":2155,"updated":"2023-07-02 22:43:10.000000000","message":"please add a line\nLOG_ERROR(\"Out of memory\");","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"\tangie_handle \u003d calloc(1, sizeof(struct angie));"},{"line_number":2154,"context_line":"\tif (!angie_handle)"},{"line_number":2155,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"\tlibusb_init(\u0026angie_handle-\u003elibusb_ctx);"},{"line_number":2158,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"3850c3d1_2359ac54","line":2155,"in_reply_to":"70ae1c96_2d105a88","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"\tangie_handle \u003d calloc(1, sizeof(struct angie));"},{"line_number":2154,"context_line":"\tif (!angie_handle)"},{"line_number":2155,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"\tlibusb_init(\u0026angie_handle-\u003elibusb_ctx);"},{"line_number":2158,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":18,"id":"15efa39e_d881596c","line":2155,"in_reply_to":"70ae1c96_2d105a88","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":2173,"context_line":"\t\t/* We got a String Descriptor, check if it is the correct one */"},{"line_number":2174,"context_line":"\t\tif (strncmp(str_manufacturer, \"NanoXplore, SAS.\", 16) !\u003d 0) {"},{"line_number":2175,"context_line":"\t\t\tLOG_ERROR(\"A different Firmware is loaded, please unplug and reconnect ANGIE.\");"},{"line_number":2176,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2177,"context_line":"\t\t}"},{"line_number":2178,"context_line":"\t\tdownload_firmware \u003d false;"},{"line_number":2179,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"016f578a_38aa7661","line":2176,"updated":"2023-07-02 22:43:10.000000000","message":"please review \"all\" the exit from this function.\nHere there is no free of angie_handle, no close of the usb device, no libusb_exit()\n\nyou can call angie_quit() to make it easier, but then also add in angie_quit()\nangie_handle \u003d NULL;","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":2173,"context_line":"\t\t/* We got a String Descriptor, check if it is the correct one */"},{"line_number":2174,"context_line":"\t\tif (strncmp(str_manufacturer, \"NanoXplore, SAS.\", 16) !\u003d 0) {"},{"line_number":2175,"context_line":"\t\t\tLOG_ERROR(\"A different Firmware is loaded, please unplug and reconnect ANGIE.\");"},{"line_number":2176,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2177,"context_line":"\t\t}"},{"line_number":2178,"context_line":"\t\tdownload_firmware \u003d false;"},{"line_number":2179,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"57c50a52_e3eccea2","line":2176,"in_reply_to":"016f578a_38aa7661","updated":"2023-07-11 08:00:12.000000000","message":"this essue of having to unplug and reconnect angie has been solved in the next push.\nand yes, a correction must be made in angie_quit()","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"da653ab6396309ee9d4d24a2fa99ee75ba486c76","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"\t\t/* We got a String Descriptor, check if it is the correct one */"},{"line_number":2174,"context_line":"\t\tif (strncmp(str_manufacturer, \"NanoXplore, SAS.\", 16) !\u003d 0) {"},{"line_number":2175,"context_line":"\t\t\tLOG_ERROR(\"A different Firmware is loaded, please unplug and reconnect ANGIE.\");"},{"line_number":2176,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2177,"context_line":"\t\t}"},{"line_number":2178,"context_line":"\t\tdownload_firmware \u003d false;"},{"line_number":2179,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"4df9bb6e_bb51c97a","line":2176,"in_reply_to":"57c50a52_e3eccea2","updated":"2023-07-11 14:11:41.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":2179,"context_line":"\t}"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"\tif (download_firmware) {"},{"line_number":2182,"context_line":"\t\tLOG_INFO(\"Loading ANGIE firmware. This is reversible by power-cycling\""},{"line_number":2183,"context_line":"\t\t\t\" ANGIE device.\");"},{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":"\t\tret \u003d libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":2186,"context_line":"\t\tif (ret !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"215adce7_dbdc949c","line":2183,"range":{"start_line":2182,"start_character":2,"end_line":2183,"end_character":21},"updated":"2023-07-02 22:43:10.000000000","message":"don\u0027t split the string. OpenOCD accepts 120 char per line, enough for this line","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":2179,"context_line":"\t}"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"\tif (download_firmware) {"},{"line_number":2182,"context_line":"\t\tLOG_INFO(\"Loading ANGIE firmware. This is reversible by power-cycling\""},{"line_number":2183,"context_line":"\t\t\t\" ANGIE device.\");"},{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":"\t\tret \u003d libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":2186,"context_line":"\t\tif (ret !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"84c4145f_cafc914c","line":2183,"range":{"start_line":2182,"start_character":2,"end_line":2183,"end_character":21},"in_reply_to":"215adce7_dbdc949c","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":2179,"context_line":"\t}"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"\tif (download_firmware) {"},{"line_number":2182,"context_line":"\t\tLOG_INFO(\"Loading ANGIE firmware. This is reversible by power-cycling\""},{"line_number":2183,"context_line":"\t\t\t\" ANGIE device.\");"},{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":"\t\tret \u003d libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":2186,"context_line":"\t\tif (ret !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"672bedee_b45a005d","line":2183,"range":{"start_line":2182,"start_character":2,"end_line":2183,"end_character":21},"in_reply_to":"215adce7_dbdc949c","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":2273,"context_line":"{"},{"line_number":2274,"context_line":"\tint ret;"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"\tret \u003d angie_usb_close(\u0026angie_handle);"},{"line_number":2277,"context_line":"\tfree(angie_handle);"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"b1575fa6_b90be667","line":2276,"updated":"2023-07-02 22:43:10.000000000","message":"please put in a single line declaration and assignment:\nint ret \u003d angie_usb_close(\u0026angie_handle);\nalso in other parts of this patch","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":2273,"context_line":"{"},{"line_number":2274,"context_line":"\tint ret;"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"\tret \u003d angie_usb_close(\u0026angie_handle);"},{"line_number":2277,"context_line":"\tfree(angie_handle);"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"8f5a88e9_2b02acc8","line":2276,"in_reply_to":"b1575fa6_b90be667","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":2273,"context_line":"{"},{"line_number":2274,"context_line":"\tint ret;"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"\tret \u003d angie_usb_close(\u0026angie_handle);"},{"line_number":2277,"context_line":"\tfree(angie_handle);"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":18,"id":"11a6e609_19bafdbd","line":2276,"in_reply_to":"b1575fa6_b90be667","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"edaf5ecdd521cca9821ab4fb4e24181c7e14feb6","unresolved":true,"context_lines":[{"line_number":2303,"context_line":""},{"line_number":2304,"context_line":"static const struct command_registration angie_subcommand_handlers[] \u003d {"},{"line_number":2305,"context_line":"\t{"},{"line_number":2306,"context_line":"\t\t.name \u003d \"download_firmware\","},{"line_number":2307,"context_line":"\t\t.handler \u003d \u0026angie_download_firmware_handler,"},{"line_number":2308,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2309,"context_line":"\t\t.help \u003d \"download firmware image to ANGIE device\","}],"source_content_type":"text/x-csrc","patch_set":18,"id":"beac45ae_9d7a655b","line":2306,"updated":"2023-07-02 22:43:10.000000000","message":"Firmware download is already done automatically at OpenOCD start, when angie is the selected adapter.\nWhat is the use case that requires this command to reload the firmware?","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2303,"context_line":""},{"line_number":2304,"context_line":"static const struct command_registration angie_subcommand_handlers[] \u003d {"},{"line_number":2305,"context_line":"\t{"},{"line_number":2306,"context_line":"\t\t.name \u003d \"download_firmware\","},{"line_number":2307,"context_line":"\t\t.handler \u003d \u0026angie_download_firmware_handler,"},{"line_number":2308,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2309,"context_line":"\t\t.help \u003d \"download firmware image to ANGIE device\","}],"source_content_type":"text/x-csrc","patch_set":18,"id":"d137a992_4596c73a","line":2306,"in_reply_to":"281418b0_6ecb85f6","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":2303,"context_line":""},{"line_number":2304,"context_line":"static const struct command_registration angie_subcommand_handlers[] \u003d {"},{"line_number":2305,"context_line":"\t{"},{"line_number":2306,"context_line":"\t\t.name \u003d \"download_firmware\","},{"line_number":2307,"context_line":"\t\t.handler \u003d \u0026angie_download_firmware_handler,"},{"line_number":2308,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2309,"context_line":"\t\t.help \u003d \"download firmware image to ANGIE device\","}],"source_content_type":"text/x-csrc","patch_set":18,"id":"7c0faac3_749f8a45","line":2306,"in_reply_to":"beac45ae_9d7a655b","updated":"2023-07-08 14:23:51.000000000","message":"Ack","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":true,"context_lines":[{"line_number":2303,"context_line":""},{"line_number":2304,"context_line":"static const struct command_registration angie_subcommand_handlers[] \u003d {"},{"line_number":2305,"context_line":"\t{"},{"line_number":2306,"context_line":"\t\t.name \u003d \"download_firmware\","},{"line_number":2307,"context_line":"\t\t.handler \u003d \u0026angie_download_firmware_handler,"},{"line_number":2308,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2309,"context_line":"\t\t.help \u003d \"download firmware image to ANGIE device\","}],"source_content_type":"text/x-csrc","patch_set":18,"id":"281418b0_6ecb85f6","line":2306,"in_reply_to":"beac45ae_9d7a655b","updated":"2023-07-11 08:00:12.000000000","message":"yes this command has no use, it will be deleted.","commit_id":"004878e26c8a7fef4f63d58f1f5dac7ad83843e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":154,"context_line":"/**************************** Function Prototypes *****************************/"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"/* USB helper functions */"},{"line_number":157,"context_line":"static int angie_usb_open(struct angie **device);"},{"line_number":158,"context_line":"static int angie_usb_close(struct angie **device);"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"/* ANGIE MCU (Cypress EZ-USB) specific functions */"},{"line_number":161,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"5e0b4b80_723bad04","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":50},"updated":"2023-07-08 14:23:51.000000000","message":"these three functions: angie_usb_open(), angie_usb_close() and below angie_load_firmware_and_renumerate() receive a parameter\nstruct angie \\*\\*device\nthat can be replaced with\nstruct angie \\*device\nas none of them change the pointer\u0027s pointer.","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":154,"context_line":"/**************************** Function Prototypes *****************************/"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"/* USB helper functions */"},{"line_number":157,"context_line":"static int angie_usb_open(struct angie **device);"},{"line_number":158,"context_line":"static int angie_usb_close(struct angie **device);"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"/* ANGIE MCU (Cypress EZ-USB) specific functions */"},{"line_number":161,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"9cd2644b_057e64ce","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":50},"in_reply_to":"5e0b4b80_723bad04","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"/**************************** Function Prototypes *****************************/"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"/* USB helper functions */"},{"line_number":157,"context_line":"static int angie_usb_open(struct angie **device);"},{"line_number":158,"context_line":"static int angie_usb_close(struct angie **device);"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"/* ANGIE MCU (Cypress EZ-USB) specific functions */"},{"line_number":161,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"9a1a50fb_db060987","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":50},"in_reply_to":"5e0b4b80_723bad04","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":252,"context_line":"static int angie_usb_open(struct angie **device)"},{"line_number":253,"context_line":"{"},{"line_number":254,"context_line":"\tstruct libusb_device_handle *usb_device_handle;"},{"line_number":255,"context_line":"\tconst uint16_t vids[] \u003d {ANGIE_VID, 0};"},{"line_number":256,"context_line":"\tconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"\tif (jtag_libusb_open(vids, pids, \u0026usb_device_handle, NULL))"},{"line_number":259,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"15978ade_d23580a5","line":256,"range":{"start_line":255,"start_character":1,"end_line":256,"end_character":53},"updated":"2023-07-08 14:23:51.000000000","message":"vids[] and pids[] must have the same length and each element on one array has to be used with corresponding element in the other.\nconst uint16_t vids[] \u003d {ANGIE_VID, ANGIE_VID,   0};\nconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":252,"context_line":"static int angie_usb_open(struct angie **device)"},{"line_number":253,"context_line":"{"},{"line_number":254,"context_line":"\tstruct libusb_device_handle *usb_device_handle;"},{"line_number":255,"context_line":"\tconst uint16_t vids[] \u003d {ANGIE_VID, 0};"},{"line_number":256,"context_line":"\tconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"\tif (jtag_libusb_open(vids, pids, \u0026usb_device_handle, NULL))"},{"line_number":259,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"ffe31b26_68e309a0","line":256,"range":{"start_line":255,"start_character":1,"end_line":256,"end_character":53},"in_reply_to":"15978ade_d23580a5","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":252,"context_line":"static int angie_usb_open(struct angie **device)"},{"line_number":253,"context_line":"{"},{"line_number":254,"context_line":"\tstruct libusb_device_handle *usb_device_handle;"},{"line_number":255,"context_line":"\tconst uint16_t vids[] \u003d {ANGIE_VID, 0};"},{"line_number":256,"context_line":"\tconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"\tif (jtag_libusb_open(vids, pids, \u0026usb_device_handle, NULL))"},{"line_number":259,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"1fced6e4_162bc386","line":256,"range":{"start_line":255,"start_character":1,"end_line":256,"end_character":53},"in_reply_to":"15978ade_d23580a5","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":255,"context_line":"\tconst uint16_t vids[] \u003d {ANGIE_VID, 0};"},{"line_number":256,"context_line":"\tconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"\tif (jtag_libusb_open(vids, pids, \u0026usb_device_handle, NULL))"},{"line_number":259,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"\t(*device)-\u003eusb_device_handle \u003d usb_device_handle;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"270940d3_8464b72f","line":258,"updated":"2023-07-08 14:23:51.000000000","message":"please propagate the error:\nint ret \u003d jtag_lib...\nif (ret !\u003d ERROR_OK)\nreturn ret;","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":255,"context_line":"\tconst uint16_t vids[] \u003d {ANGIE_VID, 0};"},{"line_number":256,"context_line":"\tconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"\tif (jtag_libusb_open(vids, pids, \u0026usb_device_handle, NULL))"},{"line_number":259,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"\t(*device)-\u003eusb_device_handle \u003d usb_device_handle;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"dcc28680_22db840e","line":258,"in_reply_to":"270940d3_8464b72f","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"\tconst uint16_t vids[] \u003d {ANGIE_VID, 0};"},{"line_number":256,"context_line":"\tconst uint16_t pids[] \u003d {ANGIE_PID, ANGIE_PID_2, 0};"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"\tif (jtag_libusb_open(vids, pids, \u0026usb_device_handle, NULL))"},{"line_number":259,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"\t(*device)-\u003eusb_device_handle \u003d usb_device_handle;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"6417ac70_ac3a2446","line":258,"in_reply_to":"270940d3_8464b72f","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":776,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_out,"},{"line_number":777,"context_line":"\t\t\t(char *)buffer, count_out, timeout_ms, \u0026transferred);"},{"line_number":778,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":780,"context_line":"\tif (transferred !\u003d count_out)"},{"line_number":781,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":782,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":22,"id":"7debde5d_abaff435","line":779,"updated":"2023-07-08 14:23:51.000000000","message":"propagate the error:\nreturn ret;","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":776,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_out,"},{"line_number":777,"context_line":"\t\t\t(char *)buffer, count_out, timeout_ms, \u0026transferred);"},{"line_number":778,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":780,"context_line":"\tif (transferred !\u003d count_out)"},{"line_number":781,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":782,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":22,"id":"5263e256_c401e53a","line":779,"in_reply_to":"7debde5d_abaff435","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":776,"context_line":"\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_out,"},{"line_number":777,"context_line":"\t\t\t(char *)buffer, count_out, timeout_ms, \u0026transferred);"},{"line_number":778,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":779,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":780,"context_line":"\tif (transferred !\u003d count_out)"},{"line_number":781,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":782,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":22,"id":"ebd4add7_66a0c6d8","line":779,"in_reply_to":"7debde5d_abaff435","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":785,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_in,"},{"line_number":786,"context_line":"\t\t\t\t(char *)buffer, count_in, timeout_ms, \u0026transferred);"},{"line_number":787,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":788,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":789,"context_line":"\t\tif (transferred !\u003d count_in)"},{"line_number":790,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":791,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":22,"id":"96e03f32_ef7c832b","line":788,"updated":"2023-07-08 14:23:51.000000000","message":"propagate the error\nreturn ret;","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":785,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_in,"},{"line_number":786,"context_line":"\t\t\t\t(char *)buffer, count_in, timeout_ms, \u0026transferred);"},{"line_number":787,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":788,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":789,"context_line":"\t\tif (transferred !\u003d count_in)"},{"line_number":790,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":791,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":22,"id":"bdf2e17e_7897221a","line":788,"in_reply_to":"96e03f32_ef7c832b","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":785,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(device-\u003eusb_device_handle, device-\u003eep_in,"},{"line_number":786,"context_line":"\t\t\t\t(char *)buffer, count_in, timeout_ms, \u0026transferred);"},{"line_number":787,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":788,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":789,"context_line":"\t\tif (transferred !\u003d count_in)"},{"line_number":790,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":791,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":22,"id":"fc8dff2e_76052c92","line":788,"in_reply_to":"96e03f32_ef7c832b","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":1962,"context_line":"\t\t    case JTAG_RUNTEST:"},{"line_number":1963,"context_line":"\t\t\t    ret \u003d angie_queue_runtest(angie_handle, cmd);"},{"line_number":1964,"context_line":"\t\t\t    break;"},{"line_number":1965,"context_line":"\t\t    case JTAG_RESET:"},{"line_number":1966,"context_line":"\t\t\t    ret \u003d angie_queue_reset(angie_handle, cmd);"},{"line_number":1967,"context_line":"\t\t\t    break;"},{"line_number":1968,"context_line":"\t\t    case JTAG_PATHMOVE:"},{"line_number":1969,"context_line":"\t\t\t    ret \u003d angie_queue_pathmove(angie_handle, cmd);"},{"line_number":1970,"context_line":"\t\t\t    break;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"3cc11964_63477c21","line":1967,"range":{"start_line":1965,"start_character":6,"end_line":1967,"end_character":13},"updated":"2023-07-08 14:23:51.000000000","message":"in my comment above at function angie_queue_reset() I mean that the case JTAG_RESET should be removed from this function and from angie_post_process_queue(),\nand .. continue at the end of this file ..","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":1962,"context_line":"\t\t    case JTAG_RUNTEST:"},{"line_number":1963,"context_line":"\t\t\t    ret \u003d angie_queue_runtest(angie_handle, cmd);"},{"line_number":1964,"context_line":"\t\t\t    break;"},{"line_number":1965,"context_line":"\t\t    case JTAG_RESET:"},{"line_number":1966,"context_line":"\t\t\t    ret \u003d angie_queue_reset(angie_handle, cmd);"},{"line_number":1967,"context_line":"\t\t\t    break;"},{"line_number":1968,"context_line":"\t\t    case JTAG_PATHMOVE:"},{"line_number":1969,"context_line":"\t\t\t    ret \u003d angie_queue_pathmove(angie_handle, cmd);"},{"line_number":1970,"context_line":"\t\t\t    break;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"f0c47fa0_daaf72be","line":1967,"range":{"start_line":1965,"start_character":6,"end_line":1967,"end_character":13},"in_reply_to":"3cc11964_63477c21","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":1962,"context_line":"\t\t    case JTAG_RUNTEST:"},{"line_number":1963,"context_line":"\t\t\t    ret \u003d angie_queue_runtest(angie_handle, cmd);"},{"line_number":1964,"context_line":"\t\t\t    break;"},{"line_number":1965,"context_line":"\t\t    case JTAG_RESET:"},{"line_number":1966,"context_line":"\t\t\t    ret \u003d angie_queue_reset(angie_handle, cmd);"},{"line_number":1967,"context_line":"\t\t\t    break;"},{"line_number":1968,"context_line":"\t\t    case JTAG_PATHMOVE:"},{"line_number":1969,"context_line":"\t\t\t    ret \u003d angie_queue_pathmove(angie_handle, cmd);"},{"line_number":1970,"context_line":"\t\t\t    break;"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"f34dfde7_a0161227","line":1967,"range":{"start_line":1965,"start_character":6,"end_line":1967,"end_character":13},"in_reply_to":"3cc11964_63477c21","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":2175,"context_line":"\tif (download_firmware) {"},{"line_number":2176,"context_line":"\t\tLOG_INFO(\"Loading ANGIE firmware. This is reversible by power-cycling ANGIE device.\");"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"\t\tret \u003d libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":2179,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2180,"context_line":"\t\t\tLOG_ERROR(\"Could not claim interface\");"},{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"\t\tret \u003d angie_load_firmware_and_renumerate(\u0026angie_handle,"},{"line_number":2183,"context_line":"\t\t\t\tANGIE_FIRMWARE_FILE, ANGIE_RENUMERATION_DELAY_US);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"b8d1eeb4_c407ea1c","line":2180,"range":{"start_line":2178,"start_character":2,"end_line":2180,"end_character":42},"updated":"2023-07-08 14:23:51.000000000","message":"oops, missed this: libusb_claim_interface() does not return ERROR_XX values, but LIBUSB errors.\nPlease change these lines as:\nif (libusb_claim_interface(..))\nLOG_ERROR(...);\nI see other same issues in other code OpenOCD, I will send a patch for them","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":2175,"context_line":"\tif (download_firmware) {"},{"line_number":2176,"context_line":"\t\tLOG_INFO(\"Loading ANGIE firmware. This is reversible by power-cycling ANGIE device.\");"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"\t\tret \u003d libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":2179,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2180,"context_line":"\t\t\tLOG_ERROR(\"Could not claim interface\");"},{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"\t\tret \u003d angie_load_firmware_and_renumerate(\u0026angie_handle,"},{"line_number":2183,"context_line":"\t\t\t\tANGIE_FIRMWARE_FILE, ANGIE_RENUMERATION_DELAY_US);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"c790d7bf_dae4f18c","line":2180,"range":{"start_line":2178,"start_character":2,"end_line":2180,"end_character":42},"in_reply_to":"b8d1eeb4_c407ea1c","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":2175,"context_line":"\tif (download_firmware) {"},{"line_number":2176,"context_line":"\t\tLOG_INFO(\"Loading ANGIE firmware. This is reversible by power-cycling ANGIE device.\");"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"\t\tret \u003d libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":2179,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2180,"context_line":"\t\t\tLOG_ERROR(\"Could not claim interface\");"},{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"\t\tret \u003d angie_load_firmware_and_renumerate(\u0026angie_handle,"},{"line_number":2183,"context_line":"\t\t\t\tANGIE_FIRMWARE_FILE, ANGIE_RENUMERATION_DELAY_US);"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"b0170f52_a9c5bc23","line":2180,"range":{"start_line":2178,"start_character":2,"end_line":2180,"end_character":42},"in_reply_to":"b8d1eeb4_c407ea1c","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":true,"context_lines":[{"line_number":2298,"context_line":"\t.commands \u003d angie_command_handlers,"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"\t.init \u003d angie_init,"},{"line_number":2301,"context_line":"\t.quit \u003d angie_quit,"},{"line_number":2302,"context_line":"\t.speed \u003d angie_speed,"},{"line_number":2303,"context_line":"\t.khz \u003d angie_khz,"},{"line_number":2304,"context_line":"\t.speed_div \u003d angie_speed_div,"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"75c935a1_f66e3052","line":2301,"updated":"2023-07-08 14:23:51.000000000","message":"add here\n.reset \u003d angie_queue_reset,\nbut maybe better renaming it as \"angie_reset\", as we do not queue it but rather execute it immediately","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"\t.commands \u003d angie_command_handlers,"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"\t.init \u003d angie_init,"},{"line_number":2301,"context_line":"\t.quit \u003d angie_quit,"},{"line_number":2302,"context_line":"\t.speed \u003d angie_speed,"},{"line_number":2303,"context_line":"\t.khz \u003d angie_khz,"},{"line_number":2304,"context_line":"\t.speed_div \u003d angie_speed_div,"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"47acc7f8_aa33f7af","line":2301,"in_reply_to":"75c935a1_f66e3052","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"\t.commands \u003d angie_command_handlers,"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"\t.init \u003d angie_init,"},{"line_number":2301,"context_line":"\t.quit \u003d angie_quit,"},{"line_number":2302,"context_line":"\t.speed \u003d angie_speed,"},{"line_number":2303,"context_line":"\t.khz \u003d angie_khz,"},{"line_number":2304,"context_line":"\t.speed_div \u003d angie_speed_div,"}],"source_content_type":"text/x-csrc","patch_set":22,"id":"dc63e56c_a41b1131","line":2301,"in_reply_to":"75c935a1_f66e3052","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"8d8318cec785bf2a4e0d64629b65c7afbc0ab838"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":1711,"context_line":" * Execute a JTAG_RESET command"},{"line_number":1712,"context_line":" *"},{"line_number":1713,"context_line":" * @param device"},{"line_number":1714,"context_line":" * @param cmd pointer to the command that shall be executed."},{"line_number":1715,"context_line":" * @return on success: ERROR_OK"},{"line_number":1716,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1717,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"2c3403f4_b6ed6705","line":1714,"updated":"2023-07-10 22:44:00.000000000","message":"the argument list in the comment is now incorrect.\nMerge together angie_queue_reset() and angie_reset() in a single function","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":true,"context_lines":[{"line_number":1711,"context_line":" * Execute a JTAG_RESET command"},{"line_number":1712,"context_line":" *"},{"line_number":1713,"context_line":" * @param device"},{"line_number":1714,"context_line":" * @param cmd pointer to the command that shall be executed."},{"line_number":1715,"context_line":" * @return on success: ERROR_OK"},{"line_number":1716,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1717,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"928fcb37_5c0be19b","line":1714,"in_reply_to":"2c3403f4_b6ed6705","updated":"2023-07-11 09:13:00.000000000","message":"i couldn\u0027t merge them as the \".reset\" line at the end of code specify that it should be a function with two arguments (int, int) related to it","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":true,"context_lines":[{"line_number":1711,"context_line":" * Execute a JTAG_RESET command"},{"line_number":1712,"context_line":" *"},{"line_number":1713,"context_line":" * @param device"},{"line_number":1714,"context_line":" * @param cmd pointer to the command that shall be executed."},{"line_number":1715,"context_line":" * @return on success: ERROR_OK"},{"line_number":1716,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1717,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"f8e05377_7bce3308","line":1714,"in_reply_to":"928fcb37_5c0be19b","updated":"2023-07-11 21:23:10.000000000","message":"what about:\nstatic int function(int trst, int srst)\n{\nstruct angie *device \u003d angie_handle;\n...","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"1577db82c55f88a58320526a873d5efb702d0bd4","unresolved":false,"context_lines":[{"line_number":1711,"context_line":" * Execute a JTAG_RESET command"},{"line_number":1712,"context_line":" *"},{"line_number":1713,"context_line":" * @param device"},{"line_number":1714,"context_line":" * @param cmd pointer to the command that shall be executed."},{"line_number":1715,"context_line":" * @return on success: ERROR_OK"},{"line_number":1716,"context_line":" * @return on failure: ERROR_FAIL"},{"line_number":1717,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"083a31e5_6827fbac","line":1714,"in_reply_to":"f8e05377_7bce3308","updated":"2023-07-12 08:53:23.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":1925,"context_line":"\t\t\t\t    break;"},{"line_number":1926,"context_line":"\t\t\t    case JTAG_TLR_RESET:"},{"line_number":1927,"context_line":"\t\t\t    case JTAG_RUNTEST:"},{"line_number":1928,"context_line":"\t\t\t    case JTAG_RESET:"},{"line_number":1929,"context_line":"\t\t\t    case JTAG_PATHMOVE:"},{"line_number":1930,"context_line":"\t\t\t    case JTAG_SLEEP:"},{"line_number":1931,"context_line":"\t\t\t    case JTAG_STABLECLOCKS:"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"02d593e3_5e43941c","line":1928,"updated":"2023-07-10 22:44:00.000000000","message":"JTAG_RESET can be removed here too.","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":1925,"context_line":"\t\t\t\t    break;"},{"line_number":1926,"context_line":"\t\t\t    case JTAG_TLR_RESET:"},{"line_number":1927,"context_line":"\t\t\t    case JTAG_RUNTEST:"},{"line_number":1928,"context_line":"\t\t\t    case JTAG_RESET:"},{"line_number":1929,"context_line":"\t\t\t    case JTAG_PATHMOVE:"},{"line_number":1930,"context_line":"\t\t\t    case JTAG_SLEEP:"},{"line_number":1931,"context_line":"\t\t\t    case JTAG_STABLECLOCKS:"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"24ab85e1_2f13d11e","line":1928,"in_reply_to":"02d593e3_5e43941c","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2198,"context_line":"\t\t\tLOG_ERROR(\"Could not download firmware and re-numerate ANGIE\");"},{"line_number":2199,"context_line":"\t\t\tfree(angie_handle);"},{"line_number":2200,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2201,"context_line":"\t\t\treturn ret;"},{"line_number":2202,"context_line":"\t\t}"},{"line_number":2203,"context_line":"\t\tret \u003d angie_load_bitstream(angie_handle, ANGIE_BITSTREAM_FILE);"},{"line_number":2204,"context_line":"\t\tif (ret !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"55fff310_d59dd4db","line":2201,"updated":"2023-07-10 22:44:00.000000000","message":"You have not closed the USB device.\nInstead of free(angie_handle) + angie_handle\u003dNULL, run:\nangie_quit();\nreturn ret;\nignoring the value returned by angie_quit().","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2198,"context_line":"\t\t\tLOG_ERROR(\"Could not download firmware and re-numerate ANGIE\");"},{"line_number":2199,"context_line":"\t\t\tfree(angie_handle);"},{"line_number":2200,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2201,"context_line":"\t\t\treturn ret;"},{"line_number":2202,"context_line":"\t\t}"},{"line_number":2203,"context_line":"\t\tret \u003d angie_load_bitstream(angie_handle, ANGIE_BITSTREAM_FILE);"},{"line_number":2204,"context_line":"\t\tif (ret !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"b53c3fb7_c5412f74","line":2201,"in_reply_to":"55fff310_d59dd4db","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2205,"context_line":"\t\t\tLOG_ERROR(\"Could not download bitstream\");"},{"line_number":2206,"context_line":"\t\t\tfree(angie_handle);"},{"line_number":2207,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2208,"context_line":"\t\t\treturn ret;"},{"line_number":2209,"context_line":"\t\t}"},{"line_number":2210,"context_line":"\t} else {"},{"line_number":2211,"context_line":"\t\tLOG_INFO(\"ANGIE device is already running ANGIE firmware\");"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"d76ff9ab_e8e2dc2b","line":2208,"updated":"2023-07-10 22:44:00.000000000","message":"also here, angie_quit();","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2205,"context_line":"\t\t\tLOG_ERROR(\"Could not download bitstream\");"},{"line_number":2206,"context_line":"\t\t\tfree(angie_handle);"},{"line_number":2207,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2208,"context_line":"\t\t\treturn ret;"},{"line_number":2209,"context_line":"\t\t}"},{"line_number":2210,"context_line":"\t} else {"},{"line_number":2211,"context_line":"\t\tLOG_INFO(\"ANGIE device is already running ANGIE firmware\");"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"23b40a6e_6a40fcf2","line":2208,"in_reply_to":"d76ff9ab_e8e2dc2b","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2215,"context_line":"\tret \u003d jtag_libusb_choose_interface(angie_handle-\u003eusb_device_handle,"},{"line_number":2216,"context_line":"\t\t\u0026angie_handle-\u003eep_in, \u0026angie_handle-\u003eep_out, -1, -1, -1, -1);"},{"line_number":2217,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":2218,"context_line":"\t\treturn ret;"},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"\t/* Initialize ANGIE command queue */"},{"line_number":2221,"context_line":"\tangie_clear_queue(angie_handle);"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"3439d62c_8dedcc7a","line":2218,"updated":"2023-07-10 22:44:00.000000000","message":"angie_quit();","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"\tret \u003d jtag_libusb_choose_interface(angie_handle-\u003eusb_device_handle,"},{"line_number":2216,"context_line":"\t\t\u0026angie_handle-\u003eep_in, \u0026angie_handle-\u003eep_out, -1, -1, -1, -1);"},{"line_number":2217,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":2218,"context_line":"\t\treturn ret;"},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"\t/* Initialize ANGIE command queue */"},{"line_number":2221,"context_line":"\tangie_clear_queue(angie_handle);"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"b3c0b5f0_299cb57e","line":2218,"in_reply_to":"3439d62c_8dedcc7a","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2223,"context_line":"\t/* Issue one test command with short timeout */"},{"line_number":2224,"context_line":"\tret \u003d angie_append_test_cmd(angie_handle);"},{"line_number":2225,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":2226,"context_line":"\t\treturn ret;"},{"line_number":2227,"context_line":""},{"line_number":2228,"context_line":"\tret \u003d angie_execute_queued_commands(angie_handle, 200);"},{"line_number":2229,"context_line":"\tif (ret !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"f70562e6_68258430","line":2226,"updated":"2023-07-10 22:44:00.000000000","message":"angie_quit();","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"\t/* Issue one test command with short timeout */"},{"line_number":2224,"context_line":"\tret \u003d angie_append_test_cmd(angie_handle);"},{"line_number":2225,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":2226,"context_line":"\t\treturn ret;"},{"line_number":2227,"context_line":""},{"line_number":2228,"context_line":"\tret \u003d angie_execute_queued_commands(angie_handle, 200);"},{"line_number":2229,"context_line":"\tif (ret !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"b88f2434_e1115ae3","line":2226,"in_reply_to":"f70562e6_68258430","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2243,"context_line":"\t\t\t\t\"the USB port and re-connect, then re-run OpenOCD\");"},{"line_number":2244,"context_line":"\t\t\tfree(angie_handle);"},{"line_number":2245,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2246,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2247,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2248,"context_line":"\t\t} else {"},{"line_number":2249,"context_line":"\t\t\t/* Successfully received Bulk IN packet -\u003e continue */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"c3f87cc2_97654e5c","line":2246,"updated":"2023-07-10 22:44:00.000000000","message":"angie_quit();","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2243,"context_line":"\t\t\t\t\"the USB port and re-connect, then re-run OpenOCD\");"},{"line_number":2244,"context_line":"\t\t\tfree(angie_handle);"},{"line_number":2245,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2246,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2247,"context_line":"\t\t\tangie_handle \u003d NULL;"},{"line_number":2248,"context_line":"\t\t} else {"},{"line_number":2249,"context_line":"\t\t\t/* Successfully received Bulk IN packet -\u003e continue */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"dfcdf968_c3fe38c2","line":2246,"in_reply_to":"c3f87cc2_97654e5c","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2256,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"},{"line_number":2257,"context_line":"\t\tret \u003d angie_execute_queued_commands(angie_handle, 200);"},{"line_number":2258,"context_line":""},{"line_number":2259,"context_line":"\tif (ret \u003d\u003d ERROR_OK) {"},{"line_number":2260,"context_line":"\t\t/* Post-process the single CMD_GET_SIGNALS command */"},{"line_number":2261,"context_line":"\t\tinput_signals \u003d angie_handle-\u003equeue_start-\u003epayload_in[0];"},{"line_number":2262,"context_line":"\t\toutput_signals \u003d angie_handle-\u003equeue_start-\u003epayload_in[1];"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"c8b29d43_72e070d6","line":2259,"updated":"2023-07-10 22:44:00.000000000","message":"what happens if we have ret!\u003dERROR_OK?\nThe function angie_init() always returns ERROR_OK!","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"fe1ea1b8323967e2862019812e2b6dfd913dad01","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"},{"line_number":2257,"context_line":"\t\tret \u003d angie_execute_queued_commands(angie_handle, 200);"},{"line_number":2258,"context_line":""},{"line_number":2259,"context_line":"\tif (ret \u003d\u003d ERROR_OK) {"},{"line_number":2260,"context_line":"\t\t/* Post-process the single CMD_GET_SIGNALS command */"},{"line_number":2261,"context_line":"\t\tinput_signals \u003d angie_handle-\u003equeue_start-\u003epayload_in[0];"},{"line_number":2262,"context_line":"\t\toutput_signals \u003d angie_handle-\u003equeue_start-\u003epayload_in[1];"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"3fc63d30_7df68bab","line":2259,"in_reply_to":"b8692f06_ab9f3c30","updated":"2023-07-12 11:35:29.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":true,"context_lines":[{"line_number":2256,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"},{"line_number":2257,"context_line":"\t\tret \u003d angie_execute_queued_commands(angie_handle, 200);"},{"line_number":2258,"context_line":""},{"line_number":2259,"context_line":"\tif (ret \u003d\u003d ERROR_OK) {"},{"line_number":2260,"context_line":"\t\t/* Post-process the single CMD_GET_SIGNALS command */"},{"line_number":2261,"context_line":"\t\tinput_signals \u003d angie_handle-\u003equeue_start-\u003epayload_in[0];"},{"line_number":2262,"context_line":"\t\toutput_signals \u003d angie_handle-\u003equeue_start-\u003epayload_in[1];"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"b8692f06_ab9f3c30","line":2259,"in_reply_to":"c8b29d43_72e070d6","updated":"2023-07-11 09:13:00.000000000","message":"yes you are correct, i will add the case of ret !\u003d ERROR_OK","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":true,"context_lines":[{"line_number":2308,"context_line":"struct adapter_driver angie_adapter_driver \u003d {"},{"line_number":2309,"context_line":"\t.name \u003d \"angie\","},{"line_number":2310,"context_line":"\t.transports \u003d jtag_only,"},{"line_number":2311,"context_line":"\t.commands \u003d angie_command_handlers,"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"\t.init \u003d angie_init,"},{"line_number":2314,"context_line":"\t.quit \u003d angie_quit,"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"53f626da_2b120858","line":2311,"updated":"2023-07-10 22:44:00.000000000","message":"there is no more any command.\nYou can remove this line and also angie_command_handlers and angie_subcommand_handlers","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a5a4d781610fe3b69fe3e0f7a0708a7d081c09a8","unresolved":false,"context_lines":[{"line_number":2308,"context_line":"struct adapter_driver angie_adapter_driver \u003d {"},{"line_number":2309,"context_line":"\t.name \u003d \"angie\","},{"line_number":2310,"context_line":"\t.transports \u003d jtag_only,"},{"line_number":2311,"context_line":"\t.commands \u003d angie_command_handlers,"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"\t.init \u003d angie_init,"},{"line_number":2314,"context_line":"\t.quit \u003d angie_quit,"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"3dec910a_456acd2c","line":2311,"in_reply_to":"53f626da_2b120858","updated":"2023-07-11 09:13:00.000000000","message":"Done","commit_id":"246838c24eb56369211ddb3846f52e1fa3785190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":true,"context_lines":[{"line_number":533,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":534,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"\t\tif (transferred !\u003d (int)chunk_size) {"},{"line_number":537,"context_line":"\t\t\t/* Abort if libusb sent less data than requested */"},{"line_number":538,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":539,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"a5ca8a70_c5fc2759","line":536,"updated":"2023-07-11 21:23:10.000000000","message":"both transferred and chunk_size are int type. No need for cast","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"1577db82c55f88a58320526a873d5efb702d0bd4","unresolved":false,"context_lines":[{"line_number":533,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":534,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"\t\tif (transferred !\u003d (int)chunk_size) {"},{"line_number":537,"context_line":"\t\t\t/* Abort if libusb sent less data than requested */"},{"line_number":538,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":539,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"c3e456a1_04e516ae","line":536,"in_reply_to":"a5ca8a70_c5fc2759","updated":"2023-07-12 08:53:23.000000000","message":"Done","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":true,"context_lines":[{"line_number":594,"context_line":"\t\t    if (angie_cmd-\u003epayload_out) {"},{"line_number":595,"context_line":"\t\t\t    LOG_ERROR(\"BUG: Duplicate payload allocation for ANGIE command\");"},{"line_number":596,"context_line":"\t\t\t    free(payload);"},{"line_number":597,"context_line":"\t\t\t    return ERROR_FAIL;"},{"line_number":598,"context_line":"\t\t    } else {"},{"line_number":599,"context_line":"\t\t\t    angie_cmd-\u003epayload_out \u003d payload;"},{"line_number":600,"context_line":"\t\t\t    angie_cmd-\u003epayload_out_size \u003d size;"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"eda3bb4f_6a077325","line":597,"updated":"2023-07-11 21:23:10.000000000","message":"after return there is no need for else.\nif (..) {\n...\nreturn ERROR_FAIL;\n}\nangie_com-\u003e...","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"1577db82c55f88a58320526a873d5efb702d0bd4","unresolved":false,"context_lines":[{"line_number":594,"context_line":"\t\t    if (angie_cmd-\u003epayload_out) {"},{"line_number":595,"context_line":"\t\t\t    LOG_ERROR(\"BUG: Duplicate payload allocation for ANGIE command\");"},{"line_number":596,"context_line":"\t\t\t    free(payload);"},{"line_number":597,"context_line":"\t\t\t    return ERROR_FAIL;"},{"line_number":598,"context_line":"\t\t    } else {"},{"line_number":599,"context_line":"\t\t\t    angie_cmd-\u003epayload_out \u003d payload;"},{"line_number":600,"context_line":"\t\t\t    angie_cmd-\u003epayload_out_size \u003d size;"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"66a7b9b5_e3e0bc21","line":597,"in_reply_to":"eda3bb4f_6a077325","updated":"2023-07-12 08:53:23.000000000","message":"Done","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":true,"context_lines":[{"line_number":605,"context_line":"\t\t\t    LOG_ERROR(\"BUG: Duplicate payload allocation for ANGIE command\");"},{"line_number":606,"context_line":"\t\t\t    free(payload);"},{"line_number":607,"context_line":"\t\t\t    return ERROR_FAIL;"},{"line_number":608,"context_line":"\t\t    } else {"},{"line_number":609,"context_line":"\t\t\t    angie_cmd-\u003epayload_in_start \u003d payload;"},{"line_number":610,"context_line":"\t\t\t    angie_cmd-\u003epayload_in \u003d payload;"},{"line_number":611,"context_line":"\t\t\t    angie_cmd-\u003epayload_in_size \u003d size;"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"4c219a4d_4ffcf88b","line":608,"updated":"2023-07-11 21:23:10.000000000","message":"same here","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"1577db82c55f88a58320526a873d5efb702d0bd4","unresolved":false,"context_lines":[{"line_number":605,"context_line":"\t\t\t    LOG_ERROR(\"BUG: Duplicate payload allocation for ANGIE command\");"},{"line_number":606,"context_line":"\t\t\t    free(payload);"},{"line_number":607,"context_line":"\t\t\t    return ERROR_FAIL;"},{"line_number":608,"context_line":"\t\t    } else {"},{"line_number":609,"context_line":"\t\t\t    angie_cmd-\u003epayload_in_start \u003d payload;"},{"line_number":610,"context_line":"\t\t\t    angie_cmd-\u003epayload_in \u003d payload;"},{"line_number":611,"context_line":"\t\t\t    angie_cmd-\u003epayload_in_size \u003d size;"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"1b37137b_fa7c0625","line":608,"in_reply_to":"4c219a4d_4ffcf88b","updated":"2023-07-12 08:53:23.000000000","message":"Done","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"80a331c65e30eefc0f3fded2573547f20b7b01dd","unresolved":true,"context_lines":[{"line_number":2229,"context_line":"\t\t/* Sending test command failed. The ANGIE device may be forever waiting for"},{"line_number":2230,"context_line":"\t\t * the host to fetch an USB Bulk IN packet (e. g. OpenOCD crashed or was"},{"line_number":2231,"context_line":"\t\t * shut down by the user via Ctrl-C. Try to retrieve this Bulk IN packet. */"},{"line_number":2232,"context_line":"\t\tdummy \u003d calloc(64, sizeof(uint8_t));"},{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(angie_handle-\u003eusb_device_handle, angie_handle-\u003eep_in,"},{"line_number":2235,"context_line":"\t\t\t\tdummy, 64, 200, \u0026transferred);"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"06270ff8_b7fe7776","line":2232,"updated":"2023-07-11 21:23:10.000000000","message":"every calloc(), malloc() and so on requires a check for the returned pointer !\u003d NULL.\nHere, simply declare dummy as a stack array:\nchar dummy[64];\nso there is no need for checks and for free().","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"1577db82c55f88a58320526a873d5efb702d0bd4","unresolved":false,"context_lines":[{"line_number":2229,"context_line":"\t\t/* Sending test command failed. The ANGIE device may be forever waiting for"},{"line_number":2230,"context_line":"\t\t * the host to fetch an USB Bulk IN packet (e. g. OpenOCD crashed or was"},{"line_number":2231,"context_line":"\t\t * shut down by the user via Ctrl-C. Try to retrieve this Bulk IN packet. */"},{"line_number":2232,"context_line":"\t\tdummy \u003d calloc(64, sizeof(uint8_t));"},{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(angie_handle-\u003eusb_device_handle, angie_handle-\u003eep_in,"},{"line_number":2235,"context_line":"\t\t\t\tdummy, 64, 200, \u0026transferred);"}],"source_content_type":"text/x-csrc","patch_set":27,"id":"c5d53af2_b4cc949b","line":2232,"in_reply_to":"06270ff8_b7fe7776","updated":"2023-07-12 08:53:23.000000000","message":"Done","commit_id":"984d690655c72547bef055a1fc05ca4c6e51ec64"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":181,"context_line":"static int angie_append_queue(struct angie *device, struct angie_cmd *angie_cmd);"},{"line_number":182,"context_line":"static int angie_execute_queued_commands(struct angie *device, int timeout_ms);"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"static void angie_print_queue(struct angie *device);"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"static int angie_append_scan_cmd(struct angie *device,"},{"line_number":187,"context_line":"\t\tenum scan_type scan_type,"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"c933da39_f36464f0","line":184,"updated":"2023-07-14 22:20:21.000000000","message":"there should be no \"printf()\" in OpenOCD.\nPlease change the name of this function as angie_dump_queue()","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":181,"context_line":"static int angie_append_queue(struct angie *device, struct angie_cmd *angie_cmd);"},{"line_number":182,"context_line":"static int angie_execute_queued_commands(struct angie *device, int timeout_ms);"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"static void angie_print_queue(struct angie *device);"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"static int angie_append_scan_cmd(struct angie *device,"},{"line_number":187,"context_line":"\t\tenum scan_type scan_type,"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"7cbd2525_2dababa2","line":184,"in_reply_to":"c933da39_f36464f0","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":502,"context_line":"\tsize \u003d (uint16_t)firmware_image-\u003esections[section_index].size;"},{"line_number":503,"context_line":"\taddr \u003d (uint16_t)firmware_image-\u003esections[section_index].base_address;"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\tLOG_DEBUG(\"section %02i at addr 0x%04x (size 0x%04x)\", section_index, addr,"},{"line_number":506,"context_line":"\t\tsize);"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"\t/* Copy section contents to local buffer */"},{"line_number":509,"context_line":"\tret \u003d image_read_section(firmware_image, section_index, 0, size, data,"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"718598c3_6cf18979","line":506,"range":{"start_line":505,"start_character":1,"end_line":506,"end_character":8},"updated":"2023-07-14 22:20:21.000000000","message":"size is uint16_t;\n\"... (size 0x%04\" PRIx16 \")\", ...","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":502,"context_line":"\tsize \u003d (uint16_t)firmware_image-\u003esections[section_index].size;"},{"line_number":503,"context_line":"\taddr \u003d (uint16_t)firmware_image-\u003esections[section_index].base_address;"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\tLOG_DEBUG(\"section %02i at addr 0x%04x (size 0x%04x)\", section_index, addr,"},{"line_number":506,"context_line":"\t\tsize);"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"\t/* Copy section contents to local buffer */"},{"line_number":509,"context_line":"\tret \u003d image_read_section(firmware_image, section_index, 0, size, data,"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"a76b3b56_bb4c2cbe","line":506,"range":{"start_line":505,"start_character":1,"end_line":506,"end_character":8},"in_reply_to":"718598c3_6cf18979","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":509,"context_line":"\tret \u003d image_read_section(firmware_image, section_index, 0, size, data,"},{"line_number":510,"context_line":"\t\t\t\u0026size_read);"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"\tif (ret !\u003d ERROR_OK || size_read !\u003d size) {"},{"line_number":513,"context_line":"\t\t/* Propagating the return code would return \u00270\u0027 (misleadingly indicating"},{"line_number":514,"context_line":"\t\t * successful execution of the function) if only the size check fails. */"},{"line_number":515,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":516,"context_line":"\t}"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tbytes_remaining \u003d size;"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":30,"id":"63328aa7_b9e1b77f","line":516,"range":{"start_line":512,"start_character":1,"end_line":516,"end_character":2},"updated":"2023-07-14 22:20:21.000000000","message":"I think it\u0027s better propagating the error when possible:\nif (ret !\u003d ERROR_OK)\nreturn ret;\nif (size_read !\u003d size)\nreturn ERROR_FAIL;","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":509,"context_line":"\tret \u003d image_read_section(firmware_image, section_index, 0, size, data,"},{"line_number":510,"context_line":"\t\t\t\u0026size_read);"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"\tif (ret !\u003d ERROR_OK || size_read !\u003d size) {"},{"line_number":513,"context_line":"\t\t/* Propagating the return code would return \u00270\u0027 (misleadingly indicating"},{"line_number":514,"context_line":"\t\t * successful execution of the function) if only the size check fails. */"},{"line_number":515,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":516,"context_line":"\t}"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tbytes_remaining \u003d size;"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":30,"id":"5fb0362a_0405244b","line":516,"range":{"start_line":512,"start_character":1,"end_line":516,"end_character":2},"in_reply_to":"63328aa7_b9e1b77f","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":530,"context_line":"\t\t\t\tchunk_size, LIBUSB_TIMEOUT_MS, \u0026transferred);"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":533,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"\t\tif (transferred !\u003d chunk_size) {"},{"line_number":536,"context_line":"\t\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"a53eb5a4_adaea016","line":533,"updated":"2023-07-14 22:20:21.000000000","message":"return ret;","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":530,"context_line":"\t\t\t\tchunk_size, LIBUSB_TIMEOUT_MS, \u0026transferred);"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":533,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"\t\tif (transferred !\u003d chunk_size) {"},{"line_number":536,"context_line":"\t\t\t/* Abort if libusb sent less data than requested */"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"3d221df0_6d2720ea","line":533,"in_reply_to":"a53eb5a4_adaea016","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":861,"context_line":" */"},{"line_number":862,"context_line":"static void angie_print_command(struct angie_cmd *angie_cmd)"},{"line_number":863,"context_line":"{"},{"line_number":864,"context_line":"\tint i;"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"\tprintf(\"  %-22s | OUT size \u003d %i, bytes \u003d 0x\","},{"line_number":867,"context_line":"\t\tangie_cmd_id_string(angie_cmd-\u003eid), angie_cmd-\u003epayload_out_size);"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"9793d8ba_85a7a750","line":864,"updated":"2023-07-14 22:20:21.000000000","message":"We already have 2 buffer 2 hex converters: hexify() and buf_to_hex_str(), but they do not add a separator!\nLet\u0027s have a new one!\npayload_out_size is max 63, but eventually let\u0027s use 64\nchar hex[64 \\* 3];\nfor (int i \u003d 0; i \u003c angie_cmd-\u003epayload_out_size; i++) {\nsprintf(hex + 3 \\* i; \"%02\" PRIX8 \" \", angie_cmd-\u003epayload_out[i]);\nhex[3 \\* angie_cmd-\u003epayload_out_size - 1] \u003d 0;\nLOG_DEBUG_IO(\"  %-22s | OUT size \u003d %\" PRIi8 \", bytes \u003d %s\",\nangie_cmd_id_string(angie_cmd-\u003eid), angie_cmd-\u003epayload_out_size, hex);","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":861,"context_line":" */"},{"line_number":862,"context_line":"static void angie_print_command(struct angie_cmd *angie_cmd)"},{"line_number":863,"context_line":"{"},{"line_number":864,"context_line":"\tint i;"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"\tprintf(\"  %-22s | OUT size \u003d %i, bytes \u003d 0x\","},{"line_number":867,"context_line":"\t\tangie_cmd_id_string(angie_cmd-\u003eid), angie_cmd-\u003epayload_out_size);"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"8cfba612_31d3aa88","line":864,"in_reply_to":"9793d8ba_85a7a750","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":868,"context_line":""},{"line_number":869,"context_line":"\tfor (i \u003d 0; i \u003c angie_cmd-\u003epayload_out_size; i++)"},{"line_number":870,"context_line":"\t\tprintf(\"%02X \", angie_cmd-\u003epayload_out[i]);"},{"line_number":871,"context_line":"\tprintf(\"\\n                         | IN size  \u003d %i\\n\","},{"line_number":872,"context_line":"\t\tangie_cmd-\u003epayload_in_size);"},{"line_number":873,"context_line":"}"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"3a549736_aa8149bf","line":872,"range":{"start_line":871,"start_character":1,"end_line":872,"end_character":30},"updated":"2023-07-14 22:20:21.000000000","message":"payload_in_size is uint8_t\nLOG_DEBUG_IO(\"... IN SIZE  \u003d %\" PRIi8 \"\\n\",...","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":868,"context_line":""},{"line_number":869,"context_line":"\tfor (i \u003d 0; i \u003c angie_cmd-\u003epayload_out_size; i++)"},{"line_number":870,"context_line":"\t\tprintf(\"%02X \", angie_cmd-\u003epayload_out[i]);"},{"line_number":871,"context_line":"\tprintf(\"\\n                         | IN size  \u003d %i\\n\","},{"line_number":872,"context_line":"\t\tangie_cmd-\u003epayload_in_size);"},{"line_number":873,"context_line":"}"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"a4267a03_351efb65","line":872,"range":{"start_line":871,"start_character":1,"end_line":872,"end_character":30},"in_reply_to":"3a549736_aa8149bf","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":881,"context_line":"{"},{"line_number":882,"context_line":"\tstruct angie_cmd *current;"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"\tprintf(\"ANGIE command queue:\\n\");"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"\tfor (current \u003d device-\u003equeue_start; current; current \u003d current-\u003enext)"},{"line_number":887,"context_line":"\t\tangie_print_command(current);"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"d267a835_ce818d51","line":884,"updated":"2023-07-14 22:20:21.000000000","message":"LOG_DEBUG_IO(\"ANGIE command queue:\");","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":881,"context_line":"{"},{"line_number":882,"context_line":"\tstruct angie_cmd *current;"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"\tprintf(\"ANGIE command queue:\\n\");"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"\tfor (current \u003d device-\u003equeue_start; current; current \u003d current-\u003enext)"},{"line_number":887,"context_line":"\t\tangie_print_command(current);"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"19cac5e2_f4549cea","line":884,"in_reply_to":"d267a835_ce818d51","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":1787,"context_line":"\t\t}"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"\t\t/* Append CLOCK_TMS command to ANGIE command queue */"},{"line_number":1790,"context_line":"\t\tLOG_INFO(\"pathmove batch: count \u003d %i, sequence \u003d 0x%x\", batch_size, tms_sequence);"},{"line_number":1791,"context_line":"\t\tret \u003d angie_append_clock_tms_cmd(angie_handle, batch_size, tms_sequence);"},{"line_number":1792,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":1793,"context_line":"\t\t\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"e5a322bc_98c9af2f","line":1790,"updated":"2023-07-14 22:20:21.000000000","message":"tms_sequence is a uint8_t\n\"... sequence \u003d 0x%\" PRIx8, ...","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"\t\t}"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"\t\t/* Append CLOCK_TMS command to ANGIE command queue */"},{"line_number":1790,"context_line":"\t\tLOG_INFO(\"pathmove batch: count \u003d %i, sequence \u003d 0x%x\", batch_size, tms_sequence);"},{"line_number":1791,"context_line":"\t\tret \u003d angie_append_clock_tms_cmd(angie_handle, batch_size, tms_sequence);"},{"line_number":1792,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":1793,"context_line":"\t\t\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"716437ce_a74eaec6","line":1790,"in_reply_to":"e5a322bc_98c9af2f","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":1877,"context_line":"\t\t    ret \u003d ERROR_OK;"},{"line_number":1878,"context_line":"\t\t    break;"},{"line_number":1879,"context_line":"\t    default:"},{"line_number":1880,"context_line":"\t\t    LOG_ERROR(\"BUG: angie post process scan encountered an unknown\""},{"line_number":1881,"context_line":"\t\t\t\" JTAG scan type\");"},{"line_number":1882,"context_line":"\t\t    ret \u003d ERROR_FAIL;"},{"line_number":1883,"context_line":"\t\t    break;"},{"line_number":1884,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"058b37de_f6f054ad","line":1881,"range":{"start_line":1880,"start_character":6,"end_line":1881,"end_character":22},"updated":"2023-07-14 22:20:21.000000000","message":"don\u0027t split the string; it can stay in a single line","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":1877,"context_line":"\t\t    ret \u003d ERROR_OK;"},{"line_number":1878,"context_line":"\t\t    break;"},{"line_number":1879,"context_line":"\t    default:"},{"line_number":1880,"context_line":"\t\t    LOG_ERROR(\"BUG: angie post process scan encountered an unknown\""},{"line_number":1881,"context_line":"\t\t\t\" JTAG scan type\");"},{"line_number":1882,"context_line":"\t\t    ret \u003d ERROR_FAIL;"},{"line_number":1883,"context_line":"\t\t    break;"},{"line_number":1884,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"eae5380a_f4db851e","line":1881,"range":{"start_line":1880,"start_character":6,"end_line":1881,"end_character":22},"in_reply_to":"058b37de_f6f054ad","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"20563e00cbe6ccdad0ac1dd1d91d43f5655acb69","unresolved":true,"context_lines":[{"line_number":2223,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(angie_handle-\u003eusb_device_handle, angie_handle-\u003eep_in,"},{"line_number":2224,"context_line":"\t\t\t\tdummy, 64, 200, \u0026transferred);"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"\t\tif (ret !\u003d 0 || transferred \u003d\u003d 0) {"},{"line_number":2227,"context_line":"\t\t\t/* Bulk IN transfer failed -\u003e unrecoverable error condition */"},{"line_number":2228,"context_line":"\t\t\tLOG_ERROR(\"Cannot communicate with ANGIE device. Disconnect ANGIE from \""},{"line_number":2229,"context_line":"\t\t\t\t\"the USB port and re-connect, then re-run OpenOCD\");"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"e1420e91_4eccbaf0","line":2226,"updated":"2023-07-14 22:20:21.000000000","message":"if (ret !\u003d ERROR_OK || transferred \u003d\u003d 0) {\nor\nif (ret !\u003d ERROR_OK || transferred \u003c 64) {","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"20fffc5858e1d9d70043d0b96d7c59febd8d85a2","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"\t\tret \u003d jtag_libusb_bulk_write(angie_handle-\u003eusb_device_handle, angie_handle-\u003eep_in,"},{"line_number":2224,"context_line":"\t\t\t\tdummy, 64, 200, \u0026transferred);"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"\t\tif (ret !\u003d 0 || transferred \u003d\u003d 0) {"},{"line_number":2227,"context_line":"\t\t\t/* Bulk IN transfer failed -\u003e unrecoverable error condition */"},{"line_number":2228,"context_line":"\t\t\tLOG_ERROR(\"Cannot communicate with ANGIE device. Disconnect ANGIE from \""},{"line_number":2229,"context_line":"\t\t\t\t\"the USB port and re-connect, then re-run OpenOCD\");"}],"source_content_type":"text/x-csrc","patch_set":30,"id":"7470b07b_76982163","line":2226,"in_reply_to":"e1420e91_4eccbaf0","updated":"2023-07-17 08:43:50.000000000","message":"Done","commit_id":"14cd8fe2d459e7bfa8b9bb8ede8f08fea76b2d19"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"60f161212c9bce5264ffcb164fffedc3d122d8a4","unresolved":true,"context_lines":[{"line_number":302,"context_line":"\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":303,"context_line":"\t\t\tREQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, \u0026reset_bit, 1, LIBUSB_TIMEOUT_MS, \u0026transferred);"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"\t/* usb_control_msg() returns the number of bytes transferred during the"},{"line_number":306,"context_line":"\t * DATA stage of the control transfer - must be exactly 1 in this case! */"},{"line_number":307,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":308,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":32,"id":"f72026a2_9c70d33d","line":305,"updated":"2023-07-22 21:16:44.000000000","message":"is this comment still valid?\nWe do not test anymore the value of transferred. What about simplify this function as:\nreturn jtag_libusb_control_transfer(..., NULL);","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6d438d15f7ea6916b55d5feed1d56a0620380101","unresolved":false,"context_lines":[{"line_number":302,"context_line":"\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":303,"context_line":"\t\t\tREQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, \u0026reset_bit, 1, LIBUSB_TIMEOUT_MS, \u0026transferred);"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"\t/* usb_control_msg() returns the number of bytes transferred during the"},{"line_number":306,"context_line":"\t * DATA stage of the control transfer - must be exactly 1 in this case! */"},{"line_number":307,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":308,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":32,"id":"5cdeb82a_b8f1a121","line":305,"in_reply_to":"f72026a2_9c70d33d","updated":"2023-07-24 08:25:36.000000000","message":"Ack","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"60f161212c9bce5264ffcb164fffedc3d122d8a4","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"\tusleep(delay_us);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"\tret \u003d angie_usb_open(device);"},{"line_number":344,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":345,"context_line":"\t\treturn ret;"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":32,"id":"2c72f819_daf50db4","line":343,"updated":"2023-07-22 21:16:44.000000000","message":"here directly:\nreturn angie_usb_open(device);","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6d438d15f7ea6916b55d5feed1d56a0620380101","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"\tusleep(delay_us);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"\tret \u003d angie_usb_open(device);"},{"line_number":344,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":345,"context_line":"\t\treturn ret;"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":32,"id":"8ed98a82_7b352326","line":343,"in_reply_to":"2c72f819_daf50db4","updated":"2023-07-24 08:25:36.000000000","message":"Ack","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"60f161212c9bce5264ffcb164fffedc3d122d8a4","unresolved":true,"context_lines":[{"line_number":868,"context_line":"\tLOG_DEBUG_IO(\" %-22s | OUT size \u003d %\" PRIi8 \", bytes \u003d %s\","},{"line_number":869,"context_line":"\t\t\t\t\tangie_cmd_id_string(angie_cmd-\u003eid), angie_cmd-\u003epayload_out_size, hex);"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"\tprintf(\"\\n                         | IN size  \u003d  %\" PRIi8 \"\\n\", angie_cmd-\u003epayload_in_size);"},{"line_number":872,"context_line":"}"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":32,"id":"2658e297_37add98f","line":871,"updated":"2023-07-22 21:16:44.000000000","message":"also this printf() has to be changed with LOG_DEBUG_IO()","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"6d438d15f7ea6916b55d5feed1d56a0620380101","unresolved":false,"context_lines":[{"line_number":868,"context_line":"\tLOG_DEBUG_IO(\" %-22s | OUT size \u003d %\" PRIi8 \", bytes \u003d %s\","},{"line_number":869,"context_line":"\t\t\t\t\tangie_cmd_id_string(angie_cmd-\u003eid), angie_cmd-\u003epayload_out_size, hex);"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"\tprintf(\"\\n                         | IN size  \u003d  %\" PRIi8 \"\\n\", angie_cmd-\u003epayload_in_size);"},{"line_number":872,"context_line":"}"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":32,"id":"8d0ba961_e32c475a","line":871,"in_reply_to":"2658e297_37add98f","updated":"2023-07-24 08:25:36.000000000","message":"Ack","commit_id":"14e0157e62d3d4e10055026b2d1aca24e775a891"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"60a04413e96dbd90768c00f6d45a0473a9309fa0","unresolved":true,"context_lines":[{"line_number":297,"context_line":" */"},{"line_number":298,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"\tint ret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":301,"context_line":"\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":302,"context_line":"\t\t\tREQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, \u0026reset_bit, 1, LIBUSB_TIMEOUT_MS, NULL);"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":34,"id":"05da014c_fa71661c","line":300,"updated":"2023-07-24 15:09:36.000000000","message":"no need for the variable ret. Use directly\nreturn jtag_libusb_control_transfer(...);","commit_id":"bfa004958c3fa8d8f6ffaa43351006e9533cf3b6"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"cba45bb01506f04448992bc6d6f05300eb3290e6","unresolved":true,"context_lines":[{"line_number":297,"context_line":" */"},{"line_number":298,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"\tint ret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":301,"context_line":"\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":302,"context_line":"\t\t\tREQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, \u0026reset_bit, 1, LIBUSB_TIMEOUT_MS, NULL);"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":34,"id":"7e89f139_2e1407d3","line":300,"in_reply_to":"05da014c_fa71661c","updated":"2023-07-24 15:13:00.000000000","message":"Done.","commit_id":"bfa004958c3fa8d8f6ffaa43351006e9533cf3b6"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"97bcdacf5463dde03aa41982e7b409722da59d92","unresolved":false,"context_lines":[{"line_number":297,"context_line":" */"},{"line_number":298,"context_line":"static int angie_cpu_reset(struct angie *device, char reset_bit)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"\tint ret \u003d jtag_libusb_control_transfer(device-\u003eusb_device_handle,"},{"line_number":301,"context_line":"\t\t\t(LIBUSB_ENDPOINT_OUT | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_RECIPIENT_DEVICE),"},{"line_number":302,"context_line":"\t\t\tREQUEST_FIRMWARE_LOAD, CPUCS_REG, 0, \u0026reset_bit, 1, LIBUSB_TIMEOUT_MS, NULL);"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":34,"id":"ae8cd1cf_493dbab4","line":300,"in_reply_to":"7e89f139_2e1407d3","updated":"2023-07-24 15:40:14.000000000","message":"Done","commit_id":"bfa004958c3fa8d8f6ffaa43351006e9533cf3b6"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"bf8acda9960e513afc9a25c325f9ecedb943db52","unresolved":true,"context_lines":[{"line_number":275,"context_line":" */"},{"line_number":276,"context_line":"static int angie_usb_close(struct angie *device)"},{"line_number":277,"context_line":"{"},{"line_number":278,"context_line":"\tif(device-\u003eusb_device_handle !\u003d NULL){"},{"line_number":279,"context_line":"\tif (libusb_release_interface(device-\u003eusb_device_handle, 0) !\u003d 0)"},{"line_number":280,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":36,"id":"bd3d5cc9_0156c171","line":278,"range":{"start_line":278,"start_character":1,"end_line":278,"end_character":39},"updated":"2023-07-27 08:57:16.000000000","message":"I added this to check if the device has been closed before, to prevent the \"angie_usb_close\" to execute two times in a row, and this is because i found a segmentation error when the \"angie_load_firmware_and_renumerate\" function fails. \n\nThis last function has already an \"angie_usb_close\" function, in the case of normal execution of this function the first time and it gives an error (eg. when the libusb release interface fails) the \"angie_quit\" function (after the load_firmware_and_renumerate function fails) will re-execute the \"angie_usb_close\" a second time and the segmentation error happens.","commit_id":"84ad4bc9fa4844205f8cf1aeb20dcbcddb04eb32"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7c13e223a6ee94fef00c4cf92b16dda7477126ba","unresolved":false,"context_lines":[{"line_number":275,"context_line":" */"},{"line_number":276,"context_line":"static int angie_usb_close(struct angie *device)"},{"line_number":277,"context_line":"{"},{"line_number":278,"context_line":"\tif(device-\u003eusb_device_handle !\u003d NULL){"},{"line_number":279,"context_line":"\tif (libusb_release_interface(device-\u003eusb_device_handle, 0) !\u003d 0)"},{"line_number":280,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":36,"id":"b067b30d_55389641","line":278,"range":{"start_line":278,"start_character":1,"end_line":278,"end_character":39},"in_reply_to":"bd3d5cc9_0156c171","updated":"2023-08-02 13:36:22.000000000","message":"Ack","commit_id":"84ad4bc9fa4844205f8cf1aeb20dcbcddb04eb32"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d48903925571077f3f2370c69d67033a67bbfdc4","unresolved":true,"context_lines":[{"line_number":1718,"context_line":"\telse"},{"line_number":1719,"context_line":"\t\thigh |\u003d SIGNAL_SRST;"},{"line_number":1720,"context_line":""},{"line_number":1721,"context_line":"\tint ret \u003d angie_append_set_signals_cmd(device, low, high);"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"\tret \u003d angie_execute_queued_commands(device, LIBUSB_TIMEOUT_MS);"},{"line_number":1724,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":38,"id":"15338fe2_54f83012","line":1721,"updated":"2023-08-12 22:06:26.000000000","message":"Ahmed,\nclang\u0027s scan-build complains that the value in ret is assigned and never used. Report here:\nhttps://build.openocd.org/job/openocd-clang/1175/clang/new/source.ffdd8149-0fbc-400e-8b2b-a43ad37f2577/#1721\n\nWould you mind sending a new patch to fix this issue?","commit_id":"94686eea6e982a83e5c1796e8a903bf683ed62e5"}],"src/jtag/interface.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fe9fe7147353205535846439cdf75ad5421bf59","unresolved":true,"context_lines":[{"line_number":393,"context_line":"extern struct adapter_driver stlink_dap_adapter_driver;"},{"line_number":394,"context_line":"extern struct adapter_driver sysfsgpio_adapter_driver;"},{"line_number":395,"context_line":"extern struct adapter_driver ulink_adapter_driver;"},{"line_number":396,"context_line":"extern struct adapter_driver angie_adapter_driver;"},{"line_number":397,"context_line":"extern struct adapter_driver usb_blaster_adapter_driver;"},{"line_number":398,"context_line":"extern struct adapter_driver usbprog_adapter_driver;"},{"line_number":399,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f281a203_701b1bd5","line":396,"updated":"2023-06-18 19:01:05.000000000","message":"please add it in alphabetic order","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":393,"context_line":"extern struct adapter_driver stlink_dap_adapter_driver;"},{"line_number":394,"context_line":"extern struct adapter_driver sysfsgpio_adapter_driver;"},{"line_number":395,"context_line":"extern struct adapter_driver ulink_adapter_driver;"},{"line_number":396,"context_line":"extern struct adapter_driver angie_adapter_driver;"},{"line_number":397,"context_line":"extern struct adapter_driver usb_blaster_adapter_driver;"},{"line_number":398,"context_line":"extern struct adapter_driver usbprog_adapter_driver;"},{"line_number":399,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"80277990_c35fa1b2","line":396,"in_reply_to":"f281a203_701b1bd5","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":393,"context_line":"extern struct adapter_driver stlink_dap_adapter_driver;"},{"line_number":394,"context_line":"extern struct adapter_driver sysfsgpio_adapter_driver;"},{"line_number":395,"context_line":"extern struct adapter_driver ulink_adapter_driver;"},{"line_number":396,"context_line":"extern struct adapter_driver angie_adapter_driver;"},{"line_number":397,"context_line":"extern struct adapter_driver usb_blaster_adapter_driver;"},{"line_number":398,"context_line":"extern struct adapter_driver usbprog_adapter_driver;"},{"line_number":399,"context_line":"extern struct adapter_driver vdebug_adapter_driver;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c8b1a5f5_0539f277","line":396,"in_reply_to":"f281a203_701b1bd5","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"}],"src/jtag/startup.tcl":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fe9fe7147353205535846439cdf75ad5421bf59","unresolved":true,"context_lines":[{"line_number":419,"context_line":"\teval ulink download_firmware $args"},{"line_number":420,"context_line":"}"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"lappend _telnet_autocomplete_skip angie_download_firmware"},{"line_number":423,"context_line":"proc angie_download_firmware args {"},{"line_number":424,"context_line":"\techo \"DEPRECATED! use \u0027angie download_firmware\u0027 not \u0027angie_download_firmware\u0027\""},{"line_number":425,"context_line":"\teval angie download_firmware $args"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"7222e6c1_33bc24c6","line":422,"updated":"2023-06-18 19:01:05.000000000","message":"We add the deprecated commands only when there is a change in the command name and/or syntax compared to a previous release of OpenOCD.\n\"angie\" commands have never been part of OpenOCD, so no need to add anything here","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":419,"context_line":"\teval ulink download_firmware $args"},{"line_number":420,"context_line":"}"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"lappend _telnet_autocomplete_skip angie_download_firmware"},{"line_number":423,"context_line":"proc angie_download_firmware args {"},{"line_number":424,"context_line":"\techo \"DEPRECATED! use \u0027angie download_firmware\u0027 not \u0027angie_download_firmware\u0027\""},{"line_number":425,"context_line":"\teval angie download_firmware $args"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"df1e766c_e69be74f","line":422,"in_reply_to":"7222e6c1_33bc24c6","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c722cf184e7a21e2b38b3e32c2f93f22ce2359c","unresolved":false,"context_lines":[{"line_number":419,"context_line":"\teval ulink download_firmware $args"},{"line_number":420,"context_line":"}"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"lappend _telnet_autocomplete_skip angie_download_firmware"},{"line_number":423,"context_line":"proc angie_download_firmware args {"},{"line_number":424,"context_line":"\techo \"DEPRECATED! use \u0027angie download_firmware\u0027 not \u0027angie_download_firmware\u0027\""},{"line_number":425,"context_line":"\teval angie download_firmware $args"}],"source_content_type":"text/x-tcl","patch_set":1,"id":"d0495cfa_6a43b86b","line":422,"in_reply_to":"7222e6c1_33bc24c6","updated":"2023-07-10 22:44:00.000000000","message":"Done","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"}],"tcl/interface/angie.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9fe9fe7147353205535846439cdf75ad5421bf59","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adapter driver angie"},{"line_number":8,"context_line":"adapter speed 10000"},{"line_number":9,"context_line":"reset_config trst_and_srst trst_push_pull srst_open_drain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"345e879b_8e58a238","line":9,"updated":"2023-06-18 19:01:05.000000000","message":"please add a newline at the end of the file","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"de212b26c0e0c0768e32751c8addad5e2669bc56","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adapter driver angie"},{"line_number":8,"context_line":"adapter speed 10000"},{"line_number":9,"context_line":"reset_config trst_and_srst trst_push_pull srst_open_drain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"156b5c92_3b8eb396","line":9,"in_reply_to":"345e879b_8e58a238","updated":"2023-07-11 08:00:12.000000000","message":"Ack","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f49afc5b130c30a97746550518e377420e31021","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adapter driver angie"},{"line_number":8,"context_line":"adapter speed 10000"},{"line_number":9,"context_line":"reset_config trst_and_srst trst_push_pull srst_open_drain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"0758bdb7_881aef08","line":9,"in_reply_to":"345e879b_8e58a238","updated":"2023-07-08 14:23:51.000000000","message":"Done","commit_id":"264bf39788c9c1f5008e7c91b37632fa93fe6b15"}]}