)]}'
{"id":"openocd~master~Iaa0d006a3d8ee611ee93333ed49a8615a6c94276","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002050":{"account":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"last_update":"2023-05-25 10:45:31.000000000","reason":"\u003cGERRIT_ACCOUNT_1002050\u003e replied on the change","reason_account":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-06-02 20:56:34.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iaa0d006a3d8ee611ee93333ed49a8615a6c94276","subject":"target: armv8: fix support of pointer authentication","status":"MERGED","created":"2023-05-25 09:53:40.000000000","updated":"2023-06-02 20:57:05.000000000","submitted":"2023-06-02 20:57:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7712","meta_rev_id":"5a11adc84ef2a27c9dc225d831c1b57a92b0d50f","_number":7712,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-02 20:57:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-02 20:57:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-06-02 20:57:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-25 09:53:40.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"state":"REVIEWER"},{"updated":"2023-05-25 10:06:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3c65014a86b641eb4cf16da06ab20a492dc15bc3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-25 09:53:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f30b20c57f730d5b5e62adc2887fcb9701f03c95","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-25 10:06:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17740/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16942/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fbc7dd350bbff65847eeebce450c3621f0cbac41","author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"real_author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"date":"2023-05-25 10:45:31.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"be37250997596e66e1c69e446978587b3e9adcd0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-02 20:56:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5a11adc84ef2a27c9dc225d831c1b57a92b0d50f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-02 20:57:05.000000000","message":"Change has been successfully cherry-picked as 4a57f3ebb21db6b89b0ceb9df34d32157731ead2","accounts_in_message":[],"_revision_number":2}],"current_revision":"4a57f3ebb21db6b89b0ceb9df34d32157731ead2","revisions":{"a2df3037b2e0a2e4609567c336d84e92cb2e31f6":{"kind":"REWORK","_number":1,"created":"2023-05-25 09:53:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/12/7712/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/7712/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/1 \u0026\u0026 git checkout -b change-7712 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/7712/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4defa3b1e323b7f7287d8e046b2c97ad4a749f87","subject":"flash/stm32l4x: support STM32C0x devices"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-25 08:49:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-25 09:51:16.000000000","tz":120},"subject":"target: armv8: fix support of pointer authentication","message":"target: armv8: fix support of pointer authentication\n\nThe registers pauth_dmask and pauth_cmask are not accessible in\nAARCH32 mode. Tagging them as \u0027hidden\u0027 is not enough and triggers\nerror:\n\tFailed to read pauth_dmask register\nwhile halting the core.\n\nTag the pauth registers as not existing, unless required by user.\n\nNote: for non existing registers there should be no need to\n      allocate their register cache. Let\u0027s keep this for a further\n      improvement.\n\nChange-Id: Iaa0d006a3d8ee611ee93333ed49a8615a6c94276\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: d0436b0cdabb (\"armv8: Add support of pointer authentication\")\n"}},"4a57f3ebb21db6b89b0ceb9df34d32157731ead2":{"kind":"REWORK","_number":2,"created":"2023-06-02 20:57:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/12/7712/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/7712/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/2 \u0026\u0026 git checkout -b change-7712 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/7712/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/7712/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"78688fea984b69d1986b6b730ff2935668cc9208","subject":"flash/jtagspi: sending command and setting parameters without probing."}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-05-25 08:49:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-06-02 20:57:05.000000000","tz":0},"subject":"target: armv8: fix support of pointer authentication","message":"target: armv8: fix support of pointer authentication\n\nThe registers pauth_dmask and pauth_cmask are not accessible in\nAARCH32 mode. Tagging them as \u0027hidden\u0027 is not enough and triggers\nerror:\n\tFailed to read pauth_dmask register\nwhile halting the core.\n\nTag the pauth registers as not existing, unless required by user.\n\nNote: for non existing registers there should be no need to\n      allocate their register cache. Let\u0027s keep this for a further\n      improvement.\n\nChange-Id: Iaa0d006a3d8ee611ee93333ed49a8615a6c94276\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: d0436b0cdabb (\"armv8: Add support of pointer authentication\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7712\nTested-by: jenkins\nReviewed-by: Koudai Iwahori \u003ckoudai@google.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
