)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a1f4743472c70b7c100135e119e125cafb9897bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae09930b_237b8cca","updated":"2023-05-28 14:29:02.000000000","message":"Thanks!","commit_id":"3427ad8ca3b8197354d56f4bab4e392f4b2d028d"}],"src/target/espressif/esp32_apptrace.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ddc1a87605c5cde4ca340360536c39f419d29041","unresolved":true,"context_lines":[{"line_number":1252,"context_line":"{"},{"line_number":1253,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_START };"},{"line_number":1254,"context_line":"\tuint32_t fired_target_num \u003d 0;"},{"line_number":1255,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM] \u003d {0};"},{"line_number":1256,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d ctx-\u003ecmd_priv;"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"\t/* get current block id */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1a7db935_ab6ebbc5","line":1255,"updated":"2023-07-13 20:52:18.000000000","message":"Compilation on old gcc 4.8.4 fails:\nsrc/target/espressif/esp32_apptrace.c:1255:9: error: missing braces around initializer [-Werror\u003dmissing-braces]\n\nChanging the initializer to {} or to {{0}} resolves the problem","commit_id":"4dc4280555e69fd33b4ebe265dca876c07425d1c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"640d32fa524199c1a7695ed4cc249e334969b84b","unresolved":true,"context_lines":[{"line_number":1252,"context_line":"{"},{"line_number":1253,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_START };"},{"line_number":1254,"context_line":"\tuint32_t fired_target_num \u003d 0;"},{"line_number":1255,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM] \u003d {0};"},{"line_number":1256,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d ctx-\u003ecmd_priv;"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"\t/* get current block id */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c6f9168d_1d1c6488","line":1255,"in_reply_to":"036c08f4_baf8a3ce","updated":"2023-07-13 21:02:06.000000000","message":"Could you please submit a separate fix which we can merge in a fast track?","commit_id":"4dc4280555e69fd33b4ebe265dca876c07425d1c"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"19b20159f534318424861da4ed2d87d04e74b231","unresolved":true,"context_lines":[{"line_number":1252,"context_line":"{"},{"line_number":1253,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_START };"},{"line_number":1254,"context_line":"\tuint32_t fired_target_num \u003d 0;"},{"line_number":1255,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM] \u003d {0};"},{"line_number":1256,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d ctx-\u003ecmd_priv;"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"\t/* get current block id */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"036c08f4_baf8a3ce","line":1255,"in_reply_to":"1a7db935_ab6ebbc5","updated":"2023-07-13 20:57:09.000000000","message":"Yes. I fixed it here. Not reviewed yet. https://review.openocd.org/c/openocd/+/7761/4/src/target/espressif/esp32_apptrace.c#1278","commit_id":"4dc4280555e69fd33b4ebe265dca876c07425d1c"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"927e42fee4ab4639ae0abfea690916a085311826","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"{"},{"line_number":1253,"context_line":"\tuint8_t cmds[] \u003d { SEGGER_SYSVIEW_COMMAND_ID_START };"},{"line_number":1254,"context_line":"\tuint32_t fired_target_num \u003d 0;"},{"line_number":1255,"context_line":"\tstruct esp32_apptrace_target_state target_state[ESP32_APPTRACE_MAX_CORES_NUM] \u003d {0};"},{"line_number":1256,"context_line":"\tstruct esp32_sysview_cmd_data *cmd_data \u003d ctx-\u003ecmd_priv;"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"\t/* get current block id */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"259207af_f1ac5c7c","line":1255,"in_reply_to":"c6f9168d_1d1c6488","updated":"2023-07-13 21:02:57.000000000","message":"Yes. Sure.","commit_id":"4dc4280555e69fd33b4ebe265dca876c07425d1c"}]}