)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9852adc341aa93ec1dc11101534474c028e5ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"610d6e84_27b16d6f","updated":"2023-05-29 15:47:51.000000000","message":"Thanks for the patch. Some minor remarks below","commit_id":"35c52e5789333a7a77bb9c2fbfa5ed53dd8ebbc1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7e520f999af57b51466c5d1d0b1eab2cd817fde2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f1209e4_fe7a4976","updated":"2023-05-30 08:28:32.000000000","message":"Thanks","commit_id":"e45610394ee0102f02f9a3ae98a4677bbba4424a"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9852adc341aa93ec1dc11101534474c028e5ea7","unresolved":true,"context_lines":[{"line_number":162,"context_line":"\t\tcase DBG_REASON_NOTHALTED:"},{"line_number":163,"context_line":"\t\t\treturn 0x0;\t\t/* no signal... shouldn\u0027t happen */"},{"line_number":164,"context_line":"\t\tdefault:"},{"line_number":165,"context_line":"\t\t\tLOG_USER(\"undefined debug reason %d (%s) - target needs reset\","},{"line_number":166,"context_line":"\t\t\t\t\ttarget-\u003edebug_reason,"},{"line_number":167,"context_line":"\t\t\t\t\ttarget_debug_reason_str(target-\u003edebug_reason));"},{"line_number":168,"context_line":"\t\t\treturn 0x0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a72dceca_faa57ef2","line":165,"updated":"2023-05-29 15:47:51.000000000","message":"what about adding a LOG_TARGET_USER() in src/helper/log.h and using it here ?","commit_id":"35c52e5789333a7a77bb9c2fbfa5ed53dd8ebbc1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7e520f999af57b51466c5d1d0b1eab2cd817fde2","unresolved":false,"context_lines":[{"line_number":162,"context_line":"\t\tcase DBG_REASON_NOTHALTED:"},{"line_number":163,"context_line":"\t\t\treturn 0x0;\t\t/* no signal... shouldn\u0027t happen */"},{"line_number":164,"context_line":"\t\tdefault:"},{"line_number":165,"context_line":"\t\t\tLOG_USER(\"undefined debug reason %d (%s) - target needs reset\","},{"line_number":166,"context_line":"\t\t\t\t\ttarget-\u003edebug_reason,"},{"line_number":167,"context_line":"\t\t\t\t\ttarget_debug_reason_str(target-\u003edebug_reason));"},{"line_number":168,"context_line":"\t\t\treturn 0x0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"63a72ae5_615faf8d","line":165,"in_reply_to":"5db96294_52a08665","updated":"2023-05-30 08:28:32.000000000","message":"Ok for me!","commit_id":"35c52e5789333a7a77bb9c2fbfa5ed53dd8ebbc1"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"b5793c2a9a720995417139a61ef39977189a0512","unresolved":true,"context_lines":[{"line_number":162,"context_line":"\t\tcase DBG_REASON_NOTHALTED:"},{"line_number":163,"context_line":"\t\t\treturn 0x0;\t\t/* no signal... shouldn\u0027t happen */"},{"line_number":164,"context_line":"\t\tdefault:"},{"line_number":165,"context_line":"\t\t\tLOG_USER(\"undefined debug reason %d (%s) - target needs reset\","},{"line_number":166,"context_line":"\t\t\t\t\ttarget-\u003edebug_reason,"},{"line_number":167,"context_line":"\t\t\t\t\ttarget_debug_reason_str(target-\u003edebug_reason));"},{"line_number":168,"context_line":"\t\t\treturn 0x0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5db96294_52a08665","line":165,"in_reply_to":"a72dceca_faa57ef2","updated":"2023-05-30 06:34:46.000000000","message":"I did think of that, but there are many more places where it would be more appropriate, so I would rather do it as part of a different patch.","commit_id":"35c52e5789333a7a77bb9c2fbfa5ed53dd8ebbc1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9852adc341aa93ec1dc11101534474c028e5ea7","unresolved":true,"context_lines":[{"line_number":802,"context_line":"\t\t}"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"\t\tif (gdb_connection-\u003ectrl_c) {"},{"line_number":805,"context_line":"\t\t\tLOG_TARGET_DEBUG(target, \"Responding with signal 2 (SIGINT) \""},{"line_number":806,"context_line":"\t\t\t\t\t\"to debugger due to Ctrl-C\");"},{"line_number":807,"context_line":"\t\t\tsignal_var \u003d 0x2;"},{"line_number":808,"context_line":"\t\t} else"},{"line_number":809,"context_line":"\t\t\tsignal_var \u003d gdb_last_signal(ct);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2150f057_5d8bbab1","line":806,"range":{"start_line":805,"start_character":1,"end_line":806,"end_character":34},"updated":"2023-05-29 15:47:51.000000000","message":"Please don\u0027t split the string. OpenOCD coding style accepts till 120 char/line","commit_id":"35c52e5789333a7a77bb9c2fbfa5ed53dd8ebbc1"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"b5793c2a9a720995417139a61ef39977189a0512","unresolved":false,"context_lines":[{"line_number":802,"context_line":"\t\t}"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"\t\tif (gdb_connection-\u003ectrl_c) {"},{"line_number":805,"context_line":"\t\t\tLOG_TARGET_DEBUG(target, \"Responding with signal 2 (SIGINT) \""},{"line_number":806,"context_line":"\t\t\t\t\t\"to debugger due to Ctrl-C\");"},{"line_number":807,"context_line":"\t\t\tsignal_var \u003d 0x2;"},{"line_number":808,"context_line":"\t\t} else"},{"line_number":809,"context_line":"\t\t\tsignal_var \u003d gdb_last_signal(ct);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5bf717e2_d7ac1c92","line":806,"range":{"start_line":805,"start_character":1,"end_line":806,"end_character":34},"in_reply_to":"2150f057_5d8bbab1","updated":"2023-05-30 06:34:46.000000000","message":"Resolved, tried to avoid lines longer than 72-80 columns as recommended.","commit_id":"35c52e5789333a7a77bb9c2fbfa5ed53dd8ebbc1"}]}