)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a20b78a31883c87a6533c4fddd7393a4a5c5540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"acaa728f_99c8a628","updated":"2023-05-30 22:24:34.000000000","message":"Thanks for addressing this.\nI\u0027m not happy about all these #if/#endif, but sometimes we need them\nI would like to propose a minor modification","commit_id":"5e5b909a7a96b930ed9ed611e17f03507aa30635"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"483075cc0b0b88ad66929bd9ca91f274127d6a85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f77d01b7_3b36e4c1","updated":"2023-05-31 07:24:49.000000000","message":"Thanks for the quick review","commit_id":"5e5b909a7a96b930ed9ed611e17f03507aa30635"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8bc1ce1e658ef609df6f12d9b9413c0761a9d32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4316c370_49a462e8","updated":"2023-05-31 21:53:18.000000000","message":"Thanks","commit_id":"88cc145b2c4e687ac247b7b74c682dab928a081c"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2a20b78a31883c87a6533c4fddd7393a4a5c5540","unresolved":true,"context_lines":[{"line_number":235,"context_line":"#else"},{"line_number":236,"context_line":"\t\tif (errno \u003d\u003d EAGAIN)"},{"line_number":237,"context_line":"#endif"},{"line_number":238,"context_line":"\t\t{"},{"line_number":239,"context_line":"\t\t\t// Try again after a delay"},{"line_number":240,"context_line":"\t\t\tusleep(1000);"},{"line_number":241,"context_line":"\t\t} else {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1ab0246d_5c834024","line":238,"updated":"2023-05-30 22:24:34.000000000","message":"it\u0027s not nice to left the \"if\" statement alone in the #if/#else/#endif\nPlus the \"{\" should be with in the same line as the if.\nWhat about:\n #ifdef _WIN32\n bool retry \u003d (WSAGetLastError() \u003d\u003d WSAEWOULDBLOCK);\n #else\n bool retry \u003d (errno \u003d\u003d EAGAIN);\n #endif\n\n if (retry) {\n     // Try ...\n } else {\n     ...\n }","commit_id":"5e5b909a7a96b930ed9ed611e17f03507aa30635"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"483075cc0b0b88ad66929bd9ca91f274127d6a85","unresolved":false,"context_lines":[{"line_number":235,"context_line":"#else"},{"line_number":236,"context_line":"\t\tif (errno \u003d\u003d EAGAIN)"},{"line_number":237,"context_line":"#endif"},{"line_number":238,"context_line":"\t\t{"},{"line_number":239,"context_line":"\t\t\t// Try again after a delay"},{"line_number":240,"context_line":"\t\t\tusleep(1000);"},{"line_number":241,"context_line":"\t\t} else {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"51af10e1_773db35f","line":238,"in_reply_to":"1ab0246d_5c834024","updated":"2023-05-31 07:24:49.000000000","message":"Done","commit_id":"5e5b909a7a96b930ed9ed611e17f03507aa30635"}]}
