)]}'
{"id":"openocd~master~Iec871c4965b116dc7cfb03c3565bab66c8b41958","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-31 21:53:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2023-06-10 17:10:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iec871c4965b116dc7cfb03c3565bab66c8b41958","subject":"gdb_server: refactor and unify function gdb_get_char_inner","status":"MERGED","created":"2023-05-30 09:56:33.000000000","updated":"2023-06-10 17:10:07.000000000","submitted":"2023-06-10 17:10:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7724","meta_rev_id":"f8fc3f972372d3c45f757b810ae18726a4b5e539","_number":7724,"owner":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-10 17:10:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-06-10 17:10:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-30 10:08:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-30 22:24:34.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-05-31 21:53:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"cf73658d3645281d8226294698f23742ab193e87","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-05-30 09:56:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41f88b475494ec4fe254f3b7cc06c1e49f23c4aa","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-30 10:08:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17758/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16960/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2a20b78a31883c87a6533c4fddd7393a4a5c5540","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-30 22:24:34.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c40b1dc3bf845470dfd8a6c37ade7d2f5b794a13","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-05-31 07:23:26.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"483075cc0b0b88ad66929bd9ca91f274127d6a85","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-05-31 07:24:49.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b202f62374d3076b08ffa4acfd6c1698e7607ea5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-31 07:48:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17762/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16964/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d8bc1ce1e658ef609df6f12d9b9413c0761a9d32","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-31 21:53:18.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a44068fe4ade46c00d59b3decb1f9a7e4f094d54","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-10 17:09:57.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f8fc3f972372d3c45f757b810ae18726a4b5e539","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-10 17:10:07.000000000","message":"Change has been successfully cherry-picked as 71180e67537117f841ff5dd7c359e3678d861e2b","accounts_in_message":[],"_revision_number":3}],"current_revision":"71180e67537117f841ff5dd7c359e3678d861e2b","revisions":{"71180e67537117f841ff5dd7c359e3678d861e2b":{"kind":"REWORK","_number":3,"created":"2023-06-10 17:10:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7724/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7724/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/3 \u0026\u0026 git checkout -b change-7724 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7724/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0854c83076749196603bebdb47ec93f50a454f79","subject":"gdb_server: add debug signal reason prints"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 08:07:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-06-10 17:10:07.000000000","tz":0},"subject":"gdb_server: refactor and unify function gdb_get_char_inner","message":"gdb_server: refactor and unify function gdb_get_char_inner\n\nThe old implementation of gdb socket error handling\nin the gdb_get_char_inner() differs between Windows and *nix\nplatforms. This patch simplifies it by using an existing\nfunction log_socket_error() which handles most of the platform\nspecific things. It also provides better error messages.\n\nChange-Id: Iec871c4965b116dc7cfb03c3565bab66c8b41958\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7724\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"88cc145b2c4e687ac247b7b74c682dab928a081c":{"kind":"REWORK","_number":2,"created":"2023-05-31 07:23:26.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/24/7724/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7724/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/2 \u0026\u0026 git checkout -b change-7724 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7724/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"78688fea984b69d1986b6b730ff2935668cc9208","subject":"flash/jtagspi: sending command and setting parameters without probing."}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 08:07:18.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-31 07:20:47.000000000","tz":120},"subject":"gdb_server: refactor and unify function gdb_get_char_inner","message":"gdb_server: refactor and unify function gdb_get_char_inner\n\nThe old implementation of gdb socket error handling\nin the gdb_get_char_inner() differs between Windows and *nix\nplatforms. This patch simplifies it by using an existing\nfunction log_socket_error() which handles most of the platform\nspecific things. It also provides better error messages.\n\nChange-Id: Iec871c4965b116dc7cfb03c3565bab66c8b41958\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"5e5b909a7a96b930ed9ed611e17f03507aa30635":{"kind":"REWORK","_number":1,"created":"2023-05-30 09:56:33.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/24/7724/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7724/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/1 \u0026\u0026 git checkout -b change-7724 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7724/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7724/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"78688fea984b69d1986b6b730ff2935668cc9208","subject":"flash/jtagspi: sending command and setting parameters without probing."}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 08:07:18.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 08:41:14.000000000","tz":120},"subject":"gdb_server: refactor and unify function gdb_get_char_inner","message":"gdb_server: refactor and unify function gdb_get_char_inner\n\nThe old implementation of gdb socket error handling\nin the gdb_get_char_inner() differs between Windows and *nix\nplatforms. This patch simplifies it by using an existing\nfunction log_socket_error() which handles most of the platform\nspecific things. It also provides better error messages.\n\nChange-Id: Iec871c4965b116dc7cfb03c3565bab66c8b41958\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}