)]}'
{"id":"openocd~master~I9bc4f3cb82370812825d52419851910b3e3f35cc","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2023-06-10 17:10:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9bc4f3cb82370812825d52419851910b3e3f35cc","subject":"semihosting: fix non-zero value on Windows isatty()","status":"MERGED","created":"2023-05-30 12:19:09.000000000","updated":"2023-06-10 17:10:27.000000000","submitted":"2023-06-10 17:10:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7725","meta_rev_id":"b2d53677f9c626e54f76ece7e3af36eabe6620dc","_number":7725,"owner":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-10 17:10:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-10 17:10:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-06-10 17:10:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-30 12:31:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-30 21:46:34.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-05-31 05:06:52.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"}],"messages":[{"id":"fcc260922c718331ad5a2b1c290c5e80adacd0b7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2023-05-30 12:19:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d1bf74f87eda8ce3ac1083f8a0c749249f1e9103","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-30 12:31:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17759/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16961/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c5ec60698a529fdc3e8877803adc1098700845f4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-30 21:46:34.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d05c59384906c59b2363d893017f72099594f2c3","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-05-31 05:06:52.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0191d7ca9d83efd0d98391fd96395a0b22a89cfa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-10 17:10:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b2d53677f9c626e54f76ece7e3af36eabe6620dc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-10 17:10:27.000000000","message":"Change has been successfully cherry-picked as 9f23a1d7c1e27c556ef9787b9d3f263f5c1ecf24","accounts_in_message":[],"_revision_number":2}],"current_revision":"9f23a1d7c1e27c556ef9787b9d3f263f5c1ecf24","revisions":{"168741426a68fa086fbae4b3d59a5e0eaffebdb5":{"kind":"REWORK","_number":1,"created":"2023-05-30 12:19:09.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/25/7725/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/7725/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/1 \u0026\u0026 git checkout -b change-7725 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/7725/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"78688fea984b69d1986b6b730ff2935668cc9208","subject":"flash/jtagspi: sending command and setting parameters without probing."}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 12:16:38.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 12:16:38.000000000","tz":120},"subject":"semihosting: fix non-zero value on Windows isatty()","message":"semihosting: fix non-zero value on Windows isatty()\n\nOn Windows, isatty() can return any non-zero value if it\u0027s an interactive\ndevice. Which diverges from the ARM semihosting specification. This patch\nintroduces a fix to make the SYS_ISTTY operation conform to spec.\n\nChange-Id: I9bc4f3cb82370812825d52419851910b3e3f35cc\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"9f23a1d7c1e27c556ef9787b9d3f263f5c1ecf24":{"kind":"REWORK","_number":2,"created":"2023-06-10 17:10:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/7725/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/7725/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/2 \u0026\u0026 git checkout -b change-7725 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/7725/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/7725/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"71180e67537117f841ff5dd7c359e3678d861e2b","subject":"gdb_server: refactor and unify function gdb_get_char_inner"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2023-05-30 12:16:38.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-06-10 17:10:27.000000000","tz":0},"subject":"semihosting: fix non-zero value on Windows isatty()","message":"semihosting: fix non-zero value on Windows isatty()\n\nOn Windows, isatty() can return any non-zero value if it\u0027s an interactive\ndevice. Which diverges from the ARM semihosting specification. This patch\nintroduces a fix to make the SYS_ISTTY operation conform to spec.\n\nChange-Id: I9bc4f3cb82370812825d52419851910b3e3f35cc\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7725\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}