)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"09e42bb8923be551c98da275a4c954c02cba5f7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"240b79a8_b1fb5772","updated":"2023-06-07 19:32:48.000000000","message":"Thanks for your patience.","commit_id":"c23cd9725f8301007ab4463487fcbd141ee6e3d5"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"b63efed27731ed0a6fa9d6da3cd78cc5a957b1ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f158d84e_9515299d","updated":"2023-06-19 22:05:40.000000000","message":"Thanks for your patience!","commit_id":"38676e386dbf22086042380dc4925d60fef6264a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c9bc930ee3cbe63d1295beb44d19b00c75a61656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2ac9008f_16bb5aad","updated":"2023-06-24 18:53:32.000000000","message":"Thanks.\nSome minor remark here and there but, in general, good!","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"cef1f18f24b0934d5140ff39b4bc14436883fc1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a79b3d9_ffc968e9","updated":"2023-06-24 21:02:11.000000000","message":"thanks for taking time to review","commit_id":"d9a002b4e2908ee6d1e6136680c814d663c2bfe7"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"c6892077a87a8c3af1cc4e3d1f3a49274d7cd2c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8e46bca2_bea020b6","updated":"2023-07-03 09:11:20.000000000","message":"Thanks for your help!","commit_id":"78613354f54eb94263e26a7d3e6bb0c47f10dc2e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dabdb5959fcd4c94bcbab6fd481e598345c3ffa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c1616e91_6341ea4d","updated":"2023-06-25 00:27:15.000000000","message":"thanks!","commit_id":"78613354f54eb94263e26a7d3e6bb0c47f10dc2e"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c1fb9fae9a1d95bff6820aec118af136287fe540","unresolved":true,"context_lines":[{"line_number":8469,"context_line":"The number and the device names are shown by the @command{pld devices} command."},{"line_number":8470,"context_line":"New PLDs are defined by @command{pld device driver_name device_name}."},{"line_number":8471,"context_line":""},{"line_number":8472,"context_line":"@deffn {Config Command} {pld device} driver_name device name [driver_options]"},{"line_number":8473,"context_line":"Defines a new PLD device, supported by driver @var{driver_name},"},{"line_number":8474,"context_line":"assigning @var{device_name} for further reference."},{"line_number":8475,"context_line":"The driver may make use of any @var{driver_options} to configure its"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"886b4833_7cfd82e3","line":8472,"updated":"2023-06-04 16:21:09.000000000","message":"You are changing the command syntax and all the existing files.cfg. This requires adding a way to deprecate the old command syntax to make old scripts still working by adding an helper in src/jtag/startup.tcl. See the other deprecated commands there.\nSo if you think this is needed, let\u0027s take some time to define the new syntax once for all.\nShould we use here the same syntax as \"target create\"?\n@deffn {Config Command} {pld create} pld_name driver -chain-position tap_name [options]\nso we can easily deprecate the command \"pld device\"?\nThe flag \"-chain-position tap_name\" can be at fixed position, so there is no need to change too much code\nThe possible [options] are \"no_jstart\", that can become \"-no_jstart\", and the family.\nFor the family, what\u0027s better, adding a \"-family\" flag or putting it in the driver name (e.g. \"lattice_ecp2\")?","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"09e42bb8923be551c98da275a4c954c02cba5f7b","unresolved":true,"context_lines":[{"line_number":8469,"context_line":"The number and the device names are shown by the @command{pld devices} command."},{"line_number":8470,"context_line":"New PLDs are defined by @command{pld device driver_name device_name}."},{"line_number":8471,"context_line":""},{"line_number":8472,"context_line":"@deffn {Config Command} {pld device} driver_name device name [driver_options]"},{"line_number":8473,"context_line":"Defines a new PLD device, supported by driver @var{driver_name},"},{"line_number":8474,"context_line":"assigning @var{device_name} for further reference."},{"line_number":8475,"context_line":"The driver may make use of any @var{driver_options} to configure its"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"beb1a2ce_eecc1f0d","line":8472,"in_reply_to":"886b4833_7cfd82e3","updated":"2023-06-07 19:32:48.000000000","message":"I tried to follow your adivces, thanks.\n\u0027-no_jstart\u0027 and \u0027-family\u0027 is not implemented yet. Also not tested yet.\nI\u0027d like to add a \u0027-family\u0027 flag (intel and lattice only)","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"b63efed27731ed0a6fa9d6da3cd78cc5a957b1ca","unresolved":false,"context_lines":[{"line_number":8469,"context_line":"The number and the device names are shown by the @command{pld devices} command."},{"line_number":8470,"context_line":"New PLDs are defined by @command{pld device driver_name device_name}."},{"line_number":8471,"context_line":""},{"line_number":8472,"context_line":"@deffn {Config Command} {pld device} driver_name device name [driver_options]"},{"line_number":8473,"context_line":"Defines a new PLD device, supported by driver @var{driver_name},"},{"line_number":8474,"context_line":"assigning @var{device_name} for further reference."},{"line_number":8475,"context_line":"The driver may make use of any @var{driver_options} to configure its"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"40b532eb_d19840dc","line":8472,"in_reply_to":"beb1a2ce_eecc1f0d","updated":"2023-06-19 22:05:40.000000000","message":"I hope this is according to your expectations.\n\nThe helper in src/jtag/startup.tcl was added and tested with an intel/cyclone3 device (-family), a xilinx/spartan device (-no_jstart) and a gowin gw1n (no special option).\n\nI think this is this is ready for review now.","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c1fb9fae9a1d95bff6820aec118af136287fe540","unresolved":true,"context_lines":[{"line_number":8477,"context_line":"@end deffn"},{"line_number":8478,"context_line":""},{"line_number":8479,"context_line":"@deffn {Command} {pld devices}"},{"line_number":8480,"context_line":"Lists the PLDs and their numbers and names."},{"line_number":8481,"context_line":"@end deffn"},{"line_number":8482,"context_line":""},{"line_number":8483,"context_line":"@deffn {Command} {pld load} num|name filename"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"91193b1a_8cd44ace","line":8480,"updated":"2023-06-04 16:21:09.000000000","message":"Maybe:\nList the known PLDs with their number and name.","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"09e42bb8923be551c98da275a4c954c02cba5f7b","unresolved":false,"context_lines":[{"line_number":8477,"context_line":"@end deffn"},{"line_number":8478,"context_line":""},{"line_number":8479,"context_line":"@deffn {Command} {pld devices}"},{"line_number":8480,"context_line":"Lists the PLDs and their numbers and names."},{"line_number":8481,"context_line":"@end deffn"},{"line_number":8482,"context_line":""},{"line_number":8483,"context_line":"@deffn {Command} {pld load} num|name filename"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"262b58e2_9b9cceb4","line":8480,"in_reply_to":"91193b1a_8cd44ace","updated":"2023-06-07 19:32:48.000000000","message":"Done","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c9bc930ee3cbe63d1295beb44d19b00c75a61656","unresolved":true,"context_lines":[{"line_number":8591,"context_line":"List the known PLDs with their number and name."},{"line_number":8592,"context_line":"@end deffn"},{"line_number":8593,"context_line":""},{"line_number":8594,"context_line":"@deffn {Command} {pld load} num|pld_name filename"},{"line_number":8595,"context_line":"Loads the file @file{filename} into the PLD identified by @var{num} or @var{pld_name}."},{"line_number":8596,"context_line":"The file format must be inferred by the driver."},{"line_number":8597,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"b64cdfde_b10b506a","line":8594,"updated":"2023-06-24 18:53:32.000000000","message":"in file src/pld/pld.c the use of \u0027num\u0027 gets deprecated.\nWe use to not document deprecated commands and options to prevent new users to use them.\nHere and below, plus in all command\u0027s \u0027.usage\u0027, the \u0027num\u0027 and \u0027pld_num\u0027 should disappear.","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"cef1f18f24b0934d5140ff39b4bc14436883fc1f","unresolved":false,"context_lines":[{"line_number":8591,"context_line":"List the known PLDs with their number and name."},{"line_number":8592,"context_line":"@end deffn"},{"line_number":8593,"context_line":""},{"line_number":8594,"context_line":"@deffn {Command} {pld load} num|pld_name filename"},{"line_number":8595,"context_line":"Loads the file @file{filename} into the PLD identified by @var{num} or @var{pld_name}."},{"line_number":8596,"context_line":"The file format must be inferred by the driver."},{"line_number":8597,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"808b2c84_21a99201","line":8594,"in_reply_to":"b64cdfde_b10b506a","updated":"2023-06-24 21:02:11.000000000","message":"Done","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c9bc930ee3cbe63d1295beb44d19b00c75a61656","unresolved":true,"context_lines":[{"line_number":8672,"context_line":""},{"line_number":8673,"context_line":"Creates a new PLD device, an FPGA of the Cyclone III family, using the TAP named @verb{|cycloneiii.tap|}:"},{"line_number":8674,"context_line":"@example"},{"line_number":8675,"context_line":"pld create cycloneiii.pld intel -chain-position cycloneiii.tap cycloneiii"},{"line_number":8676,"context_line":"@end example"},{"line_number":8677,"context_line":""},{"line_number":8678,"context_line":"@deffn {Command} {intel set_bscan} num|pld_name len"}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"5681efc4_2975e22b","line":8675,"updated":"2023-06-24 18:53:32.000000000","message":"should be \u0027-family cycloneiii\u0027 ?","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"cef1f18f24b0934d5140ff39b4bc14436883fc1f","unresolved":false,"context_lines":[{"line_number":8672,"context_line":""},{"line_number":8673,"context_line":"Creates a new PLD device, an FPGA of the Cyclone III family, using the TAP named @verb{|cycloneiii.tap|}:"},{"line_number":8674,"context_line":"@example"},{"line_number":8675,"context_line":"pld create cycloneiii.pld intel -chain-position cycloneiii.tap cycloneiii"},{"line_number":8676,"context_line":"@end example"},{"line_number":8677,"context_line":""},{"line_number":8678,"context_line":"@deffn {Command} {intel set_bscan} num|pld_name len"}],"source_content_type":"text/x-texinfo","patch_set":4,"id":"ac162ead_ced12490","line":8675,"in_reply_to":"5681efc4_2975e22b","updated":"2023-06-24 21:02:11.000000000","message":"Done","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"}],"src/pld/gowin.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c1fb9fae9a1d95bff6820aec118af136287fe540","unresolved":true,"context_lines":[{"line_number":509,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":510,"context_line":"\t\t.handler \u003d gowin_read_status_command_handler,"},{"line_number":511,"context_line":"\t\t.help \u003d \"reading status register from FPGA\","},{"line_number":512,"context_line":"\t\t.usage \u003d \"num_pld\","},{"line_number":513,"context_line":"\t}, {"},{"line_number":514,"context_line":"\t\t.name \u003d \"read_user\","},{"line_number":515,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e4bc187c_fa1faadf","line":512,"updated":"2023-06-04 16:21:09.000000000","message":"or pld_name\nAlso below","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"09e42bb8923be551c98da275a4c954c02cba5f7b","unresolved":false,"context_lines":[{"line_number":509,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":510,"context_line":"\t\t.handler \u003d gowin_read_status_command_handler,"},{"line_number":511,"context_line":"\t\t.help \u003d \"reading status register from FPGA\","},{"line_number":512,"context_line":"\t\t.usage \u003d \"num_pld\","},{"line_number":513,"context_line":"\t}, {"},{"line_number":514,"context_line":"\t\t.name \u003d \"read_user\","},{"line_number":515,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4300ac75_ce425d27","line":512,"in_reply_to":"e4bc187c_fa1faadf","updated":"2023-06-07 19:32:48.000000000","message":"Done","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"477cb325270da5cff80240bdbbae0e8e1598c083","unresolved":true,"context_lines":[{"line_number":509,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":510,"context_line":"\t\t.handler \u003d gowin_read_status_command_handler,"},{"line_number":511,"context_line":"\t\t.help \u003d \"reading status register from FPGA\","},{"line_number":512,"context_line":"\t\t.usage \u003d \"pld_num|pld_name\","},{"line_number":513,"context_line":"\t}, {"},{"line_number":514,"context_line":"\t\t.name \u003d \"read_user\","},{"line_number":515,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"b6ef6832_852e81e4","line":512,"updated":"2023-06-24 23:50:43.000000000","message":"please drop \u0027pld_num\u0027 here, in next commands below and in the other files","commit_id":"eb8753141d69a5dc17c586cb44b14f2693bb3571"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"e200162aa47a32fe3737d7a47603fba86d37ccb3","unresolved":false,"context_lines":[{"line_number":509,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":510,"context_line":"\t\t.handler \u003d gowin_read_status_command_handler,"},{"line_number":511,"context_line":"\t\t.help \u003d \"reading status register from FPGA\","},{"line_number":512,"context_line":"\t\t.usage \u003d \"pld_num|pld_name\","},{"line_number":513,"context_line":"\t}, {"},{"line_number":514,"context_line":"\t\t.name \u003d \"read_user\","},{"line_number":515,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"329dfd40_dedc853f","line":512,"in_reply_to":"b6ef6832_852e81e4","updated":"2023-06-25 00:09:09.000000000","message":"Done","commit_id":"eb8753141d69a5dc17c586cb44b14f2693bb3571"}],"src/pld/intel.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c1fb9fae9a1d95bff6820aec118af136287fe540","unresolved":true,"context_lines":[{"line_number":440,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":441,"context_line":"\t\t.handler \u003d intel_set_bscan_command_handler,"},{"line_number":442,"context_line":"\t\t.help \u003d \"set boundary scan register length of FPGA\","},{"line_number":443,"context_line":"\t\t.usage \u003d \"num_pld len\","},{"line_number":444,"context_line":"\t}, {"},{"line_number":445,"context_line":"\t\t.name \u003d \"set_check_pos\","},{"line_number":446,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7689d427_6cb812da","line":443,"updated":"2023-06-04 16:21:09.000000000","message":"or pld_name\nalso below","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"09e42bb8923be551c98da275a4c954c02cba5f7b","unresolved":false,"context_lines":[{"line_number":440,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":441,"context_line":"\t\t.handler \u003d intel_set_bscan_command_handler,"},{"line_number":442,"context_line":"\t\t.help \u003d \"set boundary scan register length of FPGA\","},{"line_number":443,"context_line":"\t\t.usage \u003d \"num_pld len\","},{"line_number":444,"context_line":"\t}, {"},{"line_number":445,"context_line":"\t\t.name \u003d \"set_check_pos\","},{"line_number":446,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"31fe0de4_702afd54","line":443,"in_reply_to":"7689d427_6cb812da","updated":"2023-06-07 19:32:48.000000000","message":"Done","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"}],"src/pld/pld.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c1fb9fae9a1d95bff6820aec118af136287fe540","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\tfor (p \u003d pld_devices; p; p \u003d p-\u003enext) {"},{"line_number":37,"context_line":"\t\tif (i++ \u003d\u003d num)"},{"line_number":38,"context_line":"\t\t\treturn p;"},{"line_number":39,"context_line":"\t}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cfb9028c_1273a0b4","line":38,"updated":"2023-06-04 16:21:09.000000000","message":"we could add here a warning\n\"DEPRECATED: use pld name \\\"%s\\\" instead of number %d\", p-\u003ename, i\nand after some versions of OpenOCD drop the use of numbers","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"09e42bb8923be551c98da275a4c954c02cba5f7b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\tfor (p \u003d pld_devices; p; p \u003d p-\u003enext) {"},{"line_number":37,"context_line":"\t\tif (i++ \u003d\u003d num)"},{"line_number":38,"context_line":"\t\t\treturn p;"},{"line_number":39,"context_line":"\t}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"38141502_ad81ead3","line":38,"in_reply_to":"cfb9028c_1273a0b4","updated":"2023-06-07 19:32:48.000000000","message":"Done","commit_id":"31b528362e4f2074a902cb02697d3c329236429b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c9bc930ee3cbe63d1295beb44d19b00c75a61656","unresolved":true,"context_lines":[{"line_number":90,"context_line":"\t\treturn ERROR_FAIL; /* exit(-1); */"},{"line_number":91,"context_line":"\t}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\t/* register pld specific commands */"},{"line_number":94,"context_line":"\tint retval;"},{"line_number":95,"context_line":"\tif (pld_driver-\u003ecommands) {"},{"line_number":96,"context_line":"\t\tretval \u003d register_commands(CMD_CTX, NULL, pld_driver-\u003ecommands);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"7f95bfab_e185149c","line":93,"updated":"2023-06-24 18:53:32.000000000","message":"we do not unregister the commands in case of late failure and exit.\nMaybe the easier way is to move this command registration later in this function so no need to unregister the commands","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"cef1f18f24b0934d5140ff39b4bc14436883fc1f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t\treturn ERROR_FAIL; /* exit(-1); */"},{"line_number":91,"context_line":"\t}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\t/* register pld specific commands */"},{"line_number":94,"context_line":"\tint retval;"},{"line_number":95,"context_line":"\tif (pld_driver-\u003ecommands) {"},{"line_number":96,"context_line":"\t\tretval \u003d register_commands(CMD_CTX, NULL, pld_driver-\u003ecommands);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"70819fe2_be9f9354","line":93,"in_reply_to":"7f95bfab_e185149c","updated":"2023-06-24 21:02:11.000000000","message":"Done","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b397273a964dd05b9070fcc5d9a4668ed8f5bc36","unresolved":true,"context_lines":[{"line_number":129,"context_line":"\t\tpld_devices \u003d pld_device;"},{"line_number":130,"context_line":"\t}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t/* register pld specific commands */"},{"line_number":133,"context_line":"\tif (pld_driver-\u003ecommands) {"},{"line_number":134,"context_line":"\t\tretval \u003d register_commands(CMD_CTX, NULL, pld_driver-\u003ecommands);"},{"line_number":135,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1f6bce1a_84482e78","line":132,"updated":"2023-06-24 22:31:41.000000000","message":"too late, here the pld_device is already added to pld_devices and in case of error you need to remove it.\nInstead move this block at line 120, and on error free() both pld_device-\u003ename and pld_device","commit_id":"d9a002b4e2908ee6d1e6136680c814d663c2bfe7"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"e200162aa47a32fe3737d7a47603fba86d37ccb3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"\t\tpld_devices \u003d pld_device;"},{"line_number":130,"context_line":"\t}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t/* register pld specific commands */"},{"line_number":133,"context_line":"\tif (pld_driver-\u003ecommands) {"},{"line_number":134,"context_line":"\t\tretval \u003d register_commands(CMD_CTX, NULL, pld_driver-\u003ecommands);"},{"line_number":135,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1c07dba9_db74d4d3","line":132,"in_reply_to":"1f6bce1a_84482e78","updated":"2023-06-25 00:09:09.000000000","message":"Done","commit_id":"d9a002b4e2908ee6d1e6136680c814d663c2bfe7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"477cb325270da5cff80240bdbbae0e8e1598c083","unresolved":false,"context_lines":[{"line_number":129,"context_line":"\t\tpld_devices \u003d pld_device;"},{"line_number":130,"context_line":"\t}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t/* register pld specific commands */"},{"line_number":133,"context_line":"\tif (pld_driver-\u003ecommands) {"},{"line_number":134,"context_line":"\t\tretval \u003d register_commands(CMD_CTX, NULL, pld_driver-\u003ecommands);"},{"line_number":135,"context_line":"\t\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"45457ad0_ea057c90","line":132,"in_reply_to":"1f6bce1a_84482e78","updated":"2023-06-24 23:50:43.000000000","message":"Done","commit_id":"d9a002b4e2908ee6d1e6136680c814d663c2bfe7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"477cb325270da5cff80240bdbbae0e8e1598c083","unresolved":true,"context_lines":[{"line_number":111,"context_line":"\t\tfree(pld_device);"},{"line_number":112,"context_line":"\t\treturn ERROR_OK;"},{"line_number":113,"context_line":"\t}"},{"line_number":114,"context_line":"\tpld_device-\u003ename \u003d alloc_printf(\"%s\", CMD_ARGV[0]);"},{"line_number":115,"context_line":"\tif (!pld_device-\u003ename) {"},{"line_number":116,"context_line":"\t\tLOG_ERROR(\"Out of memory\");"},{"line_number":117,"context_line":"\t\tfree(pld_device);"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"beb409c9_fa9fe6e6","line":114,"updated":"2023-06-24 23:50:43.000000000","message":"strdup() is enough, no need for alloc_printf()","commit_id":"eb8753141d69a5dc17c586cb44b14f2693bb3571"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"e200162aa47a32fe3737d7a47603fba86d37ccb3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"\t\tfree(pld_device);"},{"line_number":112,"context_line":"\t\treturn ERROR_OK;"},{"line_number":113,"context_line":"\t}"},{"line_number":114,"context_line":"\tpld_device-\u003ename \u003d alloc_printf(\"%s\", CMD_ARGV[0]);"},{"line_number":115,"context_line":"\tif (!pld_device-\u003ename) {"},{"line_number":116,"context_line":"\t\tLOG_ERROR(\"Out of memory\");"},{"line_number":117,"context_line":"\t\tfree(pld_device);"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"cc2e5741_11c21ed8","line":114,"in_reply_to":"beb409c9_fa9fe6e6","updated":"2023-06-25 00:09:09.000000000","message":"Done","commit_id":"eb8753141d69a5dc17c586cb44b14f2693bb3571"}],"tcl/target/zynq_7000.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c9bc930ee3cbe63d1295beb44d19b00c75a61656","unresolved":true,"context_lines":[{"line_number":46,"context_line":"${_TARGETNAME}0 configure -event reset-assert-post \"cortex_a dbginit\""},{"line_number":47,"context_line":"${_TARGETNAME}1 configure -event reset-assert-post \"cortex_a dbginit\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"pld create zynq_pl.pld virtex2 -chain-position zynq_pl.bs 1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"set XC7_JSHUTDOWN 0x0d"},{"line_number":52,"context_line":"set XC7_JPROGRAM 0x0b"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"4dabc2fd_e9a6e736","line":49,"updated":"2023-06-24 18:53:32.000000000","message":"s/1/-no_jstart/ ?","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"cef1f18f24b0934d5140ff39b4bc14436883fc1f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"${_TARGETNAME}0 configure -event reset-assert-post \"cortex_a dbginit\""},{"line_number":47,"context_line":"${_TARGETNAME}1 configure -event reset-assert-post \"cortex_a dbginit\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"pld create zynq_pl.pld virtex2 -chain-position zynq_pl.bs 1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"set XC7_JSHUTDOWN 0x0d"},{"line_number":52,"context_line":"set XC7_JPROGRAM 0x0b"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"9fdef375_eafdbf57","line":49,"in_reply_to":"4dabc2fd_e9a6e736","updated":"2023-06-24 21:02:11.000000000","message":"Done","commit_id":"b91d627a7f1af21298f13f58c403f60949ec135f"}]}