)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"1eae3e6c57ed38e7eed65e7b662cc75477393967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2e5dfa7_1c1369a3","updated":"2023-06-06 05:25:15.000000000","message":"Note: This merge request fixes the errno handling in semihosting, as discussed in past here: https://review.openocd.org/c/openocd/+/6292/2#message-375b4b372857e9003ba3b834da368237d0bd65fb","commit_id":"ee641dadcd4e950c648f05700d08b71d69282fdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f2cd4fccee64745898376c47d84e80e0fe6663cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86bfc89e_abcb6cec","updated":"2023-06-18 22:47:22.000000000","message":"Thanks for this patch.\nWould you mind clarifying why int32_t?","commit_id":"e50a9bcf4e5ea8f411f64a7ba40b7f9f31ea1cfb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6b04447366603670b554017b8acd2fb24c37ccd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44ff7198_96fa5055","updated":"2023-06-21 09:06:37.000000000","message":"thanks","commit_id":"7ed0b5c9800e104f74c37cccf4517846723347b3"}],"src/target/semihosting_common.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f2cd4fccee64745898376c47d84e80e0fe6663cb","unresolved":true,"context_lines":[{"line_number":898,"context_line":"\t\t\t\t\t\t\t * - 0-3 (\"r\") for stdin,"},{"line_number":899,"context_line":"\t\t\t\t\t\t\t * - 4-7 (\"w\") for stdout,"},{"line_number":900,"context_line":"\t\t\t\t\t\t\t * - 8-11 (\"a\") for stderr */"},{"line_number":901,"context_line":"\t\t\t\t\t\t\tint32_t fd;"},{"line_number":902,"context_line":"\t\t\t\t\t\t\tif (mode \u003c 4) {"},{"line_number":903,"context_line":"\t\t\t\t\t\t\t\tfd \u003d dup(STDIN_FILENO);"},{"line_number":904,"context_line":"\t\t\t\t\t\t\t\tsemihosting-\u003estdin_fd \u003d fd;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6f544ef9_922a3e63","line":901,"updated":"2023-06-18 22:47:22.000000000","message":"why int32_t?\nThe XXX_FILENO are int, and also semihosting-\u003estdXX_fd.\nWe use int32_t only when it has to match with a 32 bit field on the targets.","commit_id":"e50a9bcf4e5ea8f411f64a7ba40b7f9f31ea1cfb"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"562848bd3d1ac3450c67e4bd508d51e42da57bac","unresolved":false,"context_lines":[{"line_number":898,"context_line":"\t\t\t\t\t\t\t * - 0-3 (\"r\") for stdin,"},{"line_number":899,"context_line":"\t\t\t\t\t\t\t * - 4-7 (\"w\") for stdout,"},{"line_number":900,"context_line":"\t\t\t\t\t\t\t * - 8-11 (\"a\") for stderr */"},{"line_number":901,"context_line":"\t\t\t\t\t\t\tint32_t fd;"},{"line_number":902,"context_line":"\t\t\t\t\t\t\tif (mode \u003c 4) {"},{"line_number":903,"context_line":"\t\t\t\t\t\t\t\tfd \u003d dup(STDIN_FILENO);"},{"line_number":904,"context_line":"\t\t\t\t\t\t\t\tsemihosting-\u003estdin_fd \u003d fd;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5342d221_651b1aa3","line":901,"in_reply_to":"6f544ef9_922a3e63","updated":"2023-06-20 10:46:27.000000000","message":"You are correct, it should be int. Thanks for noticing.","commit_id":"e50a9bcf4e5ea8f411f64a7ba40b7f9f31ea1cfb"}]}