)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"1aac7c1646b4e8e9b9156e094074f3f26571c904","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"register: refactor register_cache_invalidate()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactor_cache_invalidate() is written a way which uses"},{"line_number":10,"context_line":"pointer arithmetic, which makes it harder to read. This patch"},{"line_number":11,"context_line":"replaces it with more readable way to iterate over array of"},{"line_number":12,"context_line":"structs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"977c0ef2_5e463239","line":9,"updated":"2023-06-07 06:21:23.000000000","message":"There\u0027s a little typo, it should be: register_cache_invalidate()","commit_id":"5e51bfcb603123bf8ed3d8c248978d802c3cbd2d"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"b89ede0f1d99e669afc6a32b45925334e420aff1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"register: refactor register_cache_invalidate()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactor_cache_invalidate() is written a way which uses"},{"line_number":10,"context_line":"pointer arithmetic, which makes it harder to read. This patch"},{"line_number":11,"context_line":"replaces it with more readable way to iterate over array of"},{"line_number":12,"context_line":"structs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7011fb6c_92a85a82","line":9,"in_reply_to":"977c0ef2_5e463239","updated":"2023-06-07 10:24:26.000000000","message":"Done","commit_id":"5e51bfcb603123bf8ed3d8c248978d802c3cbd2d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"4118b4b84079119b7dd1073c6f984db62a6ac0d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d7294d8_d45e34ae","updated":"2023-06-07 06:20:24.000000000","message":"Already reviewed internally - looks good.","commit_id":"5e51bfcb603123bf8ed3d8c248978d802c3cbd2d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"6c2cfc72a16a5d19dcc1535a146f51ee1deb8e22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b42b12b2_924a7599","updated":"2023-07-24 07:26:14.000000000","message":"Thanks!","commit_id":"798d33eab80cbc988d66910dec86e40d7cecd930"}],"src/target/register.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"02ae7d7fdc0869d8ecdb231e3a668af1d90788cc","unresolved":true,"context_lines":[{"line_number":93,"context_line":"/** Marks the contents of the register cache as invalid (and clean). */"},{"line_number":94,"context_line":"void register_cache_invalidate(struct reg_cache *cache)"},{"line_number":95,"context_line":"{"},{"line_number":96,"context_line":"\tfor (size_t n \u003d 0; n \u003c cache-\u003enum_regs; n++) {"},{"line_number":97,"context_line":"\t\tstruct reg *reg \u003d \u0026cache-\u003ereg_list[n];"},{"line_number":98,"context_line":"\t\tif (!reg-\u003eexist)"},{"line_number":99,"context_line":"\t\t\tcontinue;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"46ed5f48_c2492e41","line":96,"range":{"start_line":96,"start_character":6,"end_line":96,"end_character":12},"updated":"2023-07-24 05:45:46.000000000","message":"Do NOT use size_t as a shortcut for unsigned int.\nOn some hosts size_t is bigger, certainly not necessary here.","commit_id":"334481ba2f4aca00de923eb257a46cf71c4d4ae1"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"601db74e7823c0a15ee71135017331262621fe61","unresolved":false,"context_lines":[{"line_number":93,"context_line":"/** Marks the contents of the register cache as invalid (and clean). */"},{"line_number":94,"context_line":"void register_cache_invalidate(struct reg_cache *cache)"},{"line_number":95,"context_line":"{"},{"line_number":96,"context_line":"\tfor (size_t n \u003d 0; n \u003c cache-\u003enum_regs; n++) {"},{"line_number":97,"context_line":"\t\tstruct reg *reg \u003d \u0026cache-\u003ereg_list[n];"},{"line_number":98,"context_line":"\t\tif (!reg-\u003eexist)"},{"line_number":99,"context_line":"\t\t\tcontinue;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"efc43711_24ca2e24","line":96,"range":{"start_line":96,"start_character":6,"end_line":96,"end_character":12},"in_reply_to":"46ed5f48_c2492e41","updated":"2023-07-24 07:10:37.000000000","message":"I did use size_t as it was used to access an array.\n\nI changed it to unsigned int in the new version.\n\nThanks for the review.","commit_id":"334481ba2f4aca00de923eb257a46cf71c4d4ae1"}]}
