)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"962ec25fe30b150177e5bed596a5826e0d259935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b38530cd_d58b1de4","updated":"2023-06-18 23:17:36.000000000","message":"Thanks for the patch.\nI prefer keeping poll outside aarch64_init_debug_access() to match function name and its behavior","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"12b31d82361793b470b47c3dc9d5718a0db6b1ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6cd73f14_435716d0","updated":"2023-08-05 08:18:18.000000000","message":"thanks","commit_id":"059d1c39dd61f581155c1fb7613a9c7bc9b0b539"}],"src/target/aarch64.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"962ec25fe30b150177e5bed596a5826e0d259935","unresolved":true,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"\t/* Since this is likely called from init or reset, update target state information */"},{"line_number":241,"context_line":"\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":242,"context_line":"\t\tretval \u003d aarch64_poll(target);"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"\treturn retval;"},{"line_number":245,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"67d07917_e59333fd","line":242,"updated":"2023-06-18 23:17:36.000000000","message":"I haven\u0027t checked the other targets, but I prefer keeping aarch64_init_debug_access() not polling the targets to match the name of the function.\nPoll should be added where we need it.","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"923b11de6f91bee02e9b349f0ec8fa0404032448","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"\t/* Since this is likely called from init or reset, update target state information */"},{"line_number":241,"context_line":"\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":242,"context_line":"\t\tretval \u003d aarch64_poll(target);"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"\treturn retval;"},{"line_number":245,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"27c7f1e6_6f178545","line":242,"in_reply_to":"67d07917_e59333fd","updated":"2023-08-12 16:47:05.000000000","message":"Done","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"962ec25fe30b150177e5bed596a5826e0d259935","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"\tif (!target_was_examined(target))"},{"line_number":2004,"context_line":"\t\treturn ERROR_OK;"},{"line_number":2005,"context_line":""},{"line_number":2006,"context_line":"\tretval \u003d aarch64_init_debug_access(target);"},{"line_number":2007,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":2008,"context_line":"\t\treturn retval;"},{"line_number":2009,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a4331b1b_c06dfe90","line":2006,"updated":"2023-06-18 23:17:36.000000000","message":"This aarch64_init_debug_access() is already followed by aarch64_poll(), nothing to add here","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"962ec25fe30b150177e5bed596a5826e0d259935","unresolved":true,"context_lines":[{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"\t/* Configure core debug access */"},{"line_number":2702,"context_line":"\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":2703,"context_line":"\t\tretval \u003d aarch64_init_debug_access(target);"},{"line_number":2704,"context_line":""},{"line_number":2705,"context_line":"\treturn retval;"},{"line_number":2706,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dc859417_f947f93e","line":2703,"updated":"2023-06-18 23:17:36.000000000","message":"here should eventually be added the poll.\nIt would diverge from the other targets that don\u0027t have poll, but I think we need to update all of them","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"923b11de6f91bee02e9b349f0ec8fa0404032448","unresolved":false,"context_lines":[{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"\t/* Configure core debug access */"},{"line_number":2702,"context_line":"\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":2703,"context_line":"\t\tretval \u003d aarch64_init_debug_access(target);"},{"line_number":2704,"context_line":""},{"line_number":2705,"context_line":"\treturn retval;"},{"line_number":2706,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b3368a45_a97dcacd","line":2703,"in_reply_to":"dc859417_f947f93e","updated":"2023-08-12 16:47:05.000000000","message":"Done","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"962ec25fe30b150177e5bed596a5826e0d259935","unresolved":false,"context_lines":[{"line_number":2926,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":2927,"context_line":"\t}"},{"line_number":2928,"context_line":""},{"line_number":2929,"context_line":"\treturn aarch64_init_debug_access(target);"},{"line_number":2930,"context_line":"}"},{"line_number":2931,"context_line":""},{"line_number":2932,"context_line":"COMMAND_HANDLER(aarch64_handle_disassemble_command)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4ef7002f_df678069","line":2929,"updated":"2023-06-18 23:17:36.000000000","message":"Here we have a user command that runs aarch64_init_debug_access()\nI think we can skip the poll here, as user has dedicated command for poll.","commit_id":"4c51801c947aa4b7222d0d279a5fa20fdf142596"}]}