)]}'
{"id":"openocd~master~I6e91f1b6bc1f0d16e6f0eb76fc67d20111e3afd2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-08-05 08:18:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2023-08-12 16:47:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6e91f1b6bc1f0d16e6f0eb76fc67d20111e3afd2","subject":"target/aarch64: add missing aarch64_poll() calls","status":"MERGED","created":"2023-06-08 03:58:37.000000000","updated":"2023-08-12 16:47:14.000000000","submitted":"2023-08-12 16:47:14.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7737","meta_rev_id":"24a77987184dc5fc4125eedb9780f94433fa68ea","_number":7737,"owner":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-12 16:47:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-12 16:47:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-08 04:11:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-18 23:17:36.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"912119427f6e1c0ed55c0598f90a097a1e708ff4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2023-06-08 03:58:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b84e42ebefa983342075db7907b9ed2dc30030f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-06-08 04:11:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17791/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16993/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"962ec25fe30b150177e5bed596a5826e0d259935","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-06-18 23:17:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"64d7bbfbd7ee2afbf0c1d334341c155227219ed9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2023-08-05 00:04:57.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"7b27f32e5ef7089356a8a45691c5323a951d393a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-08-05 00:16:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18083/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17281/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"12b31d82361793b470b47c3dc9d5718a0db6b1ad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-05 08:18:18.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"923b11de6f91bee02e9b349f0ec8fa0404032448","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-12 16:47:05.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"24a77987184dc5fc4125eedb9780f94433fa68ea","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-12 16:47:14.000000000","message":"Change has been successfully cherry-picked as 307a3ca10996283697356a4835f3152dd00a9a0c","accounts_in_message":[],"_revision_number":3}],"current_revision":"307a3ca10996283697356a4835f3152dd00a9a0c","revisions":{"059d1c39dd61f581155c1fb7613a9c7bc9b0b539":{"kind":"REWORK","_number":2,"created":"2023-08-05 00:04:57.000000000","uploader":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"ref":"refs/changes/37/7737/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7737/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/2 \u0026\u0026 git checkout -b change-7737 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7737/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"24b656bff5889350b0c95d791d47e479d9fbd7f9","subject":"jtag/vdebug: adding xtensa config"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2023-06-06 20:44:13.000000000","tz":-360},"committer":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2023-08-05 00:03:49.000000000","tz":-360},"subject":"target/aarch64: add missing aarch64_poll() calls","message":"target/aarch64: add missing aarch64_poll() calls\n\nAdd missing aarch64_poll() calls to ensure the event\nTARGET_EVENT_HALTED is called when necessary.\n\nThis is needed with the poller update introduced in commit\n95603fae18f8 (\"openocd: revert workarounds for \u0027expr\u0027 syntax change\")\n\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\nChange-Id: I6e91f1b6bc1f0d16e6f0eb76fc67d20111e3afd2\n"}},"307a3ca10996283697356a4835f3152dd00a9a0c":{"kind":"REWORK","_number":3,"created":"2023-08-12 16:47:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/7737/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7737/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/3 \u0026\u0026 git checkout -b change-7737 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7737/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3c558fda4bf09b5fd612f05a86da7ad5c47630bb","subject":"tcl: add configuration files for the ARC HSDK-4xD board"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2023-06-06 20:44:13.000000000","tz":-360},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-12 16:47:14.000000000","tz":0},"subject":"target/aarch64: add missing aarch64_poll() calls","message":"target/aarch64: add missing aarch64_poll() calls\n\nAdd missing aarch64_poll() calls to ensure the event\nTARGET_EVENT_HALTED is called when necessary.\n\nThis is needed with the poller update introduced in commit\n95603fae18f8 (\"openocd: revert workarounds for \u0027expr\u0027 syntax change\")\n\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\nChange-Id: I6e91f1b6bc1f0d16e6f0eb76fc67d20111e3afd2\nReviewed-on: https://review.openocd.org/c/openocd/+/7737\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"4c51801c947aa4b7222d0d279a5fa20fdf142596":{"kind":"REWORK","_number":1,"created":"2023-06-08 03:58:37.000000000","uploader":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"ref":"refs/changes/37/7737/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7737/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/1 \u0026\u0026 git checkout -b change-7737 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7737/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7737/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"24b656bff5889350b0c95d791d47e479d9fbd7f9","subject":"jtag/vdebug: adding xtensa config"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2023-06-06 20:44:13.000000000","tz":-360},"committer":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2023-06-08 03:38:26.000000000","tz":-360},"subject":"target/aarch64: add missing aarch64_poll() calls","message":"target/aarch64: add missing aarch64_poll() calls\n\nThe code in aarch64_step() does not check the core status before\nreturning. Add call to aarch64_poll() before returning from\naarch64_step() to ensure the event TARGET_EVENT_HALTED is called.\n\nAlso add the aarch64_poll() call to aarch64_init_debug_access()\nto update target state information.\n\nThis is necessary with the poller update introduced in commit\n95603fae18f8 (\"openocd: revert workarounds for \u0027expr\u0027 syntax change\")\n\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\nChange-Id: I6e91f1b6bc1f0d16e6f0eb76fc67d20111e3afd2\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}