)]}'
{"id":"openocd~master~I9e8bf07a4a15d4544ceb564607dea66837381d70","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-07-14 16:40:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-07-14 16:40:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9e8bf07a4a15d4544ceb564607dea66837381d70","subject":"tcl/target: move Espressif shared functions to esp_common.cfg","status":"MERGED","created":"2023-06-18 10:46:59.000000000","updated":"2023-07-14 16:40:53.000000000","submitted":"2023-07-14 16:40:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7744","meta_rev_id":"1b428b387ab2302159db0ef11ed017924ec6c189","_number":7744,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-14 16:40:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-14 16:40:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-20 09:42:09.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-07-14 13:53:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f820cdf4e088b3c2eb609c2850d106d694236c43","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-06-18 10:46:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3badd53c9b403c48e92c87031a8af96bd9374f3f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-09 09:27:39.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b6ae03975b0cfe9effa17d00c46a57d35c475103","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 13:50:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5dc574fb43270e61c38260679e37f031c58c1974","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-14 13:53:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17986/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17185/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"7941825632c710648511f3f9afeef2a09a95911b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 13:56:54.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"31ef5ac130155f8831e0f19e1d17f902d7938012","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-07-14 14:20:26.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e86e0551acd13ba097e0859bb1907059db2efa5a","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-07-14 14:21:53.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"96aeae05fd8a68dae8f8b7b910fecf67188ea904","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-14 14:33:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17987/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17186/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"86a25ed85f3d817a089db0d4f7ff0adc6fd6ce27","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 16:40:46.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1b428b387ab2302159db0ef11ed017924ec6c189","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 16:40:53.000000000","message":"Change has been successfully cherry-picked as c97b9054d9f52516b529bea58f09e14a4e0d82fd","accounts_in_message":[],"_revision_number":3}],"current_revision":"c97b9054d9f52516b529bea58f09e14a4e0d82fd","revisions":{"90ebb2905308e702569a2429ee845deda5d07f36":{"kind":"REWORK","_number":1,"created":"2023-06-18 10:46:59.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/44/7744/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7744/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/1 \u0026\u0026 git checkout -b change-7744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7744/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eebcf3cff16afbce2c57cf2dba6f562e17713093","subject":"riscv/semihosting: Fix ebreak skip on fileio mode"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 08:17:33.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 10:42:58.000000000","tz":120},"subject":"tcl/target: implement shared functions in esp_common.cfg for all chip configs","message":"tcl/target: implement shared functions in esp_common.cfg for all chip configs\n\nConsolidate commonly used commands and variables from chip config files into\nfunctions in esp_common.cfg. This includes \"jtag newtap,\" \"target create,\"\nand \"configure -event.\"\nEnhances code reusability and simplifies maintenance.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9e8bf07a4a15d4544ceb564607dea66837381d70\n"}},"49913df2f0a4d42744232581a5f2b8a05a298473":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-07-14 14:20:26.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/44/7744/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7744/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/2 \u0026\u0026 git checkout -b change-7744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7744/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eebcf3cff16afbce2c57cf2dba6f562e17713093","subject":"riscv/semihosting: Fix ebreak skip on fileio mode"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 08:17:33.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-07-14 14:18:49.000000000","tz":120},"subject":"tcl/target: move Espressif shared functions to esp_common.cfg","message":"tcl/target: move Espressif shared functions to esp_common.cfg\n\nConsolidate commonly used commands and variables from\nchip config files into functions in esp_common.cfg.\nThis includes \"jtag newtap,\" \"target create,\"and \"configure -event.\"\nEnhances code reusability and simplifies maintenance.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9e8bf07a4a15d4544ceb564607dea66837381d70\n"}},"c97b9054d9f52516b529bea58f09e14a4e0d82fd":{"kind":"REWORK","_number":3,"created":"2023-07-14 16:40:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/44/7744/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/7744/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/3 \u0026\u0026 git checkout -b change-7744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/7744/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/7744/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"886d6c3cbcc4c831d48790c9f1fdb02c8036f79e","subject":"doc:usb_adapters: add lsusb dump of STLINK-V3PWR"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 08:17:33.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-14 16:40:53.000000000","tz":0},"subject":"tcl/target: move Espressif shared functions to esp_common.cfg","message":"tcl/target: move Espressif shared functions to esp_common.cfg\n\nConsolidate commonly used commands and variables from\nchip config files into functions in esp_common.cfg.\nThis includes \"jtag newtap,\" \"target create,\"and \"configure -event.\"\nEnhances code reusability and simplifies maintenance.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9e8bf07a4a15d4544ceb564607dea66837381d70\nReviewed-on: https://review.openocd.org/c/openocd/+/7744\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}