)]}'
{"id":"openocd~master~I9181737d83eeba4e983b6a455b8a1523f2576dd2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-07-14 16:41:33.000000000","reason":"removed on reply"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-07-14 16:42:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9181737d83eeba4e983b6a455b8a1523f2576dd2","subject":"tcl/target: update esp32.cfg to reference shared functions in the esp_common.cfg","status":"MERGED","created":"2023-06-18 10:46:59.000000000","updated":"2023-07-14 16:42:53.000000000","submitted":"2023-07-14 16:42:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7745","meta_rev_id":"158a5ce7bfabcd86b71f11dadd965c8b2ceaf664","_number":7745,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-14 16:42:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-14 16:42:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-18 11:13:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-20 09:41:53.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"93bb7ac40b2410569f6f82a532210b67db5d5646","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-06-18 10:46:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"036cd8555fdc01f5ff7c72159c65afd08d468a90","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-06-18 11:13:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17832/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17033/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"992a099a69b2b30e663d6688f9746cf10ffd070d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 16:41:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"158a5ce7bfabcd86b71f11dadd965c8b2ceaf664","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 16:42:53.000000000","message":"Change has been successfully cherry-picked as d70fd7c5be74f5f524130c95985670eb57f5d5fa","accounts_in_message":[],"_revision_number":2}],"current_revision":"d70fd7c5be74f5f524130c95985670eb57f5d5fa","revisions":{"1a0a7ed98aa047e954808f8f46dd4e4a778aaefd":{"kind":"REWORK","_number":1,"created":"2023-06-18 10:46:59.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/45/7745/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/7745/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/1 \u0026\u0026 git checkout -b change-7745 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/7745/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"90ebb2905308e702569a2429ee845deda5d07f36","subject":"tcl/target: implement shared functions in esp_common.cfg for all chip configs"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 08:25:07.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 10:46:24.000000000","tz":120},"subject":"tcl/target: update esp32.cfg to reference shared functions in the esp_common.cfg","message":"tcl/target: update esp32.cfg to reference shared functions in the esp_common.cfg\n\nThis commit enhances code reusability, simplifies maintenance, and ensures\nconsistency across all chip configurations by consolidating commonly used\ncommands and variables into the common config file.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9181737d83eeba4e983b6a455b8a1523f2576dd2\n"}},"d70fd7c5be74f5f524130c95985670eb57f5d5fa":{"kind":"REWORK","_number":2,"created":"2023-07-14 16:42:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/45/7745/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/7745/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/2 \u0026\u0026 git checkout -b change-7745 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/7745/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/7745/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c97b9054d9f52516b529bea58f09e14a4e0d82fd","subject":"tcl/target: move Espressif shared functions to esp_common.cfg"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 08:25:07.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-14 16:42:53.000000000","tz":0},"subject":"tcl/target: update esp32.cfg to reference shared functions in the esp_common.cfg","message":"tcl/target: update esp32.cfg to reference shared functions in the esp_common.cfg\n\nThis commit enhances code reusability, simplifies maintenance, and ensures\nconsistency across all chip configurations by consolidating commonly used\ncommands and variables into the common config file.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9181737d83eeba4e983b6a455b8a1523f2576dd2\nReviewed-on: https://review.openocd.org/c/openocd/+/7745\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}