)]}'
{"id":"openocd~master~Ifb0122f3b98a767f27746409499733b70fb7d0e8","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-07-09 09:28:26.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2023-07-14 16:43:36.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifb0122f3b98a767f27746409499733b70fb7d0e8","subject":"tcl/target: update esp32s3.cfg to reference shared functions in the esp_common.cfg","status":"MERGED","created":"2023-06-18 10:47:36.000000000","updated":"2023-07-14 16:43:36.000000000","submitted":"2023-07-14 16:43:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7747","meta_rev_id":"53aa9cc67648e63ac1b9507be256efc8da225a87","_number":7747,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-14 16:43:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-14 16:43:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-18 11:40:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-20 09:41:26.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"83a39ab958bc2b45d29a2040fe2bce0d610ce74d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2023-06-18 10:47:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5c72bb10aa246d1fbf53beddecb1064dc3aaa3d2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-06-18 11:40:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17834/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17035/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bc364ca6c5e7a9a1a4c2c0b5b4e3168dc94e38e3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-09 09:28:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"556e8611e0cc7311878975a16f923f168207101f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 16:43:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"53aa9cc67648e63ac1b9507be256efc8da225a87","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 16:43:36.000000000","message":"Change has been successfully cherry-picked as 78daf24a5c29664669bb1d9d7851cbbb90dbc444","accounts_in_message":[],"_revision_number":2}],"current_revision":"78daf24a5c29664669bb1d9d7851cbbb90dbc444","revisions":{"78daf24a5c29664669bb1d9d7851cbbb90dbc444":{"kind":"REWORK","_number":2,"created":"2023-07-14 16:43:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/7747/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/7747/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/2 \u0026\u0026 git checkout -b change-7747 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/7747/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"93002a86cde9cf95a894bdc099b67d6379e22cd3","subject":"tcl/target: update esp32s2.cfg to reference shared functions in the esp_common.cfg"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 09:00:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-14 16:43:36.000000000","tz":0},"subject":"tcl/target: update esp32s3.cfg to reference shared functions in the esp_common.cfg","message":"tcl/target: update esp32s3.cfg to reference shared functions in the esp_common.cfg\n\nThis commit enhances code reusability, simplifies maintenance, and ensures\nconsistency across all chip configurations by consolidating commonly used\ncommands and variables into the common config file.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: Ifb0122f3b98a767f27746409499733b70fb7d0e8\nReviewed-on: https://review.openocd.org/c/openocd/+/7747\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"34bf42bc6c35e2277edbbf55d5aa61bc3f95c80c":{"kind":"REWORK","_number":1,"created":"2023-06-18 10:47:36.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/47/7747/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/7747/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/1 \u0026\u0026 git checkout -b change-7747 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/7747/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/7747/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"90ebb2905308e702569a2429ee845deda5d07f36","subject":"tcl/target: implement shared functions in esp_common.cfg for all chip configs"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 09:00:22.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2023-06-18 10:47:32.000000000","tz":120},"subject":"tcl/target: update esp32s3.cfg to reference shared functions in the esp_common.cfg","message":"tcl/target: update esp32s3.cfg to reference shared functions in the esp_common.cfg\n\nThis commit enhances code reusability, simplifies maintenance, and ensures\nconsistency across all chip configurations by consolidating commonly used\ncommands and variables into the common config file.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: Ifb0122f3b98a767f27746409499733b70fb7d0e8\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}