)]}'
{"id":"openocd~master~I14d9bff3e845675be03465c307a136e69eebc317","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002151":{"account":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"last_update":"2023-08-12 16:41:45.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-07-24 15:37:14.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-08-12 16:41:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I14d9bff3e845675be03465c307a136e69eebc317","subject":"libusb_helper: split error and returned value","status":"MERGED","created":"2023-07-02 22:44:27.000000000","updated":"2023-08-12 16:41:45.000000000","submitted":"2023-08-12 16:41:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"7756","meta_rev_id":"cb9b489a5219eac932c6079d4a43b740aeadd698","_number":7756,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-12 16:41:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-12 16:41:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-12 16:41:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-02 22:44:27.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"state":"REVIEWER"},{"updated":"2023-07-02 22:46:35.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-08 14:24:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"47edcfcd47ddf02bf162e680a7d082c6ae6d5b0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-02 22:44:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e42dfe64e91b513e8b225c779a447abdaadeb6c3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-02 22:46:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/17911/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17110/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"c282be1d1e5fe4a25b408fe9bc87b4b69ad2935b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-02 22:46:47.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c3db9ed7213682ebcfd535384e1e8f41675c6ff1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-02 22:48:19.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f4be10ba17fd02024c8b56becdd065a319888af7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-02 22:48:46.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"2caab712be34d58c60ff36eae6a7cf36630d8cef","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-02 23:09:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17912/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17111/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"861cbaec61e24a6732752873394ba054ed610b34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2023-07-10 13:10:14.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"f2e962451bd7c298090d2d5ab0e8b67b123bf7b3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-10 14:07:06.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17947/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17146/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e8e30901d85767cd9b8e3f5515d9a17a8023fab8","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2023-07-11 09:12:34.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9038b16f959177ef332aecaf2a9721cb9bf60cbc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-11 20:48:17.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1dd6365106013f828d0230c81fbaec4977724158","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-07-12 08:15:46.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"c8f37aa265813add5984f567104d1056bc47a4c2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-12 23:06:51.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"b5b7f3131baf724fcc0e71bbae46368146885cae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2023-07-24 08:27:20.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"8087bfa9cc0116420e7398ebdf853c55bb8b7055","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-24 09:25:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18015/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17214/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"8d9df7cc8c43ac55986cf7627ba2998351057b3a","author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"real_author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"date":"2023-07-24 12:30:18.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"56bf786a48c0df05f8c6bc1ad5b1af2c6896a5da","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-24 15:37:14.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"eb8f4ca7ecf9e57cc5c3b6758cbbcf1c4c08b851","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-12 16:39:37.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"cb9b489a5219eac932c6079d4a43b740aeadd698","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-08-12 16:41:45.000000000","message":"Change has been successfully cherry-picked as 3b78b5c1db68841fdc18ee48b6011f4affff2bfd","accounts_in_message":[],"_revision_number":5}],"current_revision":"3b78b5c1db68841fdc18ee48b6011f4affff2bfd","revisions":{"3b78b5c1db68841fdc18ee48b6011f4affff2bfd":{"kind":"REWORK","_number":5,"created":"2023-08-12 16:41:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/56/7756/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7756/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/5 \u0026\u0026 git checkout -b change-7756 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7756/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51be311f73933d8b51938371a989f1130dec3cfc","subject":"LICENSES: Add the LGPL-2.1 license"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 21:48:42.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-08-12 16:41:45.000000000","tz":0},"subject":"libusb_helper: split error and returned value","message":"libusb_helper: split error and returned value\n\nThe USB control transfer can be executed without any data.\nThe libusb API libusb_control_transfer() can thus be called with\nzero \u0027size\u0027, thus returning zero byte transferred when succeed.\n\nThe OpenOCD API jtag_libusb_control_transfer() returns zero either\nin case of transfer error and in case of libusb_control_transfer()\nreturning zero, making impossible discriminating the two cases.\n\nExtend jtag_libusb_control_transfer() with separate return value\nfor error code and explicit parameter\u0027s pointer for transferred\nbytes.\nMake the transferred pointer optional, as many callers do not\nproperly handle the returned value.\nUse \u0027int\u0027 type pointer for transferred, instead of the \u0027uint16_t\u0027\nthat would have matched the type of \u0027size\u0027. This can simplify the\ncaller\u0027s code by using a single \u0027int transferred\u0027 variable shared\nwith other jtag_libusb_bulk_read|write, while keeping possible the\ncomparison int vs uint16_t without cast.\n\nThis change is inspired from commit d612baacaa3f\n(\"jtag_libusb_bulk_read|write: return error code instead of size\")\n\nChange-Id: I14d9bff3e845675be03465c307a136e69eebc317\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7756\nTested-by: jenkins\nReviewed-by: ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e\n"}},"396fe00810bae84caea490e1106e244174aaad38":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-07-24 08:27:20.000000000","uploader":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"ref":"refs/changes/56/7756/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7756/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/4 \u0026\u0026 git checkout -b change-7756 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7756/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"80e3f642e04c7a6be7437c9f29301b661f834559","subject":"LICENSES: Add the LGPL-2.1 license"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 21:48:42.000000000","tz":120},"committer":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-07-24 08:26:12.000000000","tz":120},"subject":"libusb_helper: split error and returned value","message":"libusb_helper: split error and returned value\n\nThe USB control transfer can be executed without any data.\nThe libusb API libusb_control_transfer() can thus be called with\nzero \u0027size\u0027, thus returning zero byte transferred when succeed.\n\nThe OpenOCD API jtag_libusb_control_transfer() returns zero either\nin case of transfer error and in case of libusb_control_transfer()\nreturning zero, making impossible discriminating the two cases.\n\nExtend jtag_libusb_control_transfer() with separate return value\nfor error code and explicit parameter\u0027s pointer for transferred\nbytes.\nMake the transferred pointer optional, as many callers do not\nproperly handle the returned value.\nUse \u0027int\u0027 type pointer for transferred, instead of the \u0027uint16_t\u0027\nthat would have matched the type of \u0027size\u0027. This can simplify the\ncaller\u0027s code by using a single \u0027int transferred\u0027 variable shared\nwith other jtag_libusb_bulk_read|write, while keeping possible the\ncomparison int vs uint16_t without cast.\n\nThis change is inspired from commit d612baacaa3f\n(\"jtag_libusb_bulk_read|write: return error code instead of size\")\n\nChange-Id: I14d9bff3e845675be03465c307a136e69eebc317\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"73556c2e8812d780d0aed61e4f5dfff5f0324923":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-07-10 13:10:14.000000000","uploader":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"ref":"refs/changes/56/7756/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7756/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/3 \u0026\u0026 git checkout -b change-7756 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7756/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"82279288842ca67e0643b257e416f22638c4c4fd","subject":"LICENSES: Add the LGPL-2.1 license"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 21:48:42.000000000","tz":120},"committer":{"name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","date":"2023-07-10 13:09:43.000000000","tz":120},"subject":"libusb_helper: split error and returned value","message":"libusb_helper: split error and returned value\n\nThe USB control transfer can be executed without any data.\nThe libusb API libusb_control_transfer() can thus be called with\nzero \u0027size\u0027, thus returning zero byte transferred when succeed.\n\nThe OpenOCD API jtag_libusb_control_transfer() returns zero either\nin case of transfer error and in case of libusb_control_transfer()\nreturning zero, making impossible discriminating the two cases.\n\nExtend jtag_libusb_control_transfer() with separate return value\nfor error code and explicit parameter\u0027s pointer for transferred\nbytes.\nMake the transferred pointer optional, as many callers do not\nproperly handle the returned value.\nUse \u0027int\u0027 type pointer for transferred, instead of the \u0027uint16_t\u0027\nthat would have matched the type of \u0027size\u0027. This can simplify the\ncaller\u0027s code by using a single \u0027int transferred\u0027 variable shared\nwith other jtag_libusb_bulk_read|write, while keeping possible the\ncomparison int vs uint16_t without cast.\n\nThis change is inspired from commit d612baacaa3f\n(\"jtag_libusb_bulk_read|write: return error code instead of size\")\n\nChange-Id: I14d9bff3e845675be03465c307a136e69eebc317\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7c0fc0f4caf4bbab39985ffc5e4c6898145cce86":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-07-02 22:48:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/56/7756/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7756/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/2 \u0026\u0026 git checkout -b change-7756 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7756/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"96266ad2429c977ec47ef0199eedb4a6ac2800b7","subject":"LICENSES: Add the LGPL-2.1 license"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 21:48:42.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 22:47:39.000000000","tz":120},"subject":"libusb_helper: split error and returned value","message":"libusb_helper: split error and returned value\n\nThe USB control transfer can be executed without any data.\nThe libusb API libusb_control_transfer() can thus be called with\nzero \u0027size\u0027, thus returning zero byte transferred when succeed.\n\nThe OpenOCD API jtag_libusb_control_transfer() returns zero either\nin case of transfer error and in case of libusb_control_transfer()\nreturning zero, making impossible discriminating the two cases.\n\nExtend jtag_libusb_control_transfer() with separate return value\nfor error code and explicit parameter\u0027s pointer for transferred\nbytes.\nMake the transferred pointer optional, as many callers do not\nproperly handle the returned value.\nUse \u0027int\u0027 type pointer for transferred, instead of the \u0027uint16_t\u0027\nthat would have matched the type of \u0027size\u0027. This can simplify the\ncaller\u0027s code by using a single \u0027int transferred\u0027 variable shared\nwith other jtag_libusb_bulk_read|write, while keeping possible the\ncomparison int vs uint16_t without cast.\n\nThis change is inspired from commit d612baacaa3f\n(\"jtag_libusb_bulk_read|write: return error code instead of size\")\n\nChange-Id: I14d9bff3e845675be03465c307a136e69eebc317\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7a710953db734cc282ecf90b542c7ebb3a4dbafa":{"kind":"REWORK","_number":1,"created":"2023-07-02 22:44:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/56/7756/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/7756/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/1 \u0026\u0026 git checkout -b change-7756 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/7756/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/7756/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"96266ad2429c977ec47ef0199eedb4a6ac2800b7","subject":"LICENSES: Add the LGPL-2.1 license"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 21:48:42.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-02 22:28:49.000000000","tz":120},"subject":"libusb_helper: split error and returned value","message":"libusb_helper: split error and returned value\n\nThe USB control transfer can be executed without any data.\nThe libusb API libusb_control_transfer() can thus be called with\nzero \u0027size\u0027, thus returning zero byte transferred when succeed.\n\nThe OpenOCD API jtag_libusb_control_transfer() returns zero either\nin case of transfer error and in case of libusb_control_transfer()\nreturning zero, making impossible discriminating the two cases.\n\nExtend jtag_libusb_control_transfer() with separate return value\nfor error code and explicit parameter\u0027s pointer for transferred\nbytes.\nMake the transferred pointer optional, as many callers do not\nproperly handle the returned value.\nUse \u0027int\u0027 type pointer for transferred, instead of the \u0027uint16_t\u0027\nthat would have matched type type of \u0027size\u0027. This can simplify the\ncaller\u0027s code by using a single \u0027int transferred\u0027 variable shared\nwith other jtag_libusb_bulk_read|write, while keeping possible the\ncomparison int vs uint16_t without cast.\n\nThis change is inspired from commit d612baacaa3f\n(\"jtag_libusb_bulk_read|write: return error code instead of size\")\n\nChange-Id: I14d9bff3e845675be03465c307a136e69eebc317\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}