)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"b07a1e4351b1f72cafb052cc7621d41c3c43ec52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab32ec84_c437f516","updated":"2023-07-09 12:36:38.000000000","message":"Thanks Antonio.","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca49d8b0a34f310c64174ea20fb9105285c4ded7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c18bf4e_ab561673","updated":"2023-07-09 09:56:35.000000000","message":"only some minor issue to review","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"43a38d4efcc9099c525e150077989de9f2cbc3dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ec52a3f_11fa8106","updated":"2023-07-11 22:06:50.000000000","message":"Erhan,\ncould you please check this error from clang scan-build?","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cb94e8e282944a7f9d27ee85fb6b9f3872dbd1b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e1bec865_c72ea9db","updated":"2023-07-09 13:21:54.000000000","message":"thanks","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"f94ca2c29379a502225f638af68ef54a9d0bb512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"54759e76_467f145a","in_reply_to":"1ec52a3f_11fa8106","updated":"2023-07-12 07:32:50.000000000","message":"Sorry, I didn\u0027t check this before submitting. Now it should be fixed with the latest patch.","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"}],"src/target/espressif/esp.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"43a38d4efcc9099c525e150077989de9f2cbc3dc","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\t\tdesc_entry_id \u003d 0;"},{"line_number":39,"context_line":"\t\tgcov_entry_id \u003d 1;"},{"line_number":40,"context_line":"\t} else {"},{"line_number":41,"context_line":"\t\ttable_size \u003d entries[1];"},{"line_number":42,"context_line":"\t\ttable_start_id \u003d ESP_DBG_STUB_TABLE_START;"},{"line_number":43,"context_line":"\t\tdesc_entry_id \u003d ESP_DBG_STUB_TABLE_START;"},{"line_number":44,"context_line":"\t\tgcov_entry_id \u003d ESP_DBG_STUB_ENTRY_FIRST;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6b96f8cb_16675e0a","line":41,"updated":"2023-07-11 22:06:50.000000000","message":"clang\u0027s scan-build complains that here table_size could be 2 or 3 or 4.\ncontinue below ...","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"f94ca2c29379a502225f638af68ef54a9d0bb512","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\t\tdesc_entry_id \u003d 0;"},{"line_number":39,"context_line":"\t\tgcov_entry_id \u003d 1;"},{"line_number":40,"context_line":"\t} else {"},{"line_number":41,"context_line":"\t\ttable_size \u003d entries[1];"},{"line_number":42,"context_line":"\t\ttable_start_id \u003d ESP_DBG_STUB_TABLE_START;"},{"line_number":43,"context_line":"\t\tdesc_entry_id \u003d ESP_DBG_STUB_TABLE_START;"},{"line_number":44,"context_line":"\t\tgcov_entry_id \u003d ESP_DBG_STUB_ENTRY_FIRST;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6acd86ec_4acaece4","line":41,"in_reply_to":"6b96f8cb_16675e0a","updated":"2023-07-12 07:32:50.000000000","message":"Yes. It should be equal to ESP_DBG_STUB_ENTRY_MAX. I removed if (table_size \u003c 2) check. \nIf something new is added to the target, we will discard it.","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"43a38d4efcc9099c525e150077989de9f2cbc3dc","unresolved":true,"context_lines":[{"line_number":58,"context_line":"\t\t\tLOG_TARGET_ERROR(target, \"Failed to read debug stubs info!\");"},{"line_number":59,"context_line":"\t\t\treturn res;"},{"line_number":60,"context_line":"\t\t}"},{"line_number":61,"context_line":"\t\tfor (unsigned int i \u003d 2; i \u003c table_size; ++i)"},{"line_number":62,"context_line":"\t\t\tentries[i] \u003d target_buffer_get_u32(target, entry_buff + sizeof(uint32_t) * i);"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\t\tdbg_stubs-\u003eentries[ESP_DBG_STUB_CAPABILITIES] \u003d entries[ESP_DBG_STUB_CAPABILITIES];"},{"line_number":65,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"421a160e_b777a88b","line":62,"range":{"start_line":61,"start_character":2,"end_line":62,"end_character":13},"updated":"2023-07-11 22:06:50.000000000","message":"... for i \u003c table_size, it means that entries[4] is not assigned","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"f94ca2c29379a502225f638af68ef54a9d0bb512","unresolved":false,"context_lines":[{"line_number":58,"context_line":"\t\t\tLOG_TARGET_ERROR(target, \"Failed to read debug stubs info!\");"},{"line_number":59,"context_line":"\t\t\treturn res;"},{"line_number":60,"context_line":"\t\t}"},{"line_number":61,"context_line":"\t\tfor (unsigned int i \u003d 2; i \u003c table_size; ++i)"},{"line_number":62,"context_line":"\t\t\tentries[i] \u003d target_buffer_get_u32(target, entry_buff + sizeof(uint32_t) * i);"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\t\tdbg_stubs-\u003eentries[ESP_DBG_STUB_CAPABILITIES] \u003d entries[ESP_DBG_STUB_CAPABILITIES];"},{"line_number":65,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ccd4fd93_5f6dc320","line":62,"range":{"start_line":61,"start_character":2,"end_line":62,"end_character":13},"in_reply_to":"421a160e_b777a88b","updated":"2023-07-12 07:32:50.000000000","message":"Done","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"43a38d4efcc9099c525e150077989de9f2cbc3dc","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\t\tfor (unsigned int i \u003d 2; i \u003c table_size; ++i)"},{"line_number":62,"context_line":"\t\t\tentries[i] \u003d target_buffer_get_u32(target, entry_buff + sizeof(uint32_t) * i);"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\t\tdbg_stubs-\u003eentries[ESP_DBG_STUB_CAPABILITIES] \u003d entries[ESP_DBG_STUB_CAPABILITIES];"},{"line_number":65,"context_line":"\t}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\tdbg_stubs-\u003eentries[ESP_DBG_STUB_DESC] \u003d entries[desc_entry_id];"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e0294c03_8ddde690","line":64,"updated":"2023-07-11 22:06:50.000000000","message":"ESP_DBG_STUB_CAPABILITIES\u003d4\nso the final error is on this line 64:\nAssigned value is garbage or undefined","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"f94ca2c29379a502225f638af68ef54a9d0bb512","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\t\tfor (unsigned int i \u003d 2; i \u003c table_size; ++i)"},{"line_number":62,"context_line":"\t\t\tentries[i] \u003d target_buffer_get_u32(target, entry_buff + sizeof(uint32_t) * i);"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\t\tdbg_stubs-\u003eentries[ESP_DBG_STUB_CAPABILITIES] \u003d entries[ESP_DBG_STUB_CAPABILITIES];"},{"line_number":65,"context_line":"\t}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\tdbg_stubs-\u003eentries[ESP_DBG_STUB_DESC] \u003d entries[desc_entry_id];"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3f63b4b4_60e86971","line":64,"in_reply_to":"e0294c03_8ddde690","updated":"2023-07-12 07:32:50.000000000","message":"Done","commit_id":"350262c480f2a27eb6966853368cb0035bfa1826"}],"src/target/espressif/esp_xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca49d8b0a34f310c64174ea20fb9105285c4ded7","unresolved":true,"context_lines":[{"line_number":20,"context_line":"#define ESP_XTENSA_DBGSTUBS_UPDATE_DATA_ENTRY(_e_) \\"},{"line_number":21,"context_line":"\tdo { \\"},{"line_number":22,"context_line":"\t\tif (!xtensa_data_addr_valid(target, (_e_))) { \\"},{"line_number":23,"context_line":"\t\t\tLOG_ERROR(\"No valid stub data entry found (0x%x)!\", (uint32_t)(_e_)); \\"},{"line_number":24,"context_line":"\t\t\treturn;\t\\"},{"line_number":25,"context_line":"\t\t} \\"},{"line_number":26,"context_line":"\t} while (0)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"051e5e4b_91fed893","line":23,"updated":"2023-07-09 09:56:35.000000000","message":"From a quick check, all the values you use for _e_ (at least in this patch) are uint32_t. So the cast is not required and, anyway, the format string should be \"%\"PRIx32.\nI don\u0027t really like macros that return, but that is more my own problem, nothing to change for you.\nInstead, to fix the checkpatch complain on re-used macro argument, use a temporarily variable in the do{}while, e.g.\nuint32_t __internal_val \u003d (_e_);","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"b07a1e4351b1f72cafb052cc7621d41c3c43ec52","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#define ESP_XTENSA_DBGSTUBS_UPDATE_DATA_ENTRY(_e_) \\"},{"line_number":21,"context_line":"\tdo { \\"},{"line_number":22,"context_line":"\t\tif (!xtensa_data_addr_valid(target, (_e_))) { \\"},{"line_number":23,"context_line":"\t\t\tLOG_ERROR(\"No valid stub data entry found (0x%x)!\", (uint32_t)(_e_)); \\"},{"line_number":24,"context_line":"\t\t\treturn;\t\\"},{"line_number":25,"context_line":"\t\t} \\"},{"line_number":26,"context_line":"\t} while (0)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"84129579_57521af8","line":23,"in_reply_to":"051e5e4b_91fed893","updated":"2023-07-09 12:36:38.000000000","message":"Done","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca49d8b0a34f310c64174ea20fb9105285c4ded7","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\tif (esp_xtensa-\u003eesp.dbg_stubs.base \u003d\u003d 0)"},{"line_number":44,"context_line":"\t\treturn ERROR_OK;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"\tLOG_TARGET_INFO(target, \"Restore debug stubs address %x\", esp_xtensa-\u003eesp.dbg_stubs.base);"},{"line_number":47,"context_line":"\tint res \u003d esp_xtensa_apptrace_status_reg_write(target, esp_xtensa-\u003eesp.dbg_stubs.base);"},{"line_number":48,"context_line":"\tif (res !\u003d ERROR_OK) {"},{"line_number":49,"context_line":"\t\tLOG_ERROR(\"Failed to write trace status (%d)!\", res);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"401efbcb_01cffb1d","line":46,"updated":"2023-07-09 09:56:35.000000000","message":"PRIx32, I think","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"b07a1e4351b1f72cafb052cc7621d41c3c43ec52","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\tif (esp_xtensa-\u003eesp.dbg_stubs.base \u003d\u003d 0)"},{"line_number":44,"context_line":"\t\treturn ERROR_OK;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"\tLOG_TARGET_INFO(target, \"Restore debug stubs address %x\", esp_xtensa-\u003eesp.dbg_stubs.base);"},{"line_number":47,"context_line":"\tint res \u003d esp_xtensa_apptrace_status_reg_write(target, esp_xtensa-\u003eesp.dbg_stubs.base);"},{"line_number":48,"context_line":"\tif (res !\u003d ERROR_OK) {"},{"line_number":49,"context_line":"\t\tLOG_ERROR(\"Failed to write trace status (%d)!\", res);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1278bdde_7429e749","line":46,"in_reply_to":"401efbcb_01cffb1d","updated":"2023-07-09 12:36:38.000000000","message":"Done","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca49d8b0a34f310c64174ea20fb9105285c4ded7","unresolved":true,"context_lines":[{"line_number":124,"context_line":"\t\treturn;"},{"line_number":125,"context_line":"\t}"},{"line_number":126,"context_line":"\tif (xtensa_data_addr_valid(target, vec_addr)) {"},{"line_number":127,"context_line":"\t\tLOG_TARGET_INFO(target, \"Detected debug stubs @ %x\", vec_addr);"},{"line_number":128,"context_line":"\t\tres \u003d esp_xtensa_apptrace_status_reg_write(target, 0);"},{"line_number":129,"context_line":"\t\tif (res !\u003d ERROR_OK)"},{"line_number":130,"context_line":"\t\t\tLOG_ERROR(\"Failed to clear debug stubs address location (%d)!\", res);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5dbf742e_44afe305","line":127,"updated":"2023-07-09 09:56:35.000000000","message":"PRIx32","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"b07a1e4351b1f72cafb052cc7621d41c3c43ec52","unresolved":false,"context_lines":[{"line_number":124,"context_line":"\t\treturn;"},{"line_number":125,"context_line":"\t}"},{"line_number":126,"context_line":"\tif (xtensa_data_addr_valid(target, vec_addr)) {"},{"line_number":127,"context_line":"\t\tLOG_TARGET_INFO(target, \"Detected debug stubs @ %x\", vec_addr);"},{"line_number":128,"context_line":"\t\tres \u003d esp_xtensa_apptrace_status_reg_write(target, 0);"},{"line_number":129,"context_line":"\t\tif (res !\u003d ERROR_OK)"},{"line_number":130,"context_line":"\t\t\tLOG_ERROR(\"Failed to clear debug stubs address location (%d)!\", res);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ea7030a7_0c0b6cd4","line":127,"in_reply_to":"5dbf742e_44afe305","updated":"2023-07-09 12:36:38.000000000","message":"Done","commit_id":"02eb215075e4e1717605142e3441a9a9d3758323"}]}