)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"8512ee5773fa716e22b207610e560d8662d169c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49874cca_44b542b7","updated":"2023-10-26 21:29:57.000000000","message":"@Tomas, I think you are much familiar with the flash drivers. Maybe we can make a progress here.","commit_id":"ddef2ed1c653a98f4f62045c4d81bd1987d042e9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d9bff96b_293a5d34","updated":"2023-11-25 23:24:11.000000000","message":"only some general comment, I\u0027m not used at reviewing flash drivers","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"004e7ce6_73a4994c","updated":"2023-11-26 15:31:49.000000000","message":"Thank you @Antonio","commit_id":"d935aa7217ec70f3ef94aaa0e55c4367f66ffa40"}],"src/flash/nor/esp_flash.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":true,"context_lines":[{"line_number":260,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":261,"context_line":"\t\treturn ret;"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"\trun.stack_size \u003d 1300;"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"\tstruct mem_param mp;"},{"line_number":266,"context_line":"\tinit_mem_param(\u0026mp,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0af1bddb_674cf600","line":263,"updated":"2023-11-25 23:24:11.000000000","message":"here 1300, in other places 1024...\nwhere these magic numbers for stack size come from?\nI\u0027m scared there would be need for change these values, later. How to compute them?","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[{"line_number":260,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":261,"context_line":"\t\treturn ret;"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"\trun.stack_size \u003d 1300;"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"\tstruct mem_param mp;"},{"line_number":266,"context_line":"\tinit_mem_param(\u0026mp,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"3a0ac3a1_39fbce79","line":263,"in_reply_to":"0af1bddb_674cf600","updated":"2023-11-26 15:31:49.000000000","message":"We are allocating a work area space according to these numbers. They are a safe stack size for the stub code running on the target and will not change unless we require a new feature that requires more stack size.","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":true,"context_lines":[{"line_number":579,"context_line":"\tuint32_t compressed_len \u003d 0;"},{"line_number":580,"context_line":"\tuint32_t stack_size \u003d 1024 + ESP_STUB_UNZIP_BUFF_SIZE;"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"\tif (offset \u0026 0x3UL) {"},{"line_number":583,"context_line":"\t\tLOG_ERROR(\"Unaligned offset!\");"},{"line_number":584,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":585,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f692cc62_a9d443c6","line":582,"updated":"2023-11-25 23:24:11.000000000","message":"if (!IS_ALIGNED(offset, 4))","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[{"line_number":579,"context_line":"\tuint32_t compressed_len \u003d 0;"},{"line_number":580,"context_line":"\tuint32_t stack_size \u003d 1024 + ESP_STUB_UNZIP_BUFF_SIZE;"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"\tif (offset \u0026 0x3UL) {"},{"line_number":583,"context_line":"\t\tLOG_ERROR(\"Unaligned offset!\");"},{"line_number":584,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":585,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"4f729304_cce39aac","line":582,"in_reply_to":"f692cc62_a9d443c6","updated":"2023-11-26 15:31:49.000000000","message":"Done","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":true,"context_lines":[{"line_number":738,"context_line":"\tstruct esp_flash_read_state rd_state;"},{"line_number":739,"context_line":"\tconst struct esp_flasher_stub_config *stub_cfg \u003d esp_info-\u003eget_stub(bank);"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"\tif (offset \u0026 0x3UL) {"},{"line_number":742,"context_line":"\t\tLOG_ERROR(\"Unaligned offset!\");"},{"line_number":743,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":744,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d601ba02_c2eb994a","line":741,"updated":"2023-11-25 23:24:11.000000000","message":"ditto","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[{"line_number":738,"context_line":"\tstruct esp_flash_read_state rd_state;"},{"line_number":739,"context_line":"\tconst struct esp_flasher_stub_config *stub_cfg \u003d esp_info-\u003eget_stub(bank);"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"\tif (offset \u0026 0x3UL) {"},{"line_number":742,"context_line":"\t\tLOG_ERROR(\"Unaligned offset!\");"},{"line_number":743,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":744,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d36bf426_eef084b6","line":741,"in_reply_to":"d601ba02_c2eb994a","updated":"2023-11-26 15:31:49.000000000","message":"Done","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":true,"context_lines":[{"line_number":800,"context_line":"\treturn ret;"},{"line_number":801,"context_line":"}"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"#define BANK_SUBNAME(_b_, _n_)  (strcmp((_b_)-\u003ename + strlen((_b_)-\u003ename) - strlen(_n_), _n_) \u003d\u003d 0)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"int esp_algo_flash_probe(struct flash_bank *bank)"},{"line_number":806,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"6542a313_feef1405","line":803,"updated":"2023-11-25 23:24:11.000000000","message":"use a function for this, even no need for inline function (the compiler will inline it anyway), and drop the hack\nCheckpatch-ignore: MACRO_ARG_REUSE\nfrom the commit message","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[{"line_number":800,"context_line":"\treturn ret;"},{"line_number":801,"context_line":"}"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"#define BANK_SUBNAME(_b_, _n_)  (strcmp((_b_)-\u003ename + strlen((_b_)-\u003ename) - strlen(_n_), _n_) \u003d\u003d 0)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"int esp_algo_flash_probe(struct flash_bank *bank)"},{"line_number":806,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8631836b_7a02652c","line":803,"in_reply_to":"6542a313_feef1405","updated":"2023-11-26 15:31:49.000000000","message":"Done","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":true,"context_lines":[{"line_number":953,"context_line":"COMMAND_HELPER(esp_algo_flash_cmd_appimage_flashoff_do, struct target *target)"},{"line_number":954,"context_line":"{"},{"line_number":955,"context_line":"\tif (CMD_ARGC !\u003d 1) {"},{"line_number":956,"context_line":"\t\tcommand_print(CMD, \"Flash offset not specified!\");"},{"line_number":957,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":958,"context_line":"\t}"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"\t/* update app image base */"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"3ac3a8e9_b3a33904","line":957,"range":{"start_line":956,"start_character":2,"end_line":957,"end_character":15},"updated":"2023-11-25 23:24:11.000000000","message":"remove command_print() before a ERROR_COMMAND_SYNTAX_ERROR","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[{"line_number":953,"context_line":"COMMAND_HELPER(esp_algo_flash_cmd_appimage_flashoff_do, struct target *target)"},{"line_number":954,"context_line":"{"},{"line_number":955,"context_line":"\tif (CMD_ARGC !\u003d 1) {"},{"line_number":956,"context_line":"\t\tcommand_print(CMD, \"Flash offset not specified!\");"},{"line_number":957,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":958,"context_line":"\t}"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"\t/* update app image base */"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8f8189bc_436f921e","line":957,"range":{"start_line":956,"start_character":2,"end_line":957,"end_character":15},"in_reply_to":"3ac3a8e9_b3a33904","updated":"2023-11-26 15:31:49.000000000","message":"Done","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a01d4459949f101ac2cd856f51af445cb835c2fb","unresolved":true,"context_lines":[{"line_number":981,"context_line":"\t\t.handler \u003d esp_algo_flash_cmd_appimage_flashoff,"},{"line_number":982,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":983,"context_line":"\t\t.help \u003d"},{"line_number":984,"context_line":"\t\t\t\"Set offset of application image in flash. Use -1 to debug the first application image from partition table.\","},{"line_number":985,"context_line":"\t\t.usage \u003d \"offset\","},{"line_number":986,"context_line":"\t},"},{"line_number":987,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"7d7d7b0c_0d4c32ee","line":984,"updated":"2023-11-25 23:24:11.000000000","message":"split the long string in two line","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"76eb41810d2923885f145f25612fa6602bcf2738","unresolved":false,"context_lines":[{"line_number":981,"context_line":"\t\t.handler \u003d esp_algo_flash_cmd_appimage_flashoff,"},{"line_number":982,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":983,"context_line":"\t\t.help \u003d"},{"line_number":984,"context_line":"\t\t\t\"Set offset of application image in flash. Use -1 to debug the first application image from partition table.\","},{"line_number":985,"context_line":"\t\t.usage \u003d \"offset\","},{"line_number":986,"context_line":"\t},"},{"line_number":987,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"705214b4_9ec97bbf","line":984,"in_reply_to":"7d7d7b0c_0d4c32ee","updated":"2023-11-26 15:31:49.000000000","message":"Done","commit_id":"fc227ae6fa3c32a340438556f66d77c84c0a2bab"}]}