)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"90536d577fa927e176c400aa582437384c080ef4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17dd98a5_2fd0fd01","updated":"2023-07-09 13:34:53.000000000","message":"Thanks for the patch.\nI have two comments, just to avoid potential headache in the future.","commit_id":"3ae31a2f723119fe2f43133a463822e88c971e8a"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"ced7e0dbe1760bcfc9deab317e6fc419656bd33b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5dc18d49_c2978d1b","in_reply_to":"17dd98a5_2fd0fd01","updated":"2023-07-10 05:58:14.000000000","message":"Very nice catch, thanks Antonio. I have uploaded v2 of the patch containing these changes, as well as a slightly modified commit message.","commit_id":"3ae31a2f723119fe2f43133a463822e88c971e8a"},{"author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"change_message_id":"7fc573168c797b1b594497c0be97da76cd9832db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b88de1c_f512ee87","updated":"2023-07-11 07:07:17.000000000","message":"Great, thank you for fixing this!","commit_id":"fbcedc20d098c5e5e7d118c9f071d3db1d28c280"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"38673b6ad8f944bbb8855488340a346d2345dbc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27adb51c_4b1fd3f7","updated":"2023-07-10 13:08:55.000000000","message":"No vote from Jenkins... I will try to manually trigger the build","commit_id":"fbcedc20d098c5e5e7d118c9f071d3db1d28c280"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"31a92f7557888874c7dbea2945c74b347b846a18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"495a3b8b_09c2ee66","updated":"2023-07-10 08:46:38.000000000","message":"Thanks!","commit_id":"fbcedc20d098c5e5e7d118c9f071d3db1d28c280"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6e8c16b270a10ab0acb4efaaa8159d371db61e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a80cc4ee_304dc1c9","updated":"2023-07-10 13:35:08.000000000","message":"Yes, I have seen it. I have retriggered the build, but there are few builds already in front of the queue. Let\u0027s wait...","commit_id":"fbcedc20d098c5e5e7d118c9f071d3db1d28c280"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"206b1fa23171942a40ccca0838c0e62f811075f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de9e0119_d4c20f09","in_reply_to":"27adb51c_4b1fd3f7","updated":"2023-07-10 13:28:19.000000000","message":"The builds have been triggered and did pass (https://build.openocd.org/job/openocd-gerrit/17939/, https://build.openocd.org/job/openocd-gerrit-build/17138/), but that did not result in a +1 from Jenkins. To make matters worse, I have since removed Jenkins from the list of reviewers and then couldn\u0027t add it back, which might be necessary here. Could you help with that please?","commit_id":"fbcedc20d098c5e5e7d118c9f071d3db1d28c280"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"9e00a99e6d0d9fcafb25588e27fb0bcc33e328ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0360e4a5_3236ee6c","in_reply_to":"a80cc4ee_304dc1c9","updated":"2023-07-10 13:44:06.000000000","message":"Looks good! Many thanks for taking care of it.","commit_id":"fbcedc20d098c5e5e7d118c9f071d3db1d28c280"}],"src/target/arc.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"90536d577fa927e176c400aa582437384c080ef4","unresolved":true,"context_lines":[{"line_number":886,"context_line":"\t\t\ttarget_buffer_set_u32(target, reg-\u003evalue, core_values[core_cnt]);"},{"line_number":887,"context_line":"\t\t\treg-\u003evalid \u003d true;"},{"line_number":888,"context_line":"\t\t\treg-\u003edirty \u003d false;"},{"line_number":889,"context_line":"\t\t\tLOG_DEBUG(\"Get core register regnum\u003d%u, name\u003d%s, value\u003d0x%08\" PRIx32,"},{"line_number":890,"context_line":"\t\t\t\ti, arc_reg-\u003ename, core_values[core_cnt++]);"},{"line_number":891,"context_line":"\t\t}"},{"line_number":892,"context_line":"\t}"},{"line_number":893,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"093cee32_7ab33b7a","line":890,"range":{"start_line":889,"start_character":3,"end_line":890,"end_character":47},"updated":"2023-07-09 13:34:53.000000000","message":"LOG_DEBUG() is a macro.\nWhile it looks ok in current implementation, it could change in future having the bad behavior of evaluating the arguments twice. In such case the increment will be repeated. Ant this would be hard to find and fix.\nI consider much safer moving the increment outside the macro, just in next line\ncore_cnt++;","commit_id":"3ae31a2f723119fe2f43133a463822e88c971e8a"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"ced7e0dbe1760bcfc9deab317e6fc419656bd33b","unresolved":false,"context_lines":[{"line_number":886,"context_line":"\t\t\ttarget_buffer_set_u32(target, reg-\u003evalue, core_values[core_cnt]);"},{"line_number":887,"context_line":"\t\t\treg-\u003evalid \u003d true;"},{"line_number":888,"context_line":"\t\t\treg-\u003edirty \u003d false;"},{"line_number":889,"context_line":"\t\t\tLOG_DEBUG(\"Get core register regnum\u003d%u, name\u003d%s, value\u003d0x%08\" PRIx32,"},{"line_number":890,"context_line":"\t\t\t\ti, arc_reg-\u003ename, core_values[core_cnt++]);"},{"line_number":891,"context_line":"\t\t}"},{"line_number":892,"context_line":"\t}"},{"line_number":893,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1f70ea6b_6449f2d1","line":890,"range":{"start_line":889,"start_character":3,"end_line":890,"end_character":47},"in_reply_to":"093cee32_7ab33b7a","updated":"2023-07-10 05:58:14.000000000","message":"Done","commit_id":"3ae31a2f723119fe2f43133a463822e88c971e8a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"90536d577fa927e176c400aa582437384c080ef4","unresolved":true,"context_lines":[{"line_number":901,"context_line":"\t\t\treg-\u003evalid \u003d true;"},{"line_number":902,"context_line":"\t\t\treg-\u003edirty \u003d false;"},{"line_number":903,"context_line":"\t\t\tLOG_DEBUG(\"Get aux register regnum\u003d%u, name\u003d%s, value\u003d0x%08\" PRIx32,"},{"line_number":904,"context_line":"\t\t\t\ti, arc_reg-\u003ename, aux_values[aux_cnt++]);"},{"line_number":905,"context_line":"\t\t}"},{"line_number":906,"context_line":"\t}"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf222d12_b39c9aa6","line":904,"updated":"2023-07-09 13:34:53.000000000","message":"same here","commit_id":"3ae31a2f723119fe2f43133a463822e88c971e8a"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"ced7e0dbe1760bcfc9deab317e6fc419656bd33b","unresolved":false,"context_lines":[{"line_number":901,"context_line":"\t\t\treg-\u003evalid \u003d true;"},{"line_number":902,"context_line":"\t\t\treg-\u003edirty \u003d false;"},{"line_number":903,"context_line":"\t\t\tLOG_DEBUG(\"Get aux register regnum\u003d%u, name\u003d%s, value\u003d0x%08\" PRIx32,"},{"line_number":904,"context_line":"\t\t\t\ti, arc_reg-\u003ename, aux_values[aux_cnt++]);"},{"line_number":905,"context_line":"\t\t}"},{"line_number":906,"context_line":"\t}"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"705b129b_12e0f464","line":904,"in_reply_to":"bf222d12_b39c9aa6","updated":"2023-07-10 05:58:14.000000000","message":"Done","commit_id":"3ae31a2f723119fe2f43133a463822e88c971e8a"}]}