)]}'
{"id":"openocd~master~I8f2d79404707fbac4503af45b393ea73f91e6beb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002160":{"account":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"last_update":"2023-07-22 20:12:21.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-07-22 20:12:04.000000000","reason":"removed on reply"},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2023-07-11 07:07:17.000000000","reason":"\u003cGERRIT_ACCOUNT_1001674\u003e replied on the change","reason_account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}}},"hashtags":[],"change_id":"I8f2d79404707fbac4503af45b393ea73f91e6beb","subject":"target/arc: fix off-by-one error in arc_save_context()","status":"MERGED","created":"2023-07-07 14:08:37.000000000","updated":"2023-07-22 20:12:21.000000000","submitted":"2023-07-22 20:12:21.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7765","meta_rev_id":"67fd19633e212b5463905e6a48675c8ccf7b17b5","_number":7765,"owner":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-22 20:12:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-22 20:12:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-22 20:12:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-07 14:28:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-09 13:34:53.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-07-10 05:56:20.000000000","updated_by":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2023-07-10 10:47:18.000000000","updated_by":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REMOVED"},{"updated":"2023-07-10 13:39:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"935a45f17ad83043ac1299825502ba1b5eafbc5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-07 14:08:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"44b0964d373e8475c95b7f9be1de2245eb57284e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-07 14:28:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17933/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17132/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"90536d577fa927e176c400aa582437384c080ef4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-09 13:34:53.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"393ec4379b62d4b4234d072e526fa676926aed6e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-10 05:54:33.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ced7e0dbe1760bcfc9deab317e6fc419656bd33b","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-10 05:58:14.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"31a92f7557888874c7dbea2945c74b347b846a18","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-10 08:46:38.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"20f64d262541c758564ccabf6a29577143520108","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-10 10:47:18.000000000","message":"Removed reviewer \u003cGERRIT_ACCOUNT_1000014\u003e.","accounts_in_message":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"_revision_number":2},{"id":"38673b6ad8f944bbb8855488340a346d2345dbc8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-10 13:08:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"206b1fa23171942a40ccca0838c0e62f811075f4","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-10 13:28:19.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6e8c16b270a10ab0acb4efaaa8159d371db61e0a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-10 13:35:08.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6333897e15f415b3b6a1f866a977bc7962d4e8c2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-10 13:39:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17945/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17144/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9e00a99e6d0d9fcafb25588e27fb0bcc33e328ca","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-10 13:44:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7fc573168c797b1b594497c0be97da76cd9832db","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-07-11 07:07:17.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"729bfee7878881e25a6b55d55b4a9d8efd58a314","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-22 20:12:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"67fd19633e212b5463905e6a48675c8ccf7b17b5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-22 20:12:21.000000000","message":"Change has been successfully cherry-picked as d57b2448eea7fac0d5ccf8b047adf0a57a557cb5","accounts_in_message":[],"_revision_number":3}],"current_revision":"d57b2448eea7fac0d5ccf8b047adf0a57a557cb5","revisions":{"d57b2448eea7fac0d5ccf8b047adf0a57a557cb5":{"kind":"REWORK","_number":3,"created":"2023-07-22 20:12:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/65/7765/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/7765/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/3 \u0026\u0026 git checkout -b change-7765 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/7765/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c57d11c78108c6547f31ca07f1ff672fa855f10","subject":"tcl/board: add esp32s3-builtin.cfg file"}],"author":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-05 13:43:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-22 20:12:21.000000000","tz":0},"subject":"target/arc: fix off-by-one error in arc_save_context()","message":"target/arc: fix off-by-one error in arc_save_context()\n\nWhile not affecting the function\u0027s main purpose, an error has\ncrept into arc_save_context() that results in logging wrong register\nvalues when the debug level is 3 or more. For instance, when debugging a\ntrivial program and halting at entry to main, the following values are\nprinted to the log:\n\nDebug: 2915 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d0,\nname\u003dr0, value\u003d0x0000000\n...\nDebug: 2947 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d60,\nname\u003dlp_count, value\u003d0x900002d8\nDebug: 2948 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d63,\nname\u003dpcl, value\u003d0xffffffff\nDebug: 2949 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d64,\nname\u003dpc, value\u003d0x900000b4\nDebug: 2950 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d65,\nname\u003dlp_start, value\u003d0x900000bc\nDebug: 2951 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d66,\nname\u003dlp_end, value\u003d0x00080801\nDebug: 2952 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d67,\nname\u003dstatus32, value\u003d0xffffffff\n\nAfter the change, the register contents make much more sense:\n\nDebug: 2923 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d0,\nname\u003dr0, value\u003d0x00000000\n...\nDebug: 2955 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d60,\nname\u003dlp_count, value\u003d0x00000000\nDebug: 2956 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d63,\nname\u003dpcl, value\u003d0x900002d8\nDebug: 2957 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d64,\nname\u003dpc, value\u003d0x900002da\nDebug: 2958 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d65,\nname\u003dlp_start, value\u003d0x900000b4\nDebug: 2959 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d66,\nname\u003dlp_end, value\u003d0x900000bc\nDebug: 2960 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d67,\nname\u003dstatus32, value\u003d0x00080801\n\nWhile at it, simplify a couple of expressions.\n\nChange-Id: I8f2d79404707fbac4503af45b393ea73f91e6beb\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7765\nTested-by: jenkins\nReviewed-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"fbcedc20d098c5e5e7d118c9f071d3db1d28c280":{"kind":"REWORK","_number":2,"created":"2023-07-10 05:54:33.000000000","uploader":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"ref":"refs/changes/65/7765/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/7765/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/2 \u0026\u0026 git checkout -b change-7765 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/7765/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56fd04832abc0ebadc21ee6127be4be9c7b46e15","subject":"semihosting: fix handling of errno"}],"author":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-05 13:43:08.000000000","tz":120},"committer":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-10 05:52:28.000000000","tz":120},"subject":"target/arc: fix off-by-one error in arc_save_context()","message":"target/arc: fix off-by-one error in arc_save_context()\n\nWhile not affecting the function\u0027s main purpose, an error has\ncrept into arc_save_context() that results in logging wrong register\nvalues when the debug level is 3 or more. For instance, when debugging a\ntrivial program and halting at entry to main, the following values are\nprinted to the log:\n\nDebug: 2915 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d0,\nname\u003dr0, value\u003d0x0000000\n...\nDebug: 2947 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d60,\nname\u003dlp_count, value\u003d0x900002d8\nDebug: 2948 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d63,\nname\u003dpcl, value\u003d0xffffffff\nDebug: 2949 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d64,\nname\u003dpc, value\u003d0x900000b4\nDebug: 2950 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d65,\nname\u003dlp_start, value\u003d0x900000bc\nDebug: 2951 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d66,\nname\u003dlp_end, value\u003d0x00080801\nDebug: 2952 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d67,\nname\u003dstatus32, value\u003d0xffffffff\n\nAfter the change, the register contents make much more sense:\n\nDebug: 2923 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d0,\nname\u003dr0, value\u003d0x00000000\n...\nDebug: 2955 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d60,\nname\u003dlp_count, value\u003d0x00000000\nDebug: 2956 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d63,\nname\u003dpcl, value\u003d0x900002d8\nDebug: 2957 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d64,\nname\u003dpc, value\u003d0x900002da\nDebug: 2958 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d65,\nname\u003dlp_start, value\u003d0x900000b4\nDebug: 2959 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d66,\nname\u003dlp_end, value\u003d0x900000bc\nDebug: 2960 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d67,\nname\u003dstatus32, value\u003d0x00080801\n\nWhile at it, simplify a couple of expressions.\n\nChange-Id: I8f2d79404707fbac4503af45b393ea73f91e6beb\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\n"}},"3ae31a2f723119fe2f43133a463822e88c971e8a":{"kind":"REWORK","_number":1,"created":"2023-07-07 14:08:37.000000000","uploader":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"ref":"refs/changes/65/7765/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/7765/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/1 \u0026\u0026 git checkout -b change-7765 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/7765/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/7765/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56fd04832abc0ebadc21ee6127be4be9c7b46e15","subject":"semihosting: fix handling of errno"}],"author":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-05 13:43:08.000000000","tz":120},"committer":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-07 14:03:18.000000000","tz":120},"subject":"target/arc: Fix off-by-one error in arc_save_context()","message":"target/arc: Fix off-by-one error in arc_save_context()\n\nWhile not affecting the function\u0027s main purpose, an error has\ncrept into arc_save_context() that results in logging wrong register\nvalues when the debug level is 3 or more. For instance, when debugging a\ntrivial program and halting at entry to main, the following values are\nprinted to the log:\n\nDebug: 2915 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d0,\nname\u003dr0, value\u003d0x0000000w\n...\nDebug: 2947 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d60,\nname\u003dlp_count, value\u003d0x900002d8\nDebug: 2948 2020 arc.c:894 arc_save_context(): Get core register regnum\u003d63,\nname\u003dpcl, value\u003d0xffffffff\nDebug: 2949 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d64,\nname\u003dpc, value\u003d0x900000b4\nDebug: 2950 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d65,\nname\u003dlp_start, value\u003d0x900000bc\nDebug: 2951 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d66,\nname\u003dlp_end, value\u003d0x00080801\nDebug: 2952 2020 arc.c:909 arc_save_context(): Get aux register regnum\u003d67,\nname\u003dstatus32, value\u003d0xffffffff\n\nAfter the change, the register contents make much more sense:\n\nDebug: 2923 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d0,\nname\u003dr0, value\u003d0x00000000\n...\nDebug: 2955 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d60,\nname\u003dlp_count, value\u003d0x00000000\nDebug: 2956 3934 arc.c:889 arc_save_context(): Get core register regnum\u003d63,\nname\u003dpcl, value\u003d0x900002d8\nDebug: 2957 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d64,\nname\u003dpc, value\u003d0x900002da\nDebug: 2958 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d65,\nname\u003dlp_start, value\u003d0x900000b4\nDebug: 2959 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d66,\nname\u003dlp_end, value\u003d0x900000bc\nDebug: 2960 3934 arc.c:903 arc_save_context(): Get aux register regnum\u003d67,\nname\u003dstatus32, value\u003d0x00080801\n\nWhile at it, simplify a couple of expressions.\n\nChange-Id: I8f2d79404707fbac4503af45b393ea73f91e6beb\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}