)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"acc1a4a02f050969052f2ce75cee941d011028a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c626df50_a954bebf","updated":"2023-11-25 23:30:00.000000000","message":"Where is the source code used to generate the files .inc?\nIf that code is not under GPL or a compatible license, the inc files cannot be included in OpenOCD","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"00b1cf02a7aa9000844a03b4b0c0776c6576cfa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56bcc8a4_30fc2f8b","in_reply_to":"12a8b7fe_8a9c29b5","updated":"2023-11-29 15:18:24.000000000","message":"yes, we will upstream all of them. (xtensa first. esp32, esp32s2 and esp32s3) \n\nI can clean but some function names will be from esp-idf with camelCase/PascalCase notation. \nLet me check, which errors needs to be filtered out.","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1f770aa6ca9f50c2562f4259621ea3f300859d5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c7a8e95_1e89c260","in_reply_to":"56bcc8a4_30fc2f8b","updated":"2023-11-29 15:59:15.000000000","message":"These are names from external libraries, so it\u0027s ok to filter them out.\nMaybe split it in one or more patch only for contrib folder and one for the flash driver, so we get FW and openocd code decoupled.","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"ffd4caa200b4df3e15fd521e035daf9860985c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e693ff1f_edf4a262","in_reply_to":"c626df50_a954bebf","updated":"2023-11-26 15:59:20.000000000","message":"It is under GPL. \n\nhttps://github.com/espressif/openocd-esp32/blob/master/contrib/loaders/flash/esp/esp32/stub_flasher_chip.c\n\nShould we add a license file somehow? We also can upload the sources but we will have to filter from the checkpatch.","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c26a17c23a6a6de638b8387d8754b8ba884cce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"12a8b7fe_8a9c29b5","in_reply_to":"e693ff1f_edf4a262","updated":"2023-11-29 15:09:01.000000000","message":"I think that the source code should be upstreamed together with the file.inc\nIn a separate patch, if you think it\u0027s easier/better.\nRegarding checkpatch, I prefer the code to be cleaned.\nI see there is one flash binary for each esp32[chs][32]. Do you plan to upstrea all of them, or is there some redundancy?","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"}],"contrib/loaders/flash/espressif/esp32/stub_flasher_code.inc":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"acc1a4a02f050969052f2ce75cee941d011028a4","unresolved":true,"context_lines":[{"line_number":609,"context_line":"0x80,0x80,0x04,0x92,0xa1,0x03,0x80,0x29,0x83,0x1d,0xf0,0x00,0x36,0x41,0x00,0x20,"},{"line_number":610,"context_line":"0xa0,0xf4,0x20,0x90,0xf5,0x0c,0x08,0x97,0x9a,0x0d,0x0b,0x22,0x7c,0xda,0x0c,0x19,"},{"line_number":611,"context_line":"0x27,0xba,0x02,0x80,0x98,0x20,0x8d,0x09,0x80,0x20,0x04,0x1d,0xf0,"},{"line_number":612,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9379d32b_68695613","line":612,"updated":"2023-11-25 23:30:00.000000000","message":"It\u0027s the second case I find an extra empty line at the end of an auto generated file. What\u0027s the reason?","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"ffd4caa200b4df3e15fd521e035daf9860985c3a","unresolved":false,"context_lines":[{"line_number":609,"context_line":"0x80,0x80,0x04,0x92,0xa1,0x03,0x80,0x29,0x83,0x1d,0xf0,0x00,0x36,0x41,0x00,0x20,"},{"line_number":610,"context_line":"0xa0,0xf4,0x20,0x90,0xf5,0x0c,0x08,0x97,0x9a,0x0d,0x0b,0x22,0x7c,0xda,0x0c,0x19,"},{"line_number":611,"context_line":"0x27,0xba,0x02,0x80,0x98,0x20,0x8d,0x09,0x80,0x20,0x04,0x1d,0xf0,"},{"line_number":612,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"470aa219_72f1adf4","line":612,"in_reply_to":"9379d32b_68695613","updated":"2023-11-26 15:59:20.000000000","message":"On MacOS it is generated with an extra line. Will check it later.","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"}],"src/flash/nor/esp32.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"acc1a4a02f050969052f2ce75cee941d011028a4","unresolved":true,"context_lines":[{"line_number":29,"context_line":"};"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"static const uint8_t esp32_flasher_stub_code[] \u003d {"},{"line_number":32,"context_line":"#include \"contrib/loaders/flash/espressif/esp32/stub_flasher_code.inc\""},{"line_number":33,"context_line":"};"},{"line_number":34,"context_line":"static const uint8_t esp32_flasher_stub_data[] \u003d {"},{"line_number":35,"context_line":"#include \"contrib/loaders/flash/espressif/esp32/stub_flasher_data.inc\""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3a85a062_5b92d05c","line":32,"updated":"2023-11-25 23:30:00.000000000","message":"check how the files from folder contrib are included in OpenOCD source code.\nThe long list of ../../../.. is needed for out-of-tree-build","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"ffd4caa200b4df3e15fd521e035daf9860985c3a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"};"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"static const uint8_t esp32_flasher_stub_code[] \u003d {"},{"line_number":32,"context_line":"#include \"contrib/loaders/flash/espressif/esp32/stub_flasher_code.inc\""},{"line_number":33,"context_line":"};"},{"line_number":34,"context_line":"static const uint8_t esp32_flasher_stub_data[] \u003d {"},{"line_number":35,"context_line":"#include \"contrib/loaders/flash/espressif/esp32/stub_flasher_data.inc\""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e8f31a4a_85d5a501","line":32,"in_reply_to":"3a85a062_5b92d05c","updated":"2023-11-26 15:59:20.000000000","message":"Done","commit_id":"428de2d50b712d3bef100b3e9906edb1b4571843"}]}