)]}'
{"id":"openocd~master~I3d252b97f01f1a1e2bf0eb8fb257bdab0c544bc2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002160":{"account":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"last_update":"2023-10-07 14:42:13.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-09-17 15:25:35.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2023-09-18 05:00:15.000000000","reason":"\u003cGERRIT_ACCOUNT_1001674\u003e replied on the change","reason_account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}}},"hashtags":[],"change_id":"I3d252b97f01f1a1e2bf0eb8fb257bdab0c544bc2","subject":"target/arc: do not invalidate icache when (un)setting breakpoints","status":"MERGED","created":"2023-07-10 06:26:15.000000000","updated":"2023-10-07 14:42:13.000000000","submitted":"2023-10-07 14:42:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7767","meta_rev_id":"efe91e461376e5c8d72bbf8a3203937431de02af","_number":7767,"owner":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-10-07 14:42:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-10-07 14:42:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-10-07 14:42:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-10 06:27:26.000000000","updated_by":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2023-07-10 06:44:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-23 14:53:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-09-17 15:25:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e20f80692967294d8ecee7a6e9df846d7cc183ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-10 06:26:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40fbf4088c62b95580ce6f90aa2b88ed902362e8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-10 06:44:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17940/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17139/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c3039b80ed498ad945b4a671c9379a0030b830ee","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-07-10 06:49:45.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8756f54663b3a04343091e24849c4f464cf848bb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-23 14:53:06.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1968ee23bcb503c73ab8a45a3bae7fae3ee1d641","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-24 20:13:22.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"872cc5cd47baf8e1aba484d05f3a2d3d869fae4d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-07-24 20:13:34.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ded09097e98c1e9abd2cb15aa59a362eb05dd487","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-24 20:25:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/18020/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17219/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"53102c785d1786954fa00c250ce01aef7d342df7","author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"real_author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"date":"2023-08-28 07:11:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4c064642a423d60c49ec4fabb00b7d4163cb1026","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-09-17 15:25:35.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"68bbc786405cf032cc0a51b9fe633fc226db1345","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2023-09-18 05:00:15.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8dbff14df1d74ab892b582738b4f76937fa60fe0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:42:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"efe91e461376e5c8d72bbf8a3203937431de02af","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-10-07 14:42:13.000000000","message":"Change has been successfully cherry-picked as d20304b3fb0f27f62844144837ee5b99ee040bcd","accounts_in_message":[],"_revision_number":3}],"current_revision":"d20304b3fb0f27f62844144837ee5b99ee040bcd","revisions":{"a9e7ccbe43b6a3b08c79debbb244e07a1270193d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-07-24 20:13:34.000000000","uploader":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"ref":"refs/changes/67/7767/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7767/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/2 \u0026\u0026 git checkout -b change-7767 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7767/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56fd04832abc0ebadc21ee6127be4be9c7b46e15","subject":"semihosting: fix handling of errno"}],"author":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-06 11:25:00.000000000","tz":120},"committer":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-24 20:05:55.000000000","tz":120},"subject":"target/arc: do not invalidate icache when (un)setting breakpoints","message":"target/arc: do not invalidate icache when (un)setting breakpoints\n\nCurrently, instruction cache is being invalidated in\narc_{un,}set_breakpoint() regardless of whether the breakpoint\u0027s type is\nHW or SW. For SW breakpoints, this has no net effect as the caches are\nflushed as a by-product of overwriting instructions in main memory and\nis thus merely unnecessary; but for HW breakpoints this invalidation is\nnot preceded by a flush and might lead to loss of data. This patch\nremoves the invalidate() call altogether to correct this undesired\nbehavior for HW breakpoints.\n\nWith this patch applied, all supported HW breakpoint tests from the gdb\ntestsuite are now passing with the arc-openocd backend.\n\nChange-Id: I3d252b97f01f1a1e2bf0eb8fb257bdab0c544bc2\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\n"}},"d20304b3fb0f27f62844144837ee5b99ee040bcd":{"kind":"REWORK","_number":3,"created":"2023-10-07 14:42:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/7767/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7767/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/3 \u0026\u0026 git checkout -b change-7767 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7767/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bdf73617e774b0791f9efec6659c78c1f60c03b5","subject":"armv8_dpm: fix registers read at debug entry"}],"author":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-06 11:25:00.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-10-07 14:42:13.000000000","tz":0},"subject":"target/arc: do not invalidate icache when (un)setting breakpoints","message":"target/arc: do not invalidate icache when (un)setting breakpoints\n\nCurrently, instruction cache is being invalidated in\narc_{un,}set_breakpoint() regardless of whether the breakpoint\u0027s type is\nHW or SW. For SW breakpoints, this has no net effect as the caches are\nflushed as a by-product of overwriting instructions in main memory and\nis thus merely unnecessary; but for HW breakpoints this invalidation is\nnot preceded by a flush and might lead to loss of data. This patch\nremoves the invalidate() call altogether to correct this undesired\nbehavior for HW breakpoints.\n\nWith this patch applied, all supported HW breakpoint tests from the gdb\ntestsuite are now passing with the arc-openocd backend.\n\nChange-Id: I3d252b97f01f1a1e2bf0eb8fb257bdab0c544bc2\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7767\nTested-by: jenkins\nReviewed-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"df9f5863fd7ea3b81f9da3c5de3fadd55fcc64c0":{"kind":"REWORK","_number":1,"created":"2023-07-10 06:26:15.000000000","uploader":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"ref":"refs/changes/67/7767/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/7767/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/1 \u0026\u0026 git checkout -b change-7767 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/7767/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/7767/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56fd04832abc0ebadc21ee6127be4be9c7b46e15","subject":"semihosting: fix handling of errno"}],"author":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-06 11:25:00.000000000","tz":120},"committer":{"name":"Artemiy Volkov","email":"artemiy@synopsys.com","date":"2023-07-10 06:16:02.000000000","tz":120},"subject":"target/arc: do not invalidate icache when (un)setting breakpoints","message":"target/arc: do not invalidate icache when (un)setting breakpoints\n\nCurrently, instruction cache is being invalidated in\narc_{un,}set_breakpoint() regardless of whether the breakpoint\u0027s type is\nHW or SW. For SW breakpoints, this has no net effect as the caches are\nflushed prior to resuming execution anyway and is thus merely\nunnecessary; but for HW breakpoints this invalidation is not preceded by\na flush and might lead to loss of data. This patch removes the\ninvalidate() call altogether to correct this undesired behavior for HW\nbreakpoints.\n\nWith this patch applied, all supported HW breakpoint tests from the gdb\ntestsuite are now passing with the arc-openocd backend.\n\nChange-Id: I3d252b97f01f1a1e2bf0eb8fb257bdab0c544bc2\nSigned-off-by: Artemiy Volkov \u003cartemiy@synopsys.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}