)]}'
{"id":"openocd~master~Ifa063ce828068f8d0371e1c2a864bb6174649848","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002161":{"account":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"last_update":"2024-02-11 23:04:48.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2024-02-11 23:04:48.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-01-28 10:55:43.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2023-12-01 20:03:57.000000000","reason":"\u003cGERRIT_ACCOUNT_1001242\u003e replied on the change","reason_account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}},"hashtags":[],"change_id":"Ifa063ce828068f8d0371e1c2a864bb6174649848","subject":"jtag/mpsse: mpsse_flush should not treat LIBUSB_ERROR_INTERRUPTED as an error","status":"MERGED","created":"2023-07-10 18:06:39.000000000","updated":"2024-02-11 23:04:48.000000000","submitted":"2024-02-11 23:04:48.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7769","meta_rev_id":"da4b2fa2caec1b9f48084627c436875615914a4b","_number":7769,"owner":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-11 23:04:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-11 23:04:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-11 23:04:48.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"}],"reviewers":{"CC":[{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}],"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-10 18:10:38.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"CC"},{"updated":"2023-07-10 18:10:38.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2023-07-10 18:10:38.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"},{"updated":"2023-07-10 18:10:38.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2023-07-10 18:22:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c6ef1e49bf34c6d1b75b2e4af94104f1ef3ccd5a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2023-07-10 18:06:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ce8582126eba18184be6d7739ba787ae3d7b643f","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2023-07-10 18:10:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"88078dcabf848acf74f2a0dd2a003368b6189dff","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-10 18:22:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17956/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17155/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"22870ace1e0294c0dcc82074c6d23c23f2de83f5","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2023-07-27 13:27:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ac7e074afbbc56aee832e17cec24e1c0fc84f920","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2023-11-30 22:52:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"25707bb03d892209207aca547652efc392843b3b","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2023-12-01 20:03:57.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c13dcb5bd837109d8ab858365e56d900916138a1","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2024-01-12 15:39:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9aaa594eb5b32fcf540d2f1d9a23db9dcbc91839","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-28 10:55:43.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d713254d0832a2c48331128df84accd1accc7359","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-11 23:04:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"da4b2fa2caec1b9f48084627c436875615914a4b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-11 23:04:48.000000000","message":"Change has been successfully cherry-picked as 50be4bd2672916f9262df31108d4611c2b0fbf44","accounts_in_message":[],"_revision_number":2}],"current_revision":"50be4bd2672916f9262df31108d4611c2b0fbf44","revisions":{"50be4bd2672916f9262df31108d4611c2b0fbf44":{"kind":"REWORK","_number":2,"created":"2024-02-11 23:04:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/69/7769/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/69/7769/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/2 \u0026\u0026 git checkout -b change-7769 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/69/7769/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b5ef1726a4e5da657080d640e16f1f4d9dc6071","subject":"jtag/drivers: Add vid_pid command to OpenJTAG"}],"author":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2023-07-10 13:30:07.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-11 23:04:48.000000000","tz":0},"subject":"jtag/mpsse: mpsse_flush should not treat LIBUSB_ERROR_INTERRUPTED as an error","message":"jtag/mpsse: mpsse_flush should not treat LIBUSB_ERROR_INTERRUPTED as an error\n\nLIBUSB_ERROR_INTERRUPTED can happen when (among other things) OpenOCD\nprocess receives a signal like SIGHUP or SIGINT during a call to libusb.\nSuch situations are expected and should not be treated as an error - the\naffected request should just be restarted.\n\nWithout this patch applied if a signal arrives during FTDI initialization\nprocedure we can easily end up (if JTAG speed is low) in situations like\nhttps://review.openocd.org/c/openocd/+/4767. This happens because\nfpsse_flush fails due to LIBUSB_ERROR_INTERRUPTED .\n\nIt should be noted that the current usage of mpsse_flush should be\nrevised since it seems that we don\u0027t always process error codes returned\nby the function.\n\nChange-Id: Ifa063ce828068f8d0371e1c2a864bb6174649848\nSigned-off-by: Parshintsev Anatoly \u003canatoly.parshintsev@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7769\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"c701787543e9ac6d6eaced0de5c17bee6fd26427":{"kind":"REWORK","_number":1,"created":"2023-07-10 18:06:39.000000000","uploader":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"ref":"refs/changes/69/7769/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/69/7769/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/1 \u0026\u0026 git checkout -b change-7769 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/69/7769/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/69/7769/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a96776178676963a179879624190acea1e26158","subject":"jtag/stlink: add STLINK-V3PWR support"}],"author":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2023-07-10 13:30:07.000000000","tz":180},"committer":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2023-07-10 18:03:12.000000000","tz":180},"subject":"jtag/mpsse: mpsse_flush should not treat LIBUSB_ERROR_INTERRUPTED as an error","message":"jtag/mpsse: mpsse_flush should not treat LIBUSB_ERROR_INTERRUPTED as an error\n\nLIBUSB_ERROR_INTERRUPTED can happen when (among other things) OpenOCD\nprocess receives a signal like SIGHUP or SIGINT during a call to libusb.\nSuch situations are expected and should not be treated as an error - the\naffected request should just be restarted.\n\nWithout this patch applied if a signal arrives during FTDI initialization\nprocedure we can easily end up (if JTAG speed is low) in situations like\nhttps://review.openocd.org/c/openocd/+/4767. This happens because\nfpsse_flush fails due to LIBUSB_ERROR_INTERRUPTED .\n\nIt should be noted that the current usage of mpsse_flush should be\nrevised since it seems that we don\u0027t always process error codes returned\nby the function.\n\nChange-Id: Ifa063ce828068f8d0371e1c2a864bb6174649848\nSigned-off-by: Parshintsev Anatoly \u003canatoly.parshintsev@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}