)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"6fc60a1c5531c4a7db3ccf2b1478f15850466479","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64de6505_c596e858","updated":"2023-07-12 11:07:42.000000000","message":"@Antonio, should I keep \"esp_xtensa_stub_tramp_win.inc\" here, or move under contrib folder?","commit_id":"f732b43aee79538f2acdd2128f3f7d1f7d67eb3f"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"1ecbfd96da7d7d85010f78db734f957cf96969e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"965087ff_261cc29f","in_reply_to":"2b215060_d35aae86","updated":"2023-09-10 19:53:34.000000000","message":"Done. Created a new folder called loaders/flash/trampoline/espressif/xtensa","commit_id":"f732b43aee79538f2acdd2128f3f7d1f7d67eb3f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a16772774cd896f0e395810bc7070fcf529440b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2b215060_d35aae86","in_reply_to":"53411316_5727e48f","updated":"2023-09-10 17:00:41.000000000","message":"It should be better to put it under contrib folder, with a simple makefile to be able to re-build it","commit_id":"f732b43aee79538f2acdd2128f3f7d1f7d67eb3f"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"9830d2899a1e21f32c968fa4423c9f906c3b2a88","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53411316_5727e48f","in_reply_to":"64de6505_c596e858","updated":"2023-08-31 11:01:15.000000000","message":"Hi Antonio, reminder. In case you missed the question.","commit_id":"f732b43aee79538f2acdd2128f3f7d1f7d67eb3f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9a16772774cd896f0e395810bc7070fcf529440b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"876dd081_8d428d50","updated":"2023-09-10 17:00:41.000000000","message":"Jenkins have removed the build files, I cannot see what was the build failure.","commit_id":"1d70c02d164b72c0ce779de69b9dddecaaa19425"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9179719579ef224d7e5a1b5734468144135915ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2d1df783_b5d3531f","updated":"2023-11-25 19:02:46.000000000","message":"I\u0027m ok with this patch.\nThere is one curiosity about the file.inc; would you mind checking it?\nIf you find it was a mistake, you can edit it with gerrit web interface to drop the line, without pushing a new patch-set","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"034f6db9a8029c41e7f179dcc10d8a44efbb5e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"add11595_74a18cfa","updated":"2023-11-26 13:46:27.000000000","message":"Thank you Antonio, Ian for the review.","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"}],"contrib/loaders/trampoline/espressif/xtensa/esp_xtensa_stub_tramp_win.inc":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9179719579ef224d7e5a1b5734468144135915ea","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* Autogenerated with ../../../../../src/helper/bin2char.sh */"},{"line_number":2,"context_line":"0x92,0xc1,0x20,0x90,0xd1,0x49,0xad,0x02,0xbd,0x03,0xcd,0x04,0xdd,0x05,0x60,0xe6,"},{"line_number":3,"context_line":"0x20,0xe0,0x08,0x00,0x2d,0x0a,0x00,0x40,0x00,0x06,0xff,0xff,"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"86ef5ca2_7d450e2c","line":4,"updated":"2023-11-25 19:02:46.000000000","message":"what a surprise, an empty line at the end of the autogenerated file!\nDid you edited it? Or the tool got mad in your PC?","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"034f6db9a8029c41e7f179dcc10d8a44efbb5e1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* Autogenerated with ../../../../../src/helper/bin2char.sh */"},{"line_number":2,"context_line":"0x92,0xc1,0x20,0x90,0xd1,0x49,0xad,0x02,0xbd,0x03,0xcd,0x04,0xdd,0x05,0x60,0xe6,"},{"line_number":3,"context_line":"0x20,0xe0,0x08,0x00,0x2d,0x0a,0x00,0x40,0x00,0x06,0xff,0xff,"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"4e3e0ff4_7af830c5","line":4,"in_reply_to":"86ef5ca2_7d450e2c","updated":"2023-11-26 13:46:27.000000000","message":"Looks like one more empty line is added on MacOS, but on Linux, it is okay. I will check the reason later.","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"}],"src/target/espressif/esp.c":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"97f4fb6a14e22474e5fc9a50bfde22932bb04f1c","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"int esp_common_init(struct esp_common *esp, const struct algorithm_hw *algo_hw)"},{"line_number":18,"context_line":"{"},{"line_number":19,"context_line":"\tesp-\u003ealgo_hw \u003d algo_hw;"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\treturn ERROR_OK;"},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"59347373_0504f7d0","line":19,"updated":"2023-11-25 22:30:29.000000000","message":"check for null esp pointer already done elsewhere?","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"034f6db9a8029c41e7f179dcc10d8a44efbb5e1f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"int esp_common_init(struct esp_common *esp, const struct algorithm_hw *algo_hw)"},{"line_number":18,"context_line":"{"},{"line_number":19,"context_line":"\tesp-\u003ealgo_hw \u003d algo_hw;"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\treturn ERROR_OK;"},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"55203a92_9ccbd4bb","line":19,"in_reply_to":"59347373_0504f7d0","updated":"2023-11-26 13:46:27.000000000","message":"Although the flow guarantees a valid pointer, I added a null check anyway.","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"}],"src/target/espressif/esp_xtensa.c":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"97f4fb6a14e22474e5fc9a50bfde22932bb04f1c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"\t\treturn ret;"},{"line_number":73,"context_line":"\tret \u003d esp_common_init(\u0026esp_xtensa-\u003eesp, \u0026xtensa_algo_hw);"},{"line_number":74,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":75,"context_line":"\t\treturn ret;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\tesp_xtensa-\u003esemihost.ops \u003d (struct esp_semihost_ops *)semihost_ops;"},{"line_number":78,"context_line":"\tesp_xtensa-\u003eapptrace.hw \u003d \u0026esp_xtensa_apptrace_hw;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"b388317c_8ed6b998","line":75,"updated":"2023-11-25 22:30:29.000000000","message":"any need to de-init esp_xtensa-\u003extensa for this failure?","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"034f6db9a8029c41e7f179dcc10d8a44efbb5e1f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\t\treturn ret;"},{"line_number":73,"context_line":"\tret \u003d esp_common_init(\u0026esp_xtensa-\u003eesp, \u0026xtensa_algo_hw);"},{"line_number":74,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":75,"context_line":"\t\treturn ret;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"\tesp_xtensa-\u003esemihost.ops \u003d (struct esp_semihost_ops *)semihost_ops;"},{"line_number":78,"context_line":"\tesp_xtensa-\u003eapptrace.hw \u003d \u0026esp_xtensa_apptrace_hw;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"45cd7a80_9f293968","line":75,"in_reply_to":"b388317c_8ed6b998","updated":"2023-11-26 13:46:27.000000000","message":"If there is an error, openocd will be terminated. Cleanup will be done by OS.","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"}],"src/target/espressif/esp_xtensa_algorithm.c":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"97f4fb6a14e22474e5fc9a50bfde22932bb04f1c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"\tstruct reg_param *params \u003d run-\u003ereg_args.params;"},{"line_number":54,"context_line":"\tinit_reg_param(\u0026params[0], \"a0\", 32, PARAM_OUT);\t\t/*TODO: move to tramp */"},{"line_number":55,"context_line":"\tinit_reg_param(\u0026params[1], \"a1\", 32, PARAM_OUT);"},{"line_number":56,"context_line":"\tinit_reg_param(\u0026params[2], \"a8\", 32, PARAM_OUT);"},{"line_number":57,"context_line":"\tinit_reg_param(\u0026params[3], \"windowbase\", 32, PARAM_OUT);\t/*TODO: move to tramp */"},{"line_number":58,"context_line":"\tinit_reg_param(\u0026params[4], \"windowstart\", 32, PARAM_OUT);\t/*TODO: move to tramp */"},{"line_number":59,"context_line":"\tinit_reg_param(\u0026params[5], \"ps\", 32, PARAM_OUT);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"dc48e7a4_fb9bacfe","line":56,"updated":"2023-11-25 22:30:29.000000000","message":"Not advocating for a change, but using a8 could trigger a window overflow, with the resulting spill incurring a performance penalty.  Or perhaps you need to use a8 for some other reason?  Might be worth considering for a future enhancement.  Marking this as resolved since it\u0027s not actionable for this review.","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"034f6db9a8029c41e7f179dcc10d8a44efbb5e1f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"\tstruct reg_param *params \u003d run-\u003ereg_args.params;"},{"line_number":54,"context_line":"\tinit_reg_param(\u0026params[0], \"a0\", 32, PARAM_OUT);\t\t/*TODO: move to tramp */"},{"line_number":55,"context_line":"\tinit_reg_param(\u0026params[1], \"a1\", 32, PARAM_OUT);"},{"line_number":56,"context_line":"\tinit_reg_param(\u0026params[2], \"a8\", 32, PARAM_OUT);"},{"line_number":57,"context_line":"\tinit_reg_param(\u0026params[3], \"windowbase\", 32, PARAM_OUT);\t/*TODO: move to tramp */"},{"line_number":58,"context_line":"\tinit_reg_param(\u0026params[4], \"windowstart\", 32, PARAM_OUT);\t/*TODO: move to tramp */"},{"line_number":59,"context_line":"\tinit_reg_param(\u0026params[5], \"ps\", 32, PARAM_OUT);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"cfd60266_2258b691","line":56,"in_reply_to":"dc48e7a4_fb9bacfe","updated":"2023-11-26 13:46:27.000000000","message":"Thanks for heads-up. Created an internal jira task to follow it.","commit_id":"930c6fd420b965cd1ed1f78c0f314c6c2681445b"}]}