)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d90832de9ed194635c51ab1787fe6e012112a101","unresolved":true,"context_lines":[{"line_number":9,"context_line":"add a line that checks the returned value of set signals function"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"add two VIDs of other original boards (have onboard angie architecture)"},{"line_number":12,"context_line":"so angie driver can connect to them can change their VID after"},{"line_number":13,"context_line":"renumeration."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ide4f1f6f38168a410191bf3ff75bcd59dcf7ef50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fac078b3_5830fcbe","line":12,"updated":"2023-08-18 16:03:42.000000000","message":"please revisit this sentence, doesn\u0027t look correct.","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"0beca4b2a627fecd60855069ab2f09859cb0f505","unresolved":false,"context_lines":[{"line_number":9,"context_line":"add a line that checks the returned value of set signals function"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"add two VIDs of other original boards (have onboard angie architecture)"},{"line_number":12,"context_line":"so angie driver can connect to them can change their VID after"},{"line_number":13,"context_line":"renumeration."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ide4f1f6f38168a410191bf3ff75bcd59dcf7ef50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3d6b6267_0154b80e","line":12,"in_reply_to":"fac078b3_5830fcbe","updated":"2023-08-18 16:51:31.000000000","message":"Done","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"0beca4b2a627fecd60855069ab2f09859cb0f505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78131051_2695672a","updated":"2023-08-18 16:51:31.000000000","message":"all Done","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"70783340d7ca35e10f0f5913b38343d6bc607d6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5cfa9d15_2091fc1a","updated":"2023-08-18 17:40:20.000000000","message":"thanks","commit_id":"cb60aeee4dd5d6e02916f6d2972e4ec29c027408"}],"contrib/60-openocd.rules":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d90832de9ed194635c51ab1787fe6e012112a101","unresolved":true,"context_lines":[{"line_number":228,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"424e\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":229,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"4a55\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":230,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"4255\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":231,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"4355\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# Marvell Sheevaplug"},{"line_number":234,"context_line":"ATTRS{idVendor}\u003d\u003d\"9e88\", ATTRS{idProduct}\u003d\u003d\"9e8f\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"70cb78f0_798b4e77","line":231,"updated":"2023-08-18 16:03:42.000000000","message":"what about keeping the product ID in numeric order for the same vendor ID?","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"0beca4b2a627fecd60855069ab2f09859cb0f505","unresolved":false,"context_lines":[{"line_number":228,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"424e\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":229,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"4a55\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":230,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"4255\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":231,"context_line":"ATTRS{idVendor}\u003d\u003d\"584e\", ATTRS{idProduct}\u003d\u003d\"4355\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# Marvell Sheevaplug"},{"line_number":234,"context_line":"ATTRS{idVendor}\u003d\u003d\"9e88\", ATTRS{idProduct}\u003d\u003d\"9e8f\", MODE\u003d\"660\", GROUP\u003d\"plugdev\", TAG+\u003d\"uaccess\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8974dd36_e1698726","line":231,"in_reply_to":"70cb78f0_798b4e77","updated":"2023-08-18 16:51:31.000000000","message":"Done","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"}],"src/jtag/drivers/angie.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d90832de9ed194635c51ab1787fe6e012112a101","unresolved":true,"context_lines":[{"line_number":33,"context_line":"#define ANGIE_PID\t\t\t\t0x424e"},{"line_number":34,"context_line":"#define ANGIE_PID_2\t\t\t\t0x4a55"},{"line_number":35,"context_line":"#define ANGIE_PID_3             0x4255"},{"line_number":36,"context_line":"#define ANGIE_PID_4             0x4355"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"/** Address of EZ-USB ANGIE CPU Control \u0026 Status register. This register can be"},{"line_number":39,"context_line":" *  written by issuing a Control EP0 vendor request. */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d9798b31_d773ad61","line":36,"updated":"2023-08-18 16:03:42.000000000","message":"also here, keep the PID in order by value and use the same indentation (or TAB or space)\nThe macro name is not really important nor used in the code, so I expect you can use:\n#define ANGIE_PID   0x424e\n#define ANGIE_PID_2 0x4255\n#define ANGIE_PID_3 0x4355\n#define ANGIE_PID_4 0x4a55","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"0beca4b2a627fecd60855069ab2f09859cb0f505","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#define ANGIE_PID\t\t\t\t0x424e"},{"line_number":34,"context_line":"#define ANGIE_PID_2\t\t\t\t0x4a55"},{"line_number":35,"context_line":"#define ANGIE_PID_3             0x4255"},{"line_number":36,"context_line":"#define ANGIE_PID_4             0x4355"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"/** Address of EZ-USB ANGIE CPU Control \u0026 Status register. This register can be"},{"line_number":39,"context_line":" *  written by issuing a Control EP0 vendor request. */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"637dacc9_49b37f19","line":36,"in_reply_to":"d9798b31_d773ad61","updated":"2023-08-18 16:51:31.000000000","message":"Done","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"},{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"d6b9f04ff40a475c56777fde4ee8d6b12f962dca","unresolved":true,"context_lines":[{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"\tint ret \u003d angie_append_set_signals_cmd(device, low, high);"},{"line_number":1724,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"},{"line_number":1725,"context_line":"\t\tangie_clear_queue(device);"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"\tret \u003d angie_execute_queued_commands(device, LIBUSB_TIMEOUT_MS);"},{"line_number":1728,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"7726fc39_8c3812c7","line":1725,"updated":"2023-12-01 18:28:41.000000000","message":"Antonio,  Ahmed: \n\nMaybe I\u0027m missing something (I\u0027m not familliar with this part of code). I was just browsing the change log...\n\nBut this line does not look right. It looks like we allocate scan command and if the allocation succeeds clear the queue. \n\nIn case I\u0027ve misread this code - sorry for the disturbance (I hope that no harm is done).","commit_id":"aa0056d27355d7719a120cdc4292215acae40819"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"e0326af1d8c597e075c2b1258c64fc644248ebca","unresolved":true,"context_lines":[{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"\tint ret \u003d angie_append_set_signals_cmd(device, low, high);"},{"line_number":1724,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"},{"line_number":1725,"context_line":"\t\tangie_clear_queue(device);"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"\tret \u003d angie_execute_queued_commands(device, LIBUSB_TIMEOUT_MS);"},{"line_number":1728,"context_line":"\tif (ret \u003d\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"e521b1be_822685e3","line":1725,"in_reply_to":"7726fc39_8c3812c7","updated":"2023-12-04 09:49:30.000000000","message":"Hello,\nI think you are right, the angie_clear_queue() function should be executed after the angie_execute_queued_commands() not before it, thank you for noticing.\ni will correct and test this part.\nCordialement.","commit_id":"aa0056d27355d7719a120cdc4292215acae40819"}]}