)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-18 11:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"contrib/frimware: add new i2c bit-banging feature to angie\u0027s firmware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add new i2c bit-banging feature, we can now connect in JTAG with the SoC"},{"line_number":10,"context_line":"target and in i2c with the dev-kit board components at the same time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5b12b53e_730f2f1c","line":7,"updated":"2023-08-18 16:21:10.000000000","message":"typo s/frimware/firmware/","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmed BOUDJELIDA \u003caboudjelida@nanoxplore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-18 11:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"contrib/frimware: add new i2c bit-banging feature to angie\u0027s firmware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add new i2c bit-banging feature, we can now connect in JTAG with the SoC"},{"line_number":10,"context_line":"target and in i2c with the dev-kit board components at the same time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"24fe453b_3569f65d","line":7,"in_reply_to":"5b12b53e_730f2f1c","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a75d6b2_dfd85c63","updated":"2023-08-18 16:21:10.000000000","message":"There is some minor comment here and there, but nothing critical.\n\nI\u0027m surprised you have completely reworked the whole USB descriptor of Angie adapter but you have kept the same VID:PID pair. Usually the VID:PID is supposed to change at any new USB layout.\nAnyway, if this adapter has not been distributed yet, I don\u0027t expect this to cause any problem.","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"}],"contrib/firmware/angie/c/src/i2c.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e321b242_1e4da0d7","line":129,"updated":"2023-08-18 16:21:10.000000000","message":"drop the extra line at the end of the file","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1ba1d796_679ef40a","line":129,"in_reply_to":"e321b242_1e4da0d7","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"}],"contrib/firmware/angie/c/src/protocol.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[{"line_number":141,"context_line":"\t/* Determine if this was the last command */"},{"line_number":142,"context_line":"\tif ((cmd_id_index + usb_out_bytecount + 1) \u003e\u003d EP1OUTBC) {"},{"line_number":143,"context_line":"\t\treturn true;"},{"line_number":144,"context_line":"\t\t/* Line between return and else required by checkpatch: */"},{"line_number":145,"context_line":"\t\tuint8_t a \u003d 0;"},{"line_number":146,"context_line":"\t} else {"},{"line_number":147,"context_line":"\t\t/* Not the last command, update cmd_id_index */"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3e8c62b4_2a661c4e","side":"PARENT","line":144,"updated":"2023-08-18 16:21:10.000000000","message":"What checkpatch say here is that there is no need for \"else\" after a \"return\".\nThe code here should be written as:\n\n if ((cmd_id_index + usb_out_bytecount + 1) \u003e\u003d EP1OUTBC)\n   return true;\n /\\* Not the last command, update cmd_id_index \\*/\n cmd_id_index +\u003d (usb_out_bytecount + 1);\n return false;","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"\t/* Determine if this was the last command */"},{"line_number":142,"context_line":"\tif ((cmd_id_index + usb_out_bytecount + 1) \u003e\u003d EP1OUTBC) {"},{"line_number":143,"context_line":"\t\treturn true;"},{"line_number":144,"context_line":"\t\t/* Line between return and else required by checkpatch: */"},{"line_number":145,"context_line":"\t\tuint8_t a \u003d 0;"},{"line_number":146,"context_line":"\t} else {"},{"line_number":147,"context_line":"\t\t/* Not the last command, update cmd_id_index */"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"19e5d3ae_c859dfc4","side":"PARENT","line":144,"in_reply_to":"3e8c62b4_2a661c4e","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"9cd4c9aa7fb2a1250fb017a4ff8b12956f01558f"}],"contrib/firmware/angie/hdl/src/angie_bitstream.ucf":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[{"line_number":15,"context_line":"net TCK\t\tLOC \u003d \u0027P44\u0027 ;"},{"line_number":16,"context_line":"net TDI\t\tLOC \u003d \u0027P45\u0027 ;"},{"line_number":17,"context_line":"net TDO\t\tLOC \u003d \u0027P46\u0027 ;"},{"line_number":18,"context_line":"net SRST        LOC \u003d \u0027P61\u0027 ;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"net SDA\t\tLOC \u003d \u0027P50\u0027 ;"},{"line_number":21,"context_line":"net SCL\t        LOC \u003d \u0027P51\u0027 ;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"a13e53c2_3b2ba5d5","line":18,"updated":"2023-08-18 16:21:10.000000000","message":"use TAB for indentation, not space","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"net TCK\t\tLOC \u003d \u0027P44\u0027 ;"},{"line_number":16,"context_line":"net TDI\t\tLOC \u003d \u0027P45\u0027 ;"},{"line_number":17,"context_line":"net TDO\t\tLOC \u003d \u0027P46\u0027 ;"},{"line_number":18,"context_line":"net SRST        LOC \u003d \u0027P61\u0027 ;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"net SDA\t\tLOC \u003d \u0027P50\u0027 ;"},{"line_number":21,"context_line":"net SCL\t        LOC \u003d \u0027P51\u0027 ;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"ba2b8267_6c3e7436","line":18,"in_reply_to":"a13e53c2_3b2ba5d5","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[{"line_number":18,"context_line":"net SRST        LOC \u003d \u0027P61\u0027 ;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"net SDA\t\tLOC \u003d \u0027P50\u0027 ;"},{"line_number":21,"context_line":"net SCL\t        LOC \u003d \u0027P51\u0027 ;"},{"line_number":22,"context_line":"net SDA_DIR\tLOC \u003d \u0027P56\u0027 ;"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"net SI_TDO\tLOC \u003d \u0027P16\u0027 ;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"e2014ccc_2f74848a","line":21,"updated":"2023-08-18 16:21:10.000000000","message":"use TAB for indentation, not space","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"net SRST        LOC \u003d \u0027P61\u0027 ;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"net SDA\t\tLOC \u003d \u0027P50\u0027 ;"},{"line_number":21,"context_line":"net SCL\t        LOC \u003d \u0027P51\u0027 ;"},{"line_number":22,"context_line":"net SDA_DIR\tLOC \u003d \u0027P56\u0027 ;"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"net SI_TDO\tLOC \u003d \u0027P16\u0027 ;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"52324ca0_6b9358c4","line":21,"in_reply_to":"e2014ccc_2f74848a","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8c583d97_59867182","line":51,"updated":"2023-08-18 16:21:10.000000000","message":"drop the extra line at the end of the file","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"24669bea_b3d3247b","line":51,"in_reply_to":"8c583d97_59867182","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"}],"contrib/firmware/angie/hdl/src/angie_bitstream.vhd":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  SDA : inout std_logic;"},{"line_number":27,"context_line":"  SDA_DIR : in std_logic;"},{"line_number":28,"context_line":"  SCL\t : in std_logic;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  FTP    : out std_logic_vector(7 downto 0):\u003d(others \u003d\u003e \u00271\u0027); -- Test points"},{"line_number":31,"context_line":"  SI_TDO : in  std_logic;"}],"source_content_type":"text/x-vhdl","patch_set":7,"id":"61fc68ec_ebdcab00","line":28,"updated":"2023-08-18 16:21:10.000000000","message":"your editor is quite crap wrt TAB vs SPACE\nhere you have a TAB while the rest of the file uses SPACE","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  SDA : inout std_logic;"},{"line_number":27,"context_line":"  SDA_DIR : in std_logic;"},{"line_number":28,"context_line":"  SCL\t : in std_logic;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  FTP    : out std_logic_vector(7 downto 0):\u003d(others \u003d\u003e \u00271\u0027); -- Test points"},{"line_number":31,"context_line":"  SI_TDO : in  std_logic;"}],"source_content_type":"text/x-vhdl","patch_set":7,"id":"57387f84_e220eb4d","line":28,"in_reply_to":"61fc68ec_ebdcab00","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6258e8e87a593d1fbf15f90140225edda49a7640","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  ST_1   : out std_logic;"},{"line_number":34,"context_line":"  ST_2   : out std_logic;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  ST_4\t : out std_logic;"},{"line_number":37,"context_line":"  ST_5\t : out std_logic;"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  SO_SDA_OUT : out std_logic;"},{"line_number":40,"context_line":"  SO_SDA_IN : in std_logic;"}],"source_content_type":"text/x-vhdl","patch_set":7,"id":"c8da97b7_c429ed98","line":37,"range":{"start_line":36,"start_character":3,"end_line":37,"end_character":11},"updated":"2023-08-18 16:21:10.000000000","message":"Also these two lines have TAB in place of SPACE","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"5d009bfc93df3db0a0ee07810977c47dfe0c3bcd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ST_1   : out std_logic;"},{"line_number":34,"context_line":"  ST_2   : out std_logic;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  ST_4\t : out std_logic;"},{"line_number":37,"context_line":"  ST_5\t : out std_logic;"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  SO_SDA_OUT : out std_logic;"},{"line_number":40,"context_line":"  SO_SDA_IN : in std_logic;"}],"source_content_type":"text/x-vhdl","patch_set":7,"id":"56e9d2b7_40c5eff4","line":37,"range":{"start_line":36,"start_character":3,"end_line":37,"end_character":11},"in_reply_to":"c8da97b7_c429ed98","updated":"2023-08-18 17:04:33.000000000","message":"Done","commit_id":"f7ec33f2d56c6596846488e631069b21decfb372"}]}