)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"24cbcc208d4ea1016eadbea1e22841216a0a5fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af65d18a_56a70fa5","updated":"2023-07-13 19:37:03.000000000","message":"Thanks Tim","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ae992d191da4f48fcd2474054f475e70b2eaf0d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e3c1975_07f18d99","updated":"2023-07-14 14:17:56.000000000","message":"Looks correct.\nNitty picky, the variable \"success\" can be dropped.","commit_id":"c05e4c5a2a1c3e7ba7e322b7245b293d4c8b6e0b"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"8cdfd14fa3e8e4cfdf5b44e60b8a5d169147ff12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"879559ec_f18a6a73","updated":"2023-07-14 14:00:23.000000000","message":"Looks good to me.","commit_id":"c05e4c5a2a1c3e7ba7e322b7245b293d4c8b6e0b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"62c6bb37013f4a7cd51c8e5e3bdd70753f9938fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"967d168e_9b26d4a7","in_reply_to":"4e3c1975_07f18d99","updated":"2023-07-14 15:28:17.000000000","message":"Even more nitty picky :), the variable \u0027written\u0027 can be dropped too and replaced by NULL in usb_write()","commit_id":"c05e4c5a2a1c3e7ba7e322b7245b293d4c8b6e0b"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"fb9f1d64b6cb40b602c4bec2615c02ac5f26110f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c328b15a_3a2b0bd2","in_reply_to":"967d168e_9b26d4a7","updated":"2023-07-14 16:51:59.000000000","message":"I\u0027ve made these further simplifications, but I don\u0027t have a target to test on.","commit_id":"c05e4c5a2a1c3e7ba7e322b7245b293d4c8b6e0b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ba1d7a890f9c3bcfdcd507151d1d3db284c067fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"95fc3643_284c619f","updated":"2023-07-21 12:03:08.000000000","message":"Tested with CC3220SF-LAUNCHXL board, the on-board adapter in XDS110 mode:\nXDS110: firmware version \u003d 3.0.0.13\nXDS110: hardware version \u003d 0x0027\nXDS110: connected to target via SWD\n\nWorks.","commit_id":"e48dbfe1a077745e6e4b5659db87c62e529fb61a"}],"src/jtag/drivers/xds110.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"24cbcc208d4ea1016eadbea1e22841216a0a5fac","unresolved":true,"context_lines":[{"line_number":492,"context_line":"\tif (written)"},{"line_number":493,"context_line":"\t\t*written \u003d bytes_written;"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"\treturn (result \u003d\u003d 0 \u0026\u0026 size \u003d\u003d bytes_written) ? true : false;"},{"line_number":496,"context_line":"}"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"static bool usb_get_response(uint32_t *total_bytes_read, uint32_t timeout)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"86bb5bf9_ada35a35","line":495,"range":{"start_line":495,"start_character":24,"end_line":495,"end_character":45},"updated":"2023-07-13 19:37:03.000000000","message":"already tested here","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ba1d7a890f9c3bcfdcd507151d1d3db284c067fe","unresolved":false,"context_lines":[{"line_number":492,"context_line":"\tif (written)"},{"line_number":493,"context_line":"\t\t*written \u003d bytes_written;"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"\treturn (result \u003d\u003d 0 \u0026\u0026 size \u003d\u003d bytes_written) ? true : false;"},{"line_number":496,"context_line":"}"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"static bool usb_get_response(uint32_t *total_bytes_read, uint32_t timeout)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b5417977_2c6a7239","line":495,"range":{"start_line":495,"start_character":24,"end_line":495,"end_character":45},"in_reply_to":"86bb5bf9_ada35a35","updated":"2023-07-21 12:03:08.000000000","message":"Done","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"24cbcc208d4ea1016eadbea1e22841216a0a5fac","unresolved":true,"context_lines":[{"line_number":599,"context_line":"\tsuccess \u003d usb_write(xds110.write_packet, (int)size, \u0026written);"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"\t/* Check if the correct number of bytes was written */"},{"line_number":602,"context_line":"\tif (written !\u003d (int)size)"},{"line_number":603,"context_line":"\t\tsuccess \u003d false;"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\treturn success;"},{"line_number":606,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2696f45a_e40bd4f7","line":603,"range":{"start_line":602,"start_character":1,"end_line":603,"end_character":18},"updated":"2023-07-13 19:37:03.000000000","message":"Or remove this test and the \u0027written\u0027 variable because the same condition is tested in usb_write()","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"5cbd0ca7d99d05a9dd5ff321f3c61f06f20ab436","unresolved":true,"context_lines":[{"line_number":599,"context_line":"\tsuccess \u003d usb_write(xds110.write_packet, (int)size, \u0026written);"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"\t/* Check if the correct number of bytes was written */"},{"line_number":602,"context_line":"\tif (written !\u003d (int)size)"},{"line_number":603,"context_line":"\t\tsuccess \u003d false;"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\treturn success;"},{"line_number":606,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d838a842_790ac2de","line":603,"range":{"start_line":602,"start_character":1,"end_line":603,"end_character":18},"in_reply_to":"2104ca7c_4f6b01af","updated":"2023-07-13 19:57:09.000000000","message":"Yes please.\nI have a kit with XDS110 on board, will test.","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"449b9c0be096f65e1b75f97cf8f0a372898833e6","unresolved":true,"context_lines":[{"line_number":599,"context_line":"\tsuccess \u003d usb_write(xds110.write_packet, (int)size, \u0026written);"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"\t/* Check if the correct number of bytes was written */"},{"line_number":602,"context_line":"\tif (written !\u003d (int)size)"},{"line_number":603,"context_line":"\t\tsuccess \u003d false;"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\treturn success;"},{"line_number":606,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2104ca7c_4f6b01af","line":603,"range":{"start_line":602,"start_character":1,"end_line":603,"end_character":18},"in_reply_to":"2696f45a_e40bd4f7","updated":"2023-07-13 19:48:53.000000000","message":"That also builds. I don\u0027t have access to a target to test this on. Do you prefer this solution? If so, I\u0027ll update this PR.","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ba1d7a890f9c3bcfdcd507151d1d3db284c067fe","unresolved":false,"context_lines":[{"line_number":599,"context_line":"\tsuccess \u003d usb_write(xds110.write_packet, (int)size, \u0026written);"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"\t/* Check if the correct number of bytes was written */"},{"line_number":602,"context_line":"\tif (written !\u003d (int)size)"},{"line_number":603,"context_line":"\t\tsuccess \u003d false;"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\treturn success;"},{"line_number":606,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"24c87da6_8a19c40b","line":603,"range":{"start_line":602,"start_character":1,"end_line":603,"end_character":18},"in_reply_to":"906f2e54_13cdcf16","updated":"2023-07-21 12:03:08.000000000","message":"Done","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"2ee7ae233dff780c5d1197dc5615f4437349cbb9","unresolved":true,"context_lines":[{"line_number":599,"context_line":"\tsuccess \u003d usb_write(xds110.write_packet, (int)size, \u0026written);"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"\t/* Check if the correct number of bytes was written */"},{"line_number":602,"context_line":"\tif (written !\u003d (int)size)"},{"line_number":603,"context_line":"\t\tsuccess \u003d false;"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"\treturn success;"},{"line_number":606,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"906f2e54_13cdcf16","line":603,"range":{"start_line":602,"start_character":1,"end_line":603,"end_character":18},"in_reply_to":"d838a842_790ac2de","updated":"2023-07-13 20:14:39.000000000","message":"I changed it.","commit_id":"5cab0003bd9d9f0028a00c463d86f882d648de50"}]}