)]}'
{"id":"openocd~master~I5d4764c777f33d48705b3e5273eb840c13cfbfb7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2023-07-22 20:16:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5d4764c777f33d48705b3e5273eb840c13cfbfb7","subject":"target/riscv: Add null pointer check before right shift for bscan tunneling.","status":"MERGED","created":"2023-07-13 16:52:37.000000000","updated":"2023-07-22 20:16:11.000000000","submitted":"2023-07-22 20:16:11.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7814","meta_rev_id":"36d1bf3b4f220ad22988dcca37369916991b23b9","_number":7814,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-22 20:16:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-22 20:16:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-22 20:16:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-13 17:05:16.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-14 13:56:38.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2023-07-14 14:25:24.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"5728a25e304ffa1757e5b0612ebf6a18ae826ba5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2023-07-13 16:52:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c6943915c12221209d169c65d02200b975e67f7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-13 17:05:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17978/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17177/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"03aa1c47502c283203e3d50e90cf3f247172f403","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2023-07-13 17:40:24.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0994e5bef2648872668e55b7d1c624bbfd90b67e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-07-13 17:51:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17979/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/17178/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3b8e298005e502ec00b83a6c57816c1c5713205e","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2023-07-14 13:56:38.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d91e68afc7a4d11b94755a65a8b0aca7125bd9ef","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-14 14:25:24.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b0b121ffee68afa921a407e7d661a4c6488b7f65","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-22 20:16:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"36d1bf3b4f220ad22988dcca37369916991b23b9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-07-22 20:16:11.000000000","message":"Change has been successfully cherry-picked as 218f6c0181633057a892a8724c506b10b9f6afaa","accounts_in_message":[],"_revision_number":3}],"current_revision":"218f6c0181633057a892a8724c506b10b9f6afaa","revisions":{"a65a7584d07339c294545283f9e463df38d00d04":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-07-13 17:40:24.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/14/7814/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/7814/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/2 \u0026\u0026 git checkout -b change-7814 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/7814/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a96776178676963a179879624190acea1e26158","subject":"jtag/stlink: add STLINK-V3PWR support"}],"author":{"name":"eolson","email":"erin.olson@seagate.com","date":"2023-06-22 18:02:21.000000000","tz":-300},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2023-07-13 17:40:24.000000000","tz":0},"subject":"target/riscv: Add null pointer check before right shift for bscan tunneling.","message":"target/riscv: Add null pointer check before right shift for bscan tunneling.\n\nChange-Id: I5d4764c777f33d48705b3e5273eb840c13cfbfb7\nSigned-off-by: eolson \u003cerin.olson@seagate.com\u003e\n"},"description":"Edit commit message"},"218f6c0181633057a892a8724c506b10b9f6afaa":{"kind":"REWORK","_number":3,"created":"2023-07-22 20:16:11.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/14/7814/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/7814/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/3 \u0026\u0026 git checkout -b change-7814 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/7814/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d57b2448eea7fac0d5ccf8b047adf0a57a557cb5","subject":"target/arc: fix off-by-one error in arc_save_context()"}],"author":{"name":"eolson","email":"erin.olson@seagate.com","date":"2023-06-22 18:02:21.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-07-22 20:16:11.000000000","tz":0},"subject":"target/riscv: Add null pointer check before right shift for bscan tunneling.","message":"target/riscv: Add null pointer check before right shift for bscan tunneling.\n\nChange-Id: I5d4764c777f33d48705b3e5273eb840c13cfbfb7\nSigned-off-by: eolson \u003cerin.olson@seagate.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7814\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"23acdc9c21ee13cc4ad367998c9e607e7ac4461f":{"kind":"REWORK","_number":1,"created":"2023-07-13 16:52:37.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/14/7814/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/7814/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/1 \u0026\u0026 git checkout -b change-7814 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/7814/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/7814/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a96776178676963a179879624190acea1e26158","subject":"jtag/stlink: add STLINK-V3PWR support"}],"author":{"name":"eolson","email":"erin.olson@seagate.com","date":"2023-06-22 18:02:21.000000000","tz":-300},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2023-07-13 16:37:24.000000000","tz":-420},"subject":"Add null pointer check before right shift for bscan tunneling.","message":"Add null pointer check before right shift for bscan tunneling.\n\nChange-Id: I5d4764c777f33d48705b3e5273eb840c13cfbfb7\nSigned-off-by: eolson \u003cerin.olson@seagate.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}