)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"change_message_id":"944a0153c663b249b73fa953fcaa55f4c8078112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49a2cce7_9d8c58a8","updated":"2023-08-04 14:18:18.000000000","message":"LGTM. Thanks!","commit_id":"273e6bd3b48002dde0ef987289caf6610a4574f6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8f864aa1025bfb3b7a6fa1630fde85e2c335ff3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"116e8108_08de20fa","updated":"2023-12-31 17:27:36.000000000","message":"merge pending for dependency on 7816","commit_id":"273e6bd3b48002dde0ef987289caf6610a4574f6"}],"src/target/arc.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0bbb2e8318f667280ef430687561703f931fafff","unresolved":true,"context_lines":[{"line_number":1336,"context_line":"\t\tif (breakpoint) {"},{"line_number":1337,"context_line":"\t\t\tLOG_DEBUG(\"skipping past breakpoint at 0x%08\" TARGET_PRIxADDR,"},{"line_number":1338,"context_line":"\t\t\t\tbreakpoint-\u003eaddress);"},{"line_number":1339,"context_line":"\t\t\tarc_unset_breakpoint(target, breakpoint);"},{"line_number":1340,"context_line":"\t\t\tarc_single_step_core(target);"},{"line_number":1341,"context_line":"\t\t\tarc_set_breakpoint(target, breakpoint);"},{"line_number":1342,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"242add99_cd2c43b4","line":1339,"updated":"2023-07-23 14:35:04.000000000","message":"this function call, the next two and all the functions called in arc_single_step_core() can return error, but all these possible errors are ignored.\nIs there any specific reason for ignoring it?","commit_id":"b7d996d116805fe8e881338b36ab80a418fb2791"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"902db3501e0701b118f0966983af791412e6c1b2","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"\t\tif (breakpoint) {"},{"line_number":1337,"context_line":"\t\t\tLOG_DEBUG(\"skipping past breakpoint at 0x%08\" TARGET_PRIxADDR,"},{"line_number":1338,"context_line":"\t\t\t\tbreakpoint-\u003eaddress);"},{"line_number":1339,"context_line":"\t\t\tarc_unset_breakpoint(target, breakpoint);"},{"line_number":1340,"context_line":"\t\t\tarc_single_step_core(target);"},{"line_number":1341,"context_line":"\t\t\tarc_set_breakpoint(target, breakpoint);"},{"line_number":1342,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fb932a6e_bba51894","line":1339,"in_reply_to":"242add99_cd2c43b4","updated":"2023-07-31 09:57:10.000000000","message":"You\u0027re right, there is no reason for that. Fixed and pushed out as v2.","commit_id":"b7d996d116805fe8e881338b36ab80a418fb2791"},{"author":{"_account_id":1002160,"name":"Artemiy Volkov","display_name":"Artemiy Volkov","email":"artemiy@synopsys.com","username":"artemiy-volkov","status":"Synopsys"},"change_message_id":"57a7e4aaaf7b1636e78cbc7e75d736664e2192c8","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"\t\tif (breakpoint) {"},{"line_number":1337,"context_line":"\t\t\tLOG_DEBUG(\"skipping past breakpoint at 0x%08\" TARGET_PRIxADDR,"},{"line_number":1338,"context_line":"\t\t\t\tbreakpoint-\u003eaddress);"},{"line_number":1339,"context_line":"\t\t\tarc_unset_breakpoint(target, breakpoint);"},{"line_number":1340,"context_line":"\t\t\tarc_single_step_core(target);"},{"line_number":1341,"context_line":"\t\t\tarc_set_breakpoint(target, breakpoint);"},{"line_number":1342,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"528d9718_63068784","line":1339,"in_reply_to":"fb932a6e_bba51894","updated":"2023-09-11 07:31:35.000000000","message":"Hi Antonio, could you consider giving this patch another look please?","commit_id":"b7d996d116805fe8e881338b36ab80a418fb2791"}]}